document macro library the original library also remains
Change-Id: Ife89e1e164d288702d30e6b79f5e703ab9467e4d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175182
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
V1037 Two or more case-branches perform the same actions. Check lines: 80, 86
Change-Id: I4f857ebdd950af1f52bea59a07b8846efcf89ae9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175280
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
In Writer the Tools>Customize>Keyboard list did not show attribution
for Alt_Shift_P which is the binding for Page Style dialog. The reason
for this was that .xcu node for the shortcut was part of Global node.
Change the Accelerators.xcu file to Modules node particularly,
under TextDocument com.sun.star.text.TextDocument.
Change-Id: I997c4e6dd292c46fe067a59f0309681d6c346a6b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175249
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
This patch fixes the bug in which you have to reset the date filter
for filter by author to work i.e. when switching the filter from one
author to another
Change-Id: Ib5d3bebf587c0e940d4984dd78f9d4a94f5cbb06
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175189
Tested-by: Jenkins
Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
Since
commit 4c2701d4cc
Author: Vladimir Glazounov <vg@openoffice.org>
Date: Tue May 22 17:53:11 2007 +0000
INTEGRATION: CWS chart2mst3 (1.1.4); FILE ADDED
V778 Two similar code fragments were found. Perhaps, this is a typo and 'xValuesX' variable should be used instead of 'xValuesY'.
Change-Id: I24a904ee2e0fa81eb50756545d4b1127b93579fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175322
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Since
commit 75f0c33a05
Author: Markus Mohrhard <markus.mohrhard@googlemail.com>
Date: Tue Jul 5 04:21:41 2011 +0200
change from manual loop to ScMarkData::iterator in calc/source/core
The 'i' counter is not used inside a nested loop. Consider inspecting usage of 'k' counter.
Change-Id: Ia7d1aeae86fda108f97c03f6e5ea7724d6542578
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175290
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Similar to commit c785399884 (In MSVC,
non-static constexpr objects are initialized at run-time, 2024-09-04).
Change-Id: Id1c9ca961efdcbfd897a03e4f85869a6f4e5260b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175297
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
V1037 Two or more case-branches perform the same actions. Check lines: 194, 200
V1037 Two or more case-branches perform the same actions. Check lines: 796, 800
V1037 Two or more case-branches perform the same actions. Check lines: 804, 810
Change-Id: Icef65820f99405ca78d31dc9e1afc0a9d5c6b355
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175279
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
That was missing with the result that for some cases the
painted text (where it was missing) differed from the
text in EditEngine mode (was set there).
Change-Id: I23ddf8e90be2335c56e5a485308c753dfe72a878
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175127
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
As defined by commit 69586e8381 (UI
tests: use a dedicated desktop on Windows, 2024-07-17).
Change-Id: Icd4ad6dfa95301fc1f6e699349278d3a0198fd08
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175296
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
In a very similar way to the character encoding dialog, handled in
Ibd36e695e733e07053bb6e22a510ac988be3ded2, we need to see this dialog
before the document opens.
I've used the same trick, where I've made the dialog into a JSDialog and
registered an early listener, but I haven't asynced it as it's never
useful to have more than 1 person using it at once.
Change-Id: I1a61660523ae2d4812890b62d16f0e6cef133e67
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174269
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
(cherry picked from commit 335bb5b39c03b7ef7d7426259b41d479ff9ea7f0)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174951
Tested-by: Jenkins
The character encoding dialog appears when importing a dialog with an
ambiguous character encoding. At the point when it appears, the document
isn't loaded, so we have to handle it in a similar way to the text
import dialog or password prompt dialog, allowing it to function early.
It's also required to make the dialog into a jsdialog, as tunneled
dialogs do not work this early in the document loading process.
I have not asynced the dialog here because there's no point. I did write
code where I set up a dialog factory to do this similar to how other
modules (sw, sc, sd, etc.) handle dialogs and make them async.
Unfortunately, this dialog is not useful with multiple users, since as
it's used on opening a document. It may, in the future, be useful to
someone to make a patch that asyncs the other writerperfect dialog (epub
export) so I have uploaded and abandoned my dialog factory patch as
Id8ec474510f3c8637639ad59331156c6e75dafb4.
Documents that require this dialog, whether async or not, cause crashes
when someone opens the document before the first person has finished
responding to this dialog. I still consider this behavior better than
crashing whenever we attempt to show this dialog at all.
Change-Id: Ibd36e695e733e07053bb6e22a510ac988be3ded2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174044
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
(cherry picked from commit 283f771b92a14c06871c931b01174622b855abe5)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174950
Tested-by: Jenkins
This ctor is meant to set the value of nTime directly; and that value
is not nanoseconds, but an encoded value, using SEC_/MIN_/HOUR_MASK.
But in some places, this ctor was misused for setting of nanoseconds,
which would only accidentally work for values less than one second.
All places that initialized tools::Time with 0, now use EMPTY.
This makes the ctor private; and for the very few cases where really
the encoded value of nTime is stored / restored, fromEncodedTime is
introduced.
Change-Id: I1f1994bd9aab1b51a41b1de637619049fe820da4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175283
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Use #pragma once instead of header guards
Change-Id: Iba43f2103628ed184933cf2611991e7aef9f0173
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173369
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Jenkins
V1037 Two or more case-branches perform the same actions. Check lines: 865, 868
Change-Id: Icc108072231fd37a73f0a35eac15bb1960e50202
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175266
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
For Qt >= 6.9, map the BLOCK_QUOTE role to
QAccessible::BlockQuote, newly introduced
upstream in qtbase commit [1]:
commit 0b5874bc96f4d1a8cba4fe14ee0b3499cc04c8cd
Author: Michael Weghorn <m.weghorn@posteo.de>
AuthorDate: Thu Sep 12 17:21:37 2024 +0200
Commit: Volker Hilsheimer <volker.hilsheimer@qt.io>
CommitDate: Fri Oct 18 21:03:09 2024 +0000
a11y: Add new BlockQuote role
With this in place, paragraphs to which the
"Block Quotation" paragraph style has been assigned,
are now shown with the "block quote" role in Accerciser
when using the qt6 VCL plugin with a current qtbase dev
build.
[1] https://code.qt.io/cgit/qt/qtbase.git/commit/?id=0b5874bc96f4d1a8cba4fe14ee0b3499cc04c8cd
Change-Id: I3b9822e4a5ce6eed3ab4820a208f794bcf398e85
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173272
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
V1037 Two or more case-branches perform the same actions. Check lines: 156, 164
V1037 Two or more case-branches perform the same actions. Check lines: 898, 908
Change-Id: Iec6ceda7c4506317860950857e516991d8a507a4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175238
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
V1037 Two or more case-branches perform the same actions. Check lines: 84, 90
Change-Id: I3e11f666cc3db56ca4d406831841b8f5660097a6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175268
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Since
commit 2f303d689e
Author: Kurt Zenker <kz@openoffice.org>
Date: Thu Jun 10 12:20:58 2004 +0000
INTEGRATION: CWS fwk02ea (1.6.38); FILE MERGED
V705 It is possible that 'else' block was forgotten or commented out, thus altering the program's operation logics.
Change-Id: Id5a331b0338a38740b5ecf3ad881d7ce4dd6033b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175289
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Since
commit 0deea02b1d
Author: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>
Date: Sat Aug 19 17:18:50 2023 +0300
tdf#138792: PDF export: add batch of dublin core attributes
V501 There are identical sub-expressions 'bKeywordsMod' to the left and to the right of the '||' operator.
V501 There are identical sub-expressions 'bThemeMod' to the left and to the right of the '||' operator.
V501 There are identical sub-expressions 'bTitleMod' to the left and to the right of the '||' operator.
Change-Id: I438e0284a190241bf86b0e127de2f12f4a1a68b7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175287
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Since
commit ad6f23d2a3
Author: TokieSan <eltokhy@aucegypt.edu>
Date: Tue Jul 18 21:54:31 2023 +0300
Added searching and filtering features to certificate chooser dialog
V501 There are identical sub-expressions 'rCharClass.uppercase(sIssuer).indexOf(aSearchStr) < 0' to the left and to the right of the '&&' operator.
Change-Id: Ifdc4b371e6d8f79ad43236e10b86e8e5b03204a9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175284
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Since
commit 78010a4db1
Author: Caolán McNamara <caolanm@redhat.com>
Date: Thu Oct 4 15:37:14 2018 +0100
Resolves: tdf#106340 resize dialog when search/replace labels are shown/hidden
V501 There are identical sub-expressions '!m_xReplaceAttrText->get_visible()' to the left and to the right of the '||' operator.
V501 There are identical sub-expressions '!m_xReplaceAttrText->get_visible()' to the left and to the right of the '||' operator.
Change-Id: Ib62557af291679c253162e3d72a39659691ef0b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175285
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
V1037 Two or more case-branches perform the same actions. Check lines: 913, 922
Change-Id: Ie9ef10d15c51b9b0702dbda41768afdee3655eab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175236
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
V1037 Two or more case-branches perform the same actions. Check lines: 871, 879
V1037 Two or more case-branches perform the same actions. Check lines: 891, 899
Change-Id: I027615d9acef9aae4c554f2dcbb033edac01940e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175239
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
* Update dictionaries from branch 'master'
to d0c939181ac181ce6479ae8604ef647055ccf44d
- Update the Korean Dictionaries: ko-KR
Update Korean dictionary file (ko_KR.dic) by DaeHyun Sung (2024.08.21)
Also, update readme description
Change-Id: I232b9eefba111f2d4969bc8e3add33984cff7381
Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/172166
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Since
commit 95824f8636
Author: Noel Power <noel.power@novell.com>
Date: Tue Nov 2 16:55:17 2010 +0000
initial import of latest cws container_controls
V524 It is odd that the body of 'removeTabListener' function is fully equivalent to the body of 'addTabListener' function.
Change-Id: Iafa1f374564ab425e8c22f4e706d361f03d3183e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175255
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
Since
commit 32cd4a92ef
Author: Jens-Heiner Rechtien <hr@openoffice.org>
Date: Wed Jun 27 11:18:37 2007 +0000
INTEGRATION: CWS awttree01 (1.1.2); FILE ADDED
V524 It is odd that the body of 'removeSelectionChangeListener' function is fully equivalent to the body of 'addSelectionChangeListener' function.
Change-Id: I807520da4515ae8dfb070b29aa772bab1ade592b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175254
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Since
commit f02e1a0abc
Author: Kurt Zenker <kz@openoffice.org>
Date: Thu Mar 6 16:58:17 2008 +0000
INTEGRATION: CWS odbmacros2 (1.36.2); FILE MERGED
V524 It is odd that the body of 'removeStorageChangeListener' function is fully equivalent to the body of 'addStorageChangeListener' function.
Change-Id: Ie5456f4ef7397d5f9144ac3167724f6c2ca32c56
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175251
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
so in practice it isn't happening. (Or the --i should be conditional
on something getting removed)
Change-Id: I0d74a46eced77c5bb1474c60c26e39061de791a7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175243
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
just set nRead to an initial 2 and leave nLen2 alone, nRead and nLen2
are only used for the loop condition
Change-Id: I269db2d986070f010a05eb58f200d19afc1bff1c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175241
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Since
commit 81c4be4582
Author: Caolán McNamara <caolan.mcnamara@collabora.com>
Date: Sat Dec 16 20:18:13 2023 +0000
cid#1545561 std::swap COPY_INSTEAD_OF_MOVE
V549 The first argument of 'swap' function is equal to the second argument.
Change-Id: Ieeb06744afe4ea09b986c78e8b25a5b5fc87d434
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175253
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
V1048 The 'beforeColRow' variable was assigned the same value.
Change-Id: I27ef13be81c9f94f452701fc1a47d6e908024a23
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175205
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
