V1024 The 'aIfstream' stream is checked for EOF before reading from it, but is not checked after reading. Potential use of invalid data.
Change-Id: I253513c47ec1482882bbfb1c6e32e25c15ace99c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175475
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
V768 The variable 'eS' is of enum type. It is odd that it is used as a variable of a Boolean-type.
Change-Id: I959f58e80cd0a2d82e6c9fffe140a442cf4dbb0c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175477
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
It was too convoluted; the three properties that were set there
all used different logic (PROP_PARA_FIRST_LINE_INDENT was only
set when the parent style id was present; PROP_PARA_LEFT_MARGIN
was set when it was found either in the entry or in its parent;
PROP_PARA_RIGHT_MARGIN was only set when parent style was found,
and it had properties). It seems to be just some leftovers from
iterative partial changes of the code.
This makes the code more uniform. For PROP_PARA_RIGHT_MARGIN it
keeps setting PROP_PARA_FIRST_LINE_INDENT/PROP_PARA_LEFT_MARGIN
from getNumberingProperty; but otherwise, all three are handled
similarly: if the property is set either in the entry itself or
in its parent, it is processed. This changes the logic slightly,
but hopefully in the correct direction.
Change-Id: I1a8fb95d055101dcbc3aaec6207721146c94cc21
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175437
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
V768 The variable 'eType' is of enum type. It is odd that it is used as a variable of a Boolean-type.
Change-Id: I38f0302d8edcaef144f6071dc86500937d305591
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175478
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
V1024 The 'aInput' stream is checked for EOF before reading from it, but is not checked after reading. Potential use of invalid data.
Change-Id: Ie0c6d1928dad804b21d3c9920cc1de8035ea0367
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175476
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
Some archs does not support NaN payload(e.g. riscv64).
It would be meaningless to continue building a test related
to NaN payload if the builder doesn't support this feature.
Change-Id: I895a8647bf7ff68f645faa7428d30b1c741669f9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175293
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
These changes improve const-correctness and reduce the need for const_cast
usage.
Change-Id: I1275edfbc0ca5d49a5e8339d1ed11148f6decd1e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174701
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
Since
commit c5db3b93ee
Author: Michael Stahl <mst@openoffice.org>
Date: Thu Feb 10 16:45:02 2011 +0100
xmlfix3: unoxml: prevent invalid child-parent relationships:
V1044 Loop break conditions do not depend on the number of iterations.
Change-Id: I611911bdcdb812ed46a529a217ab6612a254f441
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175174
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
V1037 Two or more case-branches perform the same actions. Check lines: 152, 194
V1037 Two or more case-branches perform the same actions. Check lines: 565, 592
Change-Id: I52ec0921c898ca74473631ba36a76f6444ce07d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175358
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
V1037 Two or more case-branches perform the same actions. Check lines: 289, 293
Change-Id: I9828b4d5b7faca449c5377a0bd8223cddf883a43
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175423
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
V560 A part of conditional expression is always true: pRun != pEnd.
V560 A part of conditional expression is always true: pRun != pEnd.
Change-Id: I1a99ae31346177bed731e26e883720efa018bcbc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175451
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
V560 A part of conditional expression is always true: pRotate.
V560 A part of conditional expression is always true: pRotate.
Change-Id: Icf39c1a7e3a31fb360dde684a5ebfbc176027f6c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175450
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
V560 A part of conditional expression is always true: pDoc.
Change-Id: Ie3947a3360d65a97a6a70c584c3e3f32485b4b6b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175458
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
The try/catch block prevents an exception that looks like
com.sun.star.lang.IllegalArgumentException message:
"at /Users/noelgrandin/lode/dev/core/svx/source/unodraw/unoshap2.cxx:1423"
which is inside
SvxGraphicObject::setPropertyValueImpl
Not sure where would be a better place to handle this.
regression from
commit 060b0fb4b9
Author: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
Date: Thu Mar 8 16:37:46 2018 +0900
change RTFDocumentImpl to use Graphic instead of GraphicURL
Change-Id: Iec3df20a2192df2bf595293037c8214fea151ae3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175418
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
V560 A part of conditional expression is always true: pItem.
Change-Id: I4ae18820dc7ec3232bccb099e56dd0da2b4f59eb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175456
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
V560 A part of conditional expression is always true: pDrawLayer.
Change-Id: Ibcb87390a41d835233625b7bea1e5e040ebe3b21
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175457
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
V560 A part of conditional expression is always true: pFlt.
Change-Id: Ia05e42b8700ceb3dc1ab23becf71fd281695924e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175449
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
V560 A part of conditional expression is always true: pSection.
Change-Id: If097740c8ea3b89da42c07c4e419fee731948fe7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175453
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
V560 A part of conditional expression is always true: pFlt.
Change-Id: I208c6f64fe49dec422173b9465b18182c1aac318
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175452
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
Replace include guards to pragma once in some header files in sw/inc/
Change-Id: I8e790a89ab2326748590d7a1ff2d1daee0ae0f4b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175191
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
OpenJDK source has been used for the comments
Change-Id: Ic443ef1f50894eccd5233f2c629e227b8816a8fe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173568
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
This is probably not an ideal fix, I'm not sure where exactly the
positioning is off, but this does the job for now.
regression from
commit 95ccc26ba7
Author: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
Date: Fri May 22 18:07:45 2015 +0900
Change-Id: I2f02e68418b7adf2cba8dfa4e4e51d4416a91389
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175417
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
V560 A part of conditional expression is always true: pStyleSheetProperties.
Change-Id: Ia6f0ecbf80d8de488695441c86b0b34e23c6348a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175444
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
Negative space sizes (i.e. shrunk lines at image wrapping) stored
over LONG_MAX/2, and these values had no resolution in SwBidiPortion,
causing crash/assert in conversion of DOCX document containing e.g.
Arabic text wrapping around images.
Note: apply the resolution in SwDoubleLinePortion, too.
Regression since commit 1fb6de0270
"tdf#163149 sw smart justify: fix line shrinking at image wrapping".
Change-Id: I6e45592c4eed247871d35e1f02fd5a038baddf85
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175419
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: Jenkins
V560 A part of conditional expression is always true: pNumFormat.
V560 A part of conditional expression is always true: pNumFormat != nullptr.
Change-Id: I6c780fa67bd65da06cfdde37d34eda93bb4ab13c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175445
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
V1037 Two or more case-branches perform the same actions. Check lines: 341, 345, 348
V1037 Two or more case-branches perform the same actions. Check lines: 481, 487
V1037 Two or more case-branches perform the same actions. Check lines: 689, 700
Change-Id: Ib9f4b8047f7706667f79de0170a672818ffd9030
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175346
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
V760 Two identical blocks of text were found. The second block begins from line 325.
Change-Id: I5854337d4d1c0d946b096804b536433c48f0696f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175381
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
because the param is never null
Change-Id: I58660a9e4e6c25def2a70099bffce322b477b702
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175415
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Do this explicitly, so it can't happen that .uno:Signature with params
gets dispatched, then .uno:Signature without params still has the old
XCertificate.
Change-Id: I35c4d5e0e4545fb1aabb9050aa6b11cd10c3ca85
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175414
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
Return the XAccessibleContext reference right away, instead
of assigning it to a local variable and returning at the end
of the method.
Change-Id: Iec47f4158dd40c25482366c33ed4a4642709f641
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175405
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Just return `xAcc` right away instead of first assigning it to
a local variable.
Change-Id: If11c88266b4ec72b2d5d927e3f28a14bf0cdc304
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175404
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Since
commit 97075a384a
Author: Michael Brauer <mib@openoffice.org>
Date: Wed Oct 24 13:16:17 2001 +0000
#91961#: Support of language
V1037 Two or more case-branches perform the same actions. Check lines: 1462, 1465
Change-Id: Ie27fb47ec7e22b9dbe9a2338c661c261bea8926b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175383
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
