List was defined as std::vector< Node* >; but calling it List is confusing
since you don't know what type of list it is. Also it's just asking for
compile issues since we also use std::List, a custom List<>, & a class List.
I also removed Node::Children() since it wasn't used.
Nah, having them behind dbglevel>1 is fine (which already means these
assertions won't normally be compiled even with --enable-debug).
I got mislead as I was building with dbglevel=2 everywhere. But
pondering the point of dbglevel a.k.a. OSL_DEBUG_LEVEL, I think the
right way to see it is: You are not supposed to build all (or large
parts) of LibreOffice with dbglevel=2. If we used OSL_TRACE all over
the place as thoroughly as in some files in sal/rtl, that would lead
to astronomical amounts of tracing output. (We don't use OSL_TRACE
like that, but that is another thing...)
I think the intended use of dbglevel is that you should build with
dbglevel=2 only the small part of code you are currently actively
working on, when you want to see trace output.
Of course, another problem then is that in some modules and/or
libraries it might not be possible to compile just a part of the
sources with dbglevel=2. That should be fixed.
This reverts commit a3bad28550.
This allows having a meaningful error message when extractUnoException
is called from pyuno_loader::getLoaderModule() (via
raiseRuntimeExceptionWhenNeeded()). If it is called to treat an error
that cropped up in loading uno.py, the old code would abort the whole
operation by throwing an exception because... it gets essentially the
same error. The new code leads to a sensible message on the Python
debug console.
This avoids breaking the whole python process module importing
when an uno.py import failure happens after the hooking point.
In that case, _uno_import is still the python module loader,
but _g_delegatee is not anymore bound to the previously installed
importer, and thus any module import fails with:
File "/home/master/src/libreoffice/core/install/basis3.5/program/uno.py", line 260, in _uno_import
return _g_delegatee( name, *optargs, **kwargs )
TypeError: 'NoneType' object is not callable
Mac PPC has a very old bison that does not handle .cxx extension well
not does it support --defines=<file>. the result is that the generated
header is called <foo>.cxx.h instead of <foo>.hxx
To deal with that we moved the yacc rule in the platefrom dependent section
and added some renaming magic for the PowerPC case on MacOS.
The creation of $INPATH and sub-dirs was triggered by the location
of the logfile. in buil.pl that trigger the call of mkout.pl
We adapt SourceConfig to keep track of which modules is gbuildified
For these module, the log will be at workdir/Logs/
Also clean-up the remnant of the support for dual build mode (gbuild/dmake).
Tell file name and actual error in error message. Print error message
to stderr. Always exit with failure when not able to open an input or
output file.