Commit graph

336727 commits

Author SHA1 Message Date
Caolán McNamara
45e366eadb drop unnecessary tools/string includes
Change-Id: I4278999b9b7d184c26036bbe9e3b98420f461e8c
2013-10-20 19:00:36 +01:00
Caolán McNamara
8bb4b18127 Related: fdo#38838 remove String::Equals
Change-Id: Ib85907c9e274ba4e4f4c9394f3d4ecf0c9374603
2013-10-20 19:00:36 +01:00
Caolán McNamara
b0fd64b2fa Related: fdo#38838 remove the unused String::Insert
Change-Id: I39f4c68b76d8816fc91e4dc39bf2305142d1fb93
2013-10-20 19:00:36 +01:00
Kohei Yoshida
2d41f3acc3 Reduce branching on empty matrix elements as well.
This makes a big difference in performance.

Change-Id: I88b48d10ff575d80c1c139278dc207d921f15848
2013-10-20 13:44:43 -04:00
Kohei Yoshida
426708e708 Reduce branching in CompareMatrix(). This makes a big difference.
Change-Id: I391e889a50864ae002e85d636b767d7c6f187a23
2013-10-20 13:44:43 -04:00
Kohei Yoshida
013abfd29b Pass cells to CompareFunc, rather than the whole Compare struct.
Change-Id: I4d5554fc5783b123aa0f90b7c078e1fc0f0cd866
2013-10-20 13:44:42 -04:00
Kohei Yoshida
1882a2b151 Try not to use array index access here...
Change-Id: I48967956c63ba72b62604bcabe7166fc58061d13
2013-10-20 13:44:42 -04:00
Kohei Yoshida
81a555edbc Store SharedString in Compare::Cell.
This has a slight overhead for purely numeric comparisons.

Change-Id: I243d5c81499177b3ae93b39a1af7c2f3b954bd39
2013-10-20 13:44:42 -04:00
Kohei Yoshida
73353186d5 Better way to organize 2 compared cell values.
Turns out this is slightly faster too.

Change-Id: I5a8c3474ab2a342200a5cfa9a93e6d89433595c4
2013-10-20 13:44:42 -04:00
Miklos Vajna
7b7a73d05b writerfilter: remove unused WW8PICF class
Change-Id: I4535b9f432eed9064e8fdaed99a10fcf8ad5948d
2013-10-20 19:40:31 +02:00
Lionel Elie Mamane
6940532b81 Revert "fdo#68657 bool->string conversion to 1/0, not "true"/"false"
This reverts commit b89fb0d03e.

It was intended for stble branch only; in master, we let the
incompatible change go through, but we have introduced a
work-around to get the old behaviour again.
2013-10-20 19:28:19 +02:00
Lionel Elie Mamane
5dde691e3e an ORowSetValue constructed from a boolean is a boolean
as opposed to a bit

Change-Id: Ife1c8cef5ca1266e161da3a9190e744dd70ec2fd
2013-10-20 19:27:27 +02:00
Lionel Elie Mamane
dab66665e2 ORowSetValue: adapt test to new behaviour, extend test more
Change-Id: If28046653935051303fd487d87655bacbddf4644
2013-10-20 19:27:26 +02:00
Stephan Bergmann
04fe0cae20 Some clean-up
Change-Id: I8ab23a4b09f9d31ed49c98cdbbf1abc0e684358a
2013-10-20 18:49:48 +02:00
Stephan Bergmann
615a69e33f Clean-up std::bad_alloc handling
...post 0bc89aac4c "cppumaker: Allow UNO interface functions to throw std::exception."

Change-Id: I232a1b266a45d39856d44a2f4e012b5df10fa880
2013-10-20 18:24:57 +02:00
Stephan Bergmann
b70df91abf Whatever the assertion failures in saxparser when doing i18npool...
...actually were, I cannot reproduce any problems at least with recent Xcode 5.0
on Mac OS X 10.8.  Maybe the real problem was addressed meanwhile with
254f59f623 "rhbz#1014010: Missing dependencies in
isBootstrapType list."

Change-Id: I24a920c12f70feef670f0988a6f69c26033789fd
2013-10-20 17:54:13 +02:00
Norbert Thiebaud
685570fbde pre-built bin... adjust the utility script to the movement to external/
so-called external modules are being moved from the top level to a
sub-directory in external/

The script bin_library_info is collecting among other thing the
sha of the tree object that represent the top level of the module
itself... so we need to account for the fact that such module
is not necessarily at $SRCDIR/<module> but can be at
$SRCDIR/external/module

Change-Id: I6c6912a51819669bde512fa8acad7ac82eb50334
2013-10-20 10:35:10 -05:00
Caolán McNamara
e7b4a94ad0 flush out some windows-only String::Assigns
Change-Id: Ic971825bbe7d10849718f0ad0413305dbd5547a0
2013-10-20 15:16:47 +01:00
Stephan Bergmann
0bc89aac4c cppumaker: Allow UNO interface functions to throw std::exception
...so that exceptions like std::bad_alloc need not be treated in C++
implementations of UNO interfaces to not cause std::unexpected.  Of course, this
requires implementations to be adapted and actually mention std::exception in
their exception specifications.

Change-Id: Ie7f91e7ca47d8a81e3d0ba817e65d83c7823af75
2013-10-20 16:10:53 +02:00
Stephan Bergmann
eb37196aa7 Some more cppumaker "css" clean-up
...hopefully, all generated headers that use css (indirectly) include sal/types.h

Change-Id: Iaa40fa014d54b57b395eafda8b4f35ca395d55b0
2013-10-20 16:10:53 +02:00
Noel Grandin
44b96b1d76 fdo#70285 cleanup generated C++ code
Change-Id: Ic43628de53c5139ef43bb48723fb1e0788af1cd1
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-20 16:10:53 +02:00
Caolán McNamara
f8d5bd0705 Related: fdo#38838 remove operator=(const sal_Unicode*)
Change-Id: Id14482d3088a81b012acf5183a595e7d41e860fc
2013-10-20 14:54:47 +01:00
Roi Illouz
d8d0b83435 Fix breakpoint support for Xcode
Change-Id: Ifd80d9128fdd37f91377ccb48e91db273a5b1770
Reviewed-on: https://gerrit.libreoffice.org/6358
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
2013-10-20 13:15:00 +00:00
José Guilherme Vanz
288f0029c6 fdo#52622 - Reduce copy and paste code
This commit removes copy and paste code, creating a constructor for it

Change-Id: I7a66cfda7fc7c11308d155a7a890352fdacfaacc
Reviewed-on: https://gerrit.libreoffice.org/6356
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2013-10-20 12:25:45 +00:00
Laurent Balland-Poirier
63f705643e L10n of SWF export options dialog
Change-Id: I91d29a81389e36ddf34d56760cea588c0a7c12f6
Reviewed-on: https://gerrit.libreoffice.org/6324
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2013-10-20 12:22:27 +00:00
Stanislav Horacek
e231c5d9d4 Updated core
Project: help  b84ad6a5bf1076093ef74da9f8a53ed870629818

fdo#70632 remove incorrect notes for logical functions

Change-Id: Ifaa57c0f284aaa7162554ab84249559db042b28e
Reviewed-on: https://gerrit.libreoffice.org/6357
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2013-10-20 12:10:19 +00:00
Caolán McNamara
11265856c5 drop some tools/string includes
Change-Id: I83698b10c0c4fef1929d62be809ac7d77e9a3502
2013-10-20 12:03:50 +01:00
Caolán McNamara
35373db029 Related: fdo#38838 remove String::Assign(const sal_Unicode*)
Change-Id: I0dfa34732acfd20e71fa3876466552338332610b
2013-10-20 12:03:50 +01:00
Ptyl Dragon
6dd8449172 fix save several file on by reseting the xstorable on close
Change-Id: I329d43e06b0c81cebda0464ebb0fff41714020a3
Reviewed-on: https://gerrit.libreoffice.org/6355
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
2013-10-20 09:23:22 +00:00
Lionel Elie Mamane
b89fb0d03e fdo#68657 bool->string conversion to 1/0, not "true"/"false
This matches what OO.org / older versions of LibreOffice did, and which was inadvertently changed in 2bd856e6

Reviewed-on: https://gerrit.libreoffice.org/6275
Reviewed-by: David Ostrovsky <David.Ostrovsky@gmx.de>
Tested-by: David Ostrovsky <David.Ostrovsky@gmx.de>

Conflicts:
	connectivity/source/commontools/FValue.cxx

Change-Id: I1d45ea975a096c599a996caafc41e4aa06d35fcd
2013-10-20 11:16:39 +02:00
David Ostrovsky
a8eb7a14ff Extend test to cover changed toString() conversion for bool types
Change-Id: I8becffd0c2f12c17495872a99192c7679380d05f
2013-10-20 11:02:37 +02:00
Lionel Elie Mamane
02a11749da fdo#70496 revert to using libmysqlclient
Change-Id: I5b98b5e7840e4f1c6005aee0c1f43ef814ecf77b
2013-10-19 23:03:14 +02:00
Lionel Elie Mamane
96953171bf update libmariadb to bzr revision 101
Change-Id: I98b7442aa9843f206549ad7c5a2ae141b70b1542
2013-10-19 23:03:01 +02:00
Caolán McNamara
eb007bb6d8 Make copy and pasting non-ascii text from editengine work again
regression since 80df527758

Change-Id: Ifcd8f97fdeb078be1884cfbd7175ab15ac30b23d
2013-10-19 20:18:48 +01:00
Kohei Yoshida
9b18a49fdd approxEqual with 0.0 always is false. Do a normal non-equality check.
Plus approxEqual is slightly slower.

Change-Id: I16e7db6b06b3c0eceb8b8a1b7afd29660ff1da6a
2013-10-19 14:57:59 -04:00
Caolán McNamara
31ec354708 fix CID#1038503 uninitializ
Change-Id: I7b85475d757695a0e3573627266b7756989f81a7
2013-10-19 19:16:34 +01:00
Caolán McNamara
7e2d03efbc fix CID#1103762
Change-Id: I4bf0458bfdba2f53c685bba40d561a8211a28e66
2013-10-19 19:16:34 +01:00
Caolán McNamara
3194487d62 CID#1038307 Negative loop bound
fix of coverity#1038307 Negative loop bound
d9ac156b2d wasn't complete, it assigned possible
-1 int32 to unsigned value before comparison, so -1 not detected.

Change-Id: I6c2805acae8e776902d74c641e01c036193ce3d8
2013-10-19 19:16:34 +01:00
Caolán McNamara
415c1ce394 CID#1038502 uninitialized member
Change-Id: Ie69689748e6e38e3d269855a4c72e78d7979119b
2013-10-19 19:16:34 +01:00
Caolán McNamara
577c0818bc CID#1038503 uninitialized member
Change-Id: I4ceb50cf957b70a43848bb78aeaddc7957d3ffd7
2013-10-19 19:16:33 +01:00
Caolán McNamara
5f911c416b CID1078820 has already been dereferenced on all paths leading to the check
Change-Id: I5210d67259d445f6e7f52f176cd67af82d687e37
2013-10-19 19:16:33 +01:00
Caolán McNamara
6561a048c3 CID#1103655 logically dead code, we check for < 4 already
Change-Id: I9e917530528d6e48f418f2b8fa417290a40c2403
2013-10-19 19:16:33 +01:00
Caolán McNamara
984d10ca8d CID#1103675 use normal assert, as it's toast anyway
Change-Id: I065ce5f80f0c54443aca9378a653a9f25175feee
2013-10-19 19:16:33 +01:00
Caolán McNamara
9f8a3e7329 CID#1103676 use normal assert, as it's toast anyway
Change-Id: I47340d71b5f3af9c06556965f240fb084440ea27
2013-10-19 19:16:32 +01:00
Caolán McNamara
f69a5ff7ab CID#1103681 annotate as deliberate fallthrough
Change-Id: I731ea6aca73a81420e3d23cdb504a6151112d9a5
2013-10-19 19:16:32 +01:00
Caolán McNamara
77b6b4a9c2 CID#1103755 unint members
Change-Id: Ic6961e3f18aed2f271f80c69d17a5c34a0c9fa8e
2013-10-19 19:16:32 +01:00
Caolán McNamara
8a241542a4 CID#1103761 uninit member
Change-Id: I4212adb9c0cb8e1693df8725801188bc2154fffe
2013-10-19 19:16:32 +01:00
Caolán McNamara
ec2c07b8b7 CID#1103762 uninit member
Change-Id: Ie46df319bed04ad64275e2385b8e3abc0d41295d
2013-10-19 19:16:31 +01:00
Caolán McNamara
0c28b1d555 CID#703918 ensure buffer is null terminated
Change-Id: If7937abf1ea51578187269a48af58bdede569ed6
2013-10-19 19:16:31 +01:00
Caolán McNamara
e8c15a9c20 SetS only used once with constant values
Change-Id: I2223c22da5bee6d9f9741c96eafe4d65e15dcb55
2013-10-19 19:16:31 +01:00