try to convince coverity of the errors of its ways
Change-Id: I4e847f3773931dccaff1724166072bfde0b97941
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170438
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
This patch allows tools::PolyPolygon to be iterated using c++11's
fancy range-based for-loops. It also upgrades a bunch of old-style
for-loops iterating over polypolygons to the new style to make code
more readable.
Note that not all for-loops iterating over polypolygons have been
upgraded, as I didn't find a way to automatically find those. I just
did a few I found manually.
Change-Id: Ifa8d0d44e6f0aa28fdcfd87d70058b12f48c1349
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168730
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Make variable nHScrX have tools::Long data type as it is expected to be tools::Long when used in SetPostSizePixel
Change-Id: If7e0c1ee1a9832b215c766cbf8bf916c731edfd9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167804
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
Thank you Kevin for having spotted this!
Change-Id: Ic63469d2d8dfd3f7848b6fc2250f90271055c027
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170449
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
appearance in document
Adds a drop down control to the Writer Manage Changes dialog/sidebar
panel that can be used to select how the changes list is sorted.
Change-Id: I9602322ec61ae6e15a08fbc26aa69de1b64294e5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170390
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
We did not call the method on the superclass when we don't handle
the key ourselves, but we should.
Change-Id: I67d55773b7e86297c00727b4791c16a1adcc37f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170430
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Delete annotation isn't active if no annotation is selected, but
we do not report a new selection anymore, so fix this.
Change-Id: Idb455d0c0d42412c55de4a7ca037342b58da548b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170429
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
to avoid it accidentally coming to life during shutdown.
Change-Id: I016a3396639c30350432b60c375c9777e551eb84
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170425
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
This change includes the following scalability improvements for
documents containing extremely long paragraphs:
- Reduces the size of layout contexts to account for line breaks.
- Disables a misbehaving glyph cache performance optimization for long
strings.
Change-Id: Ie9a3365076c0d112a7a655988d672a9f4609b42b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170420
Tested-by: Jenkins
Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
and
cid#1556100 Use of auto that causes a copy
cid#1556199 Use of auto that causes a copy
cid#1556239 Use of auto that causes a copy
cid#1556313 Use of auto that causes a copy
cid#1556373 Use of auto that causes a copy
cid#1556680 Use of auto that causes a copy
cid#1557020 Use of auto that causes a copy
cid#1557099 Use of auto that causes a copy
cid#1557251 Use of auto that causes a copy
cid#1557334 Use of auto that causes a copy
cid#1557468 Use of auto that causes a copy
Change-Id: Ib5ab5b33eabcac3d18899ceaaa9119e13b0139f1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170412
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
...so that testing its StringAttribute stars out with a known state. And which
revealed that the test code in unotest/source/embindtest/embindtest.js was
actually wrong in assuming that that UNO attribute would be represented by a JS
accessor property, when actually it is represented by a pair of
get-/setStringAttribute member functions.
Change-Id: I1a6e7c9f26e9a08cd089b7972a23f4c608c6b1bc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170414
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
Up to now that genereal buffering mechanism used
typeid.*hash_code to identify the class. As we
have learned this is not safe. Thus I changed it
to use enum'ed SystemDependentDataType definitions
Change-Id: I803912ec419290db1d40bae0bc41364fad64cbfd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170385
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
Prior to this patch, the selection overlay was painted above the cursor when scrolling/resizing the window. This patch reorders it so that the selection overlay is always below the cursor.
Change-Id: I5a9a66eeb6285b4a9b8954a44189ddcb6039d155
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170299
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Tested-by: Jenkins
Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Added a check for the existence of a file at a given URL.
If the specified file could not be found, the path formed from the
directory containing the presentation file and the file name is used.
Change-Id: Ia4124f4fa5e5cef19c81f325676749a2540e486a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164023
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
It used getVectorGraphicReplacement once, getting a bitmap with pixel
size that depended on the default device DPI, unrelated to the needed
bitmap size. It was not updated later, using the cached bitmap for any
requested size.
The DPI passed to convertPrimitive2DSequenceToBitmapEx must represent
the relation between the vector logic size and the pixel size of the
generated bitmap, not the target device DPI.
This change introduces VectorGraphicData::getBitmap to obtain a bitmap
for any requested pixel size, and uses it every time in the introduced
ImpGraphic::updateBitmapFromVectorGraphic method every time it needs a
new size of the image.
Change-Id: Ife1305821fff28f0cd4070615ab032211a5d8c4f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170391
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
