After the changes related to EMF+ reworking, much of the code was removed
from VCL, e.g. commit 217ad59a41 (tdf#111486
Removed not used EMF+ code, 2018-12-07). EMF+ code is now in drawinglayer
(see EmfPlusHelperData::processEmfPlusData). Unfortunately, we can't make
ImpGraphic::draw in VCL to use drawinglayer for rendering, because VCL is
lower in dependency tree (it only can use drawinglayercore).
Change-Id: I08f8c8ec66baf3dde1f35481144d5e1819bb5fc1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170311
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Since a1295cb177
"python: upgrade to 3.10.14 (master only)"
because the regex expression no longer matches
"error.cpython-310.opt-1.pyc" with two digits after "error.cpython-3"
Change-Id: I78f566da20e6b591bfa76c36dc69ea3125946d82
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170315
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Previously, when using proportional line spacing <100%, Writer applied
inconsistent height and ascent adjustments to the first and non-first
lines of paragraphs. This caused Writer to render text at inconsistent
vertical offsets.
Height and ascent adjustments are now consistent.
Change-Id: I303d6aa379007f3fa3e8c1ebb981ef205864708a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170307
Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
Tested-by: Jenkins
When the window is not maximized, the highlight overlay outside the current view is not painted when the window is resized. This patch fixes this issue by repainting the overlay when the window is resized.
Change-Id: I4ad35dcdabc0c95fd24c52a7b9cf7bc6f2583c1c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168192
Tested-by: Jenkins
Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
My debug build is slow enough already, no need to make it worse.
People who want it, can turn it on explicitly.
Change-Id: I8677534d8f0142699baa6b95a249ae5f70c5cc3c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170269
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Sort By > Document Position results
With out the patch installed gtk sorts by the Action column. x11 and qt
also do something other than expected.
Change-Id: Ic36e79cf928e5ba142b7ff435999e806b1d56214
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170059
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
This is a followup that fixes tracked change comments are not always
highlighted in the Manage Changes dialog/sidebar panel when the
anchor triangle is clicked on in the document.
Change-Id: I0bf8bebf8133777e79101e908afd268ab44c0d68
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170258
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
...after c75c21eef6 "Upgrade raptor to 2.0.16",
where it now started to fail with
> libtool: link: LD_RUN_PATH="/usr/local/lib:" /usr/bin/ccache /home/tdf/lode/opt_private/clang-llvmorg-12.0.1/bin/clang --gcc-toolchain=/opt/rh/gcc-toolset-12/root/usr -fsanitize=address -fsanitize=undefined -fsanitize=float-divide-by-zero -fsanitize=local-bounds -fsanitize-blacklist=/home/tdf/lode/jenkins/workspace/lo_ubsan/sanitize-ubsan-excludelist -fno-sanitize=function -DLIBRDF_INTERNAL=1 -O0 -Wp,-U_FORTIFY_SOURCE -fstrict-aliasing -fstrict-overflow -ggdb2 -gsplit-dwarf -Xclang -debug-info-kind=constructor -Wl,-z -Wl,origin -Wl,-rpath -Wl,\$ORIGIN -Wl,-rpath-link -Wl,/home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program -Wl,-z -Wl,origin -Wl,-rpath -Wl,\$ORIGIN -Wl,-rpath-link -Wl,/home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program -o .libs/redland-db-upgrade db_upgrade.o -L/home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/UnpackedTarball/raptor/src/.libs /home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/UnpackedTarball/raptor/src/.libs/libraptor2.so -L/home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/UnpackedTarball/libxml2/.libs /home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/UnpackedTarball/libxml2/.libs/libxml2.so -L/home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/UnpackedTarball/rasqal/src/.libs /home/tdf/lode/jenkins/workspace/lo_ubsan/workdir/UnpackedTarball/rasqal/src/.libs/librasqal.so ../src/.libs/librdf.so
> /opt/rh/gcc-toolset-12/root/usr/bin/ld: /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libicuuc.so.74: undefined reference to `__ubsan_vptr_type_cache'
> /opt/rh/gcc-toolset-12/root/usr/bin/ld: /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libicuuc.so.74: undefined reference to `__ubsan_handle_function_type_mismatch_v1'
> /opt/rh/gcc-toolset-12/root/usr/bin/ld: /home/tdf/lode/jenkins/workspace/lo_ubsan/instdir/program/libicuuc.so.74: undefined reference to `__ubsan_handle_dynamic_type_cache_miss'
> clang-12: error: linker command failed with exit code 1 (use -v to see invocation)
> make[3]: *** [Makefile:489: redland-db-upgrade] Error 1
(<https://ci.libreoffice.org/job/lo_ubsan/3239/>) because $(CC) is used to link
a (nominally C-only) executable that links against C++ ICU shared libraries that
in turn require a C++-specific UBSan library to be linked in. So just use
$(CXX) for linking instead.
Change-Id: If7c61c6ee7e1b43965a928b1560f8ab4ae2b0603
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170277
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
...by implementing (for now) just enough of the cpp2uno half of the Wasm UNO
bridge to make it work. In general, that half suffers from the same issue as
the already-implemented uno2cpp half, namely that Wasm doesn't allow to generate
code on the fly (which, in this case, would be needed to implement the vtable
slot trampoline functions). So, for now just hard-code the few
vtableSlotFunction_* that are needed by the UNO interfaces for
cppuhelper/source/exc_thrower.cxx. (A proper fix would probably use the same
approach as for the uno2cpp half, and use something like wasmcallgen to generate
at least all the vtableSlotFunction_* needed for udkapi/offapi upfront.)
The RTTI for the exceptions needs to be unique across the executable for
exception catching to actually work (as it compares exception types by RTTI
address rather than by name). We thus need to export all the relevant RTTI
symbols (which I hacked into the existing wasmcallgen for now, even if that
makes that executable's name a slight misnomer now), and access them with a new
jsGetExportedSymbol. (This exporting would also be needed by the "classical"
approach of using dlsym on the main module, cf.
<https://gerrit.libreoffice.org/c/core/+/167187> "WIP: Emscripten: Set up
support for dlsym from main module". And while that dlsym approach would work,
it is much simpler to just use that jsGetExportedSymbol than to use a dlsym
detour, and thereby avoid all the hassle of -sMAIN_MODULE detailed in the commit
message of that Gerrit change.)
It also turned out that including Emscripten's <cxxabi.h> needs
__USING_WASM_EXCEPTIONS__ to be defined, because it uses that in its declaration
of __cxa_throw. (The source for setting that define internally in Emscripten is
get_cflags in the emsdk's upstream/emscripten/tools/system_libs.py, which
defines __USING_EMSCRIPTEN_EXCEPTIONS__ for the non-Wasm, Emscripten JS
exception mode, and defines __USING_WASM_EXCEPTIONS__ for
--enable-wasm-exceptions, which we use. The commit message of
f4ec967599 "Fix redefinion of Emscripten
__cxxabiv1::__cxa_exception" documents my prior confusion of when one or the
other would be defined.)
Change-Id: Id08765ab5b4ce1553dc3a61648324526185cb64c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170246
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
This is required for OOXML, but not for ODF.
Unclear if there are use cases for this with ODF, can add some
conditions if it turns out to be a problem.
Change-Id: I3810da5c2273574135d133b4a9bbad98dc97af44
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170223
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
This exposes the (impress only) function to get the current
presentation info in JSON format and the slide rendering functions
that enable rendering of slide layers to a bitmap.
Change-Id: Id0591d5894f730eae48b3edc986ae5d804ce7c81
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170263
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
If this is an instance of ScUndoAutoFill, ShowBlock() will invoke
ScTabViewShell::MoveCursorAbs() which will delete this instance
so invoke ScSimpleUndo::EndUndo() first.
Change-Id: I7ef6dfa0444c38974e1d8c5af6672144f045d22d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170254
Tested-by: Jenkins
Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
I have "Noto Sans Arabic" installed system wide:
file: "/usr/share/fonts/google-noto-vf/NotoSansArabic[wght].ttf"(s)
fontversion: 131858(i)(s)
and there is the bundled version:
file: "./instdir/share/fonts/truetype/NotoSansArabic.ttf"(w)
fontversion: 131727(i)(w)
what we generally want to do is pick just one font, the version with the
higher number, but in this case we don't see them as near-duplicates and
so add both of them.
In my case then using any font/glyph fallback for a "en" font suggests
"Noto Sans Arabic", presumably because the bundled one has those glyphs,
but we seem to end up rendering with the system one which doesn't have
them, so font/glyph fallback for fonts that are non explicitly
configured somewhere in fontconfig end up with missing glyph symbol.
So additionally disregard the FC_INDEX and FC_POSTSCRIPT_NAME fields
when comparing fonts to find the higher version.
https://bugzilla.redhat.com/show_bug.cgi?id=2262410 has a similar
sounding problem but in the end I think it is a different issue, but
maybe the same trigger of having "Noto Sans Arabic" at the start of
the list of possibilities.
Change-Id: I500fb9cad793b63d0fbeb8c4bc1246fd68be39fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170251
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
Avoid decomposition of it in AnimatedExtractingProcessor2D
by handling there directly. Goal is to find/extract animation
primitives, so only do something when the contained Graphic
is active
Change-Id: I1d168428ddbaaac2c9d5fde7b26be380ba442c30
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170203
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
Have both a content control and a comment in a document, export to PDF
while "Comments in margin" is enabled, now the default text of the
content control has an incorrect position / size.
The transform for normal writer comment was added in commit
eb1c048005 (Resolves: fdo#36815 enable
printing WYSIWYG sidewindow comments, 2014-04-16), and e.g. the
hyperlink rectangles are transformed correctly, but the content control
PDF export code added in commit 82d90529dc
(sw content controls, rich text: add initial PDF export, 2022-09-12)
missed this.
Fix the problem by extracting the actual transform to a new
SwEnhancedPDFExportHelper::MapSwRectToPDFRect() and then using it in
both SwEnhancedPDFExportHelper::SwRectToPDFRect() (e.g. hyperlinks) and
SwContentControlPortion::DescribePDFControl().
Note that the font size of the PDF widget also needs scaling down, also
fix here.
Change-Id: I9cccbd569070336e1720ba2a82e91793083722f1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170266
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
As shown by
Change-Id: I8d19e15d8c6e95cdc5e797e6b9524d9299dc1fdd
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Tue Jul 9 17:32:01 2024 +0200
icon choice ctrl: Always use SvxIconChoiceCtrlPositionMode::AutoArrange
, `SvxIconChoiceCtrlPositionMode::AutoArrange` is the only
positioning mode that actually gets used, so simplify the code
by dropping the effectively unused code for
`SvxIconChoiceCtrlPositionMode::Free`.
(`git show --ignore-space-change` can help to see the "actual
changes" more easily.)
Change-Id: Icd5ee30eafefafbf597681e28521d5a566ea0af3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170249
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
`SvxIconChoiceCtrl_Impl` is only used by `SvtIconChoiceCtrl`
and that one explicitly sets
`SvxIconChoiceCtrlPositionMode::AutoArrange` in its ctor
to override the `SvxIconChoiceCtrlPositionMode::Free` default.
In a first step, default to `SvxIconChoiceCtrlPositionMode::AutoArrange`
and drop the setter, to simplify the code.
Further cleanup will be done in a follow-up commit.
Change-Id: I8d19e15d8c6e95cdc5e797e6b9524d9299dc1fdd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170248
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Instead of storing the current list position in
the `SvxIconChoiceCtrlEntry` and having to take
care of updating that when entries are added to
or removed from the `SvxIconChoiceCtrl_Impl` in
order to keep it in sync with the elements in
the vector, just calculate and return the vector
index in `SvxIconChoiceCtrl_Impl::GetEntryListPos` on
demand.
Change-Id: Iec4e700c1ccc1261fde778b1b38af4dbac5a14c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170247
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
GetMarkedObjBitmapEx works on BitmapEx now, and does exactly
the same.
Change-Id: Ia7333515996803fcf1ac10515950ce2f96ab01fe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170239
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
Interface and implementation to expose the ability to render
the slide's layers to a bitmap.
Change-Id: I3da48585e498354592e163d84bd29659b233c255
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170214
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Since
Change-Id: I52c40acf2024b25b0cd713fd7c91d7e0b59f4663
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Tue Jul 9 11:55:26 2024 +0200
icon choice ctrl: Drop WB_ALIGN_TOP
, it is only written to, but never read, so drop it.
Change-Id: Iee03649a1ff99bf77383710835995b393cab689e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170212
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
`WB_NOSELECTION` and `WB_SMART_ARRANGE` were
dropped earlier, so drop their doc as well.
There's no `WB_SMALL_ICON`, but `WB_SMALLICON`,
so adjust the name in the doc as well.
Change-Id: I8eb36d1184743f8e7a3e501f05e3f4b5a374e51d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170210
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
