problem:
it was very difficult to select line in online,
specifically in writer if line is very think and
it was almost impossible to select line
Change-Id: Ib641cd3d9795b93d47c78bc8f57211f51714844d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168837
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
(cherry picked from commit a0612242a395e1be1fe8383537bc5a82d6b882ac)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169011
Tested-by: Jenkins
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I6727def5dd42ecd5dae3ddd27d2af733b5883e09
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170006
Tested-by: Jenkins
Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
The issue is that we are trying to set the connector shape properties
too early, but the shapes that we want to connect to have not been created yet.
Follow-up to commit Ie95ccd5bcd4d5c3f9c45c7dcc4f88acc0c9438aa
"tdf#157172 tdf#157460 PPTX import: fix connectors adjustment values"
Change-Id: I63c76535cc718bc46d5c3ed5489b752925cd6a77
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170007
Tested-by: Jenkins
Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
Probably the only legitimate use of such is self-extracting archives,
irrelevant for LO.
ofz56826-1.zip is an example; given what Info-Zip unzip prints about
this file we don't want to successfully open it.
Change-Id: I9568710227e4a152f9dc7bc356184394d7da8eba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170002
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
In online the client side comments/annotations are used, so to
keep this behavior for presentations we only enable the core side
rendering of annotations when the document is a PDF. No change in
the desktop applitation.
Change-Id: I50ffd1b6d81d2fcf6ef9f821e783ae228e39e4e6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169969
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
after commit 85fd526fc6
"fix and simplify the ItemInstanceManager mechanism"
The problem is that some *Item classes in sw/ and sc/
share WhichIds, and a whole bunch of SfxBoolItem
subclasses share the same SfxItemType enum value.
So we ended up mixing and matching objects
of different concrete subclasses in a given
*ItemManager collection.
Add some asserts to the global pool code to catch
issues like this earlier on.
Add unique value of the SfxItemType enum for all
the SfxBoolItem subclasses
Change-Id: I3c8d4e02be1cd412b0292e973a6498df5f8e7102
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170003
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Change the condition if the documents are immediately closeable.
Now, save locked documents are not immediately closeable.
Remove the check if in quit or closing docs in SID_CLOSEDOC in
objserv.cxx as it becomes unneccessary.
Remove some extra new lines which are unnecessary changes from
before the patch.
Change-Id: Iab16629fe436f4365000fb2a016bbb1fb49c181c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169983
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
Some operations, like DrawViewShell::Activate, trigger FuDraw::ForcePointer.
The latter may call SdrView::PickAnything to test if the pointer is over an
object. In SdrMarkView::CheckSingleSdrObjectHit, the bound rectangle of the
object is tested first, which doesn't need the object's deep processing. If
the point in in the rectangle, the object is processed further, which may
render the object. The hit test is performed using a tolerance.
Commit 56a1f9bea2 (sd: extend test to check
the PDF pages aren't rendered when loaded, 2020-03-26) made sure that the
rendering doesn't happen in the LOK mode. In that mode, the mouse position
is unchanged from the values set in the ImplFrameData ctor. Previously it
was enough for the test, that the initial position was [-1, -1], which made
the point outside of the bounding rectangle of the objects. But an upcoming
fix for the map mode calculations makes tolerance large enough to consider
the point inside the rectangle, which triggers rendering and fails the test.
This change makes the default position [-32767, -32737], which should be
reliably outside of the tested rectangle.
Change-Id: Ie1142729448f7ac3c628880140f123cde66b404e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170005
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
This will prevent also opening with RepairPackage, would need to adapt
ZipPackage::getZipFileContents() a bit, but let's hope nobody acutally
has such files.
Also treat path that starts with "/" as invalid, presumably it's not
allowed by APPNOTE.TXT:
"The name of the file, with optional relative path."
Change-Id: Ic694ea2fb34f5de1d490a9a251cf56e4004e9673
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169994
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Tested-by: Jenkins
it was disabled in 731f7fe778
"disable pytest_ssl on mac" with no apparent reason
Change-Id: I7d867ad771f1459a598c4ca346390e732929d705
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169985
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(regression from commit 8b333575ee)
So it should only be set if the state is still UNKNOWN. But
SfxObjectShell::ImplGetSignatureState() is called before the repair
dialog is shown, so make sure that the second import (with
RepairPackage) finds both members as SignatureState::UNKOWN.
Change-Id: Ic914016dde6425a4d95fba7f6f66411305553930
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169989
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Limiting the contour wrapping polygon to only opaque pixels
causes clipping of any shadows or other semi-transaprent
areas in the image. So, instead of testing for fully opaque
pixels, treat pixels that are not fully transparent as opaque.
Also, tdf#161833 would cause semi-transparent pixels to be
treated as fully transparent pixels when calculating the wrap
contour for an image. To force the correct contour when loading
a document, force the contour to be recalculated by ignoring
the saved polygon if the contour is set to "recreate on edit".
Change-Id: Ibe256f54e1c82de30c2b7d5b92a69344b4a7ba10
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169745
Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Currently style:rotation-angle of table-cell-properties is imported
using ::sax::Converter::convertNumber. That imports only integer values
and ignores units. But ODF uses the data type 'angle'. That is a double
with optional units 'deg', 'rad' or 'grad'. A unit-less value is
treated as degrees.
The patch changes the import to use the new method
::sax::Converter::convertAngle(), that was introduced in commit
9f62c7a0f2.
Change-Id: I98c35a762e90b959a005f5bcdf810c5676cc8b6a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169891
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
This makes the AnnotationObject to resize the frame to the size of
the text content, or else the text that is too big will be shown
outside the object's frame (rectangle). For some reason we need to
set the object as a "text frame" (mbTextFrame = true) or else it
will not allow to automatically adjust the frame to the text
content.
Change-Id: Ib2b9a7c07626fe8b0a2286cfd67c3bf37cf9af03
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169642
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Jenkins
We are doing a lot of work in ScAttrArray::SetPatternAreaImpl,
where we move the mvData vector of CellAttributeHolder around,
so inline and reduce some of the work.
The move operator= can be simplified, leaving some of the work
to the destructor (which may well be elided when moving
arrays of elements around).
Reduces time from 50s to 39s
Change-Id: I358f48fa30f785f7b3f221079db93ab0288a7f14
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169941
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
we now have 16k columns, so storing a flat array of columns
where most of them are empty is bad for performance.
Rather store a sorted data-structure of all the ranges,
reduces time from > 5 mins to ~50s.
Change-Id: I92327daf06469c1b9d1f4c427b8ebf812641a8e6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169940
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
The previous `if (bSelected)` body a little bit further
up in `SvxIconChoiceCtrl_Impl::PaintEntry` already
has
rRenderContext.DrawRect(CalcFocusRect(pEntry));
to draw a border around the selected entry.
One border is enough, so don't draw another one
using
`vcl::RenderTools::DrawSelectionBackground`
(pass false instead of true for the `bDrawBorder` param).
For the gen and the Qt-based VCL plugins that use
Cairo rendering by default, this avoids the
additional misplaced and not properly cleared selection
rectangle.
See tdf#144981 comment 6 for where the problematic
handling in the Cairo rendering path is, but which also
mentions that changing this would break other things.
For then gen VCL plugin using Skia (`SAL_FORCESKIA=1`)
or on Windows, I see no visual change for either the
"Hyperlink" dialog (Ctrl+K) or the "Page Style" dialog
(Alt+Shift+P) in Writer with this change in place while
moving focus between entries.
On Windows, when moving focus out of the icon choice
control (into the tab page), the border now remains
black on all sides instead of being partially black
(at least the top border) and partially blue (at least
the bottom border), so it's more consistent there as well
now.
Change-Id: I6db415344e9276ce89d41c6b40fb93fc38ddf9a2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169972
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
* Drop superfluous check at the start. (Loop will
just do nothing if there are no elements.)
* Use range-based for.
Change-Id: Idbe0ba67268cf76d38b27fcf94e59eb8abd5f566
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169971
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Since
commit 35775e291d
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Tue Jul 2 12:34:57 2024 +0200
tdf#161853 Drop now unused SvxIconChoiceCtrl_Impl::SelectRect etc.
, that flag is never set, so there's no need to check
for that. Drop it.
Change-Id: Ibc2efdfc9b54c19bb90c2e71cc80e0cb4a0321a1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169970
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
instead of generating new ones.
Change-Id: I8979eaa694642cebd552534eeddcff5483831e6e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169846
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
instead of generating new ones.
Change-Id: If64690ac2aa22542e6b3939f3ed9cdc3c9f3be84
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169844
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
This mechanism to manually sort the entries by setting
a link/pointer to the neighbours isn't actually used, so
drop the code to maintain a linked list.
See
Change-Id: I44eceb41866bb6d99ccea032f98637a42dabc9ee
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Wed Jul 3 10:44:46 2024 +0200
tdf#161853 Drop always null SvxIconChoiceCtrl_Impl::pHead
Change-Id: Ib939145999725232d803103dc1fd0b49fa2d425a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169916
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
