Missed a special case in previous commit, in case the input is
completely empty and PK11_DigestFinal() doesn't see a problem with it,
aResult could be empty too.
Change-Id: I8ea900774ae390857307ec5bab38876bead6bc86
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160441
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
...when building against LLVM 18 trunk libc++,
> In file included from Numbertext.cxx:6:
> ~/llvm/inst/bin/../include/c++/v1/locale:3772:1: error: 'wstring_convert<std::codecvt_utf8<wchar_t>>' is deprecated [-Werror,-Wdeprecated-declarations]
> 3772 | wstring_convert<_Codecvt, _Elem, _WideAlloc, _ByteAlloc>::
> | ^
> ~/llvm/inst/bin/../include/c++/v1/locale:3649:17: note: in instantiation of member function 'std::wstring_convert<std::codecvt_utf8<wchar_t>>::to_bytes' requested here
> 3649 | {return to_bytes(__wstr.data(), __wstr.data() + __wstr.size());}
> | ^
> Numbertext.cxx:164:22: note: in instantiation of member function 'std::wstring_convert<std::codecvt_utf8<wchar_t>>::to_bytes' requested here
> 164 | return converter.to_bytes( s );
> | ^
> ~/llvm/inst/bin/../include/c++/v1/locale:3591:28: note: 'wstring_convert<std::codecvt_utf8<wchar_t>>' has been explicitly marked deprecated here
> 3591 | class _LIBCPP_TEMPLATE_VIS _LIBCPP_DEPRECATED_IN_CXX17 wstring_convert
> | ^
> ~/llvm/inst/bin/../include/c++/v1/__config:942:41: note: expanded from macro '_LIBCPP_DEPRECATED_IN_CXX17'
> 942 | # define _LIBCPP_DEPRECATED_IN_CXX17 _LIBCPP_DEPRECATED
> | ^
> ~/llvm/inst/bin/../include/c++/v1/__config:915:49: note: expanded from macro '_LIBCPP_DEPRECATED'
> 915 | # define _LIBCPP_DEPRECATED __attribute__((__deprecated__))
> | ^
(The warning is apparently only emitted late during compilation when
instantiating template code, so extending the existing `#pragma GCC diagnostic
push/pop` area did not work, and the `#pragma GCC diagnostic ignored` rather had
to be enabled all through to the end of the TU.)
Change-Id: Iffc1c468426407e3252724d18f358b9923f7f733
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160437
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
When scrolling on some Intel Macs either via dragging
the scrollbar thumb or via swiping the trackpad with two
fingers, final repaint of scrollbars doesn't appear to
get flushed to the screen. It appears that scrollbars
aren't updated and repainted until after a batch of
native scroll events have been dispatched. On slower
machines, this lag is long enough that any pending
forced flushes have already been done so when the timer
that repaints scrollbars finally fires, the repainted
scrollbars won't get flushed to the native window until
the next normal flush which may not occur until seconds
later.
Change-Id: Iadef6812cd2495a28347560caae81f604c908b51
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160440
Tested-by: Jenkins
Reviewed-by: Patrick Luby <plubius@libreoffice.org>
If this function returns null, storing a document will proceed without
reporting an error to the user, and lose all the data.
Change-Id: I0f9fd53702321e7997b28e12eb5bed3349bbcc13
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160435
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* Update translations from branch 'master'
to 193b35fe99d7112b6a2b9c8077bbca6471326db3
- update translations for master/24.2.0 beta1
and force-fix errors using pocheck
Change-Id: Ie89030ffdc21fe71f753b07ea11bbf838e91417c
before adding it to the list of trusted certificates.
This prevents certificates from being thoughtlessly
added to the list of trusted certificates.
Change-Id: Ifd0273df39f13432ebad72f1289ede0e6e7a8d5c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160427
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
and
cid#1546284 Using invalid iterator
cid#1546275 Using invalid iterator
cid#1546049 Using invalid iterator
cid#1545929 Using invalid iterator
cid#1545870 Using invalid iterator
cid#1545668 Using invalid iterator
cid#1545420 Using invalid iterator
Change-Id: I3ad3000631b4be5917b9c5f49f21b8cc003a309c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159056
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
But make it default-off for the while.
Change-Id: I54e2fb8544ceb5ffe88053504294e2f3d5df50d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160436
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
ScXMLExport::ExportFormatRanges cannot advance because nMaxCols is 0
so busy loop and no progression
In ScRowFormatRanges::GetMaxRows, aRowFormatRanges is empty which is why
nMaxCols is 0
In ScFormatRangeStyles::GetFormatRanges aTables appears to be 30 empty
items.
But why it is empty can't be seen from the bt.
Force this to be an assert to ensure crashtesting can flush out this
case, rather than letting it get killed off as a timeout.
Set this case as an error and break so failure results in an error
message of failure to save instead of a hang.
Change-Id: I827e1e638cddd976a48340f86741c21075afe856
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160363
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Style "Object with no fill no line" was not correctly treated during
automatic translation to UI language
Change-Id: I9364b25e326387110af81494d7fa5e4c05b5f972
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160262
Tested-by: Jenkins
Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
from Impress/Draw
last mention of them was removed in 2006 by:
commit deef3fdfd9
removing a commented out caller
that was already commented out by "initial import" time
Change-Id: I50fefe42a92c752727dfbf3b9d7c645492d034da
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160190
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
...sharing the existing option tab page for the traditional
--enable-online-update feature
Change-Id: Ic7b04bf15bf841a46a96d62cf5a857deaa399428
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160430
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
...by turning the latter into its own option --enable-online-update-mar. (The
intention is to potentially have the experimental --enable-online-update-mar
configured in alongside any traditional --enable-online-update, and have it
disabled by default at runtime---for which some configuration is needed and
which is forthcoming.)
Change-Id: Id53b4f52b310da472b305c8b23c1e2ba1931296d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160424
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
adds new expert option DisableActiveContent
Right now only disables active embedded content / OLE.
If OLE content is being imported via
UNOEmbeddedObjectCreator::createInstanceInitFromEntry with the
expert option DisableActiveContent set, the imported OLE object is
now forced to be ODummyEmbeddedObject.
ODummyEmbeddedObject doesn't implement any other state then
embed::EmbedStates::LOADED (i.e. doesn't implement RUNNING,
ACTIVE etc.) which makes it possible to prevent the imported OLE
object becoming active.
The functions that now throw lang::NoSuchElementException are
usually called on new creation of embedded content via UI. But
since the call sites expect the possibility of embedded content
failing to initialize, that is handled by showing a popup stating
some form of `unable to insert`.
A follow-up improvement of disabling insertion of OLE content via
dialogs could be implemented.
Change-Id: Ib558a2a129b491798f5036a7bb269116545be75d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160402
Tested-by: Jenkins
Reviewed-by: Sarper Akdemir <sarper.akdemir.extern@allotropia.de>
Previously to Highlight some cell's row/column, one had to
get the current cell cursor position, and pass it to HighlightOverlay(),
but now that is not required.
Change-Id: I4d08bf1fa84fcbd4820fd166c1d137bd3d950413
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160151
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(*) Make all of it use a "Scoped" paradigm
(*) pass by value, no need to allocate on heap
(*) make all of the construction go via the *Access constructors, instead of it being some via the constructors and some via the Acquire*Access methods.
(*) take the Bitmap& by const& in the constructor, so we can avoid doing const_cast in random places.
Change-Id: Ie03a9145c0965980ee8df9a89b8714a425e18f74
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160293
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Some of these look redundant, as SfxMedium::GetStorage() already does
this earlier.
Change-Id: Iba178196898adfd4ee260da908c7298f3f2c1734
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160408
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Redo the ODF encryption by storing an ODF package and wrapping it as a
stream "encrypted-package" in another ODF package, such that there is
only one encrypted stream - this requires only one KDF computation.
* This is only enabled in Experimental mode for now.
* Avoid storing unencrypted data in the pTempFile of SfxMedium, as it
is usually created in the same directory as the target file, which
may be on a network share or similar less trusted location.
* SfxMedium::SetEncryptionDataToStorage_Impl() should just set an
error status if it fails (how can it fail anyway)
* when loading a document, SfxDocPasswordVerifier extracts an encrypted
inner package (by calling SfxMedium::TryEncryptedInnerPackage())
* SfxMedium::GetStorage() automatically decrypts an encrypted inner
storage and sets it as the SfxMedium's xStorage
* when storing a document, SfxObjectShell::SaveTo_Impl() creates
the wrapped storages
* One challenge is to keep the macro/scripting signature working; this
can only be put in the inner storage, whereas the document signature
should continue to be on the outer storage; also it must use a Zip
storage, to see the "META-INF" directory. This needs a new
SfxMedium::GetScriptingStorageToSign_Impl() and changes in
SfxMedium::SignContents_Impl().
Change-Id: Ibfee36ce3a9cd030f2aa2ce1484b6d001cba2389
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160401
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
...which happens to accept the original check from
af34108d90 "Use C++20 consteval for the
Color(sal_uInt32) ctor" now, but would still fail to compile the actual code at
> In file included from xmloff/source/chart/ColorPropertySet.hxx:23,
> from xmloff/source/chart/ColorPropertySet.cxx:20:
> include/tools/color.hxx: In constructor ‘xmloff:💹:ColorPropertySet::ColorPropertySet(Color)’:
> xmloff/source/chart/ColorPropertySet.cxx:81:9: in ‘constexpr’ expansion of ‘((xmloff:💹:ColorPropertySet*)this)->xmloff:💹:ColorPropertySet::m_nDefaultColor.Color::Color(10079487)’
> include/tools/color.hxx:82:11: error: modification of ‘*(xmloff:💹:ColorPropertySet*)this’ is not a constant expression
> 82 | : mValue(nColor)
> | ^~~~~~~~~~~~~~
(see the comment at <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98752#c6>
"wrong "error: ‘this’ is not a constant expression" with consteval constructor")
Change-Id: I3b8b92cd7ba31724cf0c9fe38b6cf8aa2abd7c0f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160405
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
157298bb80 "android and bin/update: make pythonic"
had removed it, so that `make create-partial-info` would now fail at least with
> Traceback (most recent call last):
> File "bin/update/create_partial_update.py", line 10, in <module>
> from path import UpdaterPath, mkdir_p, convert_to_unix, convert_to_native
> ImportError: cannot import name 'mkdir_p' from 'path' (bin/update/path.py)
(and no idea if that make target would still do anything useful, beyond this
initial hurdle)
Change-Id: Ib1be3304e2b3468dc187c1b5e24041e68a3677fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160397
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
Only report the "heading-level" and "level" object
attributes for a Writer paragraph when this paragraph
has a heading level that can be reported as the value
of the object attribute.
No longer report the attribute without any value set otherwise,
since the attribute doesn't provide any value then,
but is rather confusing/misleading.
Change-Id: I282345b00a32a74de229058ff368f3b169bf1c03
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160346
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
It appears that calling -[NSView display] overwhelms some Intel Macs
so only flush the graphics and skip immediate redisplay of the view.
Change-Id: I7a94a1ada35526c5eda1b793f872e206b4c833ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160399
Tested-by: Jenkins
Reviewed-by: Patrick Luby <plubius@libreoffice.org>
regression from
commit 1576ef8532
Author: Noel Grandin <noelgrandin@gmail.com>
Date: Thu Dec 23 18:40:44 2021 +0200
osl::Mutex->std::mutex in SvtCommandOptions
Note that this only fixes part of the issue - specifically the part that
the original reporter described.
There is a further issue, not fixed here, which only happens on
Linux/GTK, where the messagebox dialog manages to end up behind the
About dialog, and consequently cannot be closed, which freezes the
program.
Change-Id: Idbb7f51e494a69886c80eb92efaa7cf7c6911c16
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160393
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
157298bb80 "android and bin/update: make pythonic"
had introduced this apparent typo, so that `make create-update-info` would now
fail (and no idea if that make target would still do anything useful, beyond
this initial hurdle)
Change-Id: I63c4e87e06370d99e5d036ce5c7f2a5bda3c1554
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160398
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
