(git show -w is your friend on commits like this)
Change-Id: Ie3a11986f98d196b6134fdc69e76a627e87d137b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124161
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
so gb_LinkTarget__command_staticlink should use the same workaround
for that as gb_LinkTarget__command_dynamiclink does
Change-Id: Ied9d8a3b99f09d6ea1b705e0c1ce3ef3b2d14190
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124156
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Make LOK_CALLBACK_TEXT_SELECTION, LOK_CALLBACK_TEXT_SELECTION_START,
LOK_CALLBACK_TEXT_SELECTION_END and LOK_CALLBACK_TEXT_VIEW_SELECTION
also use pull model, i.e. LO core will only set a flag and when
CallbackFlushHandler needs the actual data it'll use getLOKPayload().
This again avoids a large number of messages passed to
CallbackFlushHandler only for them to be sooner or later discarded.
Change-Id: Ia7528039be996a6e9e8491b4eba3f4133582fa56
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124146
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
Always resulted in the currency's LCID being omitted in the number
format for the default locale, which doesn't immediately harm but
loses the context (what currency a $ sign is actually), and also
lead to the "real" default currency format never matching the one
being generated for the list so no entry was selected if that
format was applied.
Change-Id: I7963e4d3701092d6e227705fc0e8282448f075b1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124152
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
In 4839b7ca3b
< Fix UITests that use File Open dialog to load documents >
the order of execution of load_file method was changed,
making the code after the yield keyword to be executed
after the test code is run, which is not what the original code did.
We need to execute that code before running the test code,
specially setActiveFrame
Change-Id: I4ba436cbdf4fe2261589527f8d38a916d47b94aa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124154
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Semantics were temporarily changed with
commit bba6a4ed92
CommitDate: Mon Oct 25 11:18:31 2021 +0200
Get rid of fuzziness in MsLangId::Conversion::convertIsoNamesToLanguage()
Change-Id: I8bbf77998bea81c5691ba518c7ae25093b0df421
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124141
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
* Update translations from branch 'master'
to 41974fc7ebdc4d8d6d8d017a6e68753fd5a049e3
- update translations for master
and force-fix errors using pocheck
Change-Id: Ic6888555f22c4e961c0734fa685969b43f89c02e
Watching a variable which returns a value from a function always shows
"out of scope" in the watch window of the Basic IDE. In order to resolve
this issue, the name of the variable being watched will be searched also
in the current method instance.
Change-Id: Id383e03925956056931d199fe86d1b352cf8e4eb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124075
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
...from aa2064c5c5 "Improve
loplugin:stringliteralvar", similar to 8b32a3edad
"Fix stack-use-after-scope" (though this case doesn't appear to have caused any
actual issues).
(After manual inspection, there appear to be no further missing `static` at
least in aa2064c5c5 "Improve
loplugin:stringliteralvar".)
Change-Id: I2b3d0d8d2af1d65f0c5bef8a858107020a620974
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124137
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Previously, pElementId (old name) was either nullptr or a pointer to
OUString created from sPlaceholderTag literal. In the methods that
consumed it, it was checked for being nullptr. Now, this is checked
with if the aElementId (new name) is empty or not.
If the variable is an empty string, it implies that it should not
be used.
Change-Id: I560fd479f428341c834ee99b0f8a34e95862e3e0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123439
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
With on-the-fly LanguageTag the fuzzy fallbacks for a few
languages aren't needed anymore. Proper fallbacks should be
obtained when needed, like when configuring default locales, or
configured values used after.
Change-Id: I8b85b8099e085508435036ac846db6c3e516dc23
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124127
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
Returns a range expressed in A1-style as defined by its coordinates
If only one pair of coordinates is given, the range will embrace only a single cell
Arguments:
Row1 : the row number of the first coordinate
Column1 : the column number of the first coordinates
Row2 : optional, the row number of the second coordinate
Column2 : optional, the column number of the second coordinates
SheetName: Default = the current sheet. If present, the sheet must exist
Is complementary to the Offset() method to compute ranges easily
Available both from Basic and Python user scripts
Change-Id: Ib9323441bbd579beb867329c8b0930653462d00e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124093
Tested-by: Jenkins
Tested-by: Jean-Pierre Ledure <jp@ledure.be>
Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
...during CppunitTest_svl_qa_cppunit, after
df42cb6552 "Optimize assignment from
OUStringLiteral to OUString",
> ==918==ERROR: AddressSanitizer: stack-use-after-scope on address 0x2b2e203b5900 at pc 0x2b2e1b9004f8 bp 0x7ffc06726270 sp 0x7ffc06726268
> READ of size 4 at 0x2b2e203b5900 thread T0
> #0 0x2b2e1b9004f7 in void rtl::str::release<_rtl_uString>(_rtl_uString*) /sal/rtl/strtmpl.hxx:1064:9
> #1 0x2b2e1b8d916c in rtl_uString_release /sal/rtl/ustring.cxx:1785:12
> #2 0x2b2e36263ec5 in rtl::OUString::~OUString() /include/rtl/ustring.hxx:493:9
> #3 0x2b2e3622c5ff in (anonymous namespace)::Test::testTdf103060() /svl/qa/unit/svl.cxx:553:1
[...]
> [2304, 2320) 'EXPECTED_G3' (line 550) <== Memory access at offset 2304 is inside this variable
(<https://ci.libreoffice.org/job/lo_ubsan/2176/>).
(aa2064c5c5 "Improve loplugin:stringliteralvar"
had failed to introduce those OUStringLiteral variables as static.)
Change-Id: I59168979fcc4b055d17d1d4f315577eef1027505
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124134
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Replacing std::unique_ptr<char[]> with std::vector<char>
* The data bytes are read into the vector internal storage
* Modification of the internal storage of the vector using the
pointer returned by data() is allowed by the standard
C++ Standard, revision n4830, section 2.3.11.4 Data [vector.data]
Returns: A pointer such that [data(), data() + size()) is a valid
range. For a non-emptyvector, data() == addressof(front()).
https://github.com/cplusplus/draft/blob/main/papers/n4835.pdf
* It could be replaced with std::string when data is not modified
Example: 6c13e5a92e
* std::vector<char> is useful when working with C functions that
get "char *" for writing data. In this case, std::string is not
usable, because data() method for it returns "const char *".
Change-Id: Ife6013b16a1803c3ad7b0c64aa0cb4c8cf4373ed
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123764
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
and make the setting for each category persist
Change-Id: I3ca41cb860734d31fd93d0d30b37c0301bc2f7dc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123960
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Most likely was an oversight when using LANGUAGE_ENGLISH as other
LANGUAGE_FRENCH and LANGUAGE_GERMAN are locales already.
Change-Id: Ie16395340cef9939a5397e3d10d6df6b13ac8d99
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124124
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
* Update translations from branch 'master'
to 26c743b6e210606f1d10d34439d2073ca2140ed6
- Update Slovenian translation
Change-Id: Ic92f48c0e8b021b0e7c1a8fb01b553bb739df2f0
Some LOK messages may get called very often, such as updates about
cursor position. And since only the last one matters, they get
generated every time, which costs some time, and then later except
for one they get all discard again from CallbackFlushHandler queue,
which again costs time.
Change the model to instead only set an 'updated' flag, and
CallbackFlushHandler will request the actual message payload only
before flushing.
This commit changes LOK_CALLBACK_INVALIDATE_VISIBLE_CURSOR and
LOK_CALLBACK_INVALIDATE_VIEW_CURSOR to work this way.
Change-Id: I376be63176c0b4b5cb492fbf529c21ed01b35481
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124083
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
