Re-cat's the build / cross-toolset warnings file at the end of
the host configure run and keeps them.
Change-Id: If46fa3660dbd04cd5a23a4d9cd79fd19067dcfbe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116437
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
... and while at it fix (new?) [loplugin:stringviewparam].
Change-Id: I4b991e58040df8082e141ba3c7a0d1968871d517
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116436
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
value list and filter by formatted values later, just like
we do in the autofilter.
Follow-up to commit 4fd1333ba4
"tdf#140968 tdf#140978 XLSX import: fix lost rounded filters".
Change-Id: If26f4c0abd54de05b497861f2c278972bd8072de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116115
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
and also tdf95549-3.xlsm
related to:
commit f8c1048eb4
Date: Wed May 19 19:04:02 2021 +0200
fix leak in oox import
and:
commit 3cd6402c54
Date: Thu May 6 18:47:30 2021 +0200
tdf#127301 XLSX import: hide hidden named range of autofilter
clearly this is fragile so just explicitly return who owns the
ScRangeData*
Change-Id: Ic3210bb8788bbbc85609bb384fa4a4625c15e487
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116432
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Regression from: b6b02e0b4c
(tdf#111903 tdf#137152 PPTX export: fix placeholders)
Placeholders lost the formatting, which has been fixed.
(fill, effects, and outline)
Change-Id: I2b9300b85cf3641d89d748a03377f950e668a2af
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116113
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
SvxBackgroundColorItem is just copied from SvxColorItem. There is
nothing special to SvxBackgroundColorItem class. SvxColorItem is a
generic item and it's used on many places related with colors. We can
use SvxColorItem for background colors too.
Change-Id: Iacea31a7557b806e95f5859ff60add9a2626ec05
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116282
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jenkins
...as inet_ntoa is potentially not thread-safe; and add a test
Change-Id: I9df945b006ba7194c3b1444c4886101c08339ad0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116425
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
std: :vector is only 3 words big in it's empty state
Change-Id: I5d7630f0ded1ace284c0a4441230bf672f4639be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116398
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
with an impl pointer, no need to use unique_ptr when storing in a map
Change-Id: I9fa13133df4a8acfb7fd973509ec2b0e194fc5d6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116423
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
To mimic Excel shortcuts and make them work on Windows+HU keyboard layout
Change-Id: I3525a8c9e370ff240105c8f1495f1abde539eee3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116242
Tested-by: Jenkins
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
LO 6.4.5 commit cf13fe3e6f
was only concerned about DOCX, but just elinated shared code.
So restore the shared code and just don't execute it for DOCX.
It doesn't look like RTF was working before this,
but this does fix DOC format.
I looked for existing unit tests in rtf and doc,
but none were found that hit this code.
Change-Id: Id624f73181384f38e1ef9f27575e0fb82eea19c7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116349
Tested-by: Jenkins
Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
In previous implementation if BKMode was set to Transparent,
then both Background of Text and Rectangle was not drawn.
It was wrong, and Rectangle should be always drawn.
This commit fix that issue and allows EMF images
exported by LTspice to be rendered correctly under LibreOffice.
Change-Id: I03801d35d92eb2a3fdc175ca1d5b348a2aa30842
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116394
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
This should use international case conversion, not just ascii one
that was used before.
Change-Id: Id01d3d0d30a846f02f97d081491b0de2c0d6ffef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116419
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
After commit ed07ec7606 ("drop
never completed GtkSalPrinter"), there is still the experimental
option left, depending on ENABLE_GTK3.
We can't drop the whole PrinterCapType::ExternalDialog, because
the osx code actually uses it.
Change-Id: Ibc4654d8c1ce1de7ee1c9dc7700bb8775af2f678
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116408
Tested-by: Jenkins
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
an empty vector is only 2 words
Change-Id: Ie9b6b8e97a9781916250cdc1b6b29406fe27d6b8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116401
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
inheriting from GdkContentProvider and implementing a replacement
get_value like gtk_text_buffer_content looks the way to go.
Change-Id: Ic376a586b77b7f00385e5744c0bc2923f2a72c94
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116397
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
since...
commit d90aa31496
Date: Fri May 28 20:39:00 2021 +0200
IsDisposed->isDisposed in vcl/../app
revert the offending hunk for now.
maybe final fix is to special case VclEventId::ObjectDying or convert to
!xWin->mpWindowImpl or something.
Change-Id: I6987aeb753181fa2eb705fa0535c092e51587a9f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116396
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
my fault, from a recent commit. besides defeating the dispose(), it
should also be checked from the call sites.
Change-Id: Ia09580d4224bcf78e5684015c747105fa6606878
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116383
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Change-Id: I91ed555f93173dee10e87025b231560693be50b5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116390
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
For cut paste transposed, references are not anymore updated during
UpdateReference(), but all these references will be updated during
UpdateTranspose(). In previous implementation, some references were moved (i.e.
updated). This caused problems in UpdateTranspose().
A transposed flag is added to the clipparam. This flag is checked during
UpdateReference().
UpdateTranspose() must only operate on (i.e. transpose) references pointing to
the source area. That's why updates must not be made during UpdateReference().
Otherwise references pointing to the destination range will be transposed
wrongly during UpdateTranspose().
References in formulas as well as in named ranges are fixed and tested.
I've added unit tests for all these cases and I've enhanced my previous
copy/paste test framework (6491c205ac) for
cut/paste tests, incl. undo.
Before LibreOffice 7.2, adjusting of references in cut paste transposed was
completely broken (tdf#71058, tdf#68976, tdf#142065 and tdf#142201).
Change-Id: I8a8d295f1cc683572905ae9633e16d010cfb8792
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116073
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
the call site does that
Change-Id: I8373eb4a6b87e96b211dd6bacea051d43b7ae8b4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116178
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
rather than having a pointer to a pointer (which is what Sequence is)
Change-Id: Ieb7b9995f6a25022fe2401adc3c38124edb83506
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116376
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
In this patch, the active background colour is disabled by passing null value as default to the FillStyleItem.
Previous Result: Background colour was still active even after inserting a header.
Result after applying this patch: Background is now remain disabled/inactive.
Change-Id: I5e8d22af338ef8ec93aa0e93d338ab8129fdc893
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113468
Tested-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
