All of those defines (should) not be used at any point in the code.
False positives may exist, because some macro names are getting
generated by some template/macro foo. This is the version which
compiled fine for me.
Also there are many commented out lines removed.
Change-Id: I6394024682e4ab3691eb72707a9363d41ba31df8
The only part where one definition was used was commented out.
All other definitions in the hrc file were unused.
Change-Id: I257e61b96271685e9321211846a0021059924abe
StringRangeEnumerator (i.e. user's input) contains page numbers in a different
page range (it excludes empty pages). So:
- first map page numbers to a common range, then compare
- user's input can't contain empty pages, remove this check
Change-Id: I4fce5215272fc90f39c9e05d3f3604734a8aebe3
FINDPRODUCT property was not available to this deferred custom action.
Not to mention that registry keys are also deleted at his stage of uninstallation.
The proper solution is to set the installation directory with a type 51 custom action,
and pass it to RemoveExtensions custom action via CustomActionData property.
Change-Id: I0ac18b3a0b19ff1a87bcf580fad9c7fdadb26f76
- inverted check in SwDoc::RemoveInvisibleContent
- various too short end positions in DeleteAndDestroy calls in
SwDoc::~SwDoc and SwDoc::ClearDoc
- std::copy to begin() of empty vector in SwReader::Read replaced
with std::back_inserter; the vector is used as a set here so the
end position should work just as well
Change-Id: Ib2ddd788fade4ee1a8beb702d5321c503985fba4
This test uses gb_CppunitTest_use_library_objects, and MSVC won't link
it now. Seems this was added in 1015cd4ff7,
but why?
Change-Id: I206132cf2b0c4075334ee7a692a12c54da9ac953
we get a large performance win by evaluating the formulas at the end of import where we can set up the ScAutoNameCache cache.
Change-Id: Id3763afb805eb9bfa9a6a55e1de3923f02e621ae
...(i.e., after logging out of a session with soffice still running, but only
with the backing window still open). The key issue was that bSessionDataExists
would always be true if /org.openoffice.Office.Recovery/RecoveryInfo/SessionData
is true, even if /org.openoffice.Office.Recovery/RecoveryList is empty. Always
calling doRestore (unless bExistsRecoveryData, but even if !bExistsSessionData)
is there to ensure that /org.openoffice.Office.Recovery/RecoveryInfo/SessionData
is eventually reset (whether or not that is really necessary).
Change-Id: I9c3fff23f8019069f36e1dd5ded634ea1917bbd4
The combination of marking it as ACT_IGNORE and osl_Signal_Terminate was
strange, as osl_Signal_Terminate caused SalMainPipeExchangeSignal_impl
(desktop/source/app/officeipcthread.cxx) to call DisableOfficeIPCThread, but
ACT_IGNORE (instead of ACT_EXIT, like other signals marked osl_Signal_Terminate)
caused the process to continue running. The net effect was that calling an
additional soffice instance after a SIGHUP would no longer connect to the first
instance, but instead would lead to two soffice instances running simultaneously
on the same UserInstallation.
Marking SIGHUP as ACT_HIDE most closely resembles the old behavior (of having
~no effect). Other options would be to mark it as ACT_IGNORE and
osl_Signal_System or as ACT_EXIT and osl_Signal_Terminate, which would both
result in instant termination. I do not know if that wouldn't actually be
better.
Change-Id: Id1ee7c1108765301e6010e0e05d6c1ff5894a414
- I had to convert SwFrmFmts, SwSpzFrmFmts, SwCharFmts, SwSectionsFmts,
SwTextFormatColl, SwGrfFmtColl all together because of the code that wants
to work with any of them.
- Introduce a pure virtual base class SwFmtsBase, since there are a handful
of methods that want to work with any of the std::vector<Sw*Fmt> types.
- the class SwSpzFrmFmts was dropped, and the code changed to use SwFrmFmts
instead, since the 2 types are identical.
Change-Id: I8c4056b5aedd574a33666e2d649a8b849958441c
Signed-off-by: Fridrich Štrba <fridrich.strba@bluewin.ch>
This commit partially reverts 9e8957de20
(as it interpreted mso-wrap-style as the wrap type of the textbox
itself, not the wrap type of the contained text) and also extends the
effect of commit 0016757efe to the
SimpleShape class as well.
Change-Id: If2bded6ad94f2866e8ea398ff0f2792e8c8e86b0
06e2005ed8 changed String to OUString and
initialized some variables with -1 instead of STRING_NOTFOUND, which was
unsigned 0xffff so var1<var2 was true if var1 had a value other than
default and var2 was default. After the change the comparison had logic
reversed and the result was a default negative currency format with
parentheses for all locales.
Change-Id: I3fe49fed7c1047618dc653fce992eb01582c398d
...as the signal can potentially be delivered to the to-be-joined thread. (It
is unclear to me whether the SalMainPipeExchangeSingal_impl handler is really
needed anyway, as there are various other places that should ensure that
DisableOfficeIPCThread is called during shutdown. At least in theory, no longer
joining here can cause the thread to incur crashes etc. when it it still running
during shutdown.)
Change-Id: I677a2e31e1a58d2b8d91634c2eb5274d63ac15f4
...that reads in word sized chunks and thus can read past the nominal end of
a memory buffer. Also, the return type of rtl_str_getLength (sal_Int32) fits
better with the type of SmPropValue.length (int) than the return type of
strlen (size_t).
Change-Id: I7ff91408b4c6d8c9913cede516586f42b8349ed3
