Commit graph

439406 commits

Author SHA1 Message Date
Michael Stahl
634844354e sysui: fix rpm errors in freedesktop-menus (4.14.1)
RPM build errors:
    Explicit %attr() mode not applicable to symlink: /workdir/CustomTarget/sysui/rpm/libreofficedev/freedesktop/usr/bin/libreofficedev6.1
    Installed (but unpackaged) file(s) found:
   /usr/local/lib/girepository-1.0/LOKDocView-0.1.typelib
   /usr/share/gir-1.0/LOKDocView-0.1.gir

The LOKDocView problem turned out to be the result of the first
incremental build after adding --with-package-format, and previously it
was avoided with a if in configure; moving the commands out of
create_tree.sh should be more obvious and reliable though.

Change-Id: I69c1566e26eeaa1d8bf88a3650a78da6ddfb5a3b
Reviewed-on: https://gerrit.libreoffice.org/76596
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-07-31 12:40:51 +02:00
Caolán McNamara
e569b9d40e weld OfaMSFilterTabPage2
Change-Id: I799eaffc808a7e41434fb76c877f4d1e8d4e1c3b
Reviewed-on: https://gerrit.libreoffice.org/76707
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-31 12:15:32 +02:00
Gabor Kelemen
e88bcb56ee tdf#42949 Fix IWYU warnings in cui/source/{c-f}*/*cxx
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: Ie5e070d13b771cf3e114c2454d49d77d95934160
Reviewed-on: https://gerrit.libreoffice.org/76506
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-31 12:15:20 +02:00
Miklos Vajna
084a7fd4d5 writerfilter: merge indentical branches in switch
Change-Id: Ia7c48f3f19342fe917350bc03f35797dd5f1e20e
Reviewed-on: https://gerrit.libreoffice.org/76715
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-31 11:19:39 +02:00
Gülşah Köse
7c973ea774 tdf#126511 Show only icon names instead of full path.
This commit shows only icon names insead of the full
path of icon on Bullet and Numbering dialog  graphic case
on Impress.

Change-Id: Iba72bf7c413993bad88add669035765aae521a59
Reviewed-on: https://gerrit.libreoffice.org/76716
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2019-07-31 10:54:46 +02:00
Tamas Bunth
cc4c20d08f mysqlc: Support reading blob as string
Change-Id: I1ef0c3817bc255e7f0c38aca73c475b19d5d7d9b
Reviewed-on: https://gerrit.libreoffice.org/76600
Tested-by: Jenkins
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2019-07-31 10:53:18 +02:00
Andrea Gelmini
8251c7bd2e Revert header guard
Thanks Stephan for explanation, read it here:
https://gerrit.libreoffice.org/#/c/76543/

Change-Id: If6c4d3b71ef2df69afe0404b9f445a62af9eadd3
Reviewed-on: https://gerrit.libreoffice.org/76714
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
2019-07-31 09:21:44 +02:00
Stephan Bergmann
de455fcaa7 Always pair openTable/closeTable calls
`--convert-to epub doc/ooo24702-1.doc` (i.e., attachment
4 SMS SPECIFICATIONS.doc at
<https://bz.apache.org/ooo/show_bug.cgi?id=24702#c1>) issues some calls to
XMLTableContext::startElement and XMLTableContext::endElement without any
matching calls to XMLTableContext::CreateChildContext, so closeTable was called
without a matching openTable call, ultimately causing

> soffice.bin: sax/source/expatwrap/saxwriter.cxx:1184: virtual void (anonymous namespace)::SAXWriter::endElement(const rtl::OUString &): Assertion `aName == m_pSaxWriterHelper->m_DebugStartedElements.top()' failed.

to fire.

Change-Id: I41c3071ace0934143881c77e4b00c23e79ff7ea2
Reviewed-on: https://gerrit.libreoffice.org/76618
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-31 09:18:54 +02:00
Stephan Bergmann
0ea06dd96c Avoid out-of-bounds string access
...as happens when loading doc/ooo112635-1.doc (i.e., attachment
justified_chinese_paragraph_issue.doc at
<https://bz.apache.org/ooo/show_bug.cgi?id=112635#c1>):

> soffice.bin: /home/sbergman/lo/core/include/rtl/ustring.hxx:689: sal_Unicode rtl::OUString::operator[](sal_Int32) const: Assertion `index >= 0 && static_cast<sal_uInt32>(index) < static_cast<sal_uInt32>(getLength())' failed.

> #4  0x00007fff80397994 in rtl::OUString::operator[](int) const (this=0x61400027fdc0, index=68) at /home/sbergman/lo/core/include/rtl/ustring.hxx:689
> #5  0x00007fff80393283 in i18npool::BreakIterator_CJK::getLineBreak(rtl::OUString const&, int, com::sun::lang::Locale const&, int, com::sun::i18n::LineBreakHyphenationOptions const&, com::sun::i18n::LineBreakUserOptions const&) (this=0x613000281480, Text="    本篇即在于指出十二宫反应的一些重点。学者若能参考上篇《星曜论》所言的星曜性质,当别有会心之处。因为事实上没有可能将一切星曜组合的", nStartPos=68, bOptions=...) at /home/sbergman/lo/core/i18npool/source/breakiterator/breakiterator_cjk.cxx:109
> #6  0x00007fff803942fa in non-virtual thunk to i18npool::BreakIterator_CJK::getLineBreak(rtl::OUString const&, int, com::sun::lang::Locale const&, int, com::sun::i18n::LineBreakHyphenationOptions const&, com::sun::i18n::LineBreakUserOptions const&) () at /home/sbergman/lo/core/instdir/program/../program/libi18npoollo.so
> #7  0x00007fff803aed0f in i18npool::BreakIteratorImpl::getLineBreak(rtl::OUString const&, int, com::sun::lang::Locale const&, int, com::sun::i18n::LineBreakHyphenationOptions const&, com::sun::i18n::LineBreakUserOptions const&) (this=0x60e0004163e0, Text="    本篇即在于指出十二宫反应的一些重点。学者若能参考上篇《星曜论》所言的星曜性质,当别有会心之处。因为事实上没有可能将一切星曜组合的", nStartPos=68, rLocale=..., nMinBreakPos=35, hOptions=..., bOptions=...) at /home/sbergman/lo/core/i18npool/source/breakiterator/breakiteratorImpl.cxx:243
> #8  0x00007fff803aeeca in non-virtual thunk to i18npool::BreakIteratorImpl::getLineBreak(rtl::OUString const&, int, com::sun::lang::Locale const&, int, com::sun::i18n::LineBreakHyphenationOptions const&, com::sun::i18n::LineBreakUserOptions const&) () at /home/sbergman/lo/core/instdir/program/../program/libi18npoollo.so
> #9  0x00007fff4d209e09 in SwTextGuess::Guess(SwTextPortion const&, SwTextFormatInfo&, unsigned short) (this=0x7fff9ae398c0, rPor=..., rInf=..., nPorHeight=304) at /home/sbergman/lo/core/sw/source/core/text/guess.cxx:407
> #10 0x00007fff4d5be607 in SwTextPortion::Format_(SwTextFormatInfo&) (this=0x604000a2f950, rInf=...) at /home/sbergman/lo/core/sw/source/core/text/portxt.cxx:310
[...]

Change-Id: I51d4bbecce4e929752a9f561f72acef446be21cb
Reviewed-on: https://gerrit.libreoffice.org/76550
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-31 09:18:23 +02:00
Stephan Bergmann
d32bed7af6 Avoid -fsanitize=float-cast-overflow
...during `--convert-to pdf doc/ooo111446-1.doc` (i.e., attachment
DirAppLaunch.docx at <https://bz.apache.org/ooo/show_bug.cgi?id=111446#c1>),
when aNew is "fig figFuncBlocks=fig figFuncBlocks+1" causing aCalc.IsCalcError()
(whether legitimately, or because there is some prior error importing that
formula):

> sw/source/core/fields/expfld.cxx:912:34: runtime error: 1.79769e+308 is outside the range of representable values of type 'unsigned int'
>  #0 in SwSetExpField::SetValue(double const&) at sw/source/core/fields/expfld.cxx:912:34
>  #1 in SwSetExpField::SetValue(double const&, SwRootFrame const*) at sw/source/core/fields/expfld.cxx:922:9
>  #2 in sw::DocumentFieldsManager::UpdateExpFieldsImpl(SwTextField*, SwRootFrame const*) at sw/source/core/doc/DocumentFieldsManager.cxx:1254:34
>  #3 in sw::DocumentFieldsManager::UpdateExpFields(SwTextField*, bool) at sw/source/core/doc/DocumentFieldsManager.cxx:924:9
>  #4 in SwViewShell::CalcLayout() at sw/source/core/view/viewsh.cxx:1024:46
>  #5 in SwEditShell::CalcLayout() at sw/source/core/edit/edws.cxx:110:18
>  #6 in SwXTextDocument::getRendererCount(com::sun::uno::Any const&, com::sun::uno::Sequence<com::sun:🫘:PropertyValue> const&) at sw/source/uibase/uno/unotxdoc.cxx:2595:25
>  #7 in PDFExport::Export(rtl::OUString const&, com::sun::uno::Sequence<com::sun:🫘:PropertyValue> const&) at filter/source/pdf/pdfexport.cxx:911:59
[...]

Change-Id: I585bb9831212390b2c28248c3ff0904093b48783
Reviewed-on: https://gerrit.libreoffice.org/76520
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-31 09:17:41 +02:00
Samuel Mehrbrodt
b25284244a tdf#126508 Fix crash when changing icon style
Regression from b58aa94f1f

Change-Id: I253447c197d8b333e26f243e26794e775f3edcee
Reviewed-on: https://gerrit.libreoffice.org/76589
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-31 07:12:13 +02:00
Xisco Fauli
77ef0a92b3 tdf#121599, tdf#123099: ignore migration dialog when
1. a new HSQLDB database is created
2. the HSQLDB database is not opened interactively

Change-Id: I7287e467e06be5eec1e5c661123e1332cdaeef9b
Reviewed-on: https://gerrit.libreoffice.org/75643
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-07-31 03:49:17 +02:00
Xisco Fauli
54028dc503 tdf#123591: truncate and round to 'scale' number of decimal places
otherwise the number will be incorrectly converted to OUString
if scale < number of decimals

See https://bugs.documentfoundation.org/show_bug.cgi?id=123591#c25

Change-Id: Ie32c9c6ab339d6907e9a4e2645d6f19bad9e67c8
Reviewed-on: https://gerrit.libreoffice.org/75727
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-07-31 03:46:51 +02:00
Andrea Gelmini
ca6df519a7 Fix typos
Change-Id: Ia5fba032635adbf85bdfcb1eb0b3ffb9cf9d4a6a
Reviewed-on: https://gerrit.libreoffice.org/76548
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-30 23:47:47 +02:00
Andrea Gelmini
682be3766c Removed duplicated include
Change-Id: I2b1b7bb2cd88be4be518d045d54a0f0ee8583b8b
Reviewed-on: https://gerrit.libreoffice.org/76713
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-30 23:47:18 +02:00
Andrea Gelmini
7166b64c9a Fix typo in code
"connectr"

Please look at:
https://gerrit.libreoffice.org/#/c/76543/1

Change-Id: I3862780f92b8ce4583d642e3f653389a4ef3cc22
Reviewed-on: https://gerrit.libreoffice.org/76575
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-30 23:04:38 +02:00
Caolán McNamara
ee0613bd9e bFirst means 1st vs 2nd column, and needs to alternate on each loop
this went wrong at...

commit f423ac2d3b
Date:   Tue Mar 5 15:16:16 2019 +0200

    remove sal_IntPtr in OfaMSFilterTabPage2

    and just use a scoped enum

Change-Id: I74bcca9ffee9faf4600da64b3c409dbf19a1290e
Reviewed-on: https://gerrit.libreoffice.org/76619
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30 21:14:29 +02:00
Caolán McNamara
588f50ac41 remove newly unused SvxCheckListBox
Change-Id: I6a5f4dfea9fbb34f02c1752140e04d1d0a8a67a7
Reviewed-on: https://gerrit.libreoffice.org/76617
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30 21:14:11 +02:00
Caolán McNamara
37c01754ae weld SwCompatibilityOptPage
Change-Id: Id66751642a631d033385c3da9ba5cd484ba9dcf6
Reviewed-on: https://gerrit.libreoffice.org/76616
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30 21:13:56 +02:00
Andrea Gelmini
f93a345ab5 Fix typos
Change-Id: Ib737ff364f627b9e4d0dc2a9903a07a0af36a8ae
Reviewed-on: https://gerrit.libreoffice.org/76551
Tested-by: Jenkins
Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-30 20:58:56 +02:00
Ashod Nakashian
70d3bbe11e sfx2: Enable sidebar on calc and writer, but not in impress
Added by Noel to this commit:
And add a special deregister mode to doc_registerCallback
so we can unregister stack-based callback objects in the
presence of multiple views.

Reviewed-on: https://gerrit.libreoffice.org/71715
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit fba6d4267b)

Change-Id: I8d846bc1f794cf16fd45486fd83ef87f43fd52c7
Reviewed-on: https://gerrit.libreoffice.org/76555
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-30 18:52:48 +02:00
Xisco Fauli
6eae30f631 tdf#126605: Do not end TextEdit when changing an attribute
otherwise, pTextEditOutlinerView becomes nullptr in
svx/source/svdraw/svdedxv.cxx:2184

Regression from e6c7a018a0

Change-Id: I9d0645f637dc92b50d01682d119c0db60238e921
Reviewed-on: https://gerrit.libreoffice.org/76606
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-07-30 18:39:26 +02:00
Caolán McNamara
4289b91d49 svxlo-SvxCheckListBox doesn't exist, svxcorelo-SvxCheckListBox does
Change-Id: I2aca664de328381e5beda5fb70bd58aa40f68abf
Reviewed-on: https://gerrit.libreoffice.org/76612
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30 18:05:15 +02:00
Aron Budea
9ad8f83912 tdf#125800: accessing cond format props in UNO throws error
These conditions were always evaluated to true: OR should
become AND when negated.

Regression from 8c637b47d9

Change-Id: I87038319ed27eff2bed2412da49e01f73ec0a79c
Reviewed-on: https://gerrit.libreoffice.org/76493
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
Reviewed-by: Aron Budea <aron.budea@collabora.com>
Tested-by: Aron Budea <aron.budea@collabora.com>
2019-07-30 18:03:33 +02:00
Gülşah Köse
392fe03c26 tdf#125642 Fix layout issues for Bullet dialog.
Change-Id: Ieacd060a8bfe4e2123e6973e30789e029ab02ca6
Reviewed-on: https://gerrit.libreoffice.org/76587
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2019-07-30 18:03:28 +02:00
Caolán McNamara
f356fbd758 drop newly unused SvxRadioButtonListBox
Change-Id: Idb80fa73fad6e4bb2a1eaa3d55d7fe90e86c8965
Reviewed-on: https://gerrit.libreoffice.org/76605
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30 17:45:22 +02:00
Caolán McNamara
af20b49acb weld SvxPersonalizationTabPage
Change-Id: I5240fc4237d8b471b2c23a8bc776cffa46a53285
Reviewed-on: https://gerrit.libreoffice.org/76607
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30 17:19:14 +02:00
Caolán McNamara
1aa246a8e8 weld SvxJavaOptionsPage
Change-Id: Ib37f6f554a890bd6397ae7b6c56f1615cd12b6b1
Reviewed-on: https://gerrit.libreoffice.org/76604
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30 17:18:43 +02:00
Gabor Kelemen
4fe32e65cc tdf#126524 Use shorter default name for unnamed data series
Change-Id: I2c67a50c36f6b09dc15d70ec44b95d47792b33e2
Reviewed-on: https://gerrit.libreoffice.org/76298
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-07-30 16:48:06 +02:00
Michael Stahl
ee1900a01c unordf: oops, and we forgot to amend with <= instead of <
... in 751a5ad9c4

Change-Id: I81fb9e12b02eedd0fc6f4deccc392543cf2c14da
Reviewed-on: https://gerrit.libreoffice.org/76614
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Tested-by: Michael Stahl <Michael.Stahl@cib.de>
2019-07-30 16:25:18 +02:00
Michael Stahl
751a5ad9c4 unordf: restore thread safety
(regression from f2c513e686)

Change-Id: I620d726555172fbaec3d468bcf21c0c1101cdc70
Reviewed-on: https://gerrit.libreoffice.org/76601
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-07-30 16:21:23 +02:00
Jan-Marek Glogowski
e79f613404 tdf#126597 don't use modeless dialog for senddoc.exe
There is already a large comment in initAttachmentList about
problems with MAPI_DIALOG_MODELESS. Using MAPI_DIALOG_MODELESS with
Outlook 2016 and multiple attachments sometimes produces a
MAPI_E_FAILURE, but most times it crashes for me. And it's not a
problem with the removed temporary files, as uncommenting that
shows the same problem. And there seems to be many more problems:

https://social.msdn.microsoft.com/Forums/en-US/5d8fece6-9d93-490c-9331-625c17e3291d/mapisendmailhelper-and-mapidialogmodeless

But actually I don't see any blocking of LO, if I switch to
using MAPI_DIALOG, as senddoc.exe already runs in the background.

So this switches MAPI_DIALOG_MODELESS to MAPI_DIALOG.

This reverts commit 5874c76371
("tdf#116074: Use modeless dialogs with supporting mailers").

Change-Id: Ie0f8f22196d1a174dfeada2bc4aabb1717ee16a7
Reviewed-on: https://gerrit.libreoffice.org/76155
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-07-30 16:15:16 +02:00
andreas kainz
6fee2e7ec0 tdf#126611 ShowDataNavigator in swxform
Change-Id: I8997ca84434f49b6e9dadd7e283455e40b90892e
Reviewed-on: https://gerrit.libreoffice.org/76593
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-07-30 16:05:49 +02:00
Marco A.G.Pinto
9ee5ad5a0b [pt_PT] Added 14 words to autocorrect
Change-Id: Iaae705b469463e302059c4be7b9f1c7968011824
Reviewed-on: https://gerrit.libreoffice.org/76577
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-07-30 14:41:37 +02:00
Caolán McNamara
08101a1ab3 weld OfaLanguagesTabPage
Change-Id: Ib0938f0c9d810c0f851dd0180093aabb4babdc19
Reviewed-on: https://gerrit.libreoffice.org/76594
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30 14:04:17 +02:00
Tor Lillqvist
30a75a8d3d tdf#125568: We need the selection string also when not "in selection mode"
Apparently being "in selection mode" has nothing to do with whether we
have a selection that we are enlarging by dragging the end marker?

Change-Id: I546a1685bd3a0102e16c1f8bc6e721819ed986e2
Reviewed-on: https://gerrit.libreoffice.org/76588
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/76591
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
2019-07-30 14:01:42 +02:00
andreas kainz
517df6f02f NB Extension support for tabbed_compact and groupedbar_compact
Change-Id: I00265a60f5a66c044bf2eafb627dd3af1c09e3ca
Reviewed-on: https://gerrit.libreoffice.org/76570
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-07-30 13:57:25 +02:00
Caolán McNamara
e199385872 weld SvxSecurityTabPage
Change-Id: I4cace9417f1f036921b3e95d946f431ec072ce3a
Reviewed-on: https://gerrit.libreoffice.org/76586
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30 13:16:22 +02:00
Caolán McNamara
f67188df86 weld SvxProxyTabPage
Change-Id: I34651fc7c56da5205b349a83276d5efa536c4301
Reviewed-on: https://gerrit.libreoffice.org/76582
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30 11:39:33 +02:00
Arkadiy Illarionov
5ba84c3c70 Simplify Sequence iterations in scaddins, sccomp, scripting
Use range-based loops, STL and comphelper functions

Change-Id: I836422a1c81a3dc9585687ed2e506eb59bb4ec91
Reviewed-on: https://gerrit.libreoffice.org/76484
Tested-by: Jenkins
Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-07-30 11:16:00 +02:00
Michael Stahl
8506932739 sw_redlinehide: remove obsolete ExperimentalMode in layout test
Change-Id: Ibf2a0ccf80209e81587982d2bac9f83f763a6270
Reviewed-on: https://gerrit.libreoffice.org/76560
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-07-30 10:27:21 +02:00
Caolán McNamara
b6b8b4c3d9 weld OfaMSFilterTabPage
Change-Id: Ie711d8624995027578f79389972c6fa26b3189a2
Reviewed-on: https://gerrit.libreoffice.org/76569
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30 09:55:03 +02:00
Caolán McNamara
6833539b46 weld SvxOnlineUpdateTabPage
Change-Id: I0043ba0b088f0b9ae8e5716c64e424419993cb96
Reviewed-on: https://gerrit.libreoffice.org/76568
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30 09:54:26 +02:00
Caolán McNamara
5a6a718d0e weld SvxEMailTabPage
Change-Id: I039564a53fe4b9c20f34efcb9e59f57528a1f5da
Reviewed-on: https://gerrit.libreoffice.org/76561
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30 09:53:59 +02:00
Caolán McNamara
0871c62fab weld SwRedlineOptionsTabPage
Change-Id: Ic901356d399e8d758747f0fea07d3656fbf89aab
Reviewed-on: https://gerrit.libreoffice.org/76559
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30 09:53:31 +02:00
Caolán McNamara
16073ff56f weld OfaViewTabPage
Change-Id: I259e10ad8bdf3d1630ab1d24590c43919a351a86
Reviewed-on: https://gerrit.libreoffice.org/76567
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30 09:52:54 +02:00
Caolán McNamara
c673b171ba weld SvxCTLOptionsPage
Change-Id: I7b891e1a1d0ffc52cfd91a33fd01b3ec8ac2cd65
Reviewed-on: https://gerrit.libreoffice.org/76562
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-30 09:51:57 +02:00
Gabor Kelemen
b368329430 tdf#62699 Drop (now) pass-through header include/vcl/salbtype.hxx
Change-Id: I2e2093ac3c8c6833b70d4932bc12a82a4483bde5
Reviewed-on: https://gerrit.libreoffice.org/76499
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-30 09:51:39 +02:00
Andrea Gelmini
bfdf259431 Fix typos
It passed "make check"

Change-Id: I50c3639ec258c7fb6d73104f8e777f96995aa8e3
Reviewed-on: https://gerrit.libreoffice.org/76543
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-30 08:52:21 +02:00
Miklos Vajna
90928f2399 tdf#112535 DOC import: fix handling the have contour but no polygon case
In case a graphic has contour enabled, but there is no wrap polygon,
that means auto-contour in Writer, and no contour in Word, so handle
this difference during DOC import.

Regarding the DOCX import -> DOC export -> DOC import scenario, this
fixes a regression from commit 628a0f313e
(DOCX drawingML import: handle SurroundContour shape property,
2014-08-11), though the DOC import part was always broken, I think.

Change-Id: I6049fcf5df20736b702de901aef7068826d43f18
(cherry picked from commit 5b7b269c5e32abf4fbb6a664453e422e3667f4a3)
Reviewed-on: https://gerrit.libreoffice.org/76566
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-30 08:50:29 +02:00