On macOS, Command-w should attempt to close the key window.
Also, pressing Command-m would fail to close the key window
due to the same cause as tdf#162010 if the resulting key
event was an input method event.
Change-Id: I0d90547d7a0833bcc18b36f6d888e1065e91ec57
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171086
Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
Tested-by: Jenkins
When the use cases require use of absolute URLs at export (Options->
Load/Save->General, Save URLs relative to file system and Save URLs
relative to internet), the fles generated from the document itself
(e.g., images that aren't embedded into HTML/ReqIF itself) may still
need to be referenced relatively.
This introduces the export filter option, named RelativeOwnObjectURL,
that overrides the general export settings specifically for these
self-generated objects.
Change-Id: I09aeb931db5712271a40c683370316783507775a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171083
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
... not breaking to next argument of a function parameter.
Change-Id: Ibc7a64c4ea64c415098a213f0ff3d96b8a9dd73c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171085
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
For one, a dependency on gb_Postprocess_get_target,AllModulesButInstsetNative
was missing, so copying from instdir might have kicked in too early, before the
instdir files had been updated (e.g., in an incremental build). For another, in
a from-scratch build, files like instdir/program/qt_soffice.html might not yet
have been around, but I'm too dumb to get gbuild to do what I want here (i.e.,
copy files from instdir to workdir once the files are available in instdir and
only if the files in instdir are newer than those in workdir). So just make
this .PHONY and always copy all the files (in line with how other PKGFORMATs
also always rebuild their artifacts, IIUC).
Change-Id: I8b84677cdf867a2b66027ec4a4d781cd1fe623b7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171077
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
DocumentToGraphicRenderer is needed by sw/qa/ unit tests now
Change-Id: Idf1aac26afa0001a8affc846b78288a6b588a1f0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171073
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
TaggedPDF is enabled by default since 544d6d781b
"tdf#39667 Enable tagged PDF by default"
Only disable it when needed
OTOH, using writer_pdf_Export as a FilterName works when
exporting calc/impress/draw documents too
Change-Id: I970406b8a87cad937c3023815e4f5caa9b4f7143
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171069
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
so reenable this and bump up min fuzz length
Change-Id: Ic493e1a55899761f6bc88dc7f4b598a82dd00411
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171067
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Test to see if preceding space is cut when cutting a word with redline
turned on.
Without the fix from tdf#139631, the preceding space is not cut in certain
situations.
Change-Id: Ic815fd04ee50ce116a8552205c24e8422d734b1b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171058
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
This could have caught tdf#162180
Change-Id: I71e86b402ae0c603d1c7ace209d55f5808b9ebe2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171054
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
TaggedPDF is enabled by default since 544d6d781b
"tdf#39667 Enable tagged PDF by default"
OTOH, using writer_pdf_Export as a FilterName works when
exporting calc/impress/draw documents too
Change-Id: I5dc0c9eedbb6716f1ef58ffd1faa16e9cc015f9d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171070
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
* Update translations from branch 'master'
to 6d1d800bd75a27d84866b7e8931d0cb1e12dbdd3
- update translations for 24.8.0 rc2/master
and force-fix errors using pocheck
Change-Id: Ic1ff9c85e537794ed5410c93b09f5d8b1d8a1e9f
Add 'startThreads' lok method for the few thread scenarios where
we need to have a background thread running that cannot be started
opportunistically.
Also add that to the ThreadJoinable interface so we can get into
UNO components' implementations to handle their worker threads
easily.
Implement joining and re-starting in WebDAV ucp too.
Change-Id: I329ef9decb32b263197e4c03a0d54952985fdd0e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167858
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170979
Tested-by: Jenkins
Unlike later versions of Java, JDK 8 does not create the last
directory segment pointed by the -d option, even if the other
segments exist. So, create the "content" segment too and allow
building with Java 8.
Change-Id: Ie7ee75ca311270e02a3e1b6b5eeb28b5a1ccdad8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169477
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
...to have $(WORKDIR)/installation/LibreOffice/emscripten populated with just
the relevant files from $(INSTDIR). (This doesn't reuse the complicated
CustomTarget_instsetoo_native/install used for other PKGFORMATs; as a special
case, it uses a much simpler CustomTarget_instsetoo_native/emscripten-install.)
Change-Id: I9c7509aadbc0e6e49ec95bf51c748c2ff9f778b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171066
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
Tested-by: Jenkins
This simplifies and deduplicates the code, and even where it was simple,
it has an advantage that if a change in algorithm is decided, it is done
in a single place.
Change-Id: I9ec55a29c5f2b2c972ac81bf07c20fc0a52a2a8b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171033
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
lets see if this works instead.
Change-Id: Ib0a5df7deed2972cfed7c3afbe5c65229c208f26
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171056
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
xCursorTunnel.get() is a SvxUnoTextCursor in this case
Change-Id: Iaa50a4895923bc1635dc69325203de7bfb77886b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171064
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
...mostly because the relevant parts of the code are hard-disabled (even if you
would --disable-wasm-strip) with ENABLE_WASM_STRIP_RECOVERYUI=TRUE and
ENABLE_WASM_STRIP_SPLASH=TRUE. (And if there are places in the code that would
need the equivalent of either --norestore or --nologo after all, we could
probably better add explicit #if EMSCRIPTEN there instead.) This allows to get
rid of hard-coding the Qt Emscripten LO command line arguments, which means that
e.g. web applications embedding LO would now be able to specify them themselves.
Change-Id: I8e2dcfd170cc32276bfb9007f098f6ae6a7f9ec1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171063
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
FillGradientPrimitive2D/ and PolyPolygonGradientPrimitive2D
now support both alphas, a gradientAlpha and a unified one.
This allows a processor to directly handle a gradient with
a unifiedAlpha if he wants. Adapted other places accordingly.
NOTE: In VclMetafileProcessor2D handling of the primitive
PolyPolygonGradientPrimitive2D has to do a local compromize,
see comment there.
Change-Id: I536f4935dafde0369f768dbd281d547b7bb08eb4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171052
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
Tested-by: Jenkins
which is the case for all English function names, but not the
TableRef item specifiers like #All, #Data, ...
Change-Id: I7f675e05b0d52eac9596b96b4d2cf299351fb82a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171022
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
typedef long long pid_t in case of #ifdef _WIN64 is the only change,
the rest of the change to the patch is just rediffing
Change-Id: Iaad34bf42ad06fc6a636b773535f199a19c863e0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171023
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Since commit 26c106a5ae "append '(Remote)'
in the titlebar when remote file is opened", 2015-08-14, the titlebar
shows "(remote)" for documents with non-empty URLs that are not file
scheme.
When recovering a non-existing document, the URL is a factory one like
"private:factory/swriter"; and INetURLObject::GetProtocol() call returns
PrivSoffice.
Indeed, recovery of a non-existing document doesn't make sense itself,
and is fixed by Justin elsewhere; but let's fix the general logic here.
Change-Id: Ibaf095981c37a2fd64f745ad0966465d98a4ed4d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171027
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
...as there can be situations (cf. the newly added test code in embindtest.js)
where objects that need to be deleted are passed as payload of the exception
value to be thrown. So there now is a (mandatory, as Embind doesn't allow to
implicitly pass undefined) third parameter now that must be an array of objects
on which to call .delete().
(75fe059974 "Embind: throwUnoException from JS"
had deliberately made throwUnoException take two arguments, because if it
"directly took a css::uno::Any argument, JS client code would need to create one
with `new Module.uno_Any(...)` and call .delete() on it, but there is no place
where it could call .delete()". There now would be such a place, but it would
probably still be tedious most of the time to explicitly construct a new uno_Any
to pass into throwUnoException both as the exception and in the toDelete array.
So keep that design decision to have throwUnoException take individual type and
value arguments.)
Change-Id: Idec029d9e500457b02d20d899b9a2328cd7a5d7e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171024
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
Tested-by: Jenkins
...and let it open with that instead of with a hard-coded example.odt. (But
keep that example.odt in CustomTarget,static_emscripten_fs_image and adapt the
example code in static/README.wasm.md to explicitly load it now.)
Change-Id: Ie43e3795e44542acba5a8e755f65acc56fa753f8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171019
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
Tested-by: Jenkins
managing which a11y issue should be checked. In default mode all the a11y issues are checked.
Change-Id: Ib01e7d76e74b0b9cc9df259295edbee135b1c8a2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170324
Tested-by: Jenkins
Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
