Qt's qtbase commit [1]
commit cecca90ff23ff27b9396defc21abd472b3fe0003
Author: Thiago Macieira <thiago.macieira@intel.com>
AuthorDate: Tue Oct 1 11:26:30 2024 -0700
Commit: Thiago Macieira <thiago.macieira@intel.com>
CommitDate: Tue Nov 12 17:14:46 2024 -0800
moc: fix support for generating meta objects for nested private classes
introduced a new QT_OBJECT_GADGET_COMMON macro, causing my
`--enable-qt6` clang plugin build with current qtbase git dev
(as of commit 957e2be00a5c45223a5ef842a5f9f2f7b7be882b)
to fail as follows for classes using the Q_OBJECT macro:
In file included from /home/michi/development/git/libreoffice/vcl/qt6/QtAccessibleRegistry.cxx:10:
In file included from /home/michi/development/git/libreoffice/vcl/qt6/../qt5/QtAccessibleRegistry.cxx:11:
In file included from /home/michi/development/git/libreoffice/vcl/inc/qt6/QtXAccessible.hxx:10:
/home/michi/development/git/libreoffice/vcl/inc/qt6/../qt5/QtXAccessible.hxx:27:5: error: declaration nested in DLLPRIVATE declaration redundantly marked as DLLPRIVATE [loplugin:dllprivate]
27 | Q_OBJECT
| ^~~~~~~~
/home/michi/development/git/qt5/qtbase/src/corelib/kernel/qtmetamacros.h:145:5: note: expanded from macro 'Q_OBJECT'
145 | QT_OBJECT_GADGET_COMMON \
| ^~~~~~~~~~~~~~~~~~~~~~~
/home/michi/development/git/qt5/qtbase/src/corelib/kernel/qtmetamacros.h:132:5: note: expanded from macro 'QT_OBJECT_GADGET_COMMON'
132 | Q_DECL_HIDDEN_STATIC_METACALL static void qt_static_metacall(QObject *, QMetaObject::Call, int, void **);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/michi/development/git/qt5/qtbase/src/corelib/kernel/qtmetamacros.h:98:39: note: expanded from macro 'Q_DECL_HIDDEN_STATIC_METACALL'
98 | #define Q_DECL_HIDDEN_STATIC_METACALL Q_DECL_HIDDEN
| ^
/home/michi/development/git/qt5/qtbase/src/corelib/global/qcompilerdetection.h:190:46: note: expanded from macro 'Q_DECL_HIDDEN'
190 | # define Q_DECL_HIDDEN __attribute__((visibility("hidden")))
| ^
/home/michi/development/git/libreoffice/vcl/inc/qt6/../qt5/QtXAccessible.hxx:25:7: note: parent declaration is here [loplugin:dllprivate]
25 | class QtXAccessible : public QObject
| ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
26 | {
| ~
27 | Q_OBJECT
| ~~~~~~~~
28 |
29 | public:
| ~~~~~~~
30 | QtXAccessible(css::uno::Reference<css::accessibility::XAccessible> xAccessible);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
31 |
32 | /** Reference to the XAccessible.
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
33 | * This is cleared once it has been passed to the QtAccessibleWidget,
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
34 | * which then keeps an own reference and takes care of all required
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
35 | * access to the XAccessible for the Qt a11y bridge. */
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
36 | css::uno::Reference<css::accessibility::XAccessible> m_xAccessible;
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
37 | };
| ~
1 error generated.
make[1]: *** [/home/michi/development/git/libreoffice/solenv/gbuild/LinkTarget.mk:339: /home/michi/development/git/libreoffice/workdir/CxxObject/vcl/qt6/QtAccessibleRegistry.o] Error 1
Extend the plugin to also take the new macro into account in
addition to Q_OBJECT.
[1] https://code.qt.io/cgit/qt/qtbase.git/commit/?id=cecca90ff23ff27b9396defc21abd472b3fe0003
Change-Id: I990f0b25010b3a0f0cc3902f732b93d13bb85d78
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176702
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Don't delete range finder during arrow key navigation since cursor keys
don't count as modifications.
Change-Id: I53566a4a84ff4dc81fdf0d8b8f6468f956958925
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176689
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Tested-by: Jenkins
and ContentEventNotifier can be de-friended
Holding this mutex to write to a just created local doesn't make sense
to me. I can't see any where that there might be another thread that
matters here.
Change-Id: I803a45a0cf02ebc306767595555018ee97d96caf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176684
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
so we can move this inside the other conditional
Change-Id: I63259598d5165e3aafbf0c1cfef70ccb1b16bb38
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176685
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
Refactored include guards into pragma once for some files
alphabetically c-d in sw/inc.
Change-Id: I8cf8059851169472d7953f4e6f5408666d27c2c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176688
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
...as exhibited by recently added 08e566f0c9 "add
a couple of tests for tools::BigInt"
Change-Id: Icd1080f86ccd985868fce34d6f86e2706acd58df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176677
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
Tested-by: Jenkins
and
cid#1607158 Overflowed return value
cid#1607271 Overflowed return value
cid#1608107 Overflowed return value
cid#1606975 Overflowed return value
cid#1608009 Overflowed return value
cid#1608353 Overflowed return value
cid#1608486 Overflowed return value
cid#1607009 Overflowed return value
cid#1606780 Overflowed return value
its totally unclear what the source of these warnings is
Change-Id: If46cac6a329dec397bd784f57d9ffe5e53af9a1a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176683
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
V1037 Two or more case-branches perform the same actions. Check lines: 146, 158. This will still be the case, the code being just at the moment similar.
Change-Id: Iceca3c717ccc6ee3ea865d3a469418ff6e8accd7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175146
Reviewed-by: David Gilbert <freedesktop@treblig.org>
Tested-by: Jenkins
add missing spaces + quote before and after function name searched
Change-Id: I3b0bd3ca780c4de9d04fda7d2c80c29e60ddd1ef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176669
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
The Command modifier converts scrollwheel events into
magnification events and the Shift modifier converts vertical
scrollwheel events into horizontal scrollwheel events. This
behavior is reasonable for mouse scrollwheel events since many
mice only have a single, vertical scrollwheel but trackpads
already have specific gestures for magnification and horizontal
scrolling. So, behave like most macOS applications and ignore
all modifiers if this a trackpad scrollwheel event.
Also, ignore all modifiers for swipe events since it appears
that devices that generate swipe events can generate both
vertical and horizontal swipe events.
Change-Id: I3c0c726759ef010d528f221c63d1e7e401726db5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176410
Tested-by: Jenkins
Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
For some unknown reason, when using the standard macOS French
layout, pressing Command-` causes -[NSView interpretKeyEvents:]
to temporarily set and unset the marked text.
Command-` should only cycle through the application's windows
so ignore marked text changes from such key down events.
Change-Id: Ifeb4ad637d572b339d7b389466815bb60a4b3120
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176652
Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
Tested-by: Jenkins
So indicate to LO that at least PostgreSQL and MySQL/MariaDB support views
Change-Id: I241fa3cfc599e11c1f1523a78a1905beadc80307
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176308
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
This renders master and the main slide as 2 separate layers, which
is useful because in a huge slideshow we can reuse the master slide
and only render the rest of the slide, which should be more compact
in size as the master slide is the one that usually contains the
(complex) background.
Change-Id: I5e86d718b7ab3b03bd0b6146ce4df218a4dd72d4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176622
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
An existing optimization avoids rendering a bubble chart bubble if
it is nearly the same size and position as the preceding bubble. This
results in incorrect rendering in the case of transparent fill. Skip
the optimization in this case.
Change-Id: Ie21235a66c4d22ac2ce793264ef5bb7b6434117e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172115
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
V1037 Two or more case-branches perform the same actions. Check lines: 830, 840, 850
V1037 Two or more case-branches perform the same actions. Check lines: 960, 1148
Change-Id: Ifff7612b44d2a3bc0ea573077104b460fed8cf76
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175222
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Change-Id: I71c6cd9b5dbcb3126da1919108be009f6512b0d0
V1037: Two or more case-branches perform the same actions. Check lines: 100, 122
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175054
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
previously a comment `(for unprotected cells)` was added to the `Delete Rows` and `Delete Columns` menu entries as a solution of tdf#136003. The change has been reverted https://gerrit.libreoffice.org/c/core/+/176614
As tdf#136003 says "Can't delete rows, despite of allow to deletes", the source of confusion is these labels `[ ] Delete Rows` and `[ ] Delete Columns` in the protect sheet dialog. Changed these to `Delete rows with unprotected cells` to make it more clear what they are about.
Change-Id: I1009fca2a3cf56ffdc513fdb9b6192b3b965d050
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176616
Tested-by: Jenkins
Reviewed-by: Sahil Gautam <sahil@libreoffice.org>
now that we are using proper reference-counting template classes to
control lifetime here, the code can be simplified and obsolete comments
removed.
Change-Id: I7693c684d4bed0e26016b5d6bbbf1c38fec62519
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176624
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Now that the hash extract part works, the other end of this external
signature support is to be able to integrate an externally generated
(e.g. qualified) signature into our PDF file.
The problem is that we have SignDocumentContentUsingCertificate() for
non-interactive signing and we have the interactive sign dialog, but we
have no way to integrate an existing PKCS#7 blob.
Fix the problem by extending vcl::filter::PDFDocument::Sign(): if a
signature value is provided, then integrate that, instead of calling
svl::crypto::Signing::Sign() to generate a new signature.
Also extend the SigningContext documentation, since now it has 3 modes
(normal sign, hash extract, sign serialize).
Change-Id: I113fb536b1a83b8a4869a7064bb415bca6a91ae4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176623
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
for the error case
Just for consistency with the other error cases in PutData/GetData
Change-Id: Ib7fd27f9347021b3063e6eac88fd8038d5f218e0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176621
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
because I might touch this area and I want to be sure I don't mess it up
Change-Id: I62c177031f690f4455a58f3280ed26186df94158
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176620
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
While trying to load notebookbar.ui for sc I found that there are issues
with the .ui file itself:
* Duplicate IDs, created in 608e1452c5
* Typo in the attribute names, created with the manual edits in
04ed7cbe53
This patch fixes above problems.
Now, one can preview the notebookbar.ui for sc with:
$ export GLADE_CATALOG_SEARCH_PATH=$PWD/instdir/share/glade
$ glade-previewer -f sc/uiconfig/scalc/ui/notebookbar.ui
Change-Id: I83be23f4a2a24a04f4fa8b627c138bc42bdf6916
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176619
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
