One gtk3-specific section is sufficient.
Change-Id: I42a5cd1b94df7874665743a386af8e2e19590b0c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176786
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
so only the one that implements it needs to override it
Change-Id: I1acffb4796d95d75edc4507f533d9b1f8987972b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176790
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
log failure and continue to export the remainder of the document
#0 0x0000733dda8ae4a1 in __cxa_throw () from target:/lib/x86_64-linux-gnu/libstdc++.so.6
#1 0x0000733dc5d0bd43 in ScCellRangeObj::getCellRangeByPosition (this=0x2a753d60, nLeft=43, nTop=-7, nRight=43, nBottom=-7)
at sc/source/ui/unoobj/cellsuno.cxx:4638
#2 0x0000733dc66150d5 in ScTableSheetObj::getCellRangeByPosition (this=0x2a753d60, nLeft=43, nTop=-7, nRight=43, nBottom=-7)
at sc/source/ui/unoobj/cellsuno.cxx:6711
#3 0x0000733dc62d3e38 in ScXMLExport::GetMerged (this=0x1fc74160, pCellAddress=<optimized out>, xTable=...)
at sc/source/filter/xml/xmlexprt.cxx:2750
#4 0x0000733dc62d7104 in ScXMLExport::AddStyleFromCells (this=0x1fc74160, xProperties=..., xTable=..., nTable=0, pOldName=0x0)
at sc/source/filter/xml/xmlexprt.cxx:2156
#5 0x0000733dc62dfebb in ScXMLExport::collectAutoStyles (this=<optimized out>)
at sc/source/filter/xml/xmlexprt.cxx:2559
#6 0x0000733dc62d0fff in ScXMLExport::ExportAutoStyles_ (this=0x1fc74160)
at sc/source/filter/xml/xmlexprt.cxx:2657
#7 0x0000733dd833a7a4 in SvXMLExport::ImplExportAutoStyles (this=0x1fc74160)
at xmloff/source/core/xmlexp.cxx:1123
#8 0x0000733dd833d098 in SvXMLExport::exportDoc (this=0x1fc74160, eClass=<optimized out>)
at xmloff/source/core/xmlexp.cxx:1389
#9 0x0000733dd83386f6 in SvXMLExport::filter (this=this@entry=0x1fc74160, aDescriptor=...)
at xmloff/source/core/xmlexp.cxx:815
#10 0x0000733dc62e6452 in ScXMLExport::filter (this=0x1fc74160, aDescriptor=...)
at sc/source/filter/xml/xmlexprt.cxx:5472
#11 0x0000733dc63204a0 in ScXMLImportWrapper::ExportToComponent (this=0x7ffc11959890, xContext=..., xModel=..., xWriter=..., aDescriptor=..., sName=...,
sMediaType=..., sComponentName=..., aArgs=..., pSharedData=...)
at sc/source/filter/xml/xmlwrap.cxx:707
#12 0x0000733dc632679a in ScXMLImportWrapper::Export (this=this@entry=0x7ffc11959890, bStylesOnly=bStylesOnly@entry=false)
at sc/source/filter/xml/xmlwrap.cxx:943
#13 0x0000733dc6465d5e in ScDocShell::SaveXML (this=0x11d1c440, pSaveMedium=0x138252f0, xStor=...)
at sc/source/ui/docshell/docsh.cxx:653
#14 0x0000733dc646a519 in ScDocShell::SaveAs (this=0x11d1c440, rMedium=...)
at sc/source/ui/docshell/docsh.cxx:1913
#15 0x0000733dd6ae7432 in SfxObjectShell::SaveAsOwnFormat (this=0x11d1c440, rMedium=...)
at sfx2/source/doc/objstor.cxx:3378
#16 0x0000733dd6af0ae6 in SfxObjectShell::SaveTo_Impl (this=0x11d1c440, rMedium=..., pSet=0x7ffc11959fe0)
at sfx2/source/doc/objstor.cxx:1520
#17 0x0000733dd6af2f08 in SfxObjectShell::DoSave_Impl (this=0x11d1c440, pArgs=0x7ffc11959fe0)
at sfx2/source/doc/objstor.cxx:2760
#18 0x0000733dd6b2b3aa in SfxBaseModel::storeSelf (this=0x5348c30, aSeqArgs=...) at /opt/rh/devtoolset-12/root/usr/include/c++/12/optional:306
#19 0x0000733dd6ab2671 in SfxStoringHelper::GUIStoreModel (this=this@entry=0x2ba275b0, xModel=..., aSlotName=..., aArgsSequence=...,
bPreselectPassword=bPreselectPassword@entry=false, nDocumentSignatureState=SignatureState::NOSIGNATURES, bIsAsync=false)
perhaps some relation to https://gerrit.libreoffice.org/c/core/+/160363
which is a somewhat similar situation
Change-Id: I6b28ef0e9df0f44641fa5c582b5827dbcfb4af8d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176765
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176792
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
Since
commit 9fe2ead3d5
Author: Noel Grandin <noel.grandin@collabora.co.uk>
Date: Fri Oct 8 06:43:18 2021 +0200
loplugin:moveparam in svx
V1030 The 'aSdrObjects' variable is used after it was moved.
Change-Id: I9b426204ff2e2e2d0f6b375e201259765aa12736
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176785
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
and generally don't bother with it when fetching data
from urls
Change-Id: I51a2601c6fb7d6c32f9e2d1286ee0d3b05b370b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176645
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
* Update helpcontent2 from branch 'master'
to e9c7414e4fd17c6f2ffbe6208db2c741fe33e803
- tdf#162504 Create help page for Number Format pane
Create new page source/text/scalc/sidebar_number_format.xhp to describe
the features of the Number Format pane in the Properties sidebar deck.
In AllLangHelp_scalc.mk
- Add new file source/text/scalc/sidebar_number_format.xhp to
repository.
In source/text/scalc/01/default_number_formats.xhp
- Add variable and section tags so that content can be easily linked and
embedded in other pages.
- Remove old comments
In source/text/shared/01/05020300.xhp
- Add variable and section tags so that content can be easily linked and
embedded in other pages.
- Remove old comments
In
/home/dione/libreoffice/helpcontent2/source/text/shared/01/sidebar_properties.xhp
THIS PAGE IS A WIP AND WILL NOT BE LINKED IN HELP UNTIL IT IS FINISHED
- Embed description of the help page for Number Formats
- Added index bookmarks (Currently commented out)
- Updated application switches to hide the desription of the Paragraph
pane for CALC and BASE.
Change-Id: I7e1849ddc41cad7fd5d4b6c57e8a03186eb6575f
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176720
Tested-by: Jenkins
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
it is only used for one thing, so rename it, and
use a default implementation to avoid having empty
implementations everywhere
Change-Id: Ib650bb520ccbfcc27537b754db4d3de4ad10e638
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176733
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
The previous command was not working, because of the lack of absolute
path and also the wrong path to the test document. This should be fixed
now.
Change-Id: I2230041e17e4b6b33cfd44e5f15a5fce086a5f1c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176764
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
it is more appropriate state variable for this particular command,
as in many cases its disabled and that can not be treated as false
as document still maybe editable
Change-Id: Ib19a0cc087518a18bf295abd08b93815606af1fa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176736
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit 04375f2a31cc6c233a015215f06682462b30425f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176748
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
Tested-by: Jenkins
To remove code duplication when rendering main and master slide,
it is needed to put them into common code, so add RenderContext
and RenderOptions classes to put the common code into those.
Change-Id: Icf4039f85e0aa5bf4d43e6fe5efb725c90504173
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176762
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* Update translations from branch 'master'
to fdabff5f73e16046cb570561051304029eef48f9
- update translations for master / 25.2 alpha1
and force-fix errors using pocheck
Change-Id: I667061bab346925defe899a544153314133b6bc5
...in
<b9d678d22f>
"[Clang] Use TargetInfo when deciding if an address space is compatible
(#115777)"
Change-Id: Ibe9e4882057edbdcdbd286416c3d317c292b2298
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176760
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
Regression from commit 70d1bd6ee0
(tdf#161652 editeng, RTF copy: only write used paragraph styles,
2024-06-20), type a few characters into the title placeholder shape in
Impress, switch to the Outline view, select all, copy, paste into
Writer: the resulting text nodes won't have paragraph styles, just
direct formatting.
Inspecting the produced RTF, the problem is that the styles table
started to omit unused styles, but the style -> offset mapping table
still included them, so the offset didn't match, which results in losing
the style on RTF import.
Fix the problem by building the mapping table later also also ignoring
unused paragraph styles there, to restore consistency between declaring
style entries and referring to them.
Change-Id: I9156a881543cc710eb12990f110ceefc77a1858b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176747
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Reduce the size of the upper boxes to get more space for the
field value input.
Fixes also tdf#162702 by setting the size also to the number
format list box.
Change-Id: I96cc38b30fa7afccf6ca009aad3b15f1f051d381
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176106
Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Although <tag></tag> and <tag/> are syntactically equivalent, we
got a report that some 3rd party tool could not process a docx file
produced by LibreOffice. In styles.xml there was
<w14:ligatures w14:val="standardContextual"></w14:ligatures>
instead of
<w14:ligatures w14:val="standardContextual"/>
This patch is meant to fix this, to mimic what Word does anyway.
Change-Id: Iea409981d2a2eac40c460bdae4d3dc7e8b0c33ae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176680
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Jenkins
As the GtkSizeGroup [1] says:
> GtkSizeGroup provides a mechanism for grouping a number of widgets
> together so they all request the same amount of space. This is typically
> useful when you want a column of widgets to have the same size, but you
> can’t use a GtkGrid widget.
However, "sizegroup1" in this .ui file is empty, i.e.
doesn't group any widgets that should be the same size,
so drop it altogether.
[1] https://docs.gtk.org/gtk3/class.SizeGroup.html
Change-Id: I9ffa6d0d302c08c6668b40847dde04de11fb24cf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176737
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
I think I managed to disable this when I converted it to
use the shared plugin infrastructure.
So fix that, and then make it much smarter to avoid various
false positives.
Change-Id: I0a4657cff3b40a00434924bf764d024dbfd7d5b3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176646
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Regression caused by 2942fdc8db
OOXML <filterColumn colId="0">
Autofilter range colID is not absolute id. It starts always with 0 even
if the autofiltered range doesn't start with col 0 in the document.
So we are checking the flag from document (rDoc), not from the autofiltered range. So
we should use absolute column id to get right flag.
Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: I1f94058caa23686596d57dd6983ddf02cd8f5e71
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176564
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176717
Tested-by: Jenkins
Pasting paragraph with a list into an empty or completely selected
paragraph with lists has been changed:
If the pasted paragraph(s) are all formatted with a list from the
paragraph style then this list will be preferred.
If some the pasted paragraphs including the first one are formatted
with a hard list then these attributes will be preferred.
If all paragraphs have a hard list or no list at all the list at
the target position will be preferred.
Change-Id: I5aa6834d32f7c69b2eb9f8330b282c0ae6fca559
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176478
Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
Tested-by: Jenkins
Lines containing EN_SPACES only ignore character height
while calculating line height. In FORMTEXT fieldmarks the character
height of the default EN_SPACES is not ignored.
Change-Id: I8a89f13875f61ed287ce1697a91b42f20bd17192
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176147
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
Tested-by: Jenkins
Since 6c04b8356c SVG was added
to the supported clipboard formats but it did not work.
SVG support is now fixed and PNG format is added in the gallery.
Change-Id: Ic9cb2eebfc37bd38605dfaa3a1c353a7532af357
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165908
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
66b4bfe302 introduced a default left/right
cell margin of 0.19 cm in DOCX import but is was also applied in RTF.
This is no longer applied in RTF import.
Change-Id: I192b2d17018c234837b926be64fdf27554b024e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173981
Tested-by: Jenkins
Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
Follow-up to a593c27e88.
If Ctrl key is presseed then remove list attributes of the paragraph, too.
Change-Id: I29ea97ff08f45061d532b11cb981c534cc786f0f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174977
Tested-by: Jenkins
Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
V758 The 'aModel' reference becomes invalid when smart pointer returned by a function is destroyed.
Change-Id: If06b81fda6fdaf4debf5061dd0e3c6c7caccad5a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176742
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
V522 There might be dereferencing of a potential null pointer.
Change-Id: I23e4eba0399243ca67ecaa3101a327eece825687
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176722
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
This reverts commit 3b267b65d2.
reports of test failures at:
https://gerrit.libreoffice.org/c/core/+/176508
Nothing depends on this right now, so I'll have second go at this later.
Change-Id: I95999f05c69fa9b2459128116927616b1f6a9ca5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176743
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
it is always called in the destructor, so lets just centralise the logic
here
Change-Id: I8c9b204d147315b6693fa7a08f759b53b9a6a17c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176731
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
it is only called to do one thing, in X11SalGraphics, so make
it private to that class, and rename it to better fit its
purpose.
Change-Id: I16ea2f86f8b596351354faa80bb2bab4d2ac6e7c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176729
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Following
commit 4f08a15f3b
Author: lovatico21 <lorenzo04lovato@gmail.com>
Date: Wed Nov 13 18:12:58 2024 +0100
updated vim footers in vcl/qt6/*.cxx
, update vim header/trailers to those in current
`TEMPLATE.SOURCECODE.HEADER` for other qt5/qt6
headers and sources as well (i.e. for directories
`vcl/inc/qt5`, `vcl/inc/qt6` and `vcl/qt5/`).
Change-Id: If9fea8f4ce955396f064dbd9fd706e76d947bce1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176705
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Since
commit 405cf00e48
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Tue May 28 11:50:12 2024 +0200
related tdf#160971 gtk3 a11y: Keep new combobox value
, closing an (editable) combobox like the font size one
in the Writer formatting toolbar resulted in the combobox's entry
having focus, while the focus was set to the document before that
commit.
Make this work as expected (again), by making grabbing the
focus conditional in 2 places:
1) In GtkInstanceComboBox::signal_popup_toggled,
only set the focus to the GtkEntry of the custom
combobox implementation if the child focus is already
inside of the combobox. As I understand it, the intended
logic is "move focus from the combo box's button to its entry",
not "unconditionally grab the focus".
This also matches what the gtk4 implementation does. Sync the
comment from the gtk4 implementation, which explicitly
mentions the case of the font combobox in the toolbar (which
behaves the same as the font size one in that regard) where
focus should not be grabbed.
2) In GtkComboBox::menu_toggled, only explicitly set focus to
the toggle button if the combo box is located inside of a popup.
This is the same condition used to grab all keyboard events.
The code to do both was introduced in
commit 131c1c7da8
Date: Sun Nov 21 19:53:47 2021 +0000
Related: tdf#145786 cooperate between our own grabs
whose commit message only explicitly mentions grabs
for popups. The scenarios described in the commit message
still work as expected with GDK_BACKEND=x11.
With this in place, focus now moves to the document
as expected when clicking on a combobox entry in the popup
for the font size combobox in Writer's formatting toolbar,
while clicking an entry in any of the comboboxes in e.g.
Writer's "Format" -> "Character" dialog's "Font" tab still
results in the entry of the combobox getting focus.
Change-Id: Ib07b034f8327dab19a2264ae3ed8e20ea918dd89
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176713
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
V758 The 'rModel' reference becomes invalid when smart pointer returned by a function is destroyed.
Change-Id: I34cbf998da49a576b43b946187de94495f5e5529
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176716
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Commit f4c2c7c79c fixed tdf#157312
by lowering the timer priority to TaskPriority::POST_PAINT. But
it caused tdf#163734 so it was reverted to TaskPriority::HIGHEST
in commit 5a38e4f979.
While reverting to TaskPriority::HIGHEST did not cause tdf#157312
to reoccur, it did cause tdf#163945 so set the timer priority to
TaskPriority::HIGH_IDLE. This priority appears to be low enough to
fix tdf#16394 without causing tdf#163734 to reoccur.
Change-Id: Ifc2833a886d52117d46c02a80c88c674ad080824
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176698
Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
Tested-by: Jenkins
Any status progress in LO status bar is also represented
as progress in Windows taskbar.
Change-Id: Ibd7131ff6246cf5ea37ab8730d0eddfa084265c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171886
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
