Change-Id: I27de9f10b54478fa265efcb2fa35b8c7e16666f2
V1037: Two or more case-branches perform the same actions. Check lines: 821 and 827, 1962 and 1967, 2006 and 2011.
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175052
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
Change-Id: Id493bc317eb9cf358c79454b7778895b78b7c8aa
V1037: Two or more case-branches perform the same actions. Check lines: 320, 323
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175048
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Change-Id: I4afca4f9d7eb8968dc7a2465222f7c2060f10bd4
V1037: Two or more case-branches perform the same actions. Check lines: 178, 194
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175055
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Change-Id: I392760b8605588576049e5afda2da64faea3fd00
V1037: Two or more case-branches perform the same actions. Check lines: 486, 489
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175049
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
V668 There is no sense in testing the 'mpMarkedRanges' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error.
V668 There is no sense in testing the 'mpMarkedRanges' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error.
Change-Id: Iba55f15534cdc9af5b86b288b5c42702ad83dc26
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175107
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
V595 The 'pDrawView' pointer was utilized before it was verified against nullptr. Check lines: 128, 133.
Change-Id: Ic07658428e4eb74d42d800df23b198800a9bab09
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175115
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
V668 There is no sense in testing the 'indxc' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error.
V668 There is no sense in testing the 'indxr' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error.
V668 There is no sense in testing the 'ipiv' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error.
Change-Id: Ifecd9ef5b831e5b312bb428e4d4f72c03cc29b7b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175106
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
V595 The 'GetView()' pointer was utilized before it was verified against nullptr. Check lines: 518, 531.
Change-Id: I9c6ebccabece0923702e6a8fb4ee6beb9b6dc198
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175114
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
V668 There is no sense in testing the 'pInfo' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error.
Change-Id: Ie6a701c8fd8d6a0386e83012d59389edaccea93e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175109
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
V668 There is no sense in testing the 'pCommentAction' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error.
Change-Id: I3fa6619f80edefd852693190ebf463f694c8b55c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175108
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
V595 The 'mpViewSh' pointer was utilized before it was verified against nullptr. Check lines: 704, 713.
Change-Id: I5c1902d9aa9a33e62cf2aa559bab9c0b3f45f688
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175112
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Since 07f8216e57
"Create string from token array directly from ScTokenArray. Still WIP."
V622 Consider inspecting the 'switch' statement. It's possible that the first 'case' operator is missing.
Change-Id: I5916fb8db4db3a0c238660a35ad1b5d985387292
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175111
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
In some cases IWYU may fail to run and give back -1 status
- A file does not have any headers included, such as
sw/source/ui/vba/vbawordbasic.hxx
- A header includes itself such as
sw/source/ui/vba/vbaformfielddropdownlistentries.hxx
- Checking headers is not called with correct -I switches
such as with sw/source/writerfilter/dmapper/*hxx misses
-I/home/gabor/core/sw/source/writerfilter/inc
Such cases were not handled/reported separately so far, so add a
debug-like option to detect similar errors.
Solving such issues is still down the road.
Change-Id: I47ac876eb4eb4a0c16bd838ce3c3e4d604a07a7f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175099
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
Set the line join type from our GC.
Change-Id: I8f64ae032930e46028cd49efefb05af06d4866d6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172926
Tested-by: Jenkins
Reviewed-by: David Gilbert <freedesktop@treblig.org>
Pdfimport is one of the few none render pieces of code to use
css::rendering::PathJoinType, switch to using basegfx::B2DLineJoin
instead.
Use that type consistently instead of throwing in sal_Int8's with it.
Change-Id: Ie1384a06558925c796ce6c83b458b4c150bcecc7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172925
Tested-by: Jenkins
Reviewed-by: David Gilbert <freedesktop@treblig.org>
Poppler's 'ClipToStroke' call wants to clip to a paths rendered
shape, i.e. with line thickness and possibly other attributes.
Use get2DDecomposition to do that.
Change-Id: I3ca54621dcb859520504e5c7d6cd41106f5c34d1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172924
Reviewed-by: David Gilbert <freedesktop@treblig.org>
Tested-by: Jenkins
V595: The 'pMethod' pointer was utilized before it was verified against nullptr. Check lines: 392, 394.
Change-Id: I7c3cdcf9aacb76ca261733924dc238e836036433
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175080
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
V1037: Two or more case-branches perform the same actions. Check lines: 996, 999
Change-Id: Idfec4df06a578c63e52ef053b73dfa2d55b5cbf3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175089
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
V581: The conditional expressions of the 'if' statements situated alongside each other are identical. Check lines: 422, 426.
Change-Id: Ib2bcd4b170b827c325628e0e7eabe6a19ca399ff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175086
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
V581: The conditional expressions of the 'if' statements situated alongside each other are identical. Check lines: 507, 520.
Change-Id: Ia376cad05bd4327662cd3b7adcbe43e25270da2f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175084
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
V581: The conditional expressions of the 'if' statements situated alongside each other are identical. Check lines: 406, 410.
V581: The conditional expressions of the 'if' statements situated alongside each other are identical. Check lines: 410, 418.
Change-Id: I971f243870a96f7195d2819f2a0a44bb63840fac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175083
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
V581: The conditional expressions of the 'if' statements situated alongside each other are identical. Check lines: 153, 157.
Change-Id: I55b32aa4dfd479c3b64044a6749c3981f3b032a4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175082
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
Parse the soon to be created clipToStrokePath command and route
it through the tree code.
Change-Id: I8fa17457ffd062e91983b6ed80bd64259aa7114e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172923
Tested-by: Jenkins
Reviewed-by: David Gilbert <freedesktop@treblig.org>
A followup patch that adds keyboard shortcut support to Draw/Impress
for .uno:Color and .uno:CharBackColor to use recentColor.
Change-Id: I1eea3b8330ca3c10e20b13e0fa83c15418eee6a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174828
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
A followup patch that adds keyboard shortcut support to Calc
for .uno:Color and .uno:CharBackColor to use recentColor.
Note that for Writer, it was .uno:FontColor (SID_ATTR_CHAR_COLOR2)
but the rest of the applications are .uno:Color (SID_ATTR_CHAR_COLOR)
I purposely did not add CharBackColor support to native Calc.
Notice that the "fill" icon on the toolbar is CELL-background, so the
color used would NOT NECESSARILY match what is seen in the toolbar,
and the sidebar also does not include a CharBackColor button.
[See patchset 1 for stuff needed for implementation.]
formatsh is for entire cells - .uno:Color opens dialog when no args: OK
editsc is for cursor-in-cell and for cursor-in-formula-bar.
drtxtobj is for comments, shapes, and textboxes (draw stuff).
Change-Id: I104b39eab1d475fc5c88837addf4bdbbd313d1be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174827
Reviewed-by: Justin Luth <jluth@mail.com>
Tested-by: Jenkins
A followup patch that adds keyboard shortcut support
for the draw objects (textbox, shapes, comments) in Writer.
Change-Id: I69dea0feb75c77fec615a3e478d4bb90db4ca84f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174805
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
(soffice:502622): Gtk-WARNING **: 13:08:51.061: Could not read property GtkBox:position with value of type gint: Could not parse integer ''
Change-Id: I43b1a0fd8d67ef60e9c252b914b4fe2d00d97c89
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175079
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
...where window decoration icons and menu text glyphs were missing
Change-Id: Iadff019a99fbe96442fc010df0d019ba5e2b98e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175088
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
The result of this patch is that a keyboard shortcut can now
set the font fore-/back-ground color using the
color shown in the toolbar/sidebar.
This is now possible thanks to Maxim's work in 7.6.2
tdf#154270 Sync toolbar button recent colors
and Andreas Heinisch's 24.8 commit 8c822b764b
tdf#72991 - Remember last used color depending in cui
This patch does 3 things:
1. SetRecentColor when the app initializes
2. Uses SID_ATTR_CHAR_COLOR's recentColor for .uno:FontColor
if no pItem was provided (i.e. a keyboard shortcut called it)
3. Uses SID_ATTR_CHAR_BACK_COLOR's recentColor for .uno:CharBackColor
if no pItem was provided
(Note that without a selection,
CharBackColor isn't so useful for a keyboard shortcut,
since it turns the drag-and-drop template on.)
Setting the recent color right away is critical for user acceptance.
Otherwise, it would only function after they first modified the color
in the toolbar/sidebar.
make CppunitTest_sw_uiwriter9 CPPUNIT_TEST_NAME=testTdf34804
Unfortunately, I can't reliably know if this request
came from an awt::KeyEvent or not, because in that case
we could just avoid CharBackColor's template altogether.
[While there is rReq.GetModifiers() as a good hint,
it is not a guarantee (in case assigned to a function key,
or CTRL held while clicking the toolbar, etc.)]
Change-Id: I7377f087dcdf7011205af005cd0d172100bade2b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174804
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
At least when building against recent upstream dev branch, qtloader.js needs FS
due to
<64007c7497>
"wasm: add 'preload' qtloader config property"
Change-Id: Ie505d531670649635774152032123389b6d106ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175085
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
This change modifies the Writer document grid algorithm to behave more
like Word when the MS_WORD_COMP_GRID_METRICS compatibility flag is set.
This flag is automatically set when importing DOC/DOCX files.
Change-Id: I99765a3ad689b319ebd14e3620b22f18661efcf4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175077
Tested-by: Jenkins
Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
A CPPUNIT Test for the bug fix on swlo!sw::WriterMultiListener::StartListening
crash.
The sample file was added to the sw/qa/uiwriter/data.
Without this fix, writer crashes when the reproducing steps were followed.
The bug fix was reverted, when the test was ran, the test failed, i.e the
assert was not reached. The bug fix was reintroduced and the test
passed showing that the test catch the bug.
Change-Id: I688672d96a36d89c940bf0d401daaaeb732590a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174908
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
