- this patch improve e8a271dd53
when replace the empty-placholder, it was missing the selection
of the whole placeholders.
- with this change have solved a other problem, when select with
the field with mouse or tab, and press backspace, then the cursor
has the wrong position, after tip text the view was wrong.
- reduce code
Change-Id: I6c2c7b2849298552770ea2d257ab844d250a97a1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174965
Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Tested-by: Jenkins
Since they use DECLARE_ODFEXPORT_TEST they should be inside
sw/qa/extras/odfexport/
Change-Id: Ia080f006c08ecf584232428563ec2aa94f6a4ce2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175067
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
- ${var/pattern/replacement} and here-string are bashism.
- here string (<<<<) is bashism too, depsited it's intended for Windows
build only (which uses Bash inside msys), however the code block is
still parsed on other platforms (without bash a /bin/sh) before
evaluated. Let's remove that too.
Change-Id: I3ba59d97b9e9a6b29496b3401c29c4fbf99f46d4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170969
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
This PPDParser ctor is used by CPDManager::createCPDParser,
which gets built with the `--enable-cpdb` autogen option.
This partially reverts commit 5c4fac1e9f.
Change-Id: Ic22fc4e776c0b0ef2013b9296c7dbe9345c4e51c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175040
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
both sides, depending on the text alignment. Set the text anchor
position based on the first paragraph alignment.
WIP: testing...
Change-Id: Ie1588c3eab5dd24eddb20baf342aca57c0dd39fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174885
Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Tested-by: Jenkins
Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
When there is a grammar check error that it has no suggestions for, Duden
may return a JSON without suggestions, but still informing about the type
of the error, like
...
{
"offset": 468,
"length": 8,
"errorcode": 21,
"type": "orth",
"proposals": []
},
...
Before the change, we underlined the error, but right-clicking it would
only bring the normal Writer's context menu, as if there were no error.
This was made in commit 7697ef9d8f (Proof
reading suggestions:, 2023-11-28); before that change, the context menu
was shown, but since it had no suggestions, and no explanation text, it
was considered better to just not show the grammar check results. But
no menu for an underlined word is no better; so let's instead show the
explanation, based on the type of the error reported by Duden - that is
stored in SingleProofreadingError::aShortComment. Also set aFullComment,
which is used in the grammar check dialog.
Incidentally, it even improves popups with suggestions, because it now
has the explanation as well, where previously only was an icon without
any text.
It may be further improved in a follow-up, because there is "errorcode"
in the message, which we may use to add more details to the explanation.
tdf#160127 should be fixed with this, too; but if there are cases when
there are neither suggestions, nor explanation available, it will need
further work.
Change-Id: I62cde204e0142d6226c9c9486f1cdb5ffc20dca8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175017
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
1) Error handling in the ExecuteCalcFunction()
function must be conditioned by the global
error handling.
True; display a user-friendly message
False: abort on the erroneous line
So far, an ambiguous error message was displayed
in both cases.
2) Above ambiguous error message was corrupted
by the detour to SF_Array.Prepend() method
in exc.RaiseFatal() and exc.RaiseAbort().
A simple workaround fixes the ambiguity
about the name of the faulty routine.
Change-Id: Iab38b48e6291e1960fc288696a7ebd18ffe8ebae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175020
Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
Tested-by: Jenkins
regression from the transparency->alpha work
Change-Id: I2aaf8262191ca6136f87c59629e95bd9a7e7e419
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174991
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
...introduced in 074714fab8 ".NET Bindings: Create
nuget package for LO SDK". The assumption is that none of the variables used in
that block of code represent paths that contain characters that would need any
form of quoting. (And if they did, the solution would not be to just wrap them
in "..." quoting, but to use '...' and escape any contained ' properly.)
Change-Id: Ie5b972c53a60c8c9a4bcfa03627a8e1998646285
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175010
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
Tested-by: Jenkins
As long as FORMTEXT has default content of 5 en spaces a click
selects the content. If the content has changed then the cursor is
placed at the mouse position.
Change-Id: If0e7717d04d29887b63ec20ed6b82c625400421a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173812
Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Tested-by: Jenkins
Limited line width at image wrap could result negative nSpaceAdd
value, i.e. paragraph line with extra letter spacing instead of
line shrinking.
Regression from commit 17eaebee27
"tdf#119908 sw smart justify: fix justification by shrinking".
Change-Id: I76cc3004d246ff7af441ca9a92eaa8fc7b09f01b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174985
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
Load the bugdoc, notice that the only shape in the document has a
captured (inside the page frame) draw shape, but its inner fly frame is
not captured inside the page frame, so a small top margin is paired with
a larger right margin, which is unexpected.
This is nominally a regression from commit
9835a5823e (sw textboxes: reimplement ODF
import/export, 2014-10-04), because previously the ODF markup for Writer
TextBoxes were ignored, so we had correct position of the shape text at
the price of losing complex content.
Fix the problem similar to what commit
a0b6587c4a (tdf#161199 sw
DoNotCaptureDrawObjsOnPage: capture wrap=none draw objects, 2024-06-13)
did: if we detect that the fly frame is part of a TextBox, then work
with the wrap type of the draw format, since these inner fly frames
always have their wrap type set to "through".
This fixes the unexpected position of the fly frame and keeps the import
of complex content working.
Change-Id: Ib0d861af0fac74d93a09178c10bc19a1b45e3ce7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174987
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
Code calling the ctor was dropped in
commit 4aa2cc878d
Date: Thu Jun 20 10:46:59 2024 +0200
loplugin:unusedmethods
which dropped GtkSalData::GetDocumentFocusListener
unused since
commit c45c64aeb5
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Mon May 6 14:44:36 2024 +0200
tdf#160806 tdf#160837 gtk3 a11y: Drop handling of some VclEventIds
Change-Id: Iee8134371fce26cb21481695ab8379d4fc61065c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174988
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
by using bulk_insert_for_each() more aggressively.
Reduces the open time from several minutes to 18s on my machine.
I had to pass down a flag, because the gtk and the gen weld
backends work differently, and the gen backend absolutely
has to know up front if the inserter function is going to
call set_text, otherwise it asserts in SvTreeListBox::SetEntryText
Change-Id: I84750888c0a80f4041cfe024e6570dd94f6d09db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174757
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
When you ENTER a placeholder, it removes the placeholder text.
In that case it doesn't treat this as a change
(because SdrObject::SetOutlinerParaObject is never called).
However, when you LEAVE the placeholder,
it puts the placeholder text back in.
This was being treated as a modification event (x2).
I tested what happens if you delete text
and then leave the placeholder.
The deleted text is already handled before we can leave the placeholder,
so that doesn't cause any concern.
TODO: an undo event is also created.
Change-Id: I366eb7a174284dc07415342258fcf65e50641be6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174860
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
After calling loadAndSave, isExported always returns true
Code added in 9e1e88ad5c
"tdf#145720 DOCX export: fix loss of tracked moving"
If it's changed to check the layout from parseLayoutDump instead
of the export, it also fails
Change-Id: I0f8248db44ab299c3b6a6ed0901357d6e153e1aa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174979
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
