Bothering users with a dialog for a problematic TLS certificate just
conditions them to click OK and compromise their security.
WebDAV UCP already doesn't show such a dialog since LO 7.3, now remove
the dialog from CMIS UCP too.
Users can add any self-signed CAs they want to use to the operating
system trusted CA store, for example with p11-kit's trust(1).
Change-Id: Iedb8518923f9ac75c33a3b0df6ff795a7810a18a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169338
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
1. in libcmis, pass the CurlInitProtocolsFunction to all subclasses of
HttpSession that need it, and add 2 upstream fixes to pass it around
2. Arrange for InitCurl_easy to be called in UCP RepoContent as well
3. If AllowInsecureProtocols is disabled, automatically upgrade
http connections to https, as is already done in webdav-curl.
Do this in Content and RepoContent; hopefully should work
to convert when m_aURL member is initialised;
the m_xIdentifier on the other hand should have the original
URL because ContentProviderImplHelper::queryExistingContents()
caching likely relies on that.
Change-Id: I20d36ed03ba7ce221d6946b1c996071f4130ec7e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169114
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* Update helpcontent2 from branch 'master'
to ade7397aed9febc73918d93ffdf6477d3f4d4175
- explicit \s and \d + put the note first for full ICU spec. tdf#113975
Change-Id: Ie06115c051def1da7b94357a392796d15a21df34
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/169402
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
found by sed -i -f ref.sed */*.yaml
--------------------ref.sed --------------------
{
N;
s#\([^\n]*\n\)\1#\1#g;
P;
D;
}
------------------------------------------------
meaning: by default it reads in one line from the file
then the N; command says "add a \n and read in the next line
which leaves a one-line pattern containing 2 lines separated by \n
then search for line1\n repeated \1
and replace with \1.
likely nothing has happened, so P; print up to the first \n (aka line1)
so that we don't lose that line
D; delete up to the first \n
so that it isn't in the pattern buffer any more,
and next search starts line2
and then repeat.
Change-Id: Ib5d38af77568f59f36083f5348762d852acaa3e8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169047
Reviewed-by: Justin Luth <jluth@mail.com>
Tested-by: Jenkins
found by sed -i -f ref.sed */*.yaml
--------------------ref.sed --------------------
{
N;
N;
N;
s#\([^\n]*\n\)\([^\n]*\)\n\1\2#\1\2#g;
P;
D;
}
------------------------------------------------
meaning: by default it reads in one line from the file
then the 3 N; commands say "add a \n and read in the next line
which leaves a one-line pattern containing 4 lines separated by \n
then search for line1\nline2\n repeated \1\2
and replace with \1\2.
likely nothing has happened, so P; print up to the first \n (aka line1)
so that we don't lose that line
D; delete up to the first \n
so that it isn't in the pattern buffer any more,
and next search starts line2
and then repeat.
Note that the pattern gets rather huge
because while we only remove one line at a time,
we unnecessarily append 3 more lines (instead of just one).
But that doesn't seem to cause the search to fail...
Change-Id: I440bca873483dc7f1716881113807fe121fe6a4c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169045
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Reviewed-by: Justin Luth <jluth@mail.com>
SwXText is heavily used. Reduce the allocation cost of
this class by de-pimpl'ing this class.
Change-Id: I01b06c978075ae312131dfff29b4f304caf69e18
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169359
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
SwXTextRange is heavily used. Reduce the allocation cost of
this class by de-pimpl'ing this class.
One strange thing I noticed is that the destructor of the Impl indicates
that deleting the bookmark via deleteMark() has to happen under the SolarMutex,
but there are two places in the existing code which violate this already.
Change-Id: I171a0d82d6d020d9a43808c424f308722770783f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169354
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
ESelection::All() select all text
ESelection::NotFound() sets seletion to not found state
ESelection::NoSelection() sets selection to no / invalid selection
Introduce max paragraph and position constants in ESelection,
use for EE_PARA_APPEND, EE_PARA_ALL, EE_PARA_MAX_COUNT,
EE_TEXTPOS_ALL, EE_TEXTPOS_MAX_COUNT.
Also simplify some ESelection constructs.
Change-Id: Ib110c5a730a1deabe4f988baa5a600249b3a31e9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169356
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Jenkins
With LibreOfficeKit (LOK) headers in place, it would be possible to
create C++ applications that can access LibreOffice functionality
without building LibreOffice, only by installing SDK and build tools.
Change-Id: I8efc8ac1cec7b3b89e4d7eb2c8d15afeb595672c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134863
Tested-by: Hossein <hossein@libreoffice.org>
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
if the paragraph, which uses transformation (Arch, Circle, etc.),
contains multiple texts and the first text is only a space character,
then we use the transparency value of the following text.
Change-Id: Ia87242e34b495802cbecf5dc0dd13d490312f435
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169351
Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
Tested-by: Jenkins
Previous patches [1] and [2] introduced a contrast white line to the selection overlay that was supposed to affect only Calc, but it ended up affecting other areas of LO, such as the star math editor as well as Writer.
This patch makes sure the changes only affect cell selection in Calc.
[1] dc243f0122
[2] 3c0db89809
Change-Id: Ie910120e4b71c55ad8c00a905e1204e291a711f9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169292
Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
Tested-by: Jenkins
This commit adds an --enable-cli/--disable-cli switch to autoconf to
control generation of the old CLI bindings (Windows only). It is
enabled by default, to not be a breaking change to users just yet.
Over time, when the old bindings are deprecated in favor of the new
.NET bindings, it could be set to disabled by default.
Change-Id: Ib60b372459cb0c735275ed17d004d037279357eb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168751
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
When using the qt5 or kf5 VCL plugins on X11/XWayland
(as can be forced using QT_QPA_PLUGIN=xcb on Wayland),
ensure that a QWindow exists for the QtObjectWidget
created in the QtObject ctor, as that is needed for
OpenGL rendering.
This makes OpenGL Impress slide transitions like the
"Tiles" one work.
Don't force native windows on Wayland, as that causes
other issues, see also QtFrame::ResolveWindowHandle
and the bugs referenced in there.
Change-Id: I8fac34d2f1cc7cc723ad4570546276a05641dd88
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169348
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
As described at [1], "QWindow supports rendering using
OpenGL [...]".
Using a QWindow for OpenGL rendering had been introduced
in
commit 56b19f9a81
Date: Fri Dec 14 12:44:20 2018 +0300
tdf#121247, tdf#121266 KDE5: Add basic support for OpenGL
, but then
commit 4366e06052
Date: Tue May 24 11:34:59 2022 +0200
tdf#148864 Qt switch QtObjectWindow to QWidget
had switched from QWindow to QWidget, and OpenGL slide
transitions like the "Tiles" one stopped working.
At least for qt6, which now uses QtMultimedia for video
playback (see the tdf#145735 commits), issues like tdf#148864
("Kubuntu 22.04 LTS LibreOffice Impress 7.3.3 Fails to Play Embedded
Videos") and tdf#125517 ("LO Impress: Can't stop presentation
with video and go to the next slide") related to video playback
appear to be no problem, so switch back to using QWindow there.
Explicitly set the window background to transparent
in `QtOpenGLContext::ImplInit`, as not doing so
caused slide content in presentation mode to not
be updated properly when testing with the attachment 183972
from tdf#149461 on Wayland.
(This was not an issue when running on XWayland, i.e.
with QT_QPA_PLATFORM=xcb).
With this in place, OpenGL transitions work with qt6.
With QT_QPA_PLATFORM=xcb, it looks all fine in my tests
on Debian testing.
With QT_QPA_PLATFORM=wayland, the slide text from attachment 183972
sometimes incorrectly showed up for a fraction of a second after
the slide transition finished, then disappeared again until
it was triggered to show as it should (e.g. by pressing the right
arrow key), s. screencast attachment 194899 in tdf#149461.
A multitude of warnings like the following are shown on stderr
in that case, which don't show up for xcb:
warn:vcl.opengl:47352:47352:vcl/source/opengl/OpenGLHelper.cxx:709: GL Error 0506 (invalid framebuffer operation) in file /home/michi/development/git/libreoffice/slideshow/source/engine/opengl/TransitionImpl.cxx at line 398
That looks like a separate issue to me, however which would
need further analysis.
Keep using the QtObjectWindow approach for qt5 to
not regress on video playback.
[1] https://doc.qt.io/qt-5/qtgui-index.html#opengl-and-opengl-es-integration
Change-Id: I6e1eb989254e2cbbfada6f719ee0518571df4c42
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169347
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Move setting the layout for the QtObjectWidget
from the QtObjectWidget ctor to the QtObject ctor,
in preparation to also use that for QWidgets other
than the QtObjectWidget.
Change-Id: Ifbb0d853659bc8099bed40db2bbe8a8778077aa2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169346
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
