To be consistent with CppunitTest_vcl_filters_test. This also allows
writing actual manual test code for writerfilter/source/rtftok/ (next to
the tested code) later, where the natural choice for such a test suite
would be CppunitTest_writerfilter_rtftok.
Change-Id: Iff5be9b95b6c2be3ef441e7a766584b2d008a66a
Reviewed-on: https://gerrit.libreoffice.org/84460
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* Make most members private
* Drop some unused members
* Rename some single-char variables for easier reading
* Spread some constness
* Finalize the KF5FilePicker class
* Test the native picker setting of the QFilePicker, instead of an
additional bool member
This is just some refactoring. While not strictly needed, it helps
keeping the following patches fixing tdf#129071 more compact.
Change-Id: I15ffe4de848a9498d7f61f99bcf031257da7cb08
Reviewed-on: https://gerrit.libreoffice.org/84456
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
re-arrange them so the private/public sections are continuous.
And make a bunch of public fields private, no-one seems to be touching
them outside the class.
Change-Id: I6378793fb01bc884961d19627a46f2a1e7eda79c
Reviewed-on: https://gerrit.libreoffice.org/84448
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Mark some stuff SAL_DLLPUBLIC_RTTI in
include/vcl/metaact.hxx
in order to make ASAN happy.
Change-Id: I97febe0968bf58b9cbe60ce647f0ada25e6f4bb0
Reviewed-on: https://gerrit.libreoffice.org/84202
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
The operation explicitly changes the table to be not floating; this will
change its position; yet when saving back to DOCX, saved values from the
grab bag were used, incorrectly restoring table floating state.
Change-Id: I19c185849443dc1a8b5ac974e09349c206b0506b
Reviewed-on: https://gerrit.libreoffice.org/84446
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
The comment mentioning "Calc has a fixed zoom at 1x
and doesn't allow zooming for now" was there since
support for the Calc UI was added in commit
02f3c4848a ("Calc UI
on Android Viewer") in 2017. That seems no longer to be
the case however, probably since commit
498dceb43f
("sc lok: Implement hi-dpi and zoom for spreadsheets.").
Zooming in and out was working just fine when I tested this
with Android Viewer using a spreadsheet containing some text
and numbers, as well as a chart and an image.
Therefore, allow zooming for Calc as well.
Don't allow to set min zoom below the page width for Calc as
somewhat suggested by the existing comment ("applies to all
types of document; in the future spreadsheets may be
singled out"). I don't see a particular reason for this and
using 0f for minZoom would break double-tap zoom.
Change-Id: Ib08439edbbac59a00005213b533df5792da965ee
Reviewed-on: https://gerrit.libreoffice.org/84421
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
And /org.openoffice.Office.Recovery/RecoveryEntry/DocumentState is nillable, so
xItem->getPropertyValue(CFG_ENTRY_PROP_DOCUMENTSTATE) >>= tmp;
can presumably fail.
Change-Id: I08c38aec13b2ceda512925b18aefd5981cf85bcd
Reviewed-on: https://gerrit.libreoffice.org/84422
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
The linker output filter command (gb_filter_link_output) ends with
an exit "${PIPESTATUS[0]}", which will quit the current Makefile
shell command always after calling the linker. This prevents the
later shell code of that line to run, which includes the merge of
the DeclareDPIAware.manifest. That manifest would tell Windows
that LO binaries are "<dpiAware>true</dpiAware>", to prevent
System DPI scaling. Since it's not merged, LO is scaled by the OS,
resulting in blurry fonts.
Since there is no reason to have an extra make "function", like
ifeq or multiple definitions, this includes the code directly.
Additionally the MS linker has localized output, so this patch
uses a more generic regexp to filter-out the default link message,
which works with the English and German locale.
Change-Id: I0099f6c38ca0eda18c7b0c108529bc73189c1504
Reviewed-on: https://gerrit.libreoffice.org/84099
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
The problem was that in case a table with 1 row and 2 cells has rotated
text in the A1 cell, then the row height is 0, so we aggressively try to
break up the text into multiple lines. Then the A2 cell adds more
content, so the row height is increased, but the A1 cell is not
re-layouted to make use of the increased amount of vertical space.
A similar (but working) situation is vertical alignment of cell content,
there adding more content to A2 re-formats A1.
Fix the problem in a similar way: track if a text frame contains at
least one rotated portion, and throw away the portions of the text frame
at the end of SwCellFrame::Format(), after vertical alignment is
handled.
Change-Id: I65383bb1af486771dc671dca3d8bbf1831ba94ff
Reviewed-on: https://gerrit.libreoffice.org/84433
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
...where the members of aRectangle passed into gtv_calc_header_bar_draw_text
(and unconditionally used there, see the definition further up in this file) are
only set for ROW and COLUMN types. Lets assume that no other types can happen
here? (This is part of libreofficekit/Executable_gtktiledviewer.mk, see
libreofficekit/README for how to execute it.)
Change-Id: I487be241e564127183751758710140ab24941f63
Reviewed-on: https://gerrit.libreoffice.org/84424
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
error: code will never be executed [-Werror,-Wunreachable-code]
In the 'old' (JNI-based) Android app case. If clang doesn't like 'if
(false)', then invert the #if condition so we don't need it.
Change-Id: I79818a51cb284519313738ab4272d109171dfcd0
Reviewed-on: https://gerrit.libreoffice.org/84431
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
...happening when LO code includes skia files:
> In file included from workdir/UnpackedTarball/icu/source/i18n/unicode/format.h:47,
> from workdir/UnpackedTarball/icu/source/i18n/unicode/numfmt.h:39,
> from i18nutil/source/utility/unicode.cxx:26:
> workdir/UnpackedTarball/icu/source/i18n/unicode/fieldpos.h: In copy constructor ‘icu_65::FieldPosition::FieldPosition(const icu_65::FieldPosition&)’:
> workdir/UnpackedTarball/icu/source/i18n/unicode/fieldpos.h:146:102: error: implicitly-declared ‘constexpr icu_65::UObject::UObject(const icu_65::UObject&)’ is deprecated [-Werror=deprecated-copy-dtor]
> 146 | : UObject(copy), fField(copy.fField), fBeginIndex(copy.fBeginIndex), fEndIndex(copy.fEndIndex) {}
> | ^
> In file included from workdir/UnpackedTarball/icu/source/common/unicode/bytestream.h:44,
> from workdir/UnpackedTarball/icu/source/common/unicode/locid.h:38,
> from include/i18nlangtag/languagetagicu.hxx:16,
> from i18nutil/source/utility/unicode.cxx:23:
> /data/sbergman/lo-gcc/core/workdir/UnpackedTarball/icu/source/common/unicode/uobject.h:230:13: note: because ‘icu_65::UObject’ has user-provided ‘virtual icu_65::UObject::~UObject()’
> 230 | virtual ~UObject();
> | ^
See e9e4eb0736 "Fix some
-Werror=deprecated-copy-dtor" for details about -Wdeprecated-copy-dtor.
Change-Id: I89b94047af30452dd4e316b33877dd0775a851aa
Reviewed-on: https://gerrit.libreoffice.org/84426
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
...happening when LO code includes skia files:
> vcl/skia/gdiimpl.cxx: In member function ‘void SkiaSalGraphicsImpl::createOffscreenSurface()’:
> vcl/skia/gdiimpl.cxx:246:83: error: implicitly-declared ‘sk_app::VulkanWindowContext::SharedGrContext& sk_app::VulkanWindowContext::SharedGrContext::operator=(const sk_app::VulkanWindowContext::SharedGrContext&)’ is deprecated [-Werror=deprecated-copy-dtor]
> 246 | mOffscreenGrContext = sk_app::VulkanWindowContext::getSharedGrContext();
> | ^
> In file included from vcl/inc/skia/gdiimpl.hxx:29,
> from vcl/skia/gdiimpl.cxx:20:
> workdir/UnpackedTarball/skia/tools/sk_app/VulkanWindowContext.h:35:9: note: because ‘sk_app::VulkanWindowContext::SharedGrContext’ has user-provided ‘sk_app::VulkanWindowContext::SharedGrContext::~SharedGrContext()’
> 35 | ~SharedGrContext() { shared.reset(); checkDestroyShared(); }
> | ^
See e9e4eb0736 "Fix some
-Werror=deprecated-copy-dtor" for details about -Wdeprecated-copy-dtor.
Change-Id: Ic393acff5c4d8e3eaa78b4dfed51626f73e95ed4
Reviewed-on: https://gerrit.libreoffice.org/84425
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
The Word 6.0 (Japanese) compatibility option
\dntblnsbdb switches off the balancing of SBCS/DBCS
characters, including the longer space sequences.
Note: using \dntblnsbdb, it will be possible to
set normal (short) space sequences in RTF export, too,
to avoid broken document layout during RTF round-trip.
Fix regression from commit 24b04db5a6
(tdf#123703 RTF import: fix length of space character sequence).
Change-Id: I5ade9e0a2db0bde204d1debe831058045fd8f586
Reviewed-on: https://gerrit.libreoffice.org/84397
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>
Switching the zoom is no longer necessary - we now have a known
and fixed zoom per view now (as the core has), that saves some
complexity.
Change-Id: I14c952ca1e06fae016faa8b6ee07115c56312ed6
Reviewed-on: https://gerrit.libreoffice.org/84372
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Doing faster lookups across the calc data structrures is far more
effective than complex caching of this kind.
Change-Id: I43d3ee948ae817ec1d196acc6e5603e6acf1970c
Reviewed-on: https://gerrit.libreoffice.org/84371
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Paste the copied Calc worksheet cell by cell in a
Writer table again instead of inserting it
as a nested table in the actual cell.
Regression from commit e9e6d4b058
(Make the RICHTEXT take precedence over EMBED_SOURCE).
Change-Id: I226c35f9f5ca3955b2ef498d1d0aeedfcec61987
Reviewed-on: https://gerrit.libreoffice.org/84389
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
