Commit graph

391367 commits

Author SHA1 Message Date
Stephan Bergmann
74a1b26ffb -Werror,-Wlogical-not-parentheses
Change-Id: I0ed6445964523b17ca5635d4d26cd429ff60c294
2016-05-02 08:21:56 +02:00
David Tardon
c4ed5807bd drop cruft
Change-Id: Ib3364e97407061ee7710cb87f1f33a2736ed9c0e
2016-05-02 06:54:30 +02:00
David Tardon
ee4f350906 use unique_ptr
Change-Id: I55ff9ae568a0d44c8ee8be922adf40e12038e436
2016-05-02 06:54:30 +02:00
David Tardon
a084962e8c fix typo
Change-Id: I841a9c12664950b2f1fe8cdf43e3d815f292eb3d
2016-05-02 06:54:30 +02:00
David Tardon
b876bbe2ca rbhz#1326602 avoid exp. bg bitmaps from deleted slides
ODF export uses SvxUnoBitmapTable (impl. of
com.sun.star.drawing.BitmapTable) to create fill bitmap styles. That
returns all XATTR_FILLBITMAP items that are in the document's pool. So
we ensure that bitmaps that are only used on deleted (either explicitly
or by undoing their insertion) slides are not in the pool.

Change-Id: I54c594a94989158f22b156fe660c1e716b988b3e
2016-05-02 06:54:30 +02:00
David Tardon
859c00663f add member prefix
Change-Id: Ic53e0c564176649b6cba84ea898c3c2f69fcad8c
2016-05-02 06:54:30 +02:00
David Tardon
10b818d4b6 use unique_ptr
Change-Id: I38d5c436985b0a68530be01c7482a68cf4e99018
2016-05-02 06:54:30 +02:00
David Tardon
ffacf4ba0f change brackets to match the rest of the file
Change-Id: Ib859d8a012522e4f07f503ded0ee80e725a24ab8
2016-05-02 06:54:30 +02:00
David Tardon
5db489719d use unique_ptr
Change-Id: I047a2436ce5603a8642aa621694560aca669b2f1
2016-05-02 06:54:30 +02:00
Takeshi Abe
07a641b110 Reduce scope of variables
Change-Id: I0018a6601f48f32736d10fd1eab58e926d97f91b
Reviewed-on: https://gerrit.libreoffice.org/24458
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-05-02 01:19:04 +00:00
Maxim Monastirsky
097bf754c0 tdf#99338 Fix GrabFocus during dispose crashes
Change-Id: I309e1e5f0d28c408c8a95190bf645abf680491b6
2016-05-02 00:22:46 +03:00
Jochen Nitschke
438f2db139 fix copy&paste error
since commit 4cab94239b

Change-Id: I8fbd55977bdf8531a66123948c0c4d23657713d4
Reviewed-on: https://gerrit.libreoffice.org/24558
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-05-01 21:20:56 +00:00
Nurhak ALTIN
a42169cdae tdf#99311 Detect SSDs in pagein
Avoid doing the pagein work if we can detect a non-rotational disk.

Change-Id: I1ce11050d7ed2a805568343cd385f2612d7c8939
Reviewed-on: https://gerrit.libreoffice.org/24560
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-05-01 15:47:33 +00:00
Armin Le Grand
75d9f7a433 Complete drawinglayer attributes
All DrawingLayer Atrributes used for ptimitives need a default
constructor. Since the o3tl::cow_wrapper is used in combination
with a static default incarnation of the impl class it is better
to define that. Also needed is a working isDefault() implementation
that compares the impl class to the static default. Added missing
stuff for this.

Change-Id: I98e9fee7343112cd979b972229423ac0ef3994a6
Reviewed-on: https://gerrit.libreoffice.org/24496
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-05-01 13:46:04 +00:00
Maxim Monastirsky
0975b5e4bd tdf#49853 Some shortcuts should always end up in the view
... because they are also used internally by vcl controls,
so we want let those controls handle them when they are
focused.

[VCL_NSApplication sendEvent] is more natural place for
this probably, but doing it there we'll lose the "blinking"
effect of the menu bar, even when the focus is in the
document area. So try harder, and handle it inside the menu
code. If this will create any trouble, we can always switch
to the simpler solution.

Change-Id: I827ab0585aabe1ed53fc31c5b8e1dddadef3361d
2016-05-01 16:16:50 +03:00
erdemdemirkapi
7fb97f25d1 rsc - remove obsolete FILE_LOCAL macros.
Change-Id: I92c19459646eaceffe87ef0f002c988595f221c5
Reviewed-on: https://gerrit.libreoffice.org/24549
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-05-01 13:16:00 +00:00
Mert Tumer
1bb8952350 tdf#99605 - add missing constructor methods.
Change-Id: I338f129c14902e2fb98e4b961ce64c61f8633b29
Reviewed-on: https://gerrit.libreoffice.org/24561
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-05-01 13:00:06 +00:00
Jochen Nitschke
a47ed7a765 loplugin:simplifybool in sw
Change-Id: I528f631165a618a70c3143c56273d8513b2cc5d2
Reviewed-on: https://gerrit.libreoffice.org/24554
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-05-01 12:45:02 +00:00
Julien Nabet
998adf0b8b Typo: OAddessBookSourcePilot->OAddressBookSourcePilot
Change-Id: I26587b761c91433fe80b9439e7e7c5e420db6192
Reviewed-on: https://gerrit.libreoffice.org/24552
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-05-01 12:29:41 +00:00
Rosemary Sebastian
87cccfbf7e Replace '||' with '&&'
so that the condition doesn't always evaluate to true

Change-Id: I66ba3d4c7985e1fad60f12836e44167f19216588
Reviewed-on: https://gerrit.libreoffice.org/24548
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-01 10:34:53 +00:00
erdemdemirkapi
3f8a2f6bfb tdf93563 volatile signal re-enterancy guards
Change-Id: Ic3e8b78d204145e94f7bc56aab60914f4f64f6e9
Reviewed-on: https://gerrit.libreoffice.org/24515
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-05-01 10:19:26 +00:00
Burcin Akalin
60fbe5099b tdf#95416 Get rid of #include "../foo/bar.hxx" style includes
Change-Id: If7b44c772744c63e603740be6267453118cfd01b
Signed-off-by: Burcin Akalin <brcnakalin@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/21937
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-05-01 10:18:20 +00:00
Mert Tumer
c6e8c96d50 tdf#99539 - fıx crash on android 5.1
Change-Id: I3d484f7d7d9e466ae1b2ac4afe2b59d060fa8b77
Reviewed-on: https://gerrit.libreoffice.org/24537
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-05-01 10:10:12 +00:00
tymyjan
3acbc64869 tdf#97499 Fixed containers parameters clearing #8
Change-Id: I82ca89ac483e9742be0d38a3c6882a240c7c38d8
Reviewed-on: https://gerrit.libreoffice.org/24499
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-01 10:09:11 +00:00
tymyjan
8e4ee4bc68 tdf#97499 Fixed containers parameters clearing #9
Change-Id: I097106e1887be283320fc518ddafda76608b46ee
Reviewed-on: https://gerrit.libreoffice.org/24521
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-01 10:07:19 +00:00
melikeyurtoglu
3962ae32d4 tdf#96890 The file "groupuinames.xml" is invalid XML
Change-Id: I623d5bbae5a016569f5c1f8174c22ee97db94467
Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/24539
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-01 10:04:14 +00:00
Andrea Gelmini
2bdb8da2dc Fix typos in code
Change-Id: I24f7b812fe625f3d91a49fb57701a36a8c68eb36
Reviewed-on: https://gerrit.libreoffice.org/24542
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-01 09:59:53 +00:00
Andrea Gelmini
75d965e5fc Fix typo in code
Change-Id: I670b016fb937fd4e87939afedd6d2047533812bf
Reviewed-on: https://gerrit.libreoffice.org/24531
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-01 09:57:14 +00:00
Andrea Gelmini
26851eccbd Fix typo in code
Change-Id: Ib674c32da1f9f4c1920c7286fa41b1297f8e1f8f
Reviewed-on: https://gerrit.libreoffice.org/24530
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-01 09:54:41 +00:00
Andrea Gelmini
0fa225fe5b Fix typo in code
Change-Id: Ia1ec84da61aa353d481ada98c41cbebaca623c0e
Reviewed-on: https://gerrit.libreoffice.org/24532
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-01 09:54:18 +00:00
Andrea Gelmini
931b6a1537 Fix typos in code
Change-Id: I408f630732a10567a3352e0c96f1289a1cf6ca81
Reviewed-on: https://gerrit.libreoffice.org/24534
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-01 09:53:04 +00:00
Andrea Gelmini
506c929a0a Fix typos
Change-Id: Ifb7c33d6052efe5ea8a1e0e10b3178073cd29ca0
Reviewed-on: https://gerrit.libreoffice.org/24536
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-01 09:51:41 +00:00
Andrea Gelmini
b0388ef109 Fix typo in code
Change-Id: Ib1daf257018d5a5da90773dd39086f18666fea9f
Reviewed-on: https://gerrit.libreoffice.org/24533
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-01 09:46:58 +00:00
Andrea Gelmini
d15163eceb Fix typos
Change-Id: Ideafa411b53fe4a5f2e6559be10c4cb82b58a256
Reviewed-on: https://gerrit.libreoffice.org/24543
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-01 09:46:27 +00:00
Markus Mohrhard
8465e99a27 add test for tdf#98990
Change-Id: I0789d250aa52994948c392c1e8f06c5546defc8f
Reviewed-on: https://gerrit.libreoffice.org/24546
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-01 09:44:37 +00:00
Jochen Nitschke
039b75d6cd follow-up for tinderbox fix
> vcl/opengl/texture.cxx:53:5:
> error: calling static member function through member call syntax,
> use 'TextureState::generate' instead [loplugin:staticcall]

Change-Id: Ie550549fb23b0199014ed41adcc2f3da8c4d1520
Reviewed-on: https://gerrit.libreoffice.org/24544
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-05-01 00:32:39 +00:00
Jochen Nitschke
75850b0af2 fix for tinderbox
>vcl/inc/opengl/TextureState.hxx:28:10:
> error: this method can be declared static TextureState::generate
> [loplugin:staticmethods]
>vcl/inc/opengl/RenderState.hxx:22:10:
> error: this method can be declared static GenericCapabilityState::readState
> [loplugin:staticmethods]
>vcl/inc/opengl/RenderState.hxx:24:17:
> error: implicit conversion (IntegralCast) from 'GLboolean'
> (aka 'unsigned char') to 'int'
> [loplugin:implicitboolconversion]

Change-Id: Iafcfe6c88b7e570d7c73a9e8920fdd7c6248ad7b
Reviewed-on: https://gerrit.libreoffice.org/24541
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-04-30 21:19:56 +00:00
Caolán McNamara
a2565e067b crashtesting: fix ooo123540-1.xlsx etc
Change-Id: I178c3e5818f4538bc306694115bc3d1cbe95513e
2016-04-30 21:16:43 +01:00
Armin Le Grand
a00a27f68e removed defaulted argument from function call
Change-Id: I09a48b1223e7a339b4760a8b719a927db2b418a3
2016-04-30 19:44:41 +02:00
Michael Meeks
81d2967bc7 tdf#99587 - make rsc work in tr_TR.UTF-8 locale.
toupper / tolower problematic with exciting Turkish 'i's, bug introduced:
|*    Ersterstellung    MM 13.02.91

Change-Id: Ifa5cfa7cf28cc3948b9206cda426eb1409dd7cc7
Reviewed-on: https://gerrit.libreoffice.org/24519
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-04-30 17:24:00 +00:00
Markus Mohrhard
9f363ee994 ignore missing children, tdf#99422
Change-Id: I2d4a7f03940045c34369876aea78c3eda81da78b
2016-04-30 18:28:51 +03:00
Jan-Marek Glogowski
320ae3dba8 Fix tdf#96515 unit test
This also makes the test font independent, as it just tests
the growth and shrink of the first page in "HideWhitespace" mode.

Change-Id: I65d6b7c761939679f72fa24c744f1df23f8ba321
Reviewed-on: https://gerrit.libreoffice.org/24520
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
Tested-by: Jan-Marek Glogowski <glogow@fbihome.de>
2016-04-30 15:18:25 +00:00
erdemdemirkapi
e070fa3eab tdf#96505 Get rid of cargo cult long integer literals
Change-Id: Idf21193d31b1e8ea73a5a0754f5cf3e5c030c061
Reviewed-on: https://gerrit.libreoffice.org/24516
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-30 15:09:59 +00:00
Andrea Gelmini
fc2590cfa1 Fix typos
Change-Id: Id81b16ff26283611f0b84929d831c827f847ab73
Reviewed-on: https://gerrit.libreoffice.org/24317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-30 15:06:45 +00:00
Feyza Yavuz
783b02de3b tdf#92768 Support hiding title objects
Change-Id: I34723ab353fbced5eb339fb0afbcb0677b3eadd4
Reviewed-on: https://gerrit.libreoffice.org/24517
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-30 13:04:06 +00:00
jan Iversen
b766c766c6 genlang, update to compile with VC 2015, and script cleanup
VC2015, detected a problem that VC2013 did not.

Change-Id: I4378ad5b2c831900460839aebe0a18bbc4bc062a
2016-04-30 12:34:50 +00:00
Tomaž Vajngerl
540fee2dc7 opengl: track the state of glViewport
We don't want to set the viewport over and over again.

Change-Id: I60b84a009d4058743e30587616604f9b6fc0f601
Reviewed-on: https://gerrit.libreoffice.org/24507
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-04-30 03:08:30 +00:00
Tomaž Vajngerl
a57d048f88 opengl: sync scissor and stencil state, generic capability state
Scissor and stencil test needed to be disabled in flush() (which
means every postDraw call) because sometimes the state became out
of sync with the current state. This commit adds sync() function
which synchronises the actual OpenGL state and adds debugging
mechanisms to warn when the state becomes out of sync (so we can
inspect the exact moment in apitrace).

Added a GenericCapabilityState for GL capabilities like
GL_SCISSORS_TEST, GL_STENCIL_TEST, GL_BLEND,... and refactored
existing ScissorState and StencilState to inherit from it.

Change-Id: Ifc159108a5ce850c78a89b1f5b8d12ecdd84f459
Reviewed-on: https://gerrit.libreoffice.org/24506
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-04-30 03:08:08 +00:00
Tomaž Vajngerl
b8f0e6452c opengl: track the state of stencil test
Change-Id: Id3e15e91316df740f04a42ed8c95b77d83240b5a
Reviewed-on: https://gerrit.libreoffice.org/24505
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-04-30 03:07:51 +00:00
Tomaž Vajngerl
51e953a357 opengl: track the state of scissor test and the dimensions
For performance reasons we shouldn't set glScissors if it is not
necessary so we remember to what dimensions we set the glScissor
and don't set it again if this is not necessary. The same goes for
enabling/disabling the GL_SCISSOR_TEST.

Change-Id: I5e1383081b4e76bdded04525c780d3a724f9db5c
Reviewed-on: https://gerrit.libreoffice.org/24504
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-04-30 03:07:25 +00:00