assert was introduced in
commit e1972743d6
Author: Noel Grandin <noelgrandin@gmail.com>
Date: Sun Sep 5 15:01:44 2021 +0200
be more disciplined with SetUpdateLayout on editengine
We want to restore UpdateLayout when we're done doing layout, we should
not just leave it FALSE
Change-Id: Ic0431ffc3c66d0d02bfd10c323b18383f52dbc95
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132209
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Revert "tdf#132740 bypass work if selection has not changed"
This reverts commit 865641047b.
Change-Id: I69244a1e57ce979bf21946e31df7165f8791423c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135302
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Apparently some selections provide only XTransferable and not
XTransferable2, making this entire call think that there's no
selection at all. Handle that properly, and if XTransferable2
is not provided, then presumably it's not important to check
for isComplex().
Change-Id: I3bbafe46a6b9ac8552c62e524137e1691b54895a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135300
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
when we are passing the result to a string_view, it is pointless.
Change-Id: I1e11d2610d70ed49c0b00d0c908829e8f1252bab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135298
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Allows to send individual images over the wire in lok case,
instead of sending full canvas at every scroll operation.
The control's horizontal and vertical modes (when it's docked to a
vertical or a horizontal parent window side) are now identical.
Some TODOs:
* Re-implement a11y - that needs to be implemented on IconView level;
* Make sure that sub-pixel positioning is not used when creating the
elements icons (makes elements look a bit slim on Windows);
* Maybe restore mouse hover indication; in non-GTK case, a call to
m_xIconView->SetHoverSelection would suffice in SalInstanceIconView.
Change-Id: Idbc35f4e38e2b49fd0848a96da557fa2c1a1f6e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134761
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
...presumably added back in the day to avoid warnings about signed vs. unsigned
comparisons with old compiler versions
Change-Id: Id95e272949e48adf0e75883368cbcd421e289b33
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135292
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
found with the help of a temporary loplugin (which i have put into the
store/ folder)
Change-Id: Ide40d09bef6993ace50039a8fd0439b7e29c09a6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135288
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
which is what the old one did, so do that here as well, libtiff will
leave the stream some other pos by default, presumably the directory.
which explains the testTdf138818 mystery
Change-Id: I574700f81a21ee164d9911e05e2023aa48d10370
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135279
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Add hyphenation zone support, i.e. allow the specified
amount of extra space in lines instead of forcing hyphenation.
It's for limiting hyphenation, used especially with
not justified paragraph alignment.
Note: this is an OOXML interoperability feature,
used also in DTP software and CSS.
* Add checkbox to Text Flow in paragraph dialog
* Store property in paragraph model (com::sun:⭐:style::ParagraphProperties::ParaHyphenationZone)
* Add ODF import/export
* Add ODF unit test
* Add layout test
Note: extend SvxHyphenZoneItem::GetPresentation() with
missing No CAPS and No last word hyphenation options.
Note: fix OSL_ENSURE condition in SwTextFormatInfo::GetHyphValues().
Follow-up to commit 29359fc15c
"tdf#149324 sw offapi xmloff: add option to not hyphenate short words".
Change-Id: Ib8eff6ea98a9aa5ca6cb9d17faa0bbb789687ce9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135247
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
- add a new m_xCheckboxFrame to SwContentControlDlg that contains all
the checkbox-related widgets
- hide this frame for non-checkbox content controls
- load the checked & unchecked states into entries to show their current
value
- provide buttons to easily pick special characters using SvxCharacterMap
Change-Id: I8f2ad862d1102bac0198360d40cfe8b653ce4ccd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135286
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
I.e. the layout side of images is not a fly frame, but a no-text frame,
with a fly frame parent.
Change-Id: If76029d02ea2cd583effb31230f5e2d9edc9f237
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135275
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
..so use o3tl::make_unsigned when comparing them against an expression of
unsigned integer type, instead of casting that expression to a signed type
Change-Id: I4fc0bd4447f55d5fd9bf893a4b22d6d2c2cfe3d7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135280
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Update helpcontent2 from branch 'master'
to 36303145afbcf57edf4a45129bd5a8b222dfec74
- Base form properties Sort dialog name is case sensitive
Selecting Base form properties data Tab Sort dialog help button caused 'page not found'
Change-Id: If91a478964304893527ac8c03d417dcee445a4ee
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134072
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
So the result will actually display as full matrix, or in the cell
range marked prior to input, instead of just the top left element
in one cell, without having to close the input with
Shift+Ctrl+Enter to force array mode. The previous behaviour can
be forced by pre-selecting/marking one cell, which also worked
previously when closing as array input.
Change-Id: I81c079ce02e0c8d0536617ca6882fb470a352441
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135278
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
* Update helpcontent2 from branch 'master'
to 6cad3f7596e2296adda304ab1c613a429bb6ae93
- tdf#129674 New command Go to Sheet
Add help to "Go to Sheet" dialog
Change-Id: Iede0523d0272b32b9b87489129bca0136d601a65
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134951
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
add #include <optional>, since:
[build CXX] comphelper/source/property/ChainablePropertySetInfo.cxx
/home/rene/LibreOffice/git/master/comphelper/source/property/ChainablePropertySet.cxx: In member function 'virtual void comphelper::ChainablePropertySet::setPropertyValue(const rtl::OUString&, const com::sun:⭐:uno::Any&)':
/home/rene/LibreOffice/git/master/comphelper/source/property/ChainablePropertySet.cxx:54:10: error: 'optional' is not a member of 'std'
54 | std::optional< osl::Guard< comphelper::SolarMutex > > xMutexGuard;
| ^~~~~~~~
/home/rene/LibreOffice/git/master/comphelper/source/property/ChainablePropertySet.cxx:23:1: note: 'std::optional' is defined in header '<optional>'; did you forget to '#include <optional>'?
22 | #include <comphelper/solarmutex.hxx>
+++ |+#include <optional>
23 |
happens since 49b9401465
Change-Id: I643e7811f1ec7588ccde5453303cd57675c6165e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135252
Tested-by: Jenkins
Tested-by: René Engelhard <rene@debian.org>
Reviewed-by: René Engelhard <rene@debian.org>
The zlib module should be used instead of NSS' bundled zlib since
commit 1c748fefc3
Change-Id: I0d820cdd795712a7dbe27ef114f0efddd3f436ef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135235
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
it's a very small object, and trivially movable. No need to allocate it
separately
Change-Id: I0adf947433e73a425f39004297c450a93ac4e5f7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135216
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
(This was there ever since the beginning in
85c2477a94 "INTEGRATION: CWS bunoexttm", while for
the similar OuterThread it was always absent.)
Change-Id: I3c43f0e35435b6035f6a1f2a1ca9f104bd639689
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135240
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Needed to eventual re-implementation of starmath's SmElementsControl
using IconView.
This required re-implementation of IconViewImpl, to layout entries
by iteration, because now it's impossible to find an entry position
just based on its index.
This coincidentally fixed some visual glitches in non-gtk IconView
implementation from commit 5813660e7b
Author Szymon Kłos <eszkadev@gmail.com>
Date Tue Feb 16 16:03:30 2016 +0100
icon view for RemoteFilesDialog
where any selected element could become first in row when scrolling.
SvTreeListBox::SetEntryHeight taking a SvTreeListEntry const* had to
be renamed to CalcEntryHeight, to avoid both virtual and non-virtual
overloads, additionally having different accessibility.
A TODO is implement separators in GtkInstanceIconView. I couldn't
find a GTK API for separators in IconView, so possibly a workaround
would be needed with some non-selectable narrow elements.
Change-Id: Ie8dc35d94049a1c48e4eb49697681ffbe93c17f4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135112
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
The parent may contain other controls (e.g. Fontworks dialog's grid
contains also a label above the icon view). The control already has
the correct size; just use it.
Fixes vertical scrollbar being partially hidden behind control's
bottom in non-GTK Fontworks dialog.
Change-Id: I424999777f24bbb28619d07a9de782057f0257a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135003
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
with this writer in calc ole case
Change-Id: I1ecd7725703674cc1bcfc9b3d411ec890bfe4bcc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135237
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
toplevel isn't a SwDocShell at this point, its a ScDocShell
Change-Id: I3aa3c72e494cf6c0ceff1286a7026ca01385ab8e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135236
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
...so use o3tl::make_unsigned when comparing it against an expression of
unsigned integer type, instead of casting that expression to a signed type
Change-Id: Id2bea3010bf67bdaeb0766b20baecba195bf0181
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135227
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
