And fix the warnings discovered in Visual Studio 2022:
C:/lo/core/cli_ure/source/uno_bridge/cli_proxy.cxx(714): warning C4456: declaration of 'numMethods' hides previous local declaration
C:/lo/core/cli_ure/source/uno_bridge/cli_proxy.cxx(681): note: see declaration of 'numMethods'
C:/lo/core/cli_ure/source/uno_bridge/cli_proxy.cxx(1032): warning C4457: declaration of 'pUnoI' hides function parameter
C:/lo/core/cli_ure/source/uno_bridge/cli_proxy.cxx(918): note: see declaration of 'pUnoI'
C:/lo/core/cli_ure/source/uno_bridge/cli_uno.cxx(109): warning C4456: declaration of 'param' hides previous local declaration
C:/lo/core/cli_ure/source/uno_bridge/cli_uno.cxx(84): note: see declaration of 'param'
C:/lo/core/cli_ure/source/uno_bridge/cli_uno.cxx(256): warning C4456: declaration of 'param' hides previous local declaration
C:/lo/core/cli_ure/source/uno_bridge/cli_uno.cxx(240): note: see declaration of 'param'
Change-Id: I99abcf17c7c431a403a488c53b65ef34d66d0940
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169782
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
Set Common::Misc::ShowDonation to false in order to get the
legacy Extensions button
Icon by Muhammad Haq on freeicons.io (slightly modified)
Change-Id: I83d10d7230722d38914934d59d70ece471e62599
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169628
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
...which were lost with de1b926fa2.
rMessageColor is put back into the switch, but uses the settings' warning
and error colours introduced by d7fd378b53
where applicable.
Colours were checked for sufficient contrast in
https://gerrit.libreoffice.org/c/core/+/47825
Change-Id: Iba42020b665e35c34f09b3788bcc973b0f8531d1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168761
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
otherwise we get the weird behaviour where two SvxTabStop instances
which are constructed the same, return false from operator==
because one instance has had getDecimal() called on it, and the
other not.
Change-Id: I1f708c1b1e03efcd9fc554eaf2777c4c3e8a80b8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169774
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
because they are unused and incorrect. They are incorrect because
hashCode and operator== are not mutually consistent, as I found
out when I tried to use them.
They were introduced in
commit c39e4f6b8a
Author: Oliver Specht <oliver.specht@cib.de>
Date: Wed May 22 12:26:46 2024 +0200
Add SfxItemType to SfxPoolItem
but were not used in that commit.
Change-Id: I1c3c67e904823117401a0f72a49c80f4bb6398a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169773
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
For the gtk4 VCL plugin, require GTK version >= 4.10
and drop code for older versions.
This simplifies maintenance, in particular since
requiring 4.10 ensures that the basic GtkAccessible API
is available.
GTK 4.10 was released on 2023-03-04 [1], so it
will be almost 2 years by the time that LO 25.2
will be released.
Given that the gtk4 VCL plugin is still experimental,
providing support for older GTK 4 releases shouldn't
have to be a concern.
[1] https://gitlab.gnome.org/GNOME/gtk/-/blob/4.10.0/NEWS?ref_type=tags
Change-Id: I6f361b533391225d0e74c174e0479b767b9d827a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169324
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
This allows the IDE to show active #ifdef conditions, type sizes,
alignment, memory layout, selected overloads, and so on.
Change-Id: Idd1211df3b3745658f1996a494929b07cf7aa573
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169772
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
And simplify its ctor, using default member initializers.
Change-Id: I08f06182c51d38299956cdf7ad2705c926c937d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169770
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
This optimizes its layout a bit, deduplicates, and exposes less guts
Change-Id: If522747fdc2c666ac7876b39e72cc689f3c5c89f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169767
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
Light gray underline visualization depended on IsShowHiddenChar()
instead of the correct IsViewMetaChar() (Show Formatting Marks).
Follow-up to commit 2f0c7d5691
"tdf#161563 tdf#161565 sw: add No Break to word context menu &
visualize" and commit 41916d9fb0
"tdf#161563 sw: show "No Break" context menu only on a whole word".
Change-Id: I3d10011962732ab3730e5f833e95252e9fe6bfee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169721
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
Change-Id: I1595c3ddcca08e4e95da608edbe18edc57b41362
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166457
Tested-by: Jenkins
Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
Introduced in commit f3234f4f14 (VBA
Add Padding properties to XTable, 2022-08-05). The unit test is
edited to test that the value returned by the methods is equal to
the initially set value, with precision of 0.1 pt.
Change-Id: I24144cd0e3c1e72bd2664a2a052ac3c7006595ff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169762
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
Make their names more explicit. This avoids ambiguity; previously,
convertTwipToMM100 was very similar to tools' convertTwipToMm100,
provoking the former function's use where the latter is better.
Drop convertTwipToMM100WithoutLimit, and use the unconstrained
function from tools directly instead.
Change-Id: Icdd1a67721cdd8a578bc786fda67c341b07ec84a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169759
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
in order to behave like cut
Change-Id: Ia30428edee00950e2874c0f615e4033167c1031b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169754
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Tested-by: Jenkins
For some reason, MSVC fails to find the o3tl::convert overload for Size
defined in <tools/gen.hxx>, unless the call to convert is unqualified,
accompanied by a 'using namespace o3tl' in convertTwipToMm100.
Change-Id: I7100ef55156b6944b5adc5aefa52eee38b3fe69e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169751
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
Use doubles instead of fractions.
Simplify correctWordWrapPolygon, which used redundant arithmetics
(it scaled by a fraction with nWrap100Percent in multiplier, then
by another fraction with nWrap100Percent in divisor).
Change-Id: I69a38ac7e3afda33a1e7725cab711d50dc80eed7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169746
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
This reverts commit ae56dc05b2
"tdf#96787: AutoCorrect: after deleting a replacement entry, it's still used".
Change-Id: Ifb4cf1b359b852c7610337d4bd389a8ca5dce610
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169713
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
Use std::copy / std::reverse_copy for double serialization. Also
remove __cplusplus conditions, because the header is not included
in any C files. And simplify the functions uses, where casts were
unneeded.
Change-Id: I1d8375e601851231fdffcf52e3f3e3bdcbcbde7f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169706
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
While writting a test for 7f593484a1
"tdf#158051 AutoCorrect: don't apply final sigma before apostrophe"
I realized the added rules where *σ’ -> ς’ ( which was the old behavior
)
instead of *σ’ -> σ’
Change-Id: Ibff92e74da3d353ba715025b244b614b7fb8f9fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169717
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: Jenkins
