Commit graph

476006 commits

Author SHA1 Message Date
Stephan Bergmann
7d8d65d850 The return value of XConnection::read is guaranteed to be non-negative
...so use o3tl::make_unsigned when comparing it against an expression of
unsigned integer type, instead of casting that expression to a signed type

Change-Id: Id2bea3010bf67bdaeb0766b20baecba195bf0181
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135227
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-06-01 16:02:19 +02:00
Michael Stahl
9b453e699f nss: upgrade to release 3.79
Fixes CVE-2022-1097 and moz#1767590 "memory safety violations"

Change-Id: I6895f066ad943402231b616dae0d7ed6f5678b5e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135234
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-06-01 15:38:14 +02:00
Mike Kaganski
7e1108f6ec Fix domain
Change-Id: I0391fb3d4b913967ed4f8459d6b30f7f39bf4b40
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135055
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-06-01 14:51:10 +02:00
Stephan Bergmann
c58a51e5f1 Fix comment
For one, the functions are already available in C++20.  For another, our
fallback implementation is only an approximation, as it doesn't enforce the
requirement that the involved template types "are standard integer types or
extended integer types" (but which is at least checked in --with-latest-c++
builds against standard libraries that already provide those C++20 functions).

Change-Id: I91208c185f2db681cf25899d3cd9a9e2912d32a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135232
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-06-01 14:48:39 +02:00
Christian Lohmaier
6c3e1ec7d2 update credits
Change-Id: I159625c29c07188e991ad55de291594f31715f02
2022-06-01 14:23:58 +02:00
Xisco Fauli
89b0d94850 sw: fix crash in SwDoc::CopyMasterHeader and SwDoc::CopyMasterFooter
Similar to 3eda5d345f
"tdf#149184 DOCX: fix crash removing footer, then saving to doc"
check that GetHeaderFormat and GetFooterFormat are not nullptr
Also restructure the code a bit to reduce the scope of pRight

See https://crashreport.libreoffice.org/stats/signature/SwDoc::CopyMasterHeader(SwPageDesc%20const%20&,SwFormatHeader%20const%20&,SwPageDesc%20&,bool,bool)
and
https://crashreport.libreoffice.org/stats/signature/SwDoc::CopyMasterFooter(SwPageDesc%20const%20&,SwFormatFooter%20const%20&,SwPageDesc%20&,bool,bool)

Change-Id: Ia30d06593124d90b88f7d26ed7be9a5d7a64872c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135230
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2022-06-01 14:18:47 +02:00
Noel Grandin
fea45cc200 clang-tidy modernize-pass-by-value in uui
Change-Id: I55f55554e325ae67a7b9fa36ee12b14804fe446b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135217
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-01 14:18:05 +02:00
Noel Grandin
2928873798 clang-tidy modernize-pass-by-value in fpicker
Change-Id: I9940338307241958e478ec6919068454d3a07b9c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135218
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-01 14:17:45 +02:00
Stephan Bergmann
acb65a60be Use more appropriate index variable types
Change-Id: Ic2cf5512cabcda0ad476c43bcbc544d0d6dd2685
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135231
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-06-01 14:15:58 +02:00
Xisco Fauli
aeeb0141ac sw: avoid another EXCEPTION_INT_DIVIDE_BY_ZERO
See https://crashreport.libreoffice.org/stats/signature/lcl_ModifyBoxes

Change-Id: I786bbf87734dd3963bd84caecc5c5f45693d42c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135185
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-06-01 14:11:10 +02:00
Xisco Fauli
ea4cd39730 sw: avoid EXCEPTION_INT_DIVIDE_BY_ZERO
See https://crashreport.libreoffice.org/stats/signature/SwFormatCol::Calc(unsigned%20short,unsigned%20short)

Change-Id: I79321737b7bed3acff3418d0b51dc6225baaf57f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135184
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-06-01 13:53:35 +02:00
Miklos Vajna
2de53e222f CppunitTest_sw_tiledrendering: use CPPUNIT_TEST_FIXTURE()
Which changes the order of the tests in the suite, so testRedlineColors
runs later and the global list of redline authors now contains
unexpected entries, leading to an assertion failure.

Fix this by clearing the redline author list at the start of each test.

Change-Id: Ifffe079eb83cd3184c962ea2e69505bd518a52bf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135229
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2022-06-01 13:27:21 +02:00
Stephan Bergmann
af1147f4a6 Use less noisy way to iterate over some (unscoped) enumeration
Change-Id: I37ed9b3dd607367d2e42fcc163c423dc416cc7c6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135224
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-06-01 11:54:32 +02:00
Seth Chaiklin
5ea5151467 tdf#149010 add and improve tooltips to "Previous Link" and "Next Link"
Change-Id: I357eb0dd45c0008ad56a541ad40b1bf3b0f77953
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135071
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2022-06-01 11:52:32 +02:00
Stephan Bergmann
e89e3a8b5a The return value of those getLength functions is guaranteed to be non-negative
...so use o3tl::make_unsigned when comparing it against an expression of
unsigned integer type, instead of casting that expression to a signed type

Change-Id: Ic47c6d96919b2aba2d16ce6d1a2a8e4c5761a480
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135219
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-06-01 10:49:20 +02:00
Stephan Bergmann
6dbccf3d93 Clean up some loop a bit
Change-Id: I96b760b7bd220b799f4843c5d5e07385a9a995d2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135215
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-06-01 09:54:55 +02:00
Miklos Vajna
9cb1a07dc2 sw content controls, date: add LOK API
- send a LOK_CALLBACK_CONTENT_CONTROL with date=true when entering a
  date content control

- extend lok::Document::sendContentControlEvent() to be able to set the
  date of a date content control (after the client's date picker is
  closed)

- update gtktiledviewer to work with these

Change-Id: I0abf21eb1d4ba233050f0aa2607b68740c048262
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135214
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2022-06-01 09:09:40 +02:00
Xisco Fauli
64f8a70298 sw: fix crash in SwAnchoredObject::UpdateObjInSortedList
See https://crashreport.libreoffice.org/stats/signature/SwAnchoredObject::UpdateObjInSortedList()

Just a few lines above (line 636) the same checks are used inside
the DocumentSettingId::CONSIDER_WRAP_ON_OBJECT_POSITION condition
so I don't understand why they weren't added here as well
Change-Id: Id8ade0a506d5996d9e357d45c20fe56a68a93eec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135188
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-06-01 09:06:53 +02:00
Miklos Vajna
de6cd24c4c CppunitTest_sw_ooxmlexport13: avoid mustTestImportOf()
Can use CPPUNIT_TEST_FIXTURE() instead.

See commit a226cec52e
(CppunitTest_sw_rtfimport: convert one testcase to use
CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.

Change-Id: Ifd4a73bc9f8272ff3f6abdb8d983f9617eb1a959
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135201
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-06-01 08:26:33 +02:00
Seth Chaiklin
f2d2334b03 tdf#121367 (related: tdf#120550) consistent labeling between modules
There is a slight difference in the label used by Writer 
  and the label used by Draw/Impress to refer to:  
  .uno:SetMinimalRowHeight and  uno:SetMinimalColumnWidth.
  This patch changes the label in Writer so that it uses the
  same label as Draw/Impress.

Change-Id: I0469b32350bf9a57903b03929675d3b7e8abe287
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135005
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Tested-by: Jenkins
2022-06-01 02:50:23 +02:00
Seth Chaiklin
5423dfb854 tdf#148736 improve labels for Arrow style popup dialogs
Change-Id: Ifc43650a3008cbd96cac8f994675e680368a215b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133287
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2022-06-01 01:16:28 +02:00
Seth Chaiklin
c2670f4525 Update git submodules
* Update helpcontent2 from branch 'master'
  to b30109758ad6b6bcb8b82d6a646fc055cd3a2402
  - refactor some embedvars that give a translation problem for some
    
    Change-Id: Ibb67c7dd61fe55892232bebc2280fb3faed0db37
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135168
    Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
    Tested-by: Jenkins
2022-06-01 00:29:49 +02:00
Jan-Marek Glogowski
cd2ea94969 Qt just resize the backing store on size change
... and if there is no need to create a Cairo surface if it
doesn't exists, there is no need for a fresh QImage either.

Change-Id: If607e03d246f3c31d66953b1e07a7af55659e64b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135209
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-06-01 00:16:32 +02:00
Eike Rathke
c30306ad19 MoveCursorAbs: it is cheaper to check for marks first and then formula mode
... so repeated travelling with cell cursor will be less affected.

Change-Id: I3f42356e66b2ec8acf60c0e0c777f8c34b9a952a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135211
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
2022-06-01 00:08:25 +02:00
Jan-Marek Glogowski
483f3125ec WIN drop effectively empty ImplDrawMenuBar
.. as VisibleMenuBar() just always returns false.

Change-Id: Ie793d84d57970cbf08b81b6ec0350b9b5fd4192c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135210
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-05-31 22:45:40 +02:00
Stephan Bergmann
bd279d3002 Use more appropriate index variable type
Change-Id: I0a6de93876d316a1aa094cf98dc2ee5c7eddebbf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135205
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-31 22:42:34 +02:00
Stephan Bergmann
d1cdf9a24d Also assert that nNodeType is non-negative
...given that nNodeType aka AnimationNode::mnNodeType is later used as an index
into the AnimationNode::mpTypes array

Change-Id: Ic208fbdfaa8dcca44ff2a99cf3b169904b14a4bf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135203
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-31 22:42:14 +02:00
Eike Rathke
93a3f142bf MoveCursorAbs: do not reset selection marks while editing a formula
i.e. when moving the cursor for reference selection, so an
existing mark is preserved for Alt+Enter or Shift+Ctrl+Enter.

Change-Id: I3a73145b4e3e299fa9eb28e2198338e76ffe5093
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135202
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
2022-05-31 22:40:23 +02:00
Szymon Kłos
09847cdbd4 jsdialog: introduce popup management
Popup windows are managed by vcl (some moving between parents
happens on show/hide popup).

We need to access correct popup window to correctly close
popup in LOK. So remember popup instances.

Change-Id: I9e1ba18ded5a1bf675f95bd7178043eebd9bbd5a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134576
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134675
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135197
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-05-31 22:09:42 +02:00
Stephan Bergmann
b19a2dfafa Use more appropriate type for SbiImage::nStringIdx
Change-Id: I1448739b373c6f7b9f5e6ee5a725fa0a129a4fb4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135204
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-31 22:03:42 +02:00
Stephan Bergmann
4c60697daa The return value of std::count_if is guaranteed to be non-negative
...so use o3tl::make_unsigned when comparing it against an expression of
unsigned integer type, instead of casting that expression to a signed type

Change-Id: I487fd04eafbf8c56b8b6bfce579b477d8f34a052
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135206
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-31 22:03:22 +02:00
Noel Grandin
a77b8b75f0 elide temporary vector in TextDecoratedPortionPrimitive2D
Change-Id: Ie3945d3a2e133d3ce527844f9c0d61a6541175e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135200
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-31 21:18:18 +02:00
Stephan Bergmann
e1bac51546 clang-cl wants VCL_DLLPUBLIC SalLayoutGlyphsCache::clear not to be inline
...to avoid

> [build DEP] LNK:CppunitTest/test_vcl_text.dll.d
> complextext.o : error LNK2019: unresolved external symbol "public: unsigned __int64 __cdecl SalLayoutGlyphsCache::GlyphsCost::operator()(class SalLayoutGlyphs const &)const " (??RGlyphsCost@SalLayoutGlyphsCache@@QEBA_KAEBVSalLayoutGlyphs@@@Z) referenced in function "private: void __cdecl o3tl::lru_map<struct SalLayoutGlyphsCache::CachedGlyphsKey,class SalLayoutGlyphs,struct SalLayoutGlyphsCache::CachedGlyphsHash,struct std::equal_to<struct SalLayoutGlyphsCache::CachedGlyphsKey>,struct SalLayoutGlyphsCache::GlyphsCost>::removeSize(class SalLayoutGlyphs const &)" (?removeSize@?$lru_map@UCachedGlyphsKey@SalLayoutGlyphsCache@@VSalLayoutGlyphs@@UCachedGlyphsHash@2@U?$equal_to@UCachedGlyphsKey@SalLayoutGlyphsCache@@@std@@UGlyphsCost@2@@o3tl@@AEAAXAEBVSalLayoutGlyphs@@@Z)

(Not sure why MSVC itself doesn't complain; maybe LLVM 15 trunk clang-cl
accidentally diverges from the MSVC semantics here.)

Change-Id: I910fc309f9e02ec0794e449b97ba111d33dcbb54
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135199
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-31 20:32:37 +02:00
Szymon Kłos
81df11b1e5 lok: don't render active textbox on all slides
when we render tiles for slide previews we use
viewid = 0 (first session)

so when first session edits any textbox and in other
session we request slide previews (eg. after new slide was added)
then we received tile with additional text from the first session

this is caused by:
    commit bee4ff508a
    desktop lok: avoid unnecessary setPart() in paintPartTile()

    If possible, switch views, not parts, that way started Impress text
    edits don't end as a side-effect.

but later there was a fix which doesn't trigger closing of texbox
editing when switching parts:

    commit ce7bf35197
    impress: don't exit textbox editing when new slide was added

so we don't need that in all cases...
to fix issue described above: still switch views instead of parts
when possible - but avoid views where editing is active

Change-Id: Ib6e66a85b9ca68d6e67e3d9cb17060aa42b85220
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133202
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133650
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135196
Tested-by: Jenkins
2022-05-31 19:18:04 +02:00
Stephan Bergmann
3a06db0af0 Use a range-based for loop
Change-Id: Id3c358e0a7f11a4a203b1acbd42b9b09c7f7a2fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135193
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-31 19:14:49 +02:00
Stephan Bergmann
66500b5041 Use some range-based for loops
Change-Id: I4935bf51c6c7e9be1e3f069c6c72e618eaa0b4a9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135189
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-31 19:08:24 +02:00
Stephan Bergmann
52da30cd18 Drop unnecessary cast to int
...when iterating over the enumerators of enum Image_XML_Entry

Change-Id: Ic59da7543a41f8b498d6f89e48faafcdf40c6873
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135194
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-31 19:07:51 +02:00
Stephan Bergmann
5dd2ef5c78 Use a range-based for loop
Change-Id: I52bfe8ec1e7ca55964f2ed3aadcc709dba3662c0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135192
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-31 18:52:21 +02:00
Stephan Bergmann
6573ade5cf Use some range-based for loops
Change-Id: I26ad6ff194742b69cb6048c48fa01de7715865ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135191
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-31 18:51:58 +02:00
Stephan Bergmann
12348430e0 Use a range-based for loop
Change-Id: I50742cd64c63d6c81599ebda3ff2c093e722c91a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135190
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-31 18:51:39 +02:00
Stephan Bergmann
259a1ebd87 Rework UUIInteractionHelper construction
...to remove the need to construct a fresh m_pImpl in
UUIInteractionHandler::initialize

Change-Id: Ia3f1b89903448f74242a5fec3dcf87c2b1f5e764
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135187
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-31 18:51:06 +02:00
Armin Le Grand (Allotropia)
391cb44d41 Advanced Diagram support: UI visualization & simple interactions
Added visualization to show an imminently recognizable additional
visualization for DynamicDiagrams that can also be used to
show/hide the DiagramDialog by the user. It is also used as
additional drag/move handle for the object.

Change-Id: I56292cebe7c7a6f79be920c17edafdd7e453b6eb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135183
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-05-31 18:39:24 +02:00
Stephan Bergmann
c593567b68 UUIInteractionRequestStringResolver::m_pImpl can be a plain data member
Change-Id: I1daed58cec87d192118f027ce1843e56b17da19b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135186
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-31 17:04:47 +02:00
Luboš Luňák
e4842a4c52 lok: add more efficient getSelectionType() replacement
The getSelectionType() function usually needs to be followed by a call
to getTextSelection(), which means having them as two functions
leads to duplicating to a number of calls, some of which may be
somewhat expensive (pDoc->getSelection() e.g. for Calc builds
another ScDocument for the selection, and then getFromTransferrable()
converts that to the given format).

Change-Id: Ib0a8844701d80eaaff4834dcd3633c09d6b921b1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134603
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-05-31 17:03:02 +02:00
Caolán McNamara
f90239263f tdf#117006 gtk: detect High Contrast
similar to https://bugzilla.mozilla.org/show_bug.cgi?id=1606038

.e.g. gnome a11y menu, pick "High Contrast"

Change-Id: I60643b3a37b722230d5ed47082e4a6491d005ce4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135179
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-31 16:04:39 +02:00
Michael Stahl
225d8f31ad curl: remove curl-7.26.0_win-proxy.patch
There is no justification why this patch was added, upstream doesn't
want to add such a feature[1], and maintaining feature patches in LO
for bundled externals doesn't make sense.

Also, this doesn't respect the Inet::Settings::ooInetHTTPProxy*
settings from the configuration.

Let's remove it and hope nobody complains.

[1] https://curl.se/mail/lib-2022-05/0083.html

Change-Id: I1ccdefb76f69e6795a28d4d25bf443555c16ab0b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135182
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-05-31 15:59:28 +02:00
Xisco Fauli
c5ca8b5bff crashreportScraper: use timeout in requests
Change-Id: I03f8740fc124c11d250368034bf6e14239df5abe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135180
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-05-31 15:43:36 +02:00
Noel Grandin
5ecdedbf81 clang-tidy modernize-pass-by-value in basic
Change-Id: I9034ab95a4ccb58e36e77d911dd33cc50857c03a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135176
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-31 15:11:27 +02:00
Noel Grandin
af44198d80 these can be stack allocated
Change-Id: Idd2e5e49ba4fcef2e80fd9c569f374a6a69f380e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135175
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-31 14:55:23 +02:00
Stephan Bergmann
6f26b6aeca Use more appropriate type for comphelper::internal::OPropertyAccessor::nPos
Change-Id: Ia7055dcc3832002fd10ae23a35fd08df5a98ae40
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135177
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-31 14:53:25 +02:00