Makes expand and collapse all work from the outline context menu and
ctrl+* short cut for all vcl plugins
Change-Id: I6cec6f1b4dedfc62216028b24d09d7f402a387cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90973
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
settings after file opening, if its value is true in the opened
ODF or OOXML document, instead of always showing disabled state.
Testing notes: double click on a data label during chart editing
to see the Data Labels for Data Series... window. On the page
"Data Labels...", click on the Number format... button to see
the checkbox "Source format".
Change-Id: Idb837d9492ad7e83b9020167c47ed52499c070a7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90079
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
GtkToggleToolButton are much wider than vcl equivalents. Split the bottom
toolbar into two toolbars. Rearrange their contents so the layout of each level
visually match.
Notes:
Master documents have two modes, master content tree and the normal content
tree.
You can drag entries from the content tree into the document, drag mode drop
down controls whether its a link or a copy etc that's dropped in.
Documents can be dropped into the content and global trees.
If outline tracking isn't active, then when content changes the tree is cleared
and refilled, typically an effort is made to reselect the same entry that was
previously selected. Additionally, if the amount of content didn't change an
effort is made to scroll back to the location the scrollbar was at before the
clear.
Change-Id: I00c015145eac5b1acc3398d3c40861d830e4264a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89725
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Change italic in Spanish to K from C
Change-Id: Ie82625f8a605de67c036a76ce438de1e883203f0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90966
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
There is not need to ever change the kind of device a view is for, so
why bother with the bool parameter to setMobilePhone() and
setTablet(). Also, make sure just either of them is called, at most
once, for a view.
Change-Id: I9ac872f0ab4772e4a7c40c49f62b32fa7b1e47f6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90968
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
In order to load numeric values, generate SbiOpcode::NUMBER_ opcodes
including the numeric value and its data type instead of SbiOpcode::CONST_.
The numeric value and its data type will be restored in
SbiRuntime::StepLOADNC. When the new compiled code is stored in documents,
e.g. password-protected libraries, leagcy LO versions will just read up to
non-numeric characters, thus correctly obtaining number value and ignoring
the type, so the change is backward-compatible.
To interpret legacy compiled code, old treatment of SbiRuntime::StepLOADI
is restored, reverting commit 0b4f8bf571.
This change reimplements the fix for tdf#129596.
Change-Id: I46ebfc77f9bea69479968950c0fb7264e4a7ab27
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90858
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Regression from commit fd7749fddc (sw: fix
handling of table vs fly overlaps in the AddVerticalFlyOffsets case,
2020-02-14), the problem was that the rectangle of the fly frame
included spacing when overlapping was checked.
Given that this code was explicitly added for Word compat purposes,
change it to ignore spacing. You can see that Word doesn't care about
spacing: increase the left margin of e.g. the pie chart in the bugdoc to
some large value and the table is still not shifted down.
Writer shifted the table down as the small spacing was already enough to
detect an overlap:
debug:21457:21457: SwTabFrame::CalcFlyOffsets: aTabRange is 896 -> 3698
debug:21457:21457: SwTabFrame::CalcFlyOffsets: aFlyRange is 3650 -> 6290
If we don't include that ~3 px spacing, then we don't overlap, similar
to Word.
Change-Id: I154c211bb0700d132fd168f49c1bbfb29e8caeb7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90939
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
For some mysterious reason the cursor was forced to
become hidden after creating SwDrawTextShell, which
is used to edit the text on shapes. Doing this
didn't have a negative effect on desktop, because
the cursor was shown anyway at a later point.
However, for LOK, the cursor was not restored. This
was unexpected as the clients didn't know editing
was possible (and on mobile wouldn't even show
the keyboard).
There doesn't seem to be any ill-effect to leaving
the cursor enabled in all cases after creating
an SwDrawTextShell instance.
Change-Id: Ifae8d533ef48b2146a451d58d729e46f5248be71
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90897
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
(cherry picked from commit a50d20b114)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90947
Tested-by: Jenkins
Change-Id: I3077e6e3a043401e66cd527c5f69b8571e8b25d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90915
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
which the normal ::insert case does, but the bulk insert omitted
Change-Id: I9b236e5f0e91292539164d39f0f90e109a1b503e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90928
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Change-Id: Iec1e6f0d5d3f79357182c92166ba83c5fad3521f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90894
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
I based the check on the gmake check, but that one doesn't need
the export, as gmake is what needs to be called for the build
to start. But ninja is currently only used during building NSS.
Also do not use Windows path for ninja on Windows, as NSS
actually invokes it from a shell script.
Change-Id: I0d8a86ee3688f27a376d547cd946bb4c59a547a2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90922
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
Found with
> while IFS= read -r i; do if test ! -f "$i"; then printf '%s\n' "$i"; fi; done <solenv/clang-format/blacklist
Change-Id: If919ef697b6dd8f7fc511835e3fa90caf37ad991
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90918
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Fixes CVE-2020-8315; this only affects Windows 7 and is a regression in
Python 3.6.
Change-Id: Ic1706e064a1b03ca1de6361794ed4586a89821d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90916
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
...with change to InterimItemWindow way of using FontSizeBox as member
variable widget
Change-Id: I0ad0c3191800ce80a88e58467950a80b5791a2da
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90510
Tested-by: Jenkins
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Expands the parent of a child, if needed, so the child can be selected.
Change-Id: If4b7322a7024065e5e96ed2ed43289c5ae7c5f5d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90899
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Change-Id: I312fb575e888c8a4c1ef0d2857e9682a7f31e295
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90187
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
(lexicographically, by Unicode code point values; to make it easier to add
further entries)
Change-Id: Ie7f5dbfbc7e2c1c8ed331d5328c059866c2e2d10
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90914
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
This is the last padded numbering type that is supported by Word but was
not supported by Writer.
Change-Id: Ica1a0843897c61a4b569105fd21e5bfe7b5012cb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90912
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
Internal NSS now needs it for building on most platforms, so better
check early in configure.
Change-Id: I45d7038536ea1416443f3b2523f25eee22911485
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90859
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
This should be the gyp variant of 54acab919e.
Change-Id: Ic50f5153c4b1f19ae74a52eb9bc0d7c6c23ae131
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90118
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
This requires installed ninja, gyp is included as source. This
allows nss be built as a parallel build, unlike the old Makefile
build system.
Since gyp internally uses python, even recursively, this requires
more complicated setup in case our internal python is used. Moreover
gyp itself seems to be kind of deprecated itself and hasn't
been ported to python3 yet, so that needs patching too.
So far only easy Unix-like systems are converted, Windows I'll
do later, the more complicated systems I'll leave to whoever
has access to them.
Change-Id: I358baad7690d2aa6df44bafa9244dc7cc828fc3f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90115
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
The current default target ('all') was a confusing mess, it did run
some tests, but it did run just some of them and it also depended
on some factors (toplevel 'make' vs module 'make'). And running
tests on plain 'make' also makes the developer cycle longer, which
is annoying, and now there's Jenkins which will do checks.
This commit makes the default make target to be 'build'. All
the other targets should work the same way, with the exception
of 'all', which I've removed (given that it was confusing, it's
probably better not to try to keep any kind of backwards compatibility
there). The 'build-nocheck' target is now equal to 'build' and thus
pointless, but I've kept it for backwards compatibility.
Change-Id: I874b7ae8d26e95efa86a00dd32cfa7fd19599b9d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89820
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
This one isn't GCC's fault, not obvious that the any must contain a
bool.
Change-Id: Iad94dc5bd1a010be1c22e527e0d14c027f0dcf60
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90910
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
The problem is that the LD_LIBRARY_PATH on the command line causes
/usr/bin/python to find LO's libpython*.so*:
18269: find library=libpython3.7m.so.1.0 [0]; searching
18269: search path=.../instdir/program (LD_LIBRARY_PATH)
18269: trying file=.../instdir/program/libpython3.7m.so.1.0
Presumably LD_LIBRARY_PATH is used to find bundled libxml/libxslt.
So let's try to disable the broken case where a bundled lxml is used
with system python and bundled libxml/libxslt; this cannot work.
(regression from 84ef6d8254)
Change-Id: I67aa8250691cae8f899d65f674aa9da23a9d1d7a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90906
Reviewed-by: Samuel Thibault <sthibault@hypra.fr>
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
Tested-by: Jenkins
Formular -> Formula
(Found when working on variable translation in
c212e295c589695c9da0c21914fb30b6af5909d6.)
Change-Id: I9409598670eabdd6ebb1ea1cb0ccc4d9d6292f8e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90464
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: I24808de5bfd176e007fdc96f120a3c9a43dc7902
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90480
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
