The meaning of "Numbering separator" is opaque. The new label indicates
where the optional text string will be placed. The added tooltip /
extended tip helps to explain.
Change-Id: Ia9da9d4d1d6bdf40ab7465cffe8d0d5faf42b27d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149992
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
For similar code sequences that can be improved.
Also move containsComment from collapseif plugin code to
plugin.cxx so we can use it from stringadd.
Change-Id: Ie07d9aedf2c31cb0b2080e1b8584294d7046a8e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149217
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Aside from general up-to-dateness, this also fixes build on some
loongarch64 systems whose libdir is `lib64`.
Change-Id: I78988c7d585be4e44b3388d8e1c7d60e2738de97
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147185
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Useful as a generic text input dialog
Change-Id: Ibc6ff0c25a790da8f1226fff7244e50ed3a1cf04
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150002
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
The colors of a ColorStopRange can be equal in case of
hit *and* miss, so in both cases. I moved it to the
common computation part. Prev version worked and did
no harm, but unnecessary color interpolations for equal
colors.
Change-Id: I19031f1021ee5955b48da5c0d8e3a03cb9512ebf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150046
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
veraPDF complains:
Specification: ISO 14289-1:2014, Clause: 7.1, Test number: 3
Content shall be marked as Artifact or tagged as real content
Form element can only be used for those form controls for which
PDFWriterImpl can produce a Widget annotation; see createDefaultWidget().
For a label control, it's not editable so it's not a PDF widget.
For an image button, it could be implemented in VCL but isn't currently.
So a fallback is required in any case, "Figure" or "Div" can be used.
Change-Id: I454030ff7c67a8a8101fcc59e945fe9dbc5f87a8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150059
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
...that were apparently forgotten by 155c056b1d
"i18npool: create instances with uno constructors" and
d2140a6320 "i18npool: create instances with uno
constructors", respectively
Change-Id: I3caedf9d2a941a8671fab554a2358776d95c4938
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150066
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
In 2002, fc680b6430 "#97583# Modify for new
services" had added the two com.sun.star.i18n.Transliteration.IGNORE_KANA and
com.sun.star.i18n.Transliteration.ignoreKana service implementations, both using
the also added ignoreKana_CreateInstance factory function, to
i18npool/source/registerservices/registerservices.cxx (back in a time when that
still used active component registration via component_writeInfo). Then in 2010
a3c8a0ed0c "sb129: #i113189# change UNO components
to use passive registration" (dropping the active component registration via
component_writeInfo) faithfully listed both those service implementations in
i18npool/util/i18npool.component. And in 2014
a4f17c00b1 "i18npool: Constructor feature for few
more implementations" switched the com.sun.star.i18n.Transliteration.IGNORE_KANA
service implementation to use a constructor attribute in
i18npool/util/i18npool.component. But it also removed from
i18npool/source/registerservices/registerservices.cxx the
ignoreKana_createInstance factory function and the
> IMPL_TRANSLITERATION_ITEM (ignoreKana),
aInstances element through which the other
com.sun.star.i18n.Transliteration.ignoreKana service implementation was created
via i18npool_component_getFactory. (It presumably either intended to also
change com.sun.star.i18n.Transliteration.ignoreKana to use a constructor, but
forgot to implement that, or accidentally broke that service implementation.)
So the com.sun.star.i18n.Transliteration.ignoreKana service implementation has
not been instantiatable ever since 2014. But it appears that nobody missed it
much, so maybe it had already been a mistake to add it (alongside the
com.sun.star.i18n.Transliteration.IGNORE_KANA service implementation) in 2002.
So just remove it completely for good now.
Change-Id: Ieda888038a70f4123a0c5f9f4e3306491f32ed64
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150068
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
At least for the case the document is launched from the StartCenter, put
that StartCenter as the parent for any dialogs that may appear during
typedetection, this avoids such dialogs not getting associated with
the start center and going behind the dialog if the start center is
clicked while the dialog was appearing.
The start center is always recycled to become the next document if
it exists, so its window is the window the final document would
appear in if successful.
Change-Id: I75a92ff424aa0b9d5d6b808e2f7f1766a80fa50c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150058
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
* Update helpcontent2 from branch 'master'
to 470abc85b20e113506966df8883e287d25079517
- tdf#154608 Add example of regex with \N{} to Help
Change-Id: I7b6c847cc3fbcbb62d9590eea4050630933e85f5
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/150062
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Specifically in sd/source/core/annotations/Annotation.cxx
We seem to end up fixing leaks here often.
The current tools::JsonWriter API is just very hard to use correctly.
So rather return an OString, which is cheap to copy,
and push that down into the LOK code.
AFAIK that seems to end up requiring less code and less adhoc copying
of data (specifically the queueing code in init.cxx was creating
copies when converting to std::string).
Ideally, we could have some special API to avoid the new strdup()
calls in init.cxx, but not sure how to prevent other people
from accidentally using that.
Change-Id: Ia33437c1bfd9cc2d54dfb99914d1b72db20335f2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149963
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
frmpaint.cxx:801: SwTextFrame::PaintSwFrame: Assertion `... || oTaggedParagraph || ...' failed.
The problem is that here the SwNumberingPortion is outside of the table
cell and even outside of the page due to negative indent, hence
CalcPaintOfst() skips it.
Have to add another special case to open the LBody/P tags in this case.
Let's not produce Lbl tag in this case since it's not visible.
(regression from commit 9b38beadf9)
Change-Id: Ic048849c9f426ebfa59e05acece1ec995fd28247
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150056
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
This happens since commit 9b38beadf9
on abi13630-1.abw.
itrpaint.cxx:419: void SwTextPainter::DrawTextLine: Assertion `roTaggedLabel' failed.
The problem is very similar to the situation fixed with commit
6c0105307efa15837e9e5287103995312f373b67; then it was the pField which
ended up empty and deleted, while now it is "this" which ends up empty
and deleted; in either case the DrawTextLine checks of the follow flags
fail because some follow flag is erroneously set.
This requires a further tweak because the length of the portion is set
to 1, so Compress() returns the wrong result there but immediately after
SwFieldPortion::Format() returns SwNumberPortion::Format() sets the
length to 0 anyway, so simply set m_nFieldLen to 0 in ctor which is
correct anyway as there's no dummy char for these.
Change-Id: Ie99f67ee19a1f6019afe68764ec746cdc862984e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150055
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
According to
officecfg/registry/schema/org/openoffice/Office/UI/Commands.xcs,
TooltipLabel is supposed to default to Label if PopupLabel is empty,
but in practice it seems TooltipLabel also defaults to ContextLabel
when TooltipLabel is empty, so this patch adds back the original
TooltipLabel, which is different from the ContextLabel, and is needed
primarily for some toolbars.
Change-Id: I538bb4d75ce9a5141c292408c3f670d4524f2069
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149986
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
7.18.6.2 Media clip data
In the media clip data dictionary, the optional CT and Alt keys
(ISO 32000-1:2008, 13.2.4.2, Table 274) are required.
Presumably writing a potentially wrong hard-coded mime type here isn't
intended.
Change-Id: Ifa8ee199a4cf9ce83f410860d59b6c30475f80e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150050
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
.. at least for the most popular types, and do it automatically in
MediaItem::setURL().
This should work in practice in most cases and is much simpler than
adding some type detection or calling into platform dependent avmedia
backends.
Remove the parameter that was only ever set to
"application/vnd.sun.star.media" anyway, the same value that would be
used if it's missing.
Stop using that silly type for everything, only use it when guessing
fails.
In case an ODF document is loaded, it will use the mime type loaded from
the file (see setting of MediaMimeType in SdXMLPluginShapeContext) and
not guess it because that would require updating the entry in
manifest.xml as well.
Change-Id: I8ce29cf7425678ae11dda1d8c875be818f8623af
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150049
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
- Removed fontitemids.hxx and moved new enum definition inside cxx file to
optimize compiling.
- Removed non-existing fontitemids.hxx from clang format excludelist.
Change-Id: I67e782821d65241264de0926e445a58dc7307ba7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149736
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
which propogates to cairo and once a cairo surface is in an error state,
that cannot be cleared and all subsequent drawing fails, so bodge that
with a high degree of stretch we draw the brace without stretch to a
temp surface and stretch that to give a far poorer visual result, but
one that can at least be rendered.
Change-Id: I6b8bb079e82c3cf03a908de750c5c445ad230750
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150031
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
primary purpose is to differentiate the two .uno commands
so that they do not have the same label in the Customize
dialog. ContextLabel is needed for use in submenus.
PopupLabel needed for Edit..., but not for Insert.
Change-Id: I4dc452805ff47669218158711b874b04330d02ef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149881
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
in the past there was intermediate calls that these affected
Change-Id: I5bb15046ff5869522dfafe72e16f9be4707c1f7e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150027
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
i.e if the crossing was triggered ultimately by a key stroke which is
likely from exiting the search box.
This way we can avoid the problem that with hover-selection that after
"enter" is used in the search box, selecting a matching row, then during
teardown of the widget the box is hidden, and the generated crossing
notification triggers unwanted selection of a different row under the
mouse.
If needs be this could be refined further to only happen for a specific
key or other details of the triggering event
Change-Id: I7e64fb5fa31a446b85016d86ecd314d13130d7b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150016
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
