This could erroneously skip a check because the child was erroneously
deemed obscured by another object.
Change-Id: I67d76ea272874671ae328266bdbdeb037c0dc625
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133842
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
... and remove obsolete comment, that problem was fixed a decade ago.
Change-Id: I06e122128ff009778da87891739016ecc8975895
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134110
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
XPath is a little heavyweight for such a simple thing. Shaves 5% off the
load time for me
Change-Id: I109f68fa1dfc228b42740000a95a2e7a3de7e320
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133927
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
The text metric value is initialized in ImplFontMetricData::ImplInitBaselines() using harfbuzz API hb_ot_layout_get_baseline. It can't handle multiple hanging baselines of the same font for different scripts yet because the script is fixed to HB_SCRIPT_UNKOWN.
Change-Id: I2574f0dba45501187064b9341c573159914a4a17
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133667
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>
keep nEndPos and nStartPos consistent if there is no following piece
Change-Id: Iaa0840eb9a60c429d60ff449aed0a2f981306b0c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134093
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Regression from b099da78a6f0b3e120f706714003b05d84d11e70
we didn't update linked OLE document after document reload
Change-Id: I8e52f6430f454b276cb43449c6f7a3b0e07e909f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130692
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
Tested-by: Jenkins
Several methods actually do not need locking because they are
calling other methods which are already locked, and thereafter
they touch only function-local state.
Change-Id: Ic0c55df65988fcc64899a31586f6a426825cba81
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134088
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
I.e. the UNO class wraps SwFormatField, and that wraps SwField.
Change-Id: Ieadcf8bf1de8a034dacc567b1193ec2c5391a42a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134092
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
a problem since...
commit e9c50fbbc3
Date: Sat Apr 2 15:49:32 2022 +0300
tdf#103954: Z compressed graphic formats support for EMF/WMF
Change-Id: Ia994587bf411a2cda3df38cb209313171b78ee9a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134091
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
OUStringNumber::toAsciiUpperCase is cheaper than OUString::toAsciiUpperCase.
Let SbRtl_Oct use OUString::number as well.
Change-Id: I3a97ec5d3a7b0005fc300310198bae47c62dfbc6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134061
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
I don't see why it should be private, it's range checked,
so there should be no harm. Especially when a number of classes get
declared as friends to get access to it anyway.
Change-Id: I333d749aa9d09aaf9dcbabf43d67a67d1257a132
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134051
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
EMF+ is allowing different caps and arrows on both ends
It is not possible to implement that with css::drawing::LineCap,
as it is set line endings on both line start and line end.
Additionally when the Dash Pattern is used, the css::drawing::LineCap
is also applied there.
To resolve that limitation, the Cap needs to be implemented
independetly by using PolygonStrokeArrowPrimitive2D, and
the css::drawing::LineCap inside drawinglayer::attribute::LineAttribute
always set to css::drawing::LineCap_BUTT
Change-Id: I4be76e2dbefcb34154a1404c3b57dc4b7f7ada85
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133299
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
...which should always be available with our C++17 toolchains
Change-Id: If3b231f58c3c27a10d68ef4946b7ee2bb4f31a4e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134083
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
It matches VBA, has an optimization in the code, and doesn't
need any additional "-2" hackery.
Change-Id: I4b90674ae643788eda5ce618b4c42e2cc045ec04
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134060
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Exported XLS documents lost their formulas opened in MSO.
Regression from commit 12ee423c75
"tdf#144397 tdf#144636 XLSX: cache external named ranges and their formulas".
Change-Id: I009630a41b29bb21349711cc07d0ed181f816374
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134075
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
We require at least GCC 7.0.0 anyway, per README.md
Change-Id: Ib974690ef4e4a1861a43f33157fde9f4bb3ac8ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134080
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
...and apparently doesn't need to, even though that dependency got added with
6ffdc88e79 "Simplify Sequence iterations in
shell..svgio"
Change-Id: I7cb67dc48d11e426d5d5f7912eca13e25a32dbc5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134079
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
...and fail loudly if writing the file fails for any reason
Change-Id: I1e6d2e3da4d2ef643f4d27067845184dbf2e40a8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134076
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
...and apparently doesn't need to, even though that dependency got added with
6af2e7d21c "use more
comphelper::OInterfaceContainerHelper2"
Change-Id: I74a4d04be9a37291bc37d908173381eb341b6df4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134077
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
This reverts commit 59059d00c2, as it effectively
did nothing, as rvalues can bind to `const &` just fine.
<https://gerrit.libreoffice.org/c/core/+/133747> "Acutally do prevent using
O[U]String::subView on temporaties" would have fixed that, but (a) it didn't
find any actual mis-uses and (b) rather would have required a handful of
legitimate cases to be dressed up with o3tl::temporary now, so is arguably not
worth it.
Change-Id: I923d0db2646dc8ea66d1b2a8b709ee2cd7a60ed4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134058
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
The logic is that in case there is no selection, we insert a placeholder
like "type here", but if there is a selection, that can be a custom
placeholder.
Without this fix, we would hit an assertion failure on inserting content
control when there is a selection, as the placeholder is empty and
operator[](0) is not allowed for empty OUStrings.
Change-Id: I8370b8d74415faf0e76dccb574aa29bea1947bb8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134041
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
Without this, the implicitly created constructor is exported by MSVC
for the DLLPUBLIC class, and requires that VirtualDevice is defined,
resulting in this error in PCH-disabled builds:
[build CXX] vcl/source/animate/Animation.cxx
C:\lo\src\core\include\rtl/ref.hxx(129): error C2027: use of undefined type 'VirtualDevice'
C:\lo\src\core\vcl\inc\impanmvw.hxx(29): note: see declaration of 'VirtualDevice'
C:\lo\src\core\include\rtl/ref.hxx(127): note: while compiling class template member function 'rtl::Reference<reference_type>::~Reference(void)'
with
[
reference_type=VirtualDevice
]
C:\lo\src\core\include\vcl/vclptr.hxx(216): note: see reference to function template instantiation 'rtl::Reference<reference_type>::~Reference(void)' being comp
iled
with
[
reference_type=VirtualDevice
]
C:\lo\src\core\include\vcl/vclptr.hxx(64): note: see reference to class template instantiation 'rtl::Reference<reference_type>' being compiled
with
[
reference_type=VirtualDevice
]
C:\lo\src\core\include\vcl/outdev.hxx(202): note: see reference to class template instantiation 'VclPtr<VirtualDevice>' being compiled
make[1]: *** [C:/lo/src/core/solenv/gbuild/LinkTarget.mk:337: C:/lo/src/build/workdir/CxxObject/vcl/source/animate/Animation.o] Error 2
Change-Id: I78723ce7d00667595aff39bcab22169ff347098f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134036
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Map each list item to a dedicated XML element:
<loext:list-item loext:display-text="..." loext:value="...">
And do the opposite on import.
Change-Id: I59a536a8317a3bb24919107b4449f858d5f6de96
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134034
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
If the lines are created with MOVETO, LINETO, LINETO...
then Line Join NONE is applied. As a result the charts are looks ugly,
with the holes inside it.
For example:
https://bugs.documentfoundation.org/attachment.cgi?id=179962
and
https://bugs.documentfoundation.org/attachment.cgi?id=179837
Additinally commit changed default line join style to miter,
as during experimenting with MS Paint and MS Word,
it appear that default Join Style is PS_JOIN_MITER and
Line Cap is Flat/Butter.
The PDF export tests has been updated, as there is less number
of PDF object after using joiners.
The size of the exported tdf145873.pptx to PDF,
was slighltly decreased from 22.8kB to 22.0KB
Change-Id: I131cc3c5e90f827d67d2360eb18167eed6315abb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133624
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
