Commit graph

476301 commits

Author SHA1 Message Date
Stephan Bergmann
a8485d558f [API CHANGE] Remove deprecated idlc and regmerge from the SDK
* Client code must replace uses of idlc and regmerge with uses of unoidl-write,
  see the changes to odk/examples/ and ure/source/uretext/ in
  40f2aee658 "Provide unoidl-write also for the
  SDK" for examples.

* The new types.rdb format is not compatible with LibreOffice < 4.1.  Clients
  generating extensions containing such files are advised to use appropriate
  LibreOffice-minimal-version elements.

* For compatibility with old extensions, reading the legacy types.rdb format is
  still supported.

* The SDK no longer ships an idl/ sub-directory containing the udkap and offapi
  .idl files (as, unlike idlc, unoidl-write does not need them).
  odk/config/cfgWin.js had to be adapted to look (somewhat arbitrarily) for an
  examples/ sub-directory instead of idl/ when checking for "an sdk folder".
  gb_UnoApi_package_idlfiles became unused and has been removed.

* The idlc and regmerge executables have been removed.  Module idlc has been
  removed except for idlc/test/parser/, which is also used by
  CustomTarget_unoidl/unoidl-write_test, and which may eventually be moved into
  module unoidl.  Module external/ucpp and the corresponding configure options
  have also been removed.

Change-Id: I42a0231699b863b5ebe2bee63bc32c8f79278cc1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122363
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-06-10 17:15:49 +02:00
Noel Grandin
611fe67394 loplugin:unusedenumconstants add support for ParenListExpr
Change-Id: I3dc2a5e4c0cae9a9ae955118e77eae63c17f7242
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135590
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-10 15:49:56 +02:00
Christian Lohmaier
27ebceb366 bump product version to 7.5.0.0.alpha0+
Change-Id: I4c696b0942edc5afe7a3d2babe62e7b70463f543
2022-06-10 15:02:00 +02:00
Michael Stahl
4561327479 tdf#140007 sw: fix SwUndoReplace
(regression from commit d6b0e84b23)

Change-Id: I1facf1584a349d1d087438f4e6fd3a63a80c6f7e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135585
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-06-10 14:59:17 +02:00
Christian Lohmaier
c94961c686 Update git submodules
* Update translations from branch 'master'
  to d876aa338f5bc378bec4500d8e4d13654d7f8cea
  - update translations for master/7.4.0 beta1
    
    and force-fix errors using pocheck
    
    Change-Id: I6b70cdc276c670e1eb166910f095c46e81256a7f
2022-06-10 14:53:38 +02:00
Miklos Vajna
04cc6e079e sw XHTML export: avoid writing default transparent background for ReqIF
We started writing properties of tables and rows since commit
c3c3303516 (sw XHTML export: output table
/ table row background format using CSS, 2022-05-10).

In case the SwTableLine has an explicit SvxBrushItem with its color set
to COL_TRANSPARENT, we turn that into a "background: transparent" CSS by
default. This is a 1:1 mapping from the doc model, but HTML defaults to
this already, so this is considered as noise.

Extend IgnorePropertyForReqIF() to filter out these unwanted defaults,
and fix SwHTMLWriter::OutCSS1_Property(), because it used to not pass
the CSS value for the filter function.

The behavior for table cells is unchanged, we continue to not export
cell properties (in the ReqIF case) at all.

Change-Id: Idbcd07809e159def694f4de017eebc7ad4104575
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135576
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-06-10 14:28:11 +02:00
Miklos Vajna
af3c766cb5 sw doc model xml dump: show table row properties
Also extract SwTableNode::dumpAsXml() from SwStartNode::dumpAsXml(),
ideally dumpAsXml() should only dump own members, not members of other
classes.

Change-Id: I5ef3e90d0cdd23ba44c192de1802844acad64cc4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135575
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-06-10 14:27:55 +02:00
Mike Kaganski
098999e62e Drop unused text column from IconView's model
... and also the hardcoded column count and width. This allows to
make the elements position themselves better in the dialog, and to
avoid the unused space below the icon in GTK, similar to non-GTK
as implemented in commit 54725f6e5f
  Author Mike Kaganski <mike.kaganski@collabora.com>
  Date   Tue May 03 09:49:07 2022 +0100
    Don't add empty labels to fontwork's icon view

Change-Id: I19fa4e2002856322266b21873b383bc887cf1029
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135584
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-06-10 14:14:23 +02:00
Mike Kaganski
e52a805172 Entry may have no text
... after the changes made to IconView.

This partially reverts commit 54725f6e5f
  Author Mike Kaganski <mike.kaganski@collabora.com>
  Date   Tue May 03 09:49:07 2022 +0100
    Don't add empty labels to fontwork's icon view

and instead, makes SvTreeListBox::GetEntryText tolerate absent text.

Change-Id: Ifc386263ad656478416907a6f6b567cd1f3331ae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135582
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
2022-06-10 14:08:49 +02:00
Xisco Fauli
629a9b92da tdf#149503: Check size of vectors
Crash introduced by 41f95c4a35
"Remove SC_DPOUT_MAXLEVELS limit in Pivot"

This brings back the old behaviour and now the
"You cannot change this part of the pivot table." message
is displayed again

Change-Id: Ibad84c0a279d7d67b709b7e311ac875739cdb210
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135578
Tested-by: Eike Rathke <erack@redhat.com>
Reviewed-by: Eike Rathke <erack@redhat.com>
2022-06-10 14:02:32 +02:00
Christian Lohmaier
3a688ca467 autocorr for da: fx can appear at end of sentence
as in e.g. "Vi kunne jo tage bussen, fx." so remove the "fx." entry from
the autocorrect list

Change-Id: I5c03f46bd1e35fcf8fa731983c7459f2ba99b174
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134107
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-06-10 13:57:24 +02:00
Mert Tumer
d952df361a LanguageTool Grammar Checker implementation
Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
Change-Id: I275cbea668afc5beb5147370119631df8b6a2d46
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135178
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-06-10 13:52:17 +02:00
Lukas
044df30366 bin/upload_symbols.py: make pythonic
Change-Id: I44d86677f64b7b4a4212b94a574a20805bac649b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133223
Tested-by: Jenkins
Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-06-10 13:43:14 +02:00
Noel Grandin
f71606c920 new loplugin:moveit
look for local variables that can be std::move'd to parameters

off by default, since it doesn't do proper data flow analysis

Change-Id: I3403a0fcffd165bdea6a772528bc53995c5fdb40
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135527
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-10 13:13:15 +02:00
Xisco Fauli
b28de9d320 tdf#135346: vcl_pdfexport: Add unittest
Change-Id: I11ad776419ea3c0eb5babd0f1ee2c7c70b7e7485
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135580
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-06-10 12:27:43 +02:00
Xisco Fauli
bc93734772 tdf#114256: vcl_pdfexport: Add unittest
Change-Id: Iaaeb0b248f84709855d9e83d34cecf22f1169769
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135581
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-06-10 12:11:32 +02:00
Eike Rathke
b7eddf3e9c Resolves: tdf#148072 Restore sheet-local names for Undo of Cut
Undo of Cut uses CopyToTable() and not UndoToTab() as Copy does,
so copy the sheet-local names also *from* Undo and not only *to*
Undo. And mark for ScAreasChanged broadcast.

Change-Id: Ib07f711a7d407dafdf548873291f1ccc81b85d47
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135568
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
2022-06-10 11:23:56 +02:00
Luboš Luňák
cd7e262f7e add missing 'xComponent->dispose()' to a test
Change-Id: I0ae2847e81eb2f1fba16e65d89ca1db1e55ac4b8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135577
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-06-10 11:20:24 +02:00
Miklos Vajna
c3787043db sw: fix use-after-free in SwFrame::ImplFindPageFrame()
Header-footer controls have a non-owning pointer to their page frames in
Writer views, so whenever a page frame gets deleted, we need to manually
make sure that the header-footer control doesn't have a pointer to the
deleted page frame.

This already works with a single view, but in case one view has a
visible header-footer control and an other view deletes the page frame
that is known to the header-footer control, then we have a problem.

Fix the problematic outdated SwFrameMenuButtonBase::m_pFrame by
extending SwPageFrame::DestroyImpl(), so it un-registers itself (before
deletion) not only from the current view, but from all views.

Found by online.git's:

tst=/tmp/testfoo.odt
cp test/data/hello-world.odt $tst
./coolstress wss://localhost:9980 $tst test/traces/writer-hello-shape.txt $tst test/traces/writer-document-edit.txt $tst test/traces/writer-mash-text-table.txt $tst test/traces/writer-rambling-text-table.txt $tst test/traces/writer-add-bullet.txt

although also reproducible on the
desktop, in case you have two views (windows), do cltr-enter to have 2
pages, go to the 2nd page in both views, view 1 clicks on the 2nd page's
header, view 2 deletes the page (backspace) and finally view 1 clicks in
the body text of the current page.

Change-Id: I35e5d82256ab5db8e5f0ba198f5d2638cbff7d3c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135573
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2022-06-10 09:56:11 +02:00
Stephan Bergmann
12ffb0cb65 external/libtiff: Missing include for _byteswap_uint64 on Windows
...now causing a -Wimplicit-function-declaration error with Clang 15 trunk after
<7d644e1215>
"[C11/C2x] Change the behavior of the implicit function declaration warning".

(Unconditionally including <stdlib.h> on all platforms even for those that don't
need it should be harmless.)

Change-Id: Ic2191308ea252cb4b88842a2767167ab2d23d9fb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135572
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-06-10 09:46:49 +02:00
Xisco Fauli
4dae3508de Add asserts to those places where I fixed a EXCEPTION_INT_DIVIDE_BY_ZERO
I found those crashes scraping https://crashreport.libreoffice.org/stats/
so those are blind fixes basically. Add these asserts,
hoping one day someone will hit them so we can find the root cause.

See
7c8b9fa98f
fae937b685
ce39195e53
23e3bff528
ea4cd39730

Change-Id: I175f47361e07961417c87cc8f3d7d4d1fb50fb2c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135448
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-06-10 09:15:46 +02:00
Miklos Vajna
d701eff351 sw XHTML export: avoid writing background of table cells in ReqIF mode
ReqIF mostly forbids using CSS styling on elements:
IgnorePropertyForReqIF() only allows 2 CSS keys by default.

This restriction was relaxed in commit
c3c3303516 (sw XHTML export: output table
/ table row background format using CSS, 2022-05-10), to allow
background for tables and table rows, using CSS markup. An unwanted side
effect of this is background for table cells, which is still considered
invalid. To make this nontrivial to fix, Css1Background::Table is used
to track formatting for all of tables, rows and cells.

Fix the problem by extending Css1Background with a TableRow and
TableCell and then audit all uses of Css1Background::Table to explicitly
say if they mean table, row or cell. This keeps table and row
backgrounds, but fixes the unwanted cell background.

Also document the 3 functions doing the export of table / row / cell
background export to improve readability.

Change-Id: I03301b1fd25593cbe83489dbf140e80138d4a0de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135570
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2022-06-10 09:01:04 +02:00
Hossein
d0e50ba13b Add information on Java baseline in README.md
As discussed in the ESC, although LibreOffice can be built with the
Java Development Kit (JDK) version 9, the JDK 9 is no longer
supported by the JVM vendors including Oracle, Red Hat and others.
Thus, it is asserted here that JDK 11 or later should be used to build
LibreOffice.

For further information on the supported versions of JDK, and its
lifcycle, see these articles:

Oracle Java SE Support Roadmap (Updated March 22, 2022)
https://www.oracle.com/java/technologies/java-se-support-roadmap.html

OpenJDK Life Cycle and Support Policy (Updated November 22 2021)
https://access.redhat.com/articles/1299013

It should be noted that JDK 8 is still supported, but it is not usable
for building LibreOffice.

It is also documented that without Java one may lose many features that
are described in the TDF wiki article Development/Java:
https://wiki.documentfoundation.org/Development/Java

Change-Id: Id001c341a221b0fe5c07c7129956a824261d32c0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135557
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-06-10 08:21:57 +02:00
Tomaž Vajngerl
317dc85697 tdf#135346 clear page row map to avoid invalid "hidden" flags
With the print range cache surviving a longer time, we can get to
a state where we reuse the page row map (m_xPageRows) that had
older "hidden rows" flags still set, but they aren't valid for
our new recalculated ranges. The result for this is that in the
bug document, the print preview is empty (as hidden flags for the
rows was kept but not valid anymore).

We don't really benefit from keeping this map, so we can just
clear it when we need to recalculate the print ranges.

Change-Id: I1f8de889d6f006e700c6f21ef5bfa52a36bcdfc9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135567
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-06-10 08:12:06 +02:00
Miklos Vajna
1cbdbff2f4 CppunitTest_sw_layoutwriter: use more SwParaPortion::dumpAsXml()
See commit feeed3e762
(CppunitTest_sw_layoutwriter: avoid some a11y-based layout testing,
2022-04-07) for motivation.

Change-Id: I1f8d1279ebd0aadfc6c657e63e62da265f785896
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135564
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-06-10 08:07:26 +02:00
Andrea Gelmini
dfa2365dd8 Fix typo
Change-Id: Id11f0afe9aa32373837289b8bc7fa1b36112a28a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135521
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-06-10 07:06:08 +02:00
Rene Engelhard
089c91b1ad fix bigendian builds
after 410a64b472 and
6624721b32 which changed the
surrounding places but missed the occurence in #ifdef OSL_BIGENDIAN:

Change-Id: I610b0e19a37207b925668d7f2315b27abce21b2d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135558
Tested-by: René Engelhard <rene@debian.org>
Reviewed-by: René Engelhard <rene@debian.org>
2022-06-09 19:32:10 +02:00
Luboš Luňák
dabf52b816 remove incorrect #ifdef DBG_UTIL around normal code (tdf#149476)
This code sets sufficient size for the virtual device that saves
the content, so it's not some optional debug code. Without this
selecting text in Calc formula bar and dragging it around leaves
artifacts, because the saved content is not large enough to restore
the original widget content. This dates back to
d51fe1189d, which supposedly made
the code warning-free (and also correct-free).

Change-Id: I52dab8c8d3a083fff9da8aed27facdf21076622e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135555
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-06-09 18:42:12 +02:00
Mike Kaganski
2a28ebeef5 Accessibility for IconView
Change-Id: I65ca9d43f70a50e2e95aabfc3b8ba1b15f9ff8be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135226
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-06-09 17:49:16 +02:00
Rafael Lima
2910ce0b43 Update git submodules
* Update helpcontent2 from branch 'master'
  to 6a94b253eee022e358504b335e190e883e74749f
  - Document new CreatePivotTable method in SF_Calc
    
    Change-Id: I56de41d153c650058e85faaad023f169b3ca79cd
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/134436
    Tested-by: Jenkins
    Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
2022-06-09 17:46:08 +02:00
Alain Romedenne
0f9658f94f Update git submodules
* Update helpcontent2 from branch 'master'
  to 09dfc9550cc74aae157411e570375edb7abda341
  - Replace outdated links to OOo's wiki
    
    Change-Id: I4603f02312347b203dbbc13170f92819401e9a3a
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135535
    Tested-by: Jenkins
    Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
    Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
2022-06-09 17:34:05 +02:00
Miklos Vajna
51eb7b8379 sw content controls: fix crash on trying to insert nested dropdown
This went wrong in commit 3dd4f36914 (sw
content controls: add document model, 2022-03-30).

Change-Id: I8040e02975d1f98cc01ef6f8a22745f27afa5276
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135554
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2022-06-09 15:48:59 +02:00
Caolán McNamara
4308db47d9 Resolves: tdf#142368 drop popover on ControlLoseFocus
which is what appears when the Control derived inputbar loses focus
while the main window losing focus gives WindowLoseFocus

Change-Id: Iae9a2874c3dd513a1a092a18846858f819542370
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135533
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-06-09 15:06:50 +02:00
Caolán McNamara
88fbab0186 ofz#47901 fix read overflow
Change-Id: I707fe54e68ef548edcb8b69b83ba64c0674e44ce
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135532
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-06-09 13:48:12 +02:00
Christian Lohmaier
de8eafffbd Update git submodules
* Update translations from branch 'master'
  to 5e97a2aaf2e7167def28de951c6dcfdb1b93bf81
  - update translations for master/7.4.0 beta1
    
    and force-fix errors using pocheck
    
    Change-Id: I6419ffd7d18beaa9637624d377e4e38f473f9a30
2022-06-09 13:11:44 +02:00
Seth Chaiklin
4361a89ee5 Update git submodules
* Update helpcontent2 from branch 'master'
  to b97210c58dbbf9c16f4a4cbeba5665ada2efe6fb
  - tdf#126658 update "defining line ends"
    
    The content of the guide page "Defining Line Ends"
    (shared/guide/lineend_define.xhp) has not been updated since
    its initial checkin in 2004. This patch updates the relevant
    menu commands, aligns the description with the current UI,
    adds a little more precision in what gets added as an arrowhead,
    and refactor to <h1> and <menuitem>.
    
    Also, add a <relatedtopics> section to the "Arrow Styles" help page
    (shared/01/05200300.xhp) with an embedded link to this guide page.
    
    Change-Id: I3e619aadddb65b77cc7216074d18c4eb138b1774
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135393
    Tested-by: Jenkins
    Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2022-06-09 12:54:03 +02:00
Xisco Fauli
e04fab838f tdf#149484: subsequent_filters: Add unittest
Change-Id: I867696100d79f599a58e8cc5a64723cec3cea2b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135525
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-06-09 12:34:41 +02:00
Noel Grandin
485300f9ae loplugin:unusedmethods
Change-Id: Ib89ab59f7ad7e90b2a44ddd122176cde904fba4d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135520
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-09 12:08:15 +02:00
Xisco Fauli
0e1a0ecffa get-forum-attachments: Add 2 more mso forums
Add login mechanism for them

Also add --config and --outdir arguments to
set the pathes

Change-Id: I641f10396e1f4cf5bdb19da287b1a2962ff4e2ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135495
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-06-09 12:02:31 +02:00
Caolán McNamara
b1d57168b8 a Frame has max two children
during creation it might not have all its children created yet
if a11y querys it during its setup.

Change-Id: Ifbbec7eeb80409dc5e871c2022d1ee1e36c6e74f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135526
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-06-09 11:51:15 +02:00
Andras Timar
8494815ba5 Update git submodules
* Update dictionaries from branch 'master'
  to 68b272ec160ded8157c13117e350fc4dfc3037fb
  - Updated Danish spellchecker
    
    Change-Id: I7c8ff2e7fac358706a580f2b24842ade0a1baa55
    Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/135531
    Tested-by: Andras Timar <andras.timar@collabora.com>
    Reviewed-by: Andras Timar <andras.timar@collabora.com>
2022-06-09 11:42:31 +02:00
Noel Grandin
e9f407fbf0 can pass by const& here
no need to copy

Change-Id: I1fcc5d645a8f5278e2122a168b00c846d75bc091
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135522
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-09 11:27:03 +02:00
Stephan Bergmann
0bbbde84b0 tdf#140886: Make "Do you really want to open it?" more reliable
70009098fd "tdf#128969: Let the user explicitly
decide to execute an external program" had shoehorned that new warning dialog
into the existing XSystemShellExecute::execute IllegalArgumentException return
path, which caused some issues:  For example, it caused the warning dialog to
reappear after you acknowledged it on macOS (see comment at
<https://bugs.documentfoundation.org/show_bug.cgi?id=140886#c10> "Allow
hyperlink opening on file with execute bit set ref. CVE-2019-9847"), and it
caused the warning dialog to erroneously appear for a non-existing file on
Windows (see comment at
<https://gerrit.libreoffice.org/c/core/+/124422/2#message-ac76b728fedc53e7d0a04c99f00364068b51a8ea>
"tdf#128969: Let the user explicitly decide to execute an external program").

So rather than reusing IllegalArgumentException for this case, use a different
kind of exception to trigger that warning dialog.  The existing
AccessControlException (which is also a RuntimeException) happened to fit more
or less well.

Change-Id: I3f743c21be48d54f10951006ef3d7172e23e9076
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135524
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-06-09 11:17:14 +02:00
Seth Chaiklin
a54e10c270 Update git submodules
* Update helpcontent2 from branch 'master'
  to dae8c0f4225b25d4612f7a9db86fc4518bf4b3d9
  - (Related) tdf#126658 update Arrow styles help to reflect UI change
    
         text/shared/01/05200300.xhp (Arrow Styles tab)
           * update new control names
           * corrections to description of tab and its use
    
         text/shared/00/00040502.xhp  ("howtoget" for Arrow Styles)
           + add appl-switches with 
               * menu variations for Writer, Calc, Draw and Impress
               + access variations using toolbars
           + add right-click access
           + add section for embedding
           * rename German ID
    
    
    Change-Id: Ic224d72b2abeee777063626f4dcdb570562d3650
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/133037
    Tested-by: Jenkins
    Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2022-06-09 11:16:14 +02:00
Balazs Varga
246d4f14c3 Ignore warning C4723 for windows arm64 build
Tinderbox message from windows arm64 build:
C:\cygwin\home\tdf\jenkins\daily_workspace\tb\src_master\include\basegfx\range\basicrange.hxx(276) :
error C2220: the following warning is treated as an error
C:\cygwin\home\tdf\jenkins\daily_workspace\tb\src_master\include\basegfx\range\basicrange.hxx(276) :
warning C4723: potential divide by 0
LINK : fatal error LNK1257: code generation failed

Change-Id: I86ce1a0ea6abdf46464dcac95b9b591120782a13
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135523
Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-06-09 11:04:12 +02:00
Khaled Hosny
be39eba9a3 Use same glyph width in PDF drawing and font subset
During PDF drawing we already know the glyph width, but when subsetting
we get it again from the font subset.

For fonts without CFF table this is redundant but harmless, but for
fonts with CFF table, if the CFF and hmtx table (the authoritative
source of glyph widths) disagree, we will be drawing the PDF string with
the wrong adjustment resulting in displaced glyphs. This is a font bug,
but avoiding redundancy and having one source of truth is an improvement
overall.

I kept the code that calculates advance widths for font subsets, just in
case it is is still used elsewhere.

Change-Id: I757cd0c2ebb6477b2f840d0005e84b5a131f7efb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135442
Tested-by: Jenkins
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-06-09 10:03:51 +02:00
Jan-Marek Glogowski
136fac12eb redland WASM: add Emscripten flags to fix NEH build
Change-Id: I4ed242e774e1ce2ac05dabb9fc657329dc4a63c6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135519
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-06-09 09:50:46 +02:00
Seth Chaiklin
64b5eb2286 tdf#149414 change Format Object label for Calc and Impress
The label for Calc was Format > OLE Object (using
  .uno:ObjectMenu), while the label for Impress was
  Format > "Object and Shape" (using .uno:FormatObjectMenu).
  This patch (a) changes the label of .uno:FormatObjectMenu
  from "Object and Shape" to "Text Box and Shape"
  (to bring it in line with Writer). This change appears
  immediately in Impress, and (b) changes the .uno:ObjectMenu
  in Calc to .uno:FormatObjectMenu, which also gives the
  "Text Box and Shape" label, which is also more appropriate
  for its submenu.

  Kept the same keyboard accelerator "o", which was used both
  in Impress and Calc.

Change-Id: Ifcf7b953b6bed262d630f7a07bf1f5000ee33aa4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135162
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2022-06-09 09:19:42 +02:00
Miklos Vajna
19632bf0bc CppunitTest_sw_ooxmlexport14: avoid mustTestImportOf()
Can use CPPUNIT_TEST_FIXTURE() instead.

See commit a226cec52e
(CppunitTest_sw_rtfimport: convert one testcase to use
CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation.

Change-Id: I6d5c130ea25982d2cc0dc424a79c6962c1aa4f1a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135510
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-06-09 08:08:01 +02:00
Noel Grandin
91fef4a475 clang-tidy modernize-pass-by-value in editeng
Change-Id: Ibf912c597896a2ac0bf3ba8108f55c5018115bb0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135501
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-09 07:56:10 +02:00