* Update translations from branch 'master'
to 40da1e34cabf93b04d900b7b6ab501fb3160efef
- Updated Slovenian translation
Change-Id: If7fea40ad58b893757b644d670f1470c40dcbfde
in Justify::SnapToGrid correctly, and use it in
SwFntObj::GetTextBreak() and SwFntObj::GetModelPositionForViewPoint()
to get correct text positions before any further calculation.
In fntcache.cxx a simple formula was used to calculate the average
width of text grids occupied by ideographs. That's incorrect because 1)
for strings containing Unicode IVS, a ideograph is composed of several
sal_Unicode and the length of the string is not the same as the number
of ideographs contained. 2) The average width doesn't work because
character width varies, like ideograph and half-width kana in the
test case.
Change-Id: I863e8d8e346f555ff184a2f47d615e513b965b34
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135342
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Writer follows the CSS box model when it comes to page borders: there
can be a positive distance between the edge of the page and the border,
and again a positive distance between the border and the body frame.
This ensures that the page border never intersect with the body frame,
which is usually what users expect. Word, however, can work with 2
distances for border and text, both measured from the edge of the page,
leading to a page border, which is inside the body text. This is
described at great detail at
<https://wiki.openoffice.org/wiki/Writer/MSInteroperability/PageBorder#Importing_case_3:>.
Fix the problem by allowing negative border distances: this doesn't
influence the position or the size of the body frame, but it gives us a
way to position the border more towards the center of the page, leading
the matching layout between Writer and Word.
The doc model (to allow negative border distances), UNO API and DOCX
filter is updated in this commit. The ODT filter works without explicit
effort. Other filters are not yet updated in this commit.
Change-Id: I723e1bdb8dc6391129f1686f88826cc089f6fd67
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135462
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
A regression of
commit e247262327
CommitDate: Tue Jul 30 23:49:55 2013 -0400
More on avoiding direct access to data members.
that changed, for example, invalid sheet references
- aRef.nTab = MAXTAB+3;
+ aRef.SetTabDeleted(true);
The then following
commit 8a19af57bb
CommitDate: Tue Jul 30 23:50:03 2013 -0400
Now nobody accesses reference members directly. Make them private.
changed ScSingleRefData::Valid()
- return nCol >= 0 && nCol <= MAXCOL &&
- nRow >= 0 && nRow <= MAXROW &&
- nTab >= 0 && nTab <= MAXTAB;
+ return ColValid() && RowValid() && TabValid();
without taking the deleted flags into account, where previous to
commit e247262327 nTab > MAXTAB
fulfilled the condition of not valid.
This makes it necessary to adjust the
TestFormula::testFuncRangeOp() test case that relied on the broken
behaviour.
Change-Id: I42e769ca0d56a2eb786bb6f65917f0c15d082763
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135453
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
When e.g. having one image selected and then double-clicking on
the other one Execute_Impl() gets called with SfxStateCache still
having bSlotDirt and mxDispatch out of date.
I originally tried to make all mxDispatch accesses first ensure
!bSlotDirty, but then unit tests started failing with hard-to-debug
crashes because GetSlotServer() also sets bCtrlDirty, which leads
SfxBindings to handle that in idle timers. So at least handle this
case, where it really is necessary.
Change-Id: I4ec5908bc955c562e14cd813e269536924ce6f2b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135344
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
we never do this deliberately
Change-Id: I6d6d8ea13fb5f09bcf631c0474e671d4605f4c69
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135427
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
The original problem was that %PRODUCTNAME wasn't replaced for
accessibility descriptions (which are reused for extended tips) under
gtk.
Universally querying all a11y descs on load to potentially replace
%PRODUCTNAME in a11y descs at runtime led to tdf146971 which was a huge
startup slowdown.
The half way 7.3 fix was to leave a11y descs alone, but do the
replacement when querying for the extended tip case. So the extended
tooltips were ok, but screen readers would still say a raw
"%PRODUCTNAME" text, hence the rewording effort to remove %PRODUCTNAME
from the a11y descs entirely for 7.4.
But there is now a few cases where some options paths exists in the a11y
descs which is not exactly correct wrt to the text shown in the options
dialog.
Reworking the options dialog to not have %PRODUCTNAME there at all and
updating everything to fit that sort of change would not be popular. So
move the cases where a11y descs really should have %PRODUCTNAME in them
out of the .ui files and into .hrc files and use specific
set_accessibility_description calls for them via ResID which will do
the %PRODUCTNAME replacement automatically.
Hopefully the a11y runtime cost for just this handful of cases is
negligible in the overall scheme of things.
Change-Id: Ieb17d26fd581cd5804a52b371b3bb5ea43023aa3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135432
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
My code comment about "drawable area" and Michaels bug comment
12 about the "frameGeometry()" usage were both half right. LO
expects the window's frame position and the drawable client area
size almost everywhere when "geometry" is involved. The frame's
border is stored in the decorations members of SalFrameGeometry.
Change-Id: Ic00ad1f1d74d7afadcaca0c01e1a41ea7f2833de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135434
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
SvxFont has code to handle these extra features, we just need
to call that
Change-Id: I45691efeeead3ea60ab838eeb081fa5f19a76b90
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135428
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
when we are passing the result to a string_view, it is pointless.
Change-Id: If2532f998343b49a2966e0c704f6f789af936e1e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135371
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
The existing labels refer to paragraph border, which is ambiguous
about where the border is located. Meanwhile these labels refer to
an area that is to the left and right of the paragraph text area,
which is well-defined (and explained in help). The change is to
indicate that these options position in relation to the regions
that are to the left and right of the paragraph text area.
Change-Id: Ica033f8f48d47fb3f65a26f93ebede26b9cf80fa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135161
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
This patch is part of a general effort to use
"Text Alternative" consistently in the UI.
The control names in the Description dialog for
Imagemap and the Imagemap dialog were both changed
to "Text Alternative". Tooltips were also added
for "Text Alternative" and "Description."
No change was made to the extended tooltip for
"Description", because this field is not exported
to HTML at present (tdf#149013)
Change-Id: I2c5931efec93cff6b1ff1bf905de770d939b9b93
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135155
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
Tooltips are added in the Options tab in the Properties dialog for
images, frames, and OLE object. The extended tooltip for
“Text Alternative” is corrected, and an extended tooltip for
“Description” is added.
Change-Id: I8a14f3aa57aa7414ab2cf4251189d845269788d6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135073
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
The "UnitTest" service is implemented as a new
Basic library called 'SFUnitTests'.
ScriptForge unit tests (SF_UnitTest class module)
======================
Class providing a framework to execute and check sets of unit tests.
The UnitTest unit testing framework was originally
inspired by unittest.py in Python
and has a similar flavor as major unit testing
frameworks in other languages.
It supports
- test automation
- sharing of setupand shutdown code
- aggregation of tests into collections.
Both the
- code describing the unit tests
- code to be tested
must be written exclusively in Basic
(the code might call functions written in other languages).
The code to be tested may be released as an extension.
It does not need to make use of ScriptForge services.
The test reporting device is the Console.
Definitions:
- Test Case: each test case is a Basic Sub.
- Test Suite: a collection of test cases stored in 1 Basic module.
- Unit test: a set of test suites stored in 1 library.
Two modes:
- the normal mode ("full mode"), using test suites and test cases
The UnitTest service is passed as argument to each test case.
- the "simple mode" limited to the use of the Assert...() methods.
Service invocation examples:
- In full mode, the service creation is external to test cases
Dim myUnitTest As Variant
myUnitTest = CreateScriptService("UnitTest", ThisComponent, "Tests")
' Test code is in the library "Tests"
' located in the current document
- In simple mode, the service creation is internal to every test case
Dim myUnitTest As Variant
myUnitTest = CreateScriptService("UnitTest")
With myUnitTest
If Not .AssertTrue(...) Then ...
' ...
.Dispose()
End With
Error handling
To support the debugging of the tested code, the UnitTest service, in cases of
- assertion failure
- Basic run-time error in the tested code
- Basic run-time error in the testing code (the unit tests)
will comment the error location and description in a message box and in the console log,
providing every test case (in either mode) implements an error handler
containing at least a call to the ReportError() method.
Change-Id: I9d9b889b148f172cd868af455493c8c696d1e953
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135365
Tested-by: Jean-Pierre Ledure <jp@ledure.be>
Tested-by: Jenkins
Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
* Update helpcontent2 from branch 'master'
to 02043ac2c6e34f4ae96abe2bdc5737e35bc01e9e
- Fix typo in AutoCorrect help page
Currently the help page uses "Clear" for a checkbox option. However, "Uncheck" is more suitable here.
Change-Id: If4a54e61ba96e5d9b4d76d175b165cb9a0cdbcbf
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/135374
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
So if the dialog is widened the Structure tab can display more
details.
Change-Id: I857ca525fea8badc229328ab4c822b7de0b2cc0b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135369
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
... instead of hard coded ',' and ';'. And truncate / append "..."
after separator, not at.
Change-Id: I62f8c00f108165102d3b6a8b73b82774b8973a67
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135370
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
This commit also tests
- 6079bf6879
"Add binary operators to ForceArrayReturn handling, tdf#149378
follow-up"
- a15ce15709
"Propagate ForceArrayReturn only for Value parameters, tdf#149378
follow-up"
- bac202275b
"Propagate inline array only for Value parameters, tdf#149378 follow-up"
based on their commit description
Change-Id: Ie69868460ae87a67b31e0bd30a66644e89ea60ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135368
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
