Opening Data Ranges dialog window of a chart with
deleted data table crashed Writer immediately.
Follow-up to commit 5b9855acc7
"tdf#132714 sw: fix crash at table row deletion associated
to a chart".
Change-Id: I96e901db75d40ae234f58827a957204bca13aa92
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147893
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
This suite is large enough so that avoiding the
declaration/registration/definition of each test manually saves a lot of
space.
Change-Id: I72b88eb4c369f45daa31c984b9e1021e66faafcc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147880
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
PERCENTILE() and QUARTILE() if an error was passed as argument (or
an error encountered during obtaining arguments) omitted to push
an error result, only setting the error.
Fallout from
commit f336f63da9
CommitDate: Thu Mar 3 16:28:59 2016 +0000
tdf#94635 Add FORECAST.ETS functions to Calc
Change-Id: I23e276fb0ce735cfd6383cc963446499dcf819f4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147922
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
Added to make
GeoTexSvxGradientElliptical
GeoTexSvxGradientSquare
GeoTexSvxGradientRect
work using the MCGR. It is still 100%
backward-compatible, so as long as there is no
source using this it will stay invisible - by
purpose.
Tests look good with all three, see the static
variable nUseGradientSteps.
NOTE: GeoTexSvxGradientElliptical still looks not
optimal due to texture back-mapping method
getEllipticalGradientAlpha, see notes in
commit "MCGR: Adapted GradientRadial to make use
of MCGR" ac824594c5
Change-Id: I56b82b867af88fe532f840dde15e0f5c299ed6a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147662
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
something in the paste stuff seems to need UI events to be
processed
Change-Id: Idf10a240ff049bd52873296619f8f820142fda7f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147918
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This suite is large enough so that avoiding the
declaration/registration/definition of each test manually saves a lot of
space.
Change-Id: I6e9c18fa0195b2e8ae44ba2782c725f6cec8d471
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147879
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Since f281d2d24c
"Actually we shouldn't always set Overlap flag on for all xlsx
charts..."
Change-Id: I3e68ff99b18033879d85e3b9d40afa5a3d25b14d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147878
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Using mouse, e.g. simply moving the mouse pointer
during editing a chart with a deleted data table
crashed Writer immediately.
Follow-up to commit 5b9855acc7
"tdf#132714 sw: fix crash at table row deletion associated
to a chart".
Change-Id: I6d89eabc84565c548e2d9ded922789d623367ce4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147882
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
on tb93:
/Volumes/tdf_builds/lode/jenkins/workspace/lo_gerrit/Config/macosx_clang_dbgutil/test/source/xmltesttools.cxx:165:testTdf78510::Load_Verify_Reload_Verify
equality assertion failed
- Expected: 2306
- Actual : 3110
- In <>, attribute 'x' of '//textarray[1]' incorrect value.
Change-Id: I5c01766de48da7e2367f80512aef81f5a327e870
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147883
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
Tested-by: Michael Stahl <michael.stahl@allotropia.de>
and SmLocalizedSymbolData cannot even be instantiated. It is better off
as a namespace, rather than a class.
Change-Id: I4d6daace649e3529cefe67cf18eed85f2cbfc980
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147857
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Rearranged the content so the size is now defined
by the longest strins only
Change-Id: I2fd6f8bd0838c13f2e7f7c370ac7aa547b7e6a7d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147505
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
The GetString method is only used in DDE context; and allowing it to
handle Anys with OUStrings generalizes the fix, simplifying its use.
Change-Id: I50952c25fa736a9ca73515801cc1b1903c62453e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147753
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
When deleting sheets, the message is adapted to the count of selected
sheets (singular or plural).
The confirmation message is skipped if selected sheets are empty
The message for pivot table data losing is replaced by regular
confirmation message if both pivot table and data are selected
Update UItests when there is no more confirmation
Change-Id: I5cbd6d7cbe271ad86c5c68820b23df5a2307f3bc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147309
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
Once a floating table with a single cell wanted to span over two pages
("split row"), SwTextFrame::SplitFrame() was called, but then the table
split failed because everything moved to the next page.
The reason for this was that we tried to grow the text frame (and all of
its parents: cell, row, table, fly), but a non-test growing a fly
normally just works by recalculating its size based on the content,
ignoring what growth is wanted.
This is fine in the non-split fly case, but we do want to increase the
size of a split fly to control what content remains in the current fly
frame and what goes to a follow fly frame.
Fix this by extending SwFlyFrame::Grow_() so it grows more than just its
own content in the split fly case if the request wanted that. Now a
single row can split, but the position of the follow fly frame is still
bad.
Change-Id: I1c6aa61996dab058c291331a795627d3fae1bca8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147858
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
This is my first go at adding anything to the UI.
(I've done some fixing of other people's design,
but never created anything new myself.)
I took all my inspiration from Miklos'
add110bad8.
In the first iteration I did a fancy "same as id"
scenario. But ID-as-unsigned, securing unique IDs,
and English-only number recognition
sadly made me decide to drop the fancy features.
Now, both are simple, stand-alone spinbuttons
that depend on tooltips to guide user input, not fancy comboboxes.
It is important for the ID to display as unsigned,
since that is how it is used as a "name" in VBA.
It should be copy-pasteable for use in VBA programming.
It is useful for the TABINDEX to display as signed,
since it allows entering a -1 to disable tab navigation to the control.
make UITest_sw_ui_misc
Change-Id: Ia7c99888e60c33ac39616b24c7c1715604c3ec69
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147591
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* Update helpcontent2 from branch 'master'
to a2868f03eda97185d96cf661624e3c8668876294
- This sentence is missing a subject
Change-Id: I2eb66e5ced49809b86a3cdb48103381646b965a2
allocate it inline, it is only one pointer in size
Change-Id: Idb6217e6c9c37da92427aa6c497223a84015c553
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147742
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
* Update helpcontent2 from branch 'master'
to 19fc476019704c84f0a4aad9846b2dac579d19a3
- Clarify that it's "character key"
See e.g. https://ask.libreoffice.org/t/88505, where people expect
capital letter in mnemonics to mean "exactly capital", i.e. with Shift.
Change-Id: Id42c3aeaad6d04a4df58780f5ce5aca71532366b
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147835
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
move sanity check inside CountTTCFonts so it applies
to the fd smuggle in via filename mechanism
Change-Id: Id2fee5801d71720747a8736859681e7c9a324bc3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147740
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
This reverts commit 3f9a8a3b76.
Reason for revert: Needs more work, currently causes all ssXX and cvXX to be added to font string when the dialog is used.
Change-Id: I07eff710a2813e60fa4de3c23eb0a3c31d40e41d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147810
Tested-by: Jenkins
Reviewed-by: خالد حسني <khaled@aliftype.com>
