and remove CppunitTest_sc_bugfix_test, which is no longer needed
Change-Id: Idb1cff6580c621e325ce0b836695190d25467a0a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148035
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Remove the `Qt::WindowMinimized` state from the widget's
window states if the `SalFrameToTop::RestoreWhenMin`
flag is set to request restoring the minimized window.
Change-Id: I0cb67f28c1e9c3f48a9a234702a4aaa7e3ffec8d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148036
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
to reduce pointer chasing - these values are all small
Change-Id: I96782494f26666657bf35c06136b4b87f29fdd2a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148039
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
it is only one pointer big
Change-Id: I21afdeb8015c658c7b9d5db24bceeb8e43694272
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148038
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This changes the import to directly fill values of a model::Theme
and model::ColorSet, without filling the oox structs first. The
goal is to get rid of the oox in the long run, but for now it is
necessary to keep reading into both, which is a duplication.
The next step is to also fill the FontScheme and FormatScheme
structures.
Change-Id: I488ec096cbc184bc70d24510ac9091a488540422
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147571
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
it is only one pointer big
Change-Id: Ic7653a59ceebcc4cd7911fabdfc49537c244f960
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148037
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Remove visual artifacts around the corners by using horizontal and
vertical round.
Change-Id: I9821103c43dfbd93e6f295034b05da8b74e802e4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148040
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Always when you call build or logerrit, then the windows-links
overwrite with linux-links, but when you using GIT for Windows
you need the windows-links.
This patch made a check it is using GIT for Windows, and check what
for link it is, when wrong link, it output the .git-hooks/README
Improve the check for links, when a link is set not need to set
the link anymore
In .git-hooks/README improve the FOR with delete of the wrong link
look here for GIT for Windows:
https://wiki.documentfoundation.org/Development/BuildingOnWindows/de#Cygwin_and_git
Change-Id: I9f6ef9aca316058ef74cb2b2d107236f03a2e2ee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147458
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
- in SwFramePage, add a new m_xFlySplitCB and bind it to the flysplit
from the UI description
- map RES_FLY_SPLIT from the doc model to this new weld::CheckButton
- disable the widget for anchor types other than to-para, also
completely hide it, unless a frame contains a single table, which
simplifies Word filters
- add UITest for this
Change-Id: I9ef44b5c66679b04c4818dc343870b92f1b6386d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148030
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
no need for the pimpl pattern here
Change-Id: I8b18df1dc4769bc6f3cc49c1d59910a0cd61d471
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147969
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Changing e.g. the HoriOrientPosition property resulted in a layout
update, but setting IsSplitAllowed to true had no effect on the layout.
The problem seems to be that the new RES_FLY_SPLIT is not handled in any
update notification.
Fix the problem by initially handling this the same way as RES_FRM_SIZE
is already done, that triggers a 2nd page when a large fly frame is
newly allowed to split, for existing fly frames as well.
Disabling needs more work, still.
Change-Id: I2cba04213286e72384a56a28f2b321f7fd577639
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148029
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
Set the filter option explicitly, rather than inferring it from the test
name.
Change-Id: I4af0edce4316b7717512db70e8ad970126e2b3e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148018
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
For a document it is expected that it always has a theme available
so we need to create a theme with some default attributes set (a
default color scheme for now) when we create a SdrModel and SdrPage
(only for Writer currently).
This also changes some ColorSets, SdrPage, SdrModel methods, to use
better return types (cost& instead of raw pointers and vice versa
depending on the use case).
Change-Id: I874247784b845109e42567e3f45647dda46ccf3b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146816
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
add tooltip for this label, and revise extended tip
Change-Id: Ibff5bac33193df749d7a4117a205f58c0592aefb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147852
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
This suite is large enough so that avoiding the
declaration/registration/definition of each test manually saves a lot of
space.
Change-Id: I842b45e14e1d05de8d8bfd7c1e2baa6da6e1c6f9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147996
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
This was added in d15f4fc67d
"add disabled test code for tdf#40110" already commented out
if the test is enabled, it will fail because fdo40110test.ods
and fdo40110test.csv were not included in the commit
Change-Id: I11e7860bdfa710a78da1a04f72e9eea5bc00d037
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147967
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
...which isn't needed anymore to suppress warnings from other plugins like
loplugin:external ever since 45c06838e9 "only
unit-test one loplugin at a time". Also, the declaration of the function test
in cppunitassertequals.hxx had already started to deviate from its definition in
cppunitassertequals.cxx.
Change-Id: I3fbc8a9a805bd5bc4d8afbf958edff04b89add3f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148010
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Modify the hack from commit ce95e39f8e
(tdf#44282 fix missing space for numbered lists in TOC, 2016-08-16),
which added the space after entry numbers unconditionally.
There are other possibilities, like custom separators between the entry
number and text (e.g., [E#][T][E][T][#]); or the entry number (maybe
with limited depth) used with page number (like in [E#][E][T][E#]-[#]).
Generally, when entry number is not immediately followed by entry text,
the space is not needed.
Additionally, the space is not needed when the number text already ends
with a space character.
Change-Id: Ifa6c474574bfb74466ab721eca49f421a3750942
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147997
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
an empty vector is only 2 words big
Change-Id: I3e4a9d42b9ecb44c57ce11c400a17a4c8b053eca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147972
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
an empty vector is only 2 words big
Change-Id: Ib8309d0819c88fe6a4f7cd322c37dd52190bd060
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147971
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
There were a few remaining DeviceFormat::DEFAULTS in remaining in
IOS blocks after commit 00659bcdbb
Change-Id: I29e1f2bd6d4ce20dea7a45ce17bc6f3b929859c6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148008
Tested-by: Jenkins
Reviewed-by: Patrick Luby <plubius@neooffice.org>
maven central so far doesn't support ipv6 on the primary URL (see
https://issues.sonatype.org/browse/MVNCENTRAL-658 ), it is only enabled
on a dedicated ipv6.repo1.maven.org URL currently.
Add that one to the list of repositories so that ipv6-only hosts can also
fetch the dependencies.
(when using internal ipv4 as well, you'll also need to export
JAVA_OPTS="-Djava.net.preferIPv6Addresses=true"
since otherwise the gradle wrapper fails to download gradle)
Change-Id: I22f0e07fd4e6bb518396f76db20c174e45588372
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147917
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
soffice.bin: /home/ms/lo/master/svl/source/items/itempool.cxx:822: const SfxPoolItem& SfxItemPool::GetDefaultItem(sal_uInt16) const: Assertion `!"unknown which - don't ask me for defaults"' failed.
Because editeng doesnt have RES_MARGIN_TEXTLEFT yet and it's mapped to a
slot id so the dialog works...
Looks like this TABS_RELATIVE_TO_INDENT doesn't exist in editeng anyway.
(regression from commit db115bec92)
Change-Id: I64169a4d6f4663adaa2a17786836c2dcc7e1f394
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148006
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Table rows exported with an extra empty cell, if there was a
nested table in them (and not in the last cell).
Partial revert of commit 1f77a5e8d5
"n#203704 fix RTF export table output for subtables".
Note: the partially reverted code was for the old table format
(used before OOo 2.3). This old format is partially converted to the
new table format since commit e366c92881
"sw: ODF import: convert the simplest sub-tables to rowspan tables".
Change-Id: I63ebefbb99e1a95cd60ce8d8dc34c307573d4b58
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147887
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>
