which indicating unit test fails.
Change-Id: I2689b0dda888e15e52ca60cc18e1705a1aefe968
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173143
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
Tested-by: Jenkins
This partial revert fixes a 24.2.4 regression from
commit 72ea1005b9
Author: Michael Stahl on Mon May 6 15:58:36 2024 +0200
tdf#160402 writerfilter: extend StyleMap with all Word styles
Footnote anchor character formatting is controlled by
the character style set in Tools - Footnotes Settings.
The default name of that style is UI dependent,
so only the English UI was importing properly
when the localized name was used in the mapping.
"Footnote Symbol" is the internal name - both the internal name
and the localized name are find-able at the same time,
so the only things that will have a problem are things
that don't connect to the style, but just hold the string name.
The unit test change is also a revert from mstahl's commit.
make CppunitTest_sw_ooxmlexport9 \
CPPUNIT_TEST_NAME=testTdf109310_endnoteStyleForMSO
and is an indication of another problem that this fixes,
namely that a new Footnote Characters style is added
with each round-trip.
Bug 162884 was only reproducible with a non-English UI.
To reproduce, I compiled with autogen.input
--with-lang=de
Thus no unit test...
Change-Id: I63d37f13f435ff7ec41d6b22d74db83dc495150a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173141
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
we already statically know the types of all these objects
Change-Id: I976dbf2b150fcd2176df18a07c2e9f21b1d2fe65
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173214
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
If an `XAccessible` doesn't have a context or
`XAccessibleContext::getAccessibleIndexInParent()` returns
an invalid index of -1, don't crash/assert, but
let `lo_accessible_get_next_accessible_sibling` return
`nullptr`.
This works around potential bugs in underlying
`XAccessible`/`XAccessibleContext` implementations for now.
This is meant to fix the assert/crash seen in the backtraces
attachment 196363 and attachment 196383 from tdf#161256
which I cannot reproduce locally on Debian testing.
Change-Id: Ic1779d875161469bf296c558039e19f1d426a259
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173216
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
In `AccObjectWinManager::InsertAccObj`, when no HWND
was explicitly passed, it is attempted to retrieve the
HWND from the parent's `AccObject`.
If no parent AccObject exists yet, create/insert that
one first.
This fixes the following assert seen when using NVDA's SayAll
feature to read the whole document with sample document mentioned in NVDA
issue [1], also attached as attachment 196385 in tdf#91739
for reference:
Assertion failed: pIAccessible && "Couldn't retrieve IAccessible object for relation target.", file C:/tools/cygwin/home/user/development/git/libreoffice/winaccessibility/source/UAccCOM/MAccessible.cxx, line 2755
It's also reproducible when manually trying to get the next
flows-to relation target via NVDA's Python console when the
first cell in the table has focus:
>>> focus.flowsTo
The issue is not reproducible when focus had been in the
second cell before, as an accessible object has already
been created otherwise in that case.
Backtrace:
1 abort ucrtbase 0x7fff3b72286e
2 get_wpgmptr ucrtbase 0x7fff3b7241b5
3 wassert ucrtbase 0x7fff3b7244f1
4 CMAccessible::get_relationTargetsOfType MAccessible.cxx 2755 0x7fff1e028729
5 NdrSendReceive RPCRT4 0x7fff3d4ca2d3
6 NdrStubCall2 RPCRT4 0x7fff3d4625a7
7 CStdStubBuffer_Invoke combase 0x7fff3cfbc4ac
8 RoGetAgileReference combase 0x7fff3cf669c3
9 RoGetAgileReference combase 0x7fff3cf6674e
10 HSTRING_UserSize combase 0x7fff3cfbefb6
11 DllGetClassObject combase 0x7fff3cf470b3
12 CoWaitForMultipleHandles combase 0x7fff3cf6774d
13 RoGetActivatableClassRegistration combase 0x7fff3cf2eb26
14 CoGetMarshalSizeMax combase 0x7fff3cf5cfba
15 CallWindowProcW USER32 0x7fff3ccbef5c
16 DispatchMessageW USER32 0x7fff3ccbe684
17 ImplSalDispatchMessage salinst.cxx 475 0x7ffed452d378
18 ImplSalYield salinst.cxx 552 0x7ffed452da9d
19 WinSalInstance::DoYield salinst.cxx 581 0x7ffed452cfa1
20 ImplYield svapp.cxx 385 0x7ffed78befc4
21 Application::Yield svapp.cxx 474 0x7ffed78c2cd2
22 Application::Execute svapp.cxx 361 0x7ffed78bc656
23 desktop::Desktop::Main app.cxx 1691 0x7ffeecf689b7
24 ImplSVMain svmain.cxx 228 0x7ffed78d3d4c
25 SVMain svmain.cxx 261 0x7ffed78d45a2
26 soffice_main sofficemain.cxx 121 0x7ffeecfb9064
27 sal_main main.c 51 0x7ff782681013
28 main main.c 49 0x7ff78268105a
29 __scrt_common_main_seh exe_common.inl 288 0x7ff782681344
30 BaseThreadInitThunk KERNEL32 0x7fff3bb07374
31 RtlUserThreadStart ntdll 0x7fff3d85cc91
[1] https://github.com/nvaccess/nvda/issues/8152#issuecomment-2342167620
Change-Id: I246251f06d1885e0da96600ffc7dd0549854382f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173224
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
The `AccObject` ctor already asserts it's non-null,
so there's no need to check again in various places.
Change-Id: Ibba363d326198a89e391a4da54cff25c95eef776
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173223
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
... and rename to use the "x" prefix for this uno::Reference.
Change-Id: Ibf422aa48d6fbada49975fa8c5f43ad6c4c3ddee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173222
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
... and rename the variable to use the "x" prefix
in line with naming conventions.
Change-Id: Ife49161162654efdf1d543909218e31e464d2fc3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173221
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
This change adds a new button, Group, to the Asian Phonetic Guide.
Clicking on this button will automatically merge all base text runs into
a single base text run.
Change-Id: I8bc2881f0c31d501f8a347156145a483bb4c96cb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173241
Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
Tested-by: Jenkins
* Update helpcontent2 from branch 'master'
to 4a1a76e6b7c74f0903b7695f137160e4c7e622f7
- tdf#162607 Remove dup's in hid2file.js Standard filter
+ Deleted shared/02/12090000.xhp because 12090100.xhp has much more info and duplicates contents
+ rebuild links to reach 12090100.xhp
+ renamed references to Default filter to Standard filter.
+ add section to standard filter icon for embed purposes
+ refactor
Change-Id: Ib88b7574fa12910c4cf9c8af9cbf79577b600e4b
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173237
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
* Update helpcontent2 from branch 'master'
to f0cce1baf94f2645e5eac9bd3dbc72de359179b5
- tdf#162607 Remove dup's in hid2file.js, NewTableDialog
+ Removed bookmarks not appropriate
+ moved some <ahelp> to UI and deleted here
Change-Id: Ic85a4c43cd4861cefa1bf67348d386464234ed65
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/173236
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
ScSolverUtil::GetDefaults should also accept values of types BYTE and SHORT. It currently only accepts LONG.
As described in the bug ticket, this is important when creating Solver extensions using Python, since pyObject2Any forces small integer numbers to be either BYTE or SHORT instead of LONG.
Change-Id: I17c7a344777c31ea333a4d21a2543d2de0b448fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173093
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
On Writer, when in readonly mode with comments activated restrict
the hability to delete comments to only those made by the same user.
Change-Id: Iaefb1166c680726c9c73a305ef67be812d3b97d2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172596
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit f93d46429c68770dd432fa6e7edcfc876891f8e1)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172890
Reviewed-by: Andreas Mantke <andreas.mantke@googlemail.com>
Tested-by: Jenkins
Reviewed-by: Jaume Pujantell <jaume.pujantell@collabora.com>
The localizable string is to allow different position/precision of the
components; but the localization of the symbols themselves (decimal
and thousand separator, currency) happens in code.
This comment is shown in Weblate UI.
Change-Id: Ib2f62fc8edf12ad3b182b40e3a8981c43b7ed67f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173104
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
aFormMap is std::pair<SwPosition, sal_uInt32> and GetTabIndex returns
sal_uInt32, so change nCurTabIndex to sal_uInt32 and continue use of
SAL_MAX_UINT32
Change-Id: Ie404e8b649f37f753f943f90a648114f080ed6b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173185
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Until we support the correct inline formulas, their import fails badly
in Impress, because we completely lose them in boxes with other content,
and even where they are the sole content, they stretch to the size of
the box incorrectly.
Commit 4038d6c393 (tdf#117658 PPTX import:
fix duplicated math object handling, 2019-11-13) opted to enable the
Choice variant from the AlternateContent representing formula boxes.
This change switches to Fallback graphic, losing the option to edit
standalone imported formulas, but instead, allowing to see the formulas
as they were created in PowerPoint.
Unit test in sd/qa/unit/export-tests-ooxml2.cxx, created in commit
331a0a347e (starmath: fix OOXML export
of non-BMP Unicode, 2016-01-21) was changed, because it depended on
importing the formula from PPTX, which is disabled here. Since it
was fixing the export part, the FODP source seems to be a reasonable
replacement.
Change-Id: Ibd0e2bcd68296020c3bc057cb6a563918926cf2f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173163
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
doesn't make sense to compare to
std::numeric_limits<sal_Int64>::max
here, while sal_Int32 does
Change-Id: Ic19beb6c2a0a46c5b45d37e833d566d91ddc10cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173161
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
Also fix getting the slides, so we don't rely that a WeakReference
is set, as it is not set (yet) when running the test.
Change-Id: Icd338e31fbd0bb7c45a06357b955b85081ed38c9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172868
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
This finally allows removing the hack for the LOK case in
SfxObjectShell::CheckIsReadonly() to show the signatures dialog
read-only.
Also fix a case while signing PDFs where the file stream was on the
stack, but now that we finish signing in an async callback, signing
crashed due to a use-after-free.
Fix that by giving the std::unique_ptr to the utl::OStreamWrapper ctor,
which knows to take over ownership in this case, and that wrapper is
reference-counted.
Next problem is that the add/remove buttons in the dialog are still
hidden in the LOK case, that's not yet fixed here.
Change-Id: I71ee50ae55d4e62f5d265a35e3810e3b2b63a9b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173155
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Fix wrong border line styles if we have merged cells.
Change-Id: I238aa08c65b9aefd7b77b0f4ae3c3df979a7171d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173109
Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
Tested-by: Jenkins
This reverts commit 91f0b84675.
Reason for revert:
commit 6ca8cf32d2
Author: Caolán McNamara <caolan.mcnamara@collabora.com>
Date: Mon Sep 9 13:33:47 2024 +0100
tdf#162732 force centered alignment for donate button text
bit of a bodge, gtk defaults to baseline alignment here, so force
what we want instead in a separate "Donate" button.
Change-Id: I6301d158e97c279a86f8fe541ce336bdd3535645
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173094
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
