Commit graph

451433 commits

Author SHA1 Message Date
Stephan Bergmann
38cfe86259 Upcoming improved loplugin:staticanonymous -> redundantstatic: package
Change-Id: Ie183cb0d374e8d9a02891a765f46583f7cc1c345
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97618
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01 19:49:56 +02:00
Noel Grandin
a380b4e972 reorder parameters of SvXMLExport::SvXMLExport
so they all have similar order

Change-Id: Id8baef058d52f6cce9d9be41b0341eec8ad648b6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97628
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-01 18:40:30 +02:00
Regényi Balázs
d63321d949 tdf#133863 tdf#133864 DOCX shape import: width relative to inside
and outside margins.

See commit 43d7f4e364
(offapi: document the 4 new properties which are no longer read-only).
commit b46f4bc976
(tdf#133070 DOCX import: fix shape height relative to bottom page margin)
commit 330ed8120e
(tdf#133670 DOCX import: fix shape width relative to right margin)
commit 7380905abc
(tdf#132976 DOCX import: fix shape width relative to left margin)

Co-authored-by: Szabolcs Tóth

Change-Id: If81b7c80732141be1491ca82770cf6eee99f5656
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97627
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
2020-07-01 18:33:59 +02:00
Caolán McNamara
b8db739c20 don't use a variable called 'min' to store a max value
Change-Id: If21dcd572147d8aeffd2fe2c30b3c8f7b2366960
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97626
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-01 18:05:23 +02:00
Caolán McNamara
d2f1cd0043 weld EditControl for browsebox
Change-Id: I8f21c12f7ee10e1b9ba883a8ff01bb5252429f09
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97353
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-01 18:04:46 +02:00
Stephan Bergmann
96dc14a041 Adapt solenv/flatpak-manifest.in to recent download.lst changes
Change-Id: I6490a4d6151ae163053f12c872477f2bbfcb3d95
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97630
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01 18:02:55 +02:00
Jan Holesovsky
cae77280d1 android: Add a CP x86 configuration too.
Change-Id: I8d584811244cd613b8637d9dd2cf1bfe1985ecec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97610
Tested-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit 9213bfce95)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97579
Tested-by: Jenkins
2020-07-01 18:00:09 +02:00
Stephan Bergmann
4332375ace Adapt Flatpak build to new Box2D external requirement
...introduced with a7f2239e64 "external: bundle
box2d"

Change-Id: Ia1a46dc517073d3cf7f221d3f7275741e94995a1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97629
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01 17:41:25 +02:00
Olivier Hallot
2cc95ef7f0 Update git submodules
* Update helpcontent2 from branch 'master'
  to 659dba3909b17d8a3206572b9b6de5acad3db590
  - Capitalize funciton name
    
    Change-Id: I48c456ecdd591b84315f95b15013d708e6028cb4
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/97641
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-07-01 17:20:45 +02:00
Jan-Marek Glogowski
17b75eb1d7 tdf#130991 Fit the drop-down arrow into its rect
Looking at the original fixed-size arrow painting code replaced
in commit b62c43d120 ("Anti-alias
toolbar button drop-downs."), it  used some fixed values of 5
and 3 to match the arrow box width of 11.

The new code assumes the width is the expected arrow size, minus
a minimal margin to separate the arrow from the button border,
and there is enough height available. Based on these assumptions,
the code now scales, positions and paints the triangle to fill
the available space.

Change-Id: Ied721e494d105106086ef6252e72ae7395eafe08
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97537
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-07-01 17:18:15 +02:00
Olivier Hallot
53d5e2db91 Update git submodules
* Update helpcontent2 from branch 'master'
  to 93dc60612485b96089088ec8c316e62b836b9bc4
  - mute l10n in some lines of Basic
    
    Change-Id: Ibdf0ffcf32e47174c3572d95e9afeaa366a109d9
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/97640
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-07-01 17:12:40 +02:00
Stephan Bergmann
71999016fe Upcoming improved loplugin:staticanonymous -> redundantstatic: pyuno
Change-Id: I188716d5da92d495b9511f000dd9c1a78259fa9c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97621
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01 16:43:14 +02:00
Olivier Hallot
eac284aa00 Move ahelp contents for ext'ded tooltips QR code
Copy <ahelp> contents of the QRcode Help page to the
AtkObject::accesible-description field in qrcodegen.ui file
for each applicable widget.

Such move will turn <ahelp> tag obsolete, althout its contents
should be preserved.

helpcontent2/source/text/shared/guide/qrcode.xhp

Change-Id: Icded2e6bfd6c5c0e525a8174bea44a2997217510
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97526
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-07-01 16:37:20 +02:00
Olivier Hallot
6fabad9e9d Update git submodules
* Update helpcontent2 from branch 'master'
  to 5e74f53b93134f1174f477fcbf54e93f06a4c707
  - tdf#134376 Add Calc cell style Help page
    
    Change-Id: I57f32bdfc4435cbe21b7cca1cb5170892e69447d
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/97622
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-07-01 16:36:37 +02:00
Miklos Vajna
c540483134 configure: add a --with-product-flavor switch
Defaults to Personal to point out this is supported by volunteers.

This affects the splash screen, the window title, the about dialog and
the start center.

Change-Id: I216a7f547618377ed268454ebfd2801c4c3901b7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97427
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-07-01 16:35:13 +02:00
Stephan Bergmann
b551604a81 Upcoming improved loplugin:staticanonymous -> redundantstatic: lotuswordpro
Change-Id: I5b68c490b534da933de4f26e01328dfb2976dafc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97616
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01 16:17:39 +02:00
Stephan Bergmann
6a9f71f232 Upcoming improved loplugin:staticanonymous -> redundantstatic: linguistic
Change-Id: I9f179db10c55f41e07c1f7fd519a58d68b7e6ad9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97614
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01 16:16:34 +02:00
Caolán McNamara
7bbe1e6b98 name:border hack no longer in use and can be retired
since...

commit 3c5e074a8f
Author: Caolán McNamara <caolanm@redhat.com>
Date:   Fri Jun 19 12:37:05 2020 +0100

    weld DataNavigator

Change-Id: I5541ed81d695e6d3bae978888aca866df08c1f8d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97597
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-01 16:16:12 +02:00
Xisco Fauli
6f9d03561f tdf#126504: sw: Add unittest
Change-Id: Iceca8bc3ae2dcad04040498565200361157f83e9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97613
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-01 15:44:45 +02:00
Xisco Fauli
c131d6c6b9 tdf#131424: sc: Add unittest
Change-Id: Ida3df74d44ca027de68f9b5f96a352452d747bfd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97595
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-01 15:26:53 +02:00
Luboš Luňák
ee2d218413 don't add a cell to a non-existent column (tdf#104865)
This change also needs invalidating column position hints if
the columns get changed by the copying of the cells.

Change-Id: I4793e25f253c0197d88b313bc9336435cef649f4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97603
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-07-01 14:59:10 +02:00
Miklos Vajna
3b7c81b953 sw doc model xml dump: show SdrModel of embedded charts
Change-Id: Iae9daefb9b2173736c039d6177d7356c27eb7a33
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97605
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2020-07-01 14:56:23 +02:00
Stephan Bergmann
5ab5f2d865 Upcoming improved loplugin:staticanonymous -> redundantstatic: lingucomponent
Change-Id: I70423a669527f2ce6ec25f58b8c409c0e2231962
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97604
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01 14:17:38 +02:00
Eike Rathke
80496ca9cd Update git submodules
* Update helpcontent2 from branch 'master'
  to b59586b7da5b2fe01ffb0c55ae522b5e82bead0f
  - Adjust OFFSET() note to reality
    
    It was never necessary to enter OFFSET() as an array formula if a
    cell range reference is returned. Whether to use an array formula
    entirely depends on how the resulting range(s) are to be used as
    arguments to calling functions.
    
    Change-Id: Icb771c680f1b9c076017ebd2c78f440529ecc1b2
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/97620
    Reviewed-by: Eike Rathke <erack@redhat.com>
    Tested-by: Jenkins
2020-07-01 13:58:51 +02:00
Stephan Bergmann
c4304e8ad9 Upcoming improved loplugin:staticanonymous -> redundantstatic: libreofficekit
Change-Id: I113905b8e13f65f48529969fb93e66074dc6407d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97601
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01 13:27:53 +02:00
Stephan Bergmann
9ec4372029 Upcoming improved loplugin:staticanonymous -> redundantstatic: l10ntools
Change-Id: I9b97f64f27dee5fe0c17ceaf93f7d137141be249
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97600
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01 13:20:34 +02:00
Stephan Bergmann
b122a39c33 Upcoming improved loplugin:staticanonymous -> redundantstatic: i18npool
Change-Id: I8b93f7610103f4bd8e86e2d9f57929922b6dc92c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97568
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01 13:20:18 +02:00
Stephan Bergmann
74512c394d Upcoming improved loplugin:staticanonymous -> redundantstatic: jvmfwk
Change-Id: I979e9142324df589229aafbb4a17f7495a79f0dc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97594
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01 13:20:03 +02:00
Caolán McNamara
4d714c1d29 support has-frame for SpinButtons too
Change-Id: Id09ba9fa7bf0130cffd0f40dcfdcf5bdf0bc16b6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97598
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-01 13:06:23 +02:00
Jan-Marek Glogowski
4bb8bb043f tdf#134054 Qt5 really scale the toolbox button
I missed that code in the HiDPI patch. Instead of some fixed 25px
size, use the real content size and ask the QStyle for the real
size.

Change-Id: I227190baab2c1716aa40ef6d16d55dbded0830cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97538
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-07-01 11:58:42 +02:00
Jan-Marek Glogowski
1eba1c4597 tdf#130991 Scale the drop-down arrow size-request
When requesting the size of the drop-down arrow button, the arrow
rect must be scaled, like all other native size requests.

Change-Id: Ic0ccd96e812527c880868d385484655526ebb09b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97536
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-07-01 11:55:51 +02:00
Jan-Marek Glogowski
06fb3e7b7f tdf#132172 Qt5 just handle visible widget's focus
I investigated the state of isWindow() and the SalFrameToTop
flags for the detached find toolbar (tdf#126607) and the Impress
presentation and the tabbed "page size" drop-down and all had the
same status (isWin: 1, flags: 12). Than I had a look at the gtk3
implementation, which just handles focus requests, if the widget
is already mapped (gtk_widget_get_mapped).

So I also dumped the visibility as the nearest equivalent in Qt to
the X11 mapped state, and that was different. In the end Qt now
also just handles the focus for already visible widgets, like
gtk3, which works for all the cases I tested (incl. tdf#125517).

And omiting either activateWindow or setFocus breaks some cases...
and I still don't understand the GrabFocusOnly flag, which is just
handled in the X11 backends at all...

Note: this doesn't happen with 7.0+, because the weld'ed version
of that control (commit 3afc718edd
"rework PageSizePopup to be a PopupWindowController") doesn't
expose this bug (and also doesn't support mouse-over highlight).

Change-Id: Id085732f6a52bbc69ed47fbd3d57454756a03121
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97549
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-07-01 11:52:21 +02:00
Luboš Luňák
3dfc6d42ed update Skia to chrome/m85 snapshot
Change-Id: I3af3517c9c213e0db8365aecd0a008d817ca4dcf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97592
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-07-01 11:35:08 +02:00
Stephan Bergmann
3550a459db Upcoming improved loplugin:staticanonymous -> redundantstatic: io
Change-Id: I150aa3666a9e1acf5fba445b9a709ccd9d8c7e85
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97593
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01 11:33:54 +02:00
Andrea Gelmini
67f5f45505 Fix typos
Change-Id: I4f1c0d90fcb7726ceadd72c9cb9f96a57cade67a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97602
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-07-01 11:26:39 +02:00
Stephan Bergmann
b71c22923d Upcoming improved loplugin:staticanonymous -> redundantstatic: idlc
Change-Id: Id0716adf2b16839c1d940bc1d187bcc107ed79ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97591
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01 11:05:52 +02:00
Stephan Bergmann
df6d9c0d3a Upcoming improved loplugin:staticanonymous -> redundantstatic: i18nutil
Change-Id: I2264559759133cb6617e8a7db28a26749bb59191
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97590
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01 11:05:31 +02:00
Miklos Vajna
e18bc316ef Related: tdf#131175 OOXML chart: insert hatch definition into the right table
Both the chart and the containing document has one, but the intention is
to insert this into the chart one.

This is needed, but not enough to render the right hatch for data
labels.

Change-Id: I485d84e2ae33728963b648c05e730d418567fc0e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97569
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2020-07-01 10:37:05 +02:00
Caolán McNamara
194c9eecc3 Related: tdf#134360 table row/height widgets can get stuck insensitive
Change-Id: I1be53f33f60c510757c67f1da8f863539ecbffdb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97547
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-01 10:31:36 +02:00
Stephan Bergmann
7837676c15 Upcoming improved loplugin:staticanonymous -> redundantstatic: i18nlangtag
Change-Id: I06102a8b7fe8cffaf1fe72b32c997c6225d37d67
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97565
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01 10:21:18 +02:00
Regényi Balázs
b46f4bc976 tdf#133070 DOCX import: fix shape height relative to bottom page margin
using UNO API RelativeHeightRelation and the associated
lo-ext attribute for OpenDocument export.

See commit 43d7f4e364
(offapi: document the 4 new properties which are no longer read-only).

Co-authored-by: Szabolcs Tóth

Change-Id: I31db99fac5ad24971fa427671198b47906e9c057
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95451
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
2020-07-01 10:15:44 +02:00
Stephan Bergmann
04445c599f Upcoming improved loplugin:staticanonymous -> redundantstatic: hwpfilter
Change-Id: I6f5a81cf83d15b9c8a21bf0581c009bdfe03f4a4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97564
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01 09:58:45 +02:00
Stephan Bergmann
ae662de2f1 Upcoming improved loplugin:staticanonymous -> redundantstatic: framework
Change-Id: I71eaaa7cbc1c38e541291d48eb5f05157fd4c8c7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97563
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01 09:48:21 +02:00
Stephan Bergmann
38e5edbbb3 Upcoming improved loplugin:staticanonymous -> redundantstatic: filter
Change-Id: I345f4677b0ac32f8373fb13c6db07041247e3982
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97561
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01 09:47:53 +02:00
Xisco Fauli
f70b001fb1 tdf#134404: sw: Add unittest
Change-Id: I81e46e06ad7964e52b45ce3433a25758cc7d19fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97534
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-01 09:37:15 +02:00
Stephan Bergmann
7df1884118 Upcoming improved loplugin:staticanonymous -> redundantstatic: fpicker
Change-Id: Iea0c39a036c9e890ee3afee143923386d2ca775c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97562
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01 09:21:37 +02:00
Miklos Vajna
f4331e94ff Remove some unused includes
Change-Id: I44c9ad2511d484e3c7fb1c33f25fcb343eabd232
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97548
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-07-01 09:20:05 +02:00
Stephan Bergmann
45751ae0fd Upcoming improved loplugin:staticanonymous -> redundantstatic: emfio
Change-Id: Id7ceb329a6fa6f2af15bf4599ef97dcbd44fa64d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97559
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01 08:40:16 +02:00
Stephan Bergmann
6e6772e773 Upcoming improved loplugin:staticanonymous -> redundantstatic: editeng
Change-Id: Ic5294dc53b1a7b6c654619cde8ef5133c222ae1a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97558
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01 08:37:14 +02:00
Stephan Bergmann
d9693dada2 Upcoming improved loplugin:staticanonymous -> redundantstatic: drawinglayer
Change-Id: If00914a6eda240143fbde57215e015a36d588c9d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97557
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01 08:36:24 +02:00