Commit graph

451433 commits

Author SHA1 Message Date
Noel Grandin
9be078ae0d binaryurp: create instances with uno constructors
See tdf#74608 for motivation

Change-Id: Ide39715f83b0183f560e16fa69fcb3112496936d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97933
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-05 11:36:55 +02:00
Dennis Francis
ef740ac129 lokit: scPrintTwipsMsgs: LOK_CALLBACK_COMMENT
Allow print twips coordinates in LOK_CALLBACK_COMMENT

Change-Id: I052dacb311c651c49d61fd9937951fa5b81b32d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97967
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
(cherry picked from commit dd64235e32)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97978
Tested-by: Jenkins
2020-07-05 11:01:20 +02:00
Dennis Francis
e3601efee2 lokit: scPrintTwipsMsgs: LOK_CALLBACK_*SELECTION*
Allow print twips coordinates in the below messages:

LOK_CALLBACK_CELL_SELECTION_AREA
LOK_CALLBACK_TEXT_SELECTION
LOK_CALLBACK_TEXT_VIEW_SELECTION

Change-Id: I267a636bbeab434b305a45abe3e21cb5afc4c1e9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97966
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
(cherry picked from commit b10cd97344)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97977
Tested-by: Jenkins
2020-07-05 11:00:04 +02:00
Noel Grandin
a2d844ca71 basctl: create instances with uno constructors
See tdf#74608 for motivation

Change-Id: Ibada6b9b7e6c754487c90ce1a37c17019db55370
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97932
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-05 10:20:16 +02:00
László Németh
99d4bf9446 tdf#133524 AutoCorrect: fix Romanian nested quotations
typing " inside primary quotation marks: use
the correct order of the double angle quotes:

    „... «quote» ...”

Add also Aragonese, Asturian and Catalan to the
"<<" and ">>" replacement.

See commit 57f07b1d73
(tdf#133524 AutoCorrect: support double angle quotes).

Change-Id: I2e80cc45768eefa3eb62b446ca822ee6c46f7242
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97970
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
2020-07-05 10:10:43 +02:00
Dennis Francis
fdf39bcc9b lokit: scPrintTwipsMsgs: LOK_CALLBACK_CELL_VIEW_CURSOR
Allow print twips coordinates in LOK_CALLBACK_CELL_VIEW_CURSOR

Change-Id: I0373cbd2b87b4d1088af41453ab548274de6ca23
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97965
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
(cherry picked from commit 14b8f2009f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97976
Tested-by: Jenkins
2020-07-05 09:41:14 +02:00
Dennis Francis
ca8c1cec87 lokit: scPrintTwipsMsgs: LOK_CALLBACK_REFERENCE_MARKS
Allow print twips coordinates in LOK_CALLBACK_REFERENCE_MARKS

Change-Id: I1bf84c5aebe84ee034ac27932fa8a01d0a3ae831
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97964
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
(cherry picked from commit b461894caf)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97975
Tested-by: Jenkins
2020-07-05 09:40:14 +02:00
Dennis Francis
ff8ddf5253 lokit: do not set an artificial cursor size when it is zero...
when we send the message in print twips coordinates. It is important for
the client to know the exact position and coordinates to allow client
side print-twips -> tile-twips conversion when/if it is needed.

Change-Id: I6699894758886f1b5648ac9bf3c9e6ab4192c72e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97963
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
(cherry picked from commit d88cad2c19)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97974
Tested-by: Jenkins
2020-07-05 09:39:21 +02:00
Dennis Francis
b5020e0aab lokit: scPrintTwipsMsgs: LOK_CALLBACK_CELL_CURSOR
Allow print twips coordinates in LOK_CALLBACK_CELL_CURSOR msg.

Change-Id: Ib9de372db46db9d462983e15fb12d58624d066f5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97962
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
(cherry picked from commit 679738b5e0)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97973
Tested-by: Jenkins
2020-07-05 09:38:35 +02:00
Dennis Francis
a94216649b Allow cell coordinates calculation in print twips too
Change-Id: Ie8f23bd7ba8de57d7aab104add99501a54f08819
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97961
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
(cherry picked from commit 0722934920)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97990
Tested-by: Jenkins
2020-07-05 09:37:33 +02:00
Tor Lillqvist
6420c1edbf Bin leftover support for OS X on PowerPC
Change-Id: I2108aca1a7ce12fc0b028124170df502a6c46e60
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98012
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-07-05 09:12:46 +02:00
Tor Lillqvist
1c4aa5c2d5 We don't build OpenSSL for iOS but if we did, it would be arm64
Just for completeness. Did not check whether we actually could build
OpenSSL for iOS. As we have managed without so far there probably is
no need.

Change-Id: Icd41622e7336e723ccd5a3157e956c43f6f92a76
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98011
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-07-05 09:12:17 +02:00
Tor Lillqvist
95856ba49d Use up-to-date config.{guess,sub} for external/curl, too
Change-Id: I65741410e9ba14326a6ad7a676d1dfb10006e34f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97988
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-07-05 09:11:11 +02:00
Tor Lillqvist
2869eacfeb Set CROSS_COMPILE=1 when cross-compiling nss
Change-Id: Iad826eb83e4c49078e6c668661446b5b70e6a981
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97987
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-07-05 09:10:19 +02:00
Tor Lillqvist
429f5c788a Be more generic for CPUNAME=ARM64
It's used not just for iOS but can be macOS too.

Also, nss wants to call it CPU_ARCH=aarch64.

Change-Id: I6398c3bf1409f2ccf16b0d154ad7c2b56f493b15
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97986
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-07-05 09:09:51 +02:00
Tor Lillqvist
f019f4aa6e We don't actually build nss for iOS, but if we did, it would be for arm64
iOS is 64-bit only since long.

Change-Id: Ic0d9f69764951f420be10947c5b8889a3f95962c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97985
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-07-05 09:09:12 +02:00
Tor Lillqvist
bb649c3156 Use up-to-date config.{guess,sub} for external/nss, too
Change-Id: I387aba22b90ab1bde1ae3659ea06a5838c1c829d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97983
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-07-05 09:08:37 +02:00
Rizal Muttaqin
ed8356ec56 Colibre tdf#133268, Sukapura tdf#106229
- Colibre: Update help icons, update Presenter Console/Screen icons to follow Segoe MDL2
- Sukapura: Add help icons, update Presenter Console/Screen icons to follow SF-Symbols and add the UI
- Sukapura: Clean SVG files from unwanted bitmap

Change-Id: I87b0bb982565fadec97e7585d8c0f3e87cea8a5f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97969
Tested-by: Jenkins
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-07-05 03:28:57 +02:00
Tor Lillqvist
86884f876e For macOS on arm64, be sure to use HOST_PLATFORM=arm64-apple-darwin
(That is for the external projects.)

Change-Id: I709ff37ebca304f862ff94bdb1c6e6035f5cda77
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97981
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-07-05 00:01:40 +02:00
Noel Grandin
e3adb51c54 reduce number of framework libraries
Change-Id: I18bfdba3d26593f796d8b0bda87720e31066d5e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97968
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-04 22:42:54 +02:00
Tor Lillqvist
50889effe5 Remove leftovers for OS X on PowerPC
Change-Id: Id9d553e58635c2fa7414108467ff7d22f5c74c41
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97980
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-07-04 22:02:07 +02:00
Caolán McNamara
f9d86399e9 tdf#134479 allow disable font preview to work on existing font comboboxes
not just newly created one.

you can only restore back to a text-only view, not a text+(icon/whatever) view

Change-Id: Ic3becd7a942ee6b1dbabb57eebf1e25d1b626fdb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97972
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-04 19:55:29 +02:00
Noel Grandin
d70da0b9e2 reduce number of framework libraries
Change-Id: If2bf85301eb1523a636d031f6e5a9f78cb1ee06b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97871
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-04 16:56:59 +02:00
Dennis Francis
e6eeecbe72 use lcl_ExtendTiledDimension() in getRowColumnHeaders()
to avoid code repetitions.

Change-Id: If83b42175fb53132174fa33d169806e17a4a5cbe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96973
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
(cherry picked from commit 3c6c039685)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97959
Tested-by: Jenkins
2020-07-04 16:37:14 +02:00
Dennis Francis
adf1182bbd use helper-class ScRangeProvider in getRowColumnHeader()
and avoid some code repetitions.

Change-Id: I3e006bc8d9880f3e1ec892aa8f2423edbf9bbf14
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96972
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
(cherry picked from commit c888a2d7dc)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97958
Tested-by: Jenkins
2020-07-04 15:32:52 +02:00
Dennis Francis
954ec00ccd lokit: scPrintTwipsMsgs: Extend the tiled-area limits...
if the client visible area is "close" to these limits. Also
send tile-invalidations for the new area uncovered.

** All this is done only if the flag scPrintTwipsMsgs is set.

Change-Id: I3d6b8c6aaae1eb934030c5bdbc1094dc8be16a9f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96971
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
(cherry picked from commit d64a5efdb8)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97957
Tested-by: Jenkins
2020-07-04 15:29:47 +02:00
Dennis Francis
2c798d6715 lokit: add new callback type LOK_CALLBACK_INVALIDATE_SHEET_GEOMETRY
This is to notify the clients about changes in current sheet's geometry
data. Use this to notify clients of various sheet geometry invalidations
if the new feature flag scPrintTwipsMsgs is set.

Change-Id: I478d2e646606320399905d7b15881a165a53146d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96969
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
(cherry picked from commit 7d0181f519)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97956
Tested-by: Jenkins
2020-07-04 15:27:29 +02:00
Dennis Francis
b6d8dd62dd lokit: Introduce new flag "sc_print_twips_msgs"...
for conditioning all changes needed to allow calc messages in print
twips coordinates.

Change-Id: I407b4d4d4e0a1dfb2c4339cafa10b368b437c82d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96904
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
(cherry picked from commit 8f382dcee0)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96967
Tested-by: Jenkins
2020-07-04 12:04:55 +02:00
Dennis Francis
9f7cf0907e add row/col limits to the JSON
Change-Id: I92cead8212f30d0cc9b811be21b6639830e84fa4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96903
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
(cherry picked from commit fcb176a46c)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96966
Tested-by: Jenkins
2020-07-04 12:03:18 +02:00
Dennis Francis
568d0e13ad lokit: table-outline: skip empty collections...
while encoding the information as string.

Change-Id: I890efc4a9b60125c68c663a69569864308fdbdcf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96902
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
(cherry picked from commit 2a7d29c51d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96965
Tested-by: Jenkins
2020-07-04 12:01:56 +02:00
Dennis Francis
d24d7e2186 Unit tests for ITiledRenderable::getSheetGeometryData()
(Testing of groups/ouline case is not included)

Change-Id: Ia53e5489c376d2d86461a9fd3db4f5b7dc963b99
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96898
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
(cherry picked from commit 4b7333da7f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96964
Tested-by: Jenkins
2020-07-04 09:48:57 +02:00
Dennis Francis
777f9cec09 Introduce ITiledRenderable::getSheetGeometryData()
ITiledRenderable::getSheetGeometryData(bool bColumns, bool bRows,
				       bool bSizes, bool bHidden,
				       bool bFiltered, bool bGroups)

and implement it for the Calc derivation (ScModelObj).

The aim is to use it actively in LOOL instead of the interface:

ITiledRenderable::getRowColumnHeaders(const tools::Rectangle& /*rRectangle*/)

This is used by the LOOL to fetch the sheet geometry data for just the
current view-area in the clients, so LOOL queries this everytime some
client's view-area changes.

Like the existing interface, the new one will provide all 'kinds' of
sheet geometry info [col/row sizes(twips), hidden/filtered and
grouping]. But the difference is, it generates data for the whole sheet
(not view-area specific). So the method need not be queried every time
the view area changes in the LOOL clients, and more importantly it
enables the clients to locate any cell at any zoom level without any
further help from the core. This means core needn't send various
client(zoom) specific positioning messages in pixel aligned twips. It
just can send all positioning messages in print twips uniformly to all
clients.

Conflicts:
	sc/source/core/data/segmenttree.cxx
	sc/source/ui/inc/tabview.hxx
	sc/source/ui/unoobj/docuno.cxx

Change-Id: Ib6aee9a0c92746b1576ed244e98cb54b572778c0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96892
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
(cherry picked from commit 9faf7b5e7a)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96963
Tested-by: Jenkins
2020-07-04 09:47:30 +02:00
Andrea Gelmini
c6073a5a01 Removed executable permission on cxx file
Change-Id: Id2139b19566a69e0e6e95346cab85dee6ef90943
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97812
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
2020-07-04 09:05:51 +02:00
Adolfo Jayme Barrientos
8bb4952920 Fix HIG spacing in About dialog
Change-Id: Ia67d5c8994c39a1e89c79e8d51a2a679cba73d3e
2020-07-04 01:57:35 -05:00
Noel Grandin
43d2f3d5f1 avmedia/mac: create instances with uno constructors
See tdf#74608 for motivation.

Change-Id: I7dfb9933c1625b4e0b68cf8ab459eebcd3db9d44
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97893
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-04 08:33:02 +02:00
Noel Grandin
78639945da UnoControl: create instances with uno constructors
See tdf#74608 for motivation.

Change-Id: I3df173e3c7064d3d925d3abe5c652b8cbe6c8ea5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97892
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-04 08:32:56 +02:00
Mark Hung
7dcc18b5ac tdf#119223 export the object name for pptx documents.
Originally the name was always an object type plus
an index. That not only ignores the existing
object name, but also makes an unnamed object named
in the roundtrip. So here the object name is used
no matter it is empty or not, to keep unamed object
unamed.

Change-Id: Ib29a8fbc1fd67fa9a4a4efbfd0b2e9c4fb50de0a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96908
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>
2020-07-04 06:40:55 +02:00
Heiko Tietze
92c2318db9 Revert "tdf#126733: inverted emoticons sets for the conditional formatting"
This reverts commit a330d8eef0.

Reason for revert: Regression for existing documents

Change-Id: I7bf70ddfa54c40732ca902f258530f34cac6cd98
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97910
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
2020-07-04 01:27:39 +02:00
Mike Kaganski
49124a6c5e Re-implement 481e686a66
Marking documents modified simply on entry to an edit box created a
problem, when using search in a read-only Online session made the
document modified, and then auto-save failed, displaying a warning:

    Document cannot be saved. Check your permissions or contact the
    storage server administrator.

The original problem, that 481e686a66
fixed, was that entering a box in Impress in browser, typing, then
pressing Save without exiting the box did not save the edits. Yet,
the same sequence works outside of Online. In that case, the doc is
marked modified in SdrObjEditView::KeyInput, which obviously is not
called from Online, where SdrObjEditView::Command is called instead
with CommandEventId::ExtTextInput. So just make sure that we mark
the document modified also in this case, making sure that only the
actual edits set the "modified" flag.

This reverts 481e686a66.

Change-Id: Ib05bc0492616a306dd328bcb8f2e1c9d7e7aa191
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97870
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-04 00:12:32 +02:00
László Németh
a5073875fe tdf#134463 DOCX import: fix other "half" of contextualSpacing
Always ignore own bottom margin setting of the previous paragraph
with contextual spacing, if the actual paragraph is identical.
I.e. in that case, too, when the actual paragraph has no
contextual spacing, like MSO does.

Note: PARA_SPACE_MAX mode hasn't included this modification,
yet, so only ODT documents converted from DOCX use it at the
default setting.

See also commit e318d5d814
(tdf#125893 DOCX import: fix "half" contextual paragraph spacing).

Change-Id: I83fab2a2d85eeb9d48a8546d5a4e6423988d642c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97874
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
2020-07-03 22:59:58 +02:00
Caolán McNamara
b6b7415095 rename FormattedEntry to EntryFormatter
Change-Id: I96079720f60b789f0b8d5483973150cb050e87e9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97859
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-03 18:10:13 +02:00
Caolán McNamara
8ac055fa8a change FormattedEntry to not own the Entry it operates on
Change-Id: I5b5753312a5bbfed3dbcdc47cc1781cbcf168750
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97858
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-03 18:09:53 +02:00
Caolán McNamara
97ccd327c6 change FormattedField so it doesn't inherit from Formatter but provides one
Change-Id: I728380fb4e2ed914c4b96c0915075af097846c55
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97825
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-03 18:08:47 +02:00
Xisco Fauli
643df295fa tdf#134455: sc: Add unittest
Change-Id: I48fe0445d08116e95da087a7ceeb45c1ad6609dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97823
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-03 18:06:53 +02:00
Xisco Fauli
3d79ac71d1 tdf#35636: sc: Add unittest
Change-Id: I79eee92015b4a4eafd57702e2ac1bf7fe1682f0b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97840
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-03 18:06:04 +02:00
László Németh
d35b796efb Update git submodules
* Update helpcontent2 from branch 'master'
  to 4e7e70de93368b2d4de54665245484929d76eb90
  - tdf#133524 tdf#133589 (related) Document new "Localized options"
    
    of AutoCorrect.
    
    Change-Id: I8fce33762184ea558f62cce71cb0c09210623a22
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/97822
    Tested-by: Jenkins
    Reviewed-by: László Németh <nemeth@numbertext.org>
2020-07-03 17:24:31 +02:00
Thorsten Behrens
b1954b19bc sfx2: cleanup cxx-only default params
Followup commit to a8ee7bc96f - not
idiomatic to have function-definition-only default params

Change-Id: I606545d7396ed1123247115e92ac2830a0738e34
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97813
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-07-03 17:21:39 +02:00
Jan-Marek Glogowski
b1d0d0cf86 [API CHANGE] Move NSS profile handling into NSS service
While developing the patchset for tdf#127909, I broke the
certificate path dialog, because I wasn't aware, that the
NSSInitializer service has to use the same logic to auto-
select the users profile, then the dialog. So currently you
have to keep the complex service and dialog auto-select
logic in sync.

To prevent this error, this moves all the profile auto-selection
and enumeration into the NSSInitializer service. What I also
stumbled over is the particular lifecycle of the NSS library
initialization in the NSS service. This is just done, when the
first user calls some crypto function. As a result it's actually
possible to change the path setting without restarting
LibreOffice. But since the NSS deninitialization is run as an
atexit handler, this setting can't be changed after the init.

What is currently missing is any indication inside the dialog of
the currently active NSS setting in comparison to any later user
selection, if the user doesn't restart LibreOffice as requested.

Change-Id: I886962777958c363abeb0ec91fc8a35cbd39eb98
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97668
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-07-03 17:13:12 +02:00
Jan-Marek Glogowski
47c098e576 Qt5 better / working wakeup handling
Report some of the stuff we can in AnyInput. And instead of
posting an event, just use QAbstractEventDispatcher::wakeUp().

Change-Id: I020a71eca7208030ddbfcd2b16d9bc4ceff315e5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/73676
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-07-03 15:58:54 +02:00
Noel Grandin
23e8739b98 tdf#131942 no progress bar saving in Calc
regression from
    commit a7de363cea.
    remove unnecessary Window::Update() calls, which immediately follow
Invalidate

Change-Id: If081f9a54ad7fe528a7885ac796f0ec6a7059872
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96975
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-03 15:40:51 +02:00