when editing is enabled also delete and backspace should be possible
this applies e.g. to input fields within protected sections
Change-Id: Iee5ef133971a3f2967e6c92e685a16afa003cfe8
Reviewed-on: https://gerrit.libreoffice.org/19399
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
Minimal invasive fix for the problem, further work on error propagation
in array/matrix cases may be needed.
Change-Id: Ia6a7fe8138b98b78ffbe89572eb51ab8e9c0fdca
Creating thumbnails is quite an expensive operation, so let's avoid that on
load, and do that only on the document save or document close.
In case the user chooses not to save a modified document, thumbnail is not
generated which can lead to document that has no thumbnail; but that's
probably a good tradeoff for the speedup.
Change-Id: I61bf5ec3fae9596e87963ac7a28ba6e4e52c4e99
silence UrF: Unread field, some sources online suggest that it
might be the case
Change-Id: I2287da343e97bec93e0aaf7a82a408c18ab76d9b
Reviewed-on: https://gerrit.libreoffice.org/19396
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
The LOK API can describe a multi-selection, so find-all can signal all
matches, editeng can have a single selection only. Instead of having no
selections after a find-all, select the first match, so e.g. copy works.
Change-Id: I0eab2565916f0c3cce5d77279c0d927ad4b7054c
At the request of bug tdf#94957, adding unicode conversion
shortcut (alt+x) to Math also.
Change-Id: I5b4d17543a819f035ade0d9a516eeef8542a286e
Reviewed-on: https://gerrit.libreoffice.org/19323
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
and
coverity#1326732 Dm: Dubious method used
coverity#1326734 Dm: Dubious method used
coverity#1326735 Dm: Dubious method used
coverity#1326739 Dm: Dubious method used
Change-Id: Id9d39decf7442b503079ebcfe8c881f0f2fe3eb3
For one, if sd::Outliner::RememberStartPosition() cares about storing
the current selection in the DrawViewShell case in maStartSelection,
then sd::Outliner::RestoreStartPosition() should probably restore it.
For another, sd::Outliner::StartSearchAndReplace() returned true in the
"nothing was found" case, which restarted the spellchecking, which
killed the selection. If the selection has been restored already, then
at least don't kill it in the find case: find is read-only, so no need
to restart the spellchecker.
Change-Id: Idd886d449a9cfb164887fc6b1fde27b5e63e272b
Avoid the horrible convention of hard-coding in a C++ unit test code
addresses of data in the spreadsheet document being tested. Instead,
mark the expected (= as calculated by Excel) and calculated (by
LibreOffice) formula results, rectangular blocks of data, so that the
C++ code can easily find it, and then compare. This is much more
flexible. No need to edit hardoded row and column numbers in the C++
code when adding more test data.
The systematic.xls file has documentation on how to maintain it.
Change-Id: I4fb088fe21831dd3b3213d21916460a708aa0842
Used the same style as existing code, added a new virtual isMinOrMax()
and add some special casing in Reduction::GenSlidingWindowFunction(),
and fsim_count() and fmax_count() functions that count how many
non-NaN numbers we actually see. As such, I am not sure at all that
this is an ideal way to do this, but will have to do for now.
Change-Id: I846a8d24f4563f8fae1a45971a4ce202ed918487
Not sure why the code from f5e7207053
did not produce correct results any longer. Anyway, now OpenCL
division works right in case of empty or zero cells.
Clearly I need to add unit tests to make sure this stuff keeps
working. In later commits.
Change-Id: I93b787ad5da453af1601768308fb614a332ed142
We get correct result by simplifying the code;)
No need to have the outer "if (gid0 < X)" test around the calculation
code generated by Reduction::GenSlidingWindowFunction(). The lhs and
rhs check the gid0 range themselves and that leads to the desired
result for subtraction.
While fixing this I noticed that the handling of empty cells in
division is also wrong. Will fix in another commit.
Change-Id: Ia45bd81e692a17b0453cc79cd4673a00e119562a
