Commit graph

14518 commits

Author SHA1 Message Date
Caolán McNamara
dd689fb914 cid#1557699 COPY_INSTEAD_OF_MOVE
and

cid#1557435 COPY_INSTEAD_OF_MOVE
cid#1557307 COPY_INSTEAD_OF_MOVE
cid#1557209 COPY_INSTEAD_OF_MOVE
cid#1557192 COPY_INSTEAD_OF_MOVE
cid#1557184 COPY_INSTEAD_OF_MOVE
cid#1557183 COPY_INSTEAD_OF_MOVE
cid#1557171 COPY_INSTEAD_OF_MOVE
cid#1557150 COPY_INSTEAD_OF_MOVE
cid#1557148 COPY_INSTEAD_OF_MOVE
cid#1557123 COPY_INSTEAD_OF_MOVE
cid#1557118 COPY_INSTEAD_OF_MOVE
cid#1557116 COPY_INSTEAD_OF_MOVE
cid#1557103 COPY_INSTEAD_OF_MOVE
cid#1557078 COPY_INSTEAD_OF_MOVE
cid#1557075 COPY_INSTEAD_OF_MOVE
cid#1557071 COPY_INSTEAD_OF_MOVE
cid#1557070 COPY_INSTEAD_OF_MOVE
cid#1557067 COPY_INSTEAD_OF_MOVE
cid#1557049 COPY_INSTEAD_OF_MOVE
cid#1557046 COPY_INSTEAD_OF_MOVE
cid#1557042 COPY_INSTEAD_OF_MOVE
cid#1557036 COPY_INSTEAD_OF_MOVE
cid#1557030 COPY_INSTEAD_OF_MOVE
cid#1557024 COPY_INSTEAD_OF_MOVE
cid#1557012 COPY_INSTEAD_OF_MOVE
cid#1557009 COPY_INSTEAD_OF_MOVE
cid#1557008 COPY_INSTEAD_OF_MOVE
cid#1557004 COPY_INSTEAD_OF_MOVE
cid#1556999 COPY_INSTEAD_OF_MOVE
cid#1556992 COPY_INSTEAD_OF_MOVE
cid#1556987 COPY_INSTEAD_OF_MOVE
cid#1556984 COPY_INSTEAD_OF_MOVE
cid#1556981 COPY_INSTEAD_OF_MOVE

Change-Id: Id2687aa282f4e2d4b8053b73c7aa1a74a9516b16
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171974
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-18 11:04:45 +02:00
Caolán McNamara
c93eb54c87 cid#1557618 COPY_INSTEAD_OF_MOVE
and

cid#1557535 COPY_INSTEAD_OF_MOVE
cid#1557520 COPY_INSTEAD_OF_MOVE
cid#1557513 COPY_INSTEAD_OF_MOVE
cid#1557503 COPY_INSTEAD_OF_MOVE
cid#1557487 COPY_INSTEAD_OF_MOVE
cid#1557483 COPY_INSTEAD_OF_MOVE
cid#1557479 COPY_INSTEAD_OF_MOVE
cid#1557474 COPY_INSTEAD_OF_MOVE
cid#1557461 COPY_INSTEAD_OF_MOVE
cid#1557446 COPY_INSTEAD_OF_MOVE
cid#1557445 COPY_INSTEAD_OF_MOVE
cid#1557441 COPY_INSTEAD_OF_MOVE
cid#1557435 COPY_INSTEAD_OF_MOVE
cid#1557433 COPY_INSTEAD_OF_MOVE
cid#1557429 COPY_INSTEAD_OF_MOVE
cid#1557375 COPY_INSTEAD_OF_MOVE
cid#1557372 COPY_INSTEAD_OF_MOVE
cid#1557356 COPY_INSTEAD_OF_MOVE
cid#1557350 COPY_INSTEAD_OF_MOVE
cid#1557344 COPY_INSTEAD_OF_MOVE
cid#1557339 COPY_INSTEAD_OF_MOVE
cid#1557332 COPY_INSTEAD_OF_MOVE
cid#1557330 COPY_INSTEAD_OF_MOVE
cid#1557328 COPY_INSTEAD_OF_MOVE
cid#1557323 COPY_INSTEAD_OF_MOVE
cid#1557315 COPY_INSTEAD_OF_MOVE
cid#1557313 COPY_INSTEAD_OF_MOVE
cid#1557304 COPY_INSTEAD_OF_MOVE
cid#1557297 COPY_INSTEAD_OF_MOVE
cid#1557291 COPY_INSTEAD_OF_MOVE
cid#1557290 COPY_INSTEAD_OF_MOVE
cid#1557271 COPY_INSTEAD_OF_MOVE
cid#1557266 COPY_INSTEAD_OF_MOVE
cid#1557262 COPY_INSTEAD_OF_MOVE
cid#1557259 COPY_INSTEAD_OF_MOVE
cid#1557246 COPY_INSTEAD_OF_MOVE
cid#1557242 COPY_INSTEAD_OF_MOVE
cid#1557241 COPY_INSTEAD_OF_MOVE
cid#1557236 COPY_INSTEAD_OF_MOVE
cid#1557228 COPY_INSTEAD_OF_MOVE
cid#1557225 COPY_INSTEAD_OF_MOVE
cid#1557221 COPY_INSTEAD_OF_MOVE
cid#1557217 COPY_INSTEAD_OF_MOVE
cid#1557213 COPY_INSTEAD_OF_MOVE
cid#1557211 COPY_INSTEAD_OF_MOVE
cid#1557209 COPY_INSTEAD_OF_MOVE
cid#1557205 COPY_INSTEAD_OF_MOVE
cid#1557204 COPY_INSTEAD_OF_MOVE
cid#1557193 COPY_INSTEAD_OF_MOVE
cid#1556082 COPY_INSTEAD_OF_MOVE

Change-Id: I07f195a79a69d4bac0d14317854efc88d6fe94d7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171927
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-16 09:30:37 +02:00
Caolán McNamara
437412d79b cid#1557980 COPY_INSTEAD_OF_MOVE
and

cid#1557869 COPY_INSTEAD_OF_MOVE
cid#1557807 COPY_INSTEAD_OF_MOVE
cid#1557804 COPY_INSTEAD_OF_MOVE
cid#1557799 COPY_INSTEAD_OF_MOVE
cid#1557781 COPY_INSTEAD_OF_MOVE
cid#1557781 COPY_INSTEAD_OF_MOVE
cid#1557766 COPY_INSTEAD_OF_MOVE
cid#1557746 COPY_INSTEAD_OF_MOVE
cid#1557737 COPY_INSTEAD_OF_MOVE

Change-Id: I1866c576f525ea697c62e9e0a96890e5fdaa780f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171795
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-14 09:27:19 +02:00
Caolán McNamara
e63da1689d cid#1556026 COPY_INSTEAD_OF_MOVE
and

cid#1556027 COPY_INSTEAD_OF_MOVE
cid#1556030 COPY_INSTEAD_OF_MOVE
cid#1556032 COPY_INSTEAD_OF_MOVE
cid#1556036 COPY_INSTEAD_OF_MOVE
cid#1556049 COPY_INSTEAD_OF_MOVE
cid#1557490 COPY_INSTEAD_OF_MOVE

Change-Id: If694c4d518323a8ae58bb13569f401b2b36cd427
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171704
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
2024-08-09 21:00:59 +02:00
Caolán McNamara
59768e6051 cid#555593 COPY_INSTEAD_OF_MOVE
and

cid#1555849 COPY_INSTEAD_OF_MOVE
cid#1555936 COPY_INSTEAD_OF_MOVE
cid#1555951 COPY_INSTEAD_OF_MOVE
cid#1555955 COPY_INSTEAD_OF_MOVE
cid#1555960 COPY_INSTEAD_OF_MOVE
cid#1555964 COPY_INSTEAD_OF_MOVE
cid#1555965 COPY_INSTEAD_OF_MOVE
cid#1555975 COPY_INSTEAD_OF_MOVE
cid#1555979 COPY_INSTEAD_OF_MOVE
cid#1555987 COPY_INSTEAD_OF_MOVE
cid#1555990 COPY_INSTEAD_OF_MOVE
cid#1555991 COPY_INSTEAD_OF_MOVE
cid#1556002 COPY_INSTEAD_OF_MOVE
cid#1556008 COPY_INSTEAD_OF_MOVE
cid#1556011 COPY_INSTEAD_OF_MOVE
cid#1556015 COPY_INSTEAD_OF_MOVE
cid#1556017 COPY_INSTEAD_OF_MOVE
cid#1556023 COPY_INSTEAD_OF_MOVE

Change-Id: I8ab99d8e52a1780173a4272c59d408432c29de9f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171572
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-06 22:31:35 +02:00
Caolán McNamara
ac0514fb3d cid#1555415 COPY_INSTEAD_OF_MOVE
and

cid#1555430 COPY_INSTEAD_OF_MOVE
cid#1555497 COPY_INSTEAD_OF_MOVE
cid#1555542 COPY_INSTEAD_OF_MOVE
cid#1555543 COPY_INSTEAD_OF_MOVE
cid#1555564 COPY_INSTEAD_OF_MOVE
cid#1555593 COPY_INSTEAD_OF_MOVE
cid#1555602 COPY_INSTEAD_OF_MOVE
cid#1555610 COPY_INSTEAD_OF_MOVE
cid#1555667 COPY_INSTEAD_OF_MOVE
cid#1555693 COPY_INSTEAD_OF_MOVE
cid#1555719 COPY_INSTEAD_OF_MOVE
cid#1555757 COPY_INSTEAD_OF_MOVE
cid#1555795 COPY_INSTEAD_OF_MOVE
cid#1555826 COPY_INSTEAD_OF_MOVE
cid#1555847 COPY_INSTEAD_OF_MOVE
cid#1555851 COPY_INSTEAD_OF_MOVE
cid#1555863 COPY_INSTEAD_OF_MOVE
cid#1555865 COPY_INSTEAD_OF_MOVE
cid#1555867 COPY_INSTEAD_OF_MOVE
cid#1555869 COPY_INSTEAD_OF_MOVE
cid#1555879 COPY_INSTEAD_OF_MOVE
cid#1555890 COPY_INSTEAD_OF_MOVE
cid#1555893 COPY_INSTEAD_OF_MOVE
cid#1555900 COPY_INSTEAD_OF_MOVE
cid#1555922 COPY_INSTEAD_OF_MOVE
cid#1555925 COPY_INSTEAD_OF_MOVE

Change-Id: I5d362a09e80eecd282e63c745bfe26eac2631a0d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171492
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
2024-08-06 09:13:52 +02:00
Mike Kaganski
aed5979ecc Fix off-by-1 error
Regression after commit af5a1b5925
Drop uses of css::uno::Sequence::getConstArray in dbaccess, 2024-04-30.

Change-Id: Ifaecdeb2898f2e9089b1f893a1e9ba46352cc353
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171505
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-08-06 06:18:55 +02:00
Caolán McNamara
7f9f32aa11 cid#1556472 COPY_INSTEAD_OF_MOVE
and

cid#1556481 COPY_INSTEAD_OF_MOVE
cid#1556486 COPY_INSTEAD_OF_MOVE
cid#1556491 COPY_INSTEAD_OF_MOVE
cid#1556507 COPY_INSTEAD_OF_MOVE
cid#1556515 COPY_INSTEAD_OF_MOVE
cid#1556518 COPY_INSTEAD_OF_MOVE
cid#1556519 COPY_INSTEAD_OF_MOVE
cid#1556533 COPY_INSTEAD_OF_MOVE
cid#1556536 COPY_INSTEAD_OF_MOVE
cid#1556559 COPY_INSTEAD_OF_MOVE
cid#1556577 COPY_INSTEAD_OF_MOVE
cid#1556581 COPY_INSTEAD_OF_MOVE

Change-Id: I2ad2f2194e2a89c7246e8742b2fc8be7580e38c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171394
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-08-02 17:27:10 +02:00
Caolán McNamara
4177e553e0 cid#1555587 COPY_INSTEAD_OF_MOVE
and

cid#1555589 COPY_INSTEAD_OF_MOVE
cid#1555593 COPY_INSTEAD_OF_MOVE
cid#1555596 COPY_INSTEAD_OF_MOVE
cid#1555602 COPY_INSTEAD_OF_MOVE
cid#1555608 COPY_INSTEAD_OF_MOVE
cid#1555610 COPY_INSTEAD_OF_MOVE
cid#1555620 COPY_INSTEAD_OF_MOVE
cid#1555623 COPY_INSTEAD_OF_MOVE
cid#1555625 COPY_INSTEAD_OF_MOVE
cid#1555626 COPY_INSTEAD_OF_MOVE
cid#1555634 COPY_INSTEAD_OF_MOVE
cid#1555638 COPY_INSTEAD_OF_MOVE
cid#1555667 COPY_INSTEAD_OF_MOVE
cid#1555682 COPY_INSTEAD_OF_MOVE
cid#1555686 COPY_INSTEAD_OF_MOVE
cid#1555702 COPY_INSTEAD_OF_MOVE
cid#1555710 COPY_INSTEAD_OF_MOVE
cid#1555750 COPY_INSTEAD_OF_MOVE
cid#1555752 COPY_INSTEAD_OF_MOVE
cid#1555761 COPY_INSTEAD_OF_MOVE
cid#1555762 COPY_INSTEAD_OF_MOVE
cid#1555771 COPY_INSTEAD_OF_MOVE
cid#1555772 COPY_INSTEAD_OF_MOVE
cid#1555784 COPY_INSTEAD_OF_MOVE
cid#1555785 COPY_INSTEAD_OF_MOVE

Change-Id: Ib9724230c05b2027b4edf64e6a0bb5e22a270a88
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171274
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-31 17:37:14 +02:00
Ilmari Lauhakangas
656c48d4a2 cui, dbaccess, desktop, external, filter, librelogo: fix issues found by
Ruff linter

Change-Id: I34df4c10520406a2b9d2d8f3487f877698a324f8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171090
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-07-27 12:51:55 +02:00
Caolán McNamara
e571123891 cid#1557746 COPY_INSTEAD_OF_MOVE
and

cid#1557751 COPY_INSTEAD_OF_MOVE
cid#1557771 COPY_INSTEAD_OF_MOVE
cid#1557775 COPY_INSTEAD_OF_MOVE
cid#1557786 COPY_INSTEAD_OF_MOVE
cid#1557787 COPY_INSTEAD_OF_MOVE
cid#1557790 COPY_INSTEAD_OF_MOVE
cid#1557793 COPY_INSTEAD_OF_MOVE
cid#1557794 COPY_INSTEAD_OF_MOVE

Change-Id: I1b02b6eca303b1a08975ea8aae7c9dbefbada47f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171061
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-26 12:24:39 +02:00
Xisco Fauli
e22dfeef0c related tdf#161865: fix another ODR violation
Change-Id: I082ad91c0c060e7231d0af15868960cb2399b088
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170971
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-24 21:39:56 +02:00
Xisco Fauli
43812baa4c dbaccess: Fix --without-java build
ENABLE_FIREBIRD_SDBC condition was added in
9aaf21b285
"sd: function to return a presentation info in a JSON document"
for no apparent reason.

Change-Id: Ia9a68340a73b87ed51a8b9c4a7fb3e67c59e7b68
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170887
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
2024-07-23 11:20:44 +02:00
Mike Kaganski
6e51784dc5 Use tools::Duration / DateTime to avoid use of boost
Change-Id: Idec79929952929d1720b67fc865ac4a0c4908678
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170817
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
2024-07-21 19:15:22 +02:00
Mike Kaganski
a245fd604c tdf#156530: fix OPreparedStatement::setString
The problem was, that the function only considered the target XSQLVAR's
sqltype,  ignoring sqlsubtype.  This led to a situation when assignment
to NUMERIC or DECIMAL  was treated as assignment  to an underlying type,
like SQL_LONG, performed without taking scale into account.

Use ColumnTypeInfo and its getSdbcType, which provides the correct type,
and add missing cases to setString.  Fix setObjectWithInfo to make sure
that the resulting number is correct.

This also fixes export of NUMERIC/DECIMAL in HSQL migration. Previously
it miscalculated the position of decimal separator,  which accidentally
went unnoticed in the existing unit test, because it was compensated by
broken handling in Firebird SDBC for the specific numbers in the test.

OResultSet::makeNumericString was also fixed; it didn't handle properly
the case of zero fractional part:  initial number 1200 with scale 2 was
converted to a string "12.000" instead of expected "12.00".

Change-Id: I5adac59737d21f91c782fe867d4827fb880fd62a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170812
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
2024-07-21 17:22:52 +02:00
Mike Kaganski
b92b1ca8c1 Refactor for clarity
Change-Id: Ie15fe9d2542000132c9928099f515dca8d287d52
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170737
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-07-21 07:13:34 +02:00
Caolán McNamara
d33d592801 cid#1554791 COPY_INSTEAD_OF_MOVE
and

cid#1554819 COPY_INSTEAD_OF_MOVE
cid#1554837 COPY_INSTEAD_OF_MOVE
cid#1554881 COPY_INSTEAD_OF_MOVE
cid#1554882 COPY_INSTEAD_OF_MOVE
cid#1554884 COPY_INSTEAD_OF_MOVE
cid#1554891 COPY_INSTEAD_OF_MOVE
cid#1554892 COPY_INSTEAD_OF_MOVE
cid#1554897 COPY_INSTEAD_OF_MOVE
cid#1554904 COPY_INSTEAD_OF_MOVE
cid#1554918 COPY_INSTEAD_OF_MOVE
cid#1554928 COPY_INSTEAD_OF_MOVE
cid#1554931 COPY_INSTEAD_OF_MOVE
cid#1554944 COPY_INSTEAD_OF_MOVE
cid#1554945 COPY_INSTEAD_OF_MOVE
cid#1554959 COPY_INSTEAD_OF_MOVE
cid#1554960 COPY_INSTEAD_OF_MOVE
cid#1554963 COPY_INSTEAD_OF_MOVE
cid#1554966 COPY_INSTEAD_OF_MOVE
cid#1554969 COPY_INSTEAD_OF_MOVE
cid#1554973 COPY_INSTEAD_OF_MOVE
cid#1555011 COPY_INSTEAD_OF_MOVE
cid#1555012 COPY_INSTEAD_OF_MOVE
cid#1555015 COPY_INSTEAD_OF_MOVE
cid#1555044 COPY_INSTEAD_OF_MOVE
cid#1555051 COPY_INSTEAD_OF_MOVE
cid#1555055 COPY_INSTEAD_OF_MOVE
cid#1555063 COPY_INSTEAD_OF_MOVE
cid#1555068 COPY_INSTEAD_OF_MOVE
cid#1555073 COPY_INSTEAD_OF_MOVE
cid#1555074 COPY_INSTEAD_OF_MOVE
cid#1555078 COPY_INSTEAD_OF_MOVE
cid#1555080 COPY_INSTEAD_OF_MOVE
cid#1555091 COPY_INSTEAD_OF_MOVE
cid#1555099 COPY_INSTEAD_OF_MOVE
cid#1555101 COPY_INSTEAD_OF_MOVE
cid#1555121 COPY_INSTEAD_OF_MOVE
cid#1610739 COPY_INSTEAD_OF_MOVE
cid#1608424 COPY_INSTEAD_OF_MOVE
cid#1608059 COPY_INSTEAD_OF_MOVE
cid#1607952 COPY_INSTEAD_OF_MOVE
cid#1607653 COPY_INSTEAD_OF_MOVE
cid#1607614 COPY_INSTEAD_OF_MOVE
cid#1607592 COPY_INSTEAD_OF_MOVE

Change-Id: Ie9f922a9fe1b8001dfab31e2741fe8bd5558e442
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170802
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-20 23:03:28 +02:00
Mike Kaganski
1edfbb3108 tdf#136637: handle SQLException in OStatementBase::disposing
The problem was unhandled exception thrown from destructor, resulting
in a crash.

Change-Id: Ib9d2deb2fe9745bf8df060c4e5bf6436b4ca468d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170790
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-07-20 16:42:15 +02:00
Gabor Kelemen
6c0db491f0 tdf#43157 Use SAL_WARN_IF instead of OSL_ENSURE
Change-Id: Id4674025a6abcacd5a8096630908c3e2f7a2821c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168129
Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Tested-by: Jenkins
2024-07-20 12:34:57 +02:00
Caolán McNamara
3693894529 cid#1554837 COPY_INSTEAD_OF_MOVE
and

cid#1554847 COPY_INSTEAD_OF_MOVE
cid#1554850 COPY_INSTEAD_OF_MOVE
cid#1554857 COPY_INSTEAD_OF_MOVE
cid#1554860 COPY_INSTEAD_OF_MOVE
cid#1554870 COPY_INSTEAD_OF_MOVE
cid#1554874 COPY_INSTEAD_OF_MOVE
cid#1557899 COPY_INSTEAD_OF_MOVE
cid#1608424 COPY_INSTEAD_OF_MOVE
cid#1608402 COPY_INSTEAD_OF_MOVE

Change-Id: Iaa6e39cf24cd56cdc4a9be5cbf2b8073a1f635c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170722
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
2024-07-19 12:09:11 +02:00
Noel Grandin
7f5a7ef638 make UStringLess single-arg constructor explicit
Change-Id: I0fb4723fa878f8ebdbe5ac0fe080559ffd4736dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170679
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
2024-07-18 15:34:13 +02:00
Caolán McNamara
4504d921a6 cid#1555694 COPY_INSTEAD_OF_MOVE
and

cid#1555695 COPY_INSTEAD_OF_MOVE
cid#1555696 COPY_INSTEAD_OF_MOVE
cid#1555705 COPY_INSTEAD_OF_MOVE
cid#1555711 COPY_INSTEAD_OF_MOVE
cid#1555713 COPY_INSTEAD_OF_MOVE
cid#1555727 COPY_INSTEAD_OF_MOVE
cid#1555742 COPY_INSTEAD_OF_MOVE
cid#1555745 COPY_INSTEAD_OF_MOVE
cid#1555749 COPY_INSTEAD_OF_MOVE
cid#1555760 COPY_INSTEAD_OF_MOVE
cid#1555773 COPY_INSTEAD_OF_MOVE
cid#1555774 COPY_INSTEAD_OF_MOVE
cid#1555778 COPY_INSTEAD_OF_MOVE
cid#1555790 COPY_INSTEAD_OF_MOVE
cid#1555831 COPY_INSTEAD_OF_MOVE
cid#1555847 COPY_INSTEAD_OF_MOVE
cid#1555851 COPY_INSTEAD_OF_MOVE
cid#1555853 COPY_INSTEAD_OF_MOVE
cid#1607763 COPY_INSTEAD_OF_MOVE
cid#1607504 COPY_INSTEAD_OF_MOVE

Change-Id: I991f15f12e773d325ed9725498df5725b049a858
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170625
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-17 21:49:14 +02:00
Caolán McNamara
e68f28ec9f cid#1607892 COPY_INSTEAD_OF_MOVE
and

cid#1607910 COPY_INSTEAD_OF_MOVE
cid#1607818 COPY_INSTEAD_OF_MOVE
cid#1557402 COPY_INSTEAD_OF_MOVE
cid#1556530 COPY_INSTEAD_OF_MOVE
cid#1557396 COPY_INSTEAD_OF_MOVE
cid#1556522 COPY_INSTEAD_OF_MOVE
cid#1555628 COPY_INSTEAD_OF_MOVE
cid#1554705 COPY_INSTEAD_OF_MOVE

Change-Id: Iae3fbf4a04bf3714f416995640b9d70fe204cf73
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170321
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-11 09:26:28 +02:00
Mike Kaganski
493b8ab997 Simplify comphelper::query_aggregation
Change-Id: Id673c27e21c6706367f2effc92bbea61c83a5482
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170133
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-07-09 05:46:19 +02:00
Marco Cecchetti
9aaf21b285 sd: function to return a presentation info in a JSON document
The presentation info includes properties like document size, if the
slide is visible, master slide information and similar.

[ Miklos: don't refer to removed tools::ScopedJsonWriterArray. ]

Change-Id: I5b0acff2ee0df351dd1859e02695ca249e17c391
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170155
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-07-08 19:18:46 +02:00
Caolán McNamara
22802bf3c3 cid#1557639 COPY_INSTEAD_OF_MOVE
Change-Id: I02c8486503a54d1ddcdf80f9d7c7ee6389e4e05c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170104
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
2024-07-08 16:29:03 +02:00
Caolán McNamara
f8480844a6 cid#1556887 COPY_INSTEAD_OF_MOVE
Change-Id: I7e93494191e11c82af9e66ddd467a73f6bc60490
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170103
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-08 16:28:55 +02:00
Adam Seskunas
3c8f9d02e8 dbaccess complex/DataSource.java to extras/dataSource.cxx
Port the Junit test in DataSource.java over to CppUnit.
In order to port the test as written in Java the
CRM Database was ported, so add a test for that here as
well.

Change-Id: Ib9ac369e3faaa30207b83368889763f0eb063876
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169071
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-07-07 20:07:06 +02:00
Xisco Fauli
7aba05331b DBTestBase: call close at tearDown
Otherwise, calling different tests one after the other
will fail with

warn:vcl:994718:994718:vcl/source/app/svmain.cxx:497: DeInitVCL: some top Windows are still alive
text = "lu9947181i0ytl.tmp — LibreOfficeDev Base" type = "10WorkWindow", ptr = 0x555b3ab76810

Change-Id: I6124b768e165ed841738d29c6071e7950b58229f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170058
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
2024-07-06 09:08:58 +02:00
Xisco Fauli
7216a5a4ff CppunitTest_dbaccess_embeddeddb_performancetest: fix dependencies
Otherwise it fails with

EmbeddedDBPerformanceTest::testPerformance finished in: 426ms
macros_test.cxx:74:Assertion
Test name: EmbeddedDBPerformanceTest::testPerformance
assertion failed
- Expression: xComponent.is()

After this patch, the tests still fail, but for another reason.

Change-Id: I4fc11a9feef79efd71be8d6bab76f8777c92d115
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170012
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
2024-07-05 15:31:58 +02:00
Noel Grandin
24403f4448 fix --disable-firebird-sdbc build
Change-Id: I92e4f1b834b9afe806c29f45af94a562fcb3d78e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169993
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-04 20:50:56 +02:00
Caolán McNamara
07e310498f cid#1608601 silence Unchecked return value
Change-Id: Iab18edb8ddb0860b337c0caf5c1fcf661521541f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169982
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
2024-07-04 12:58:46 +02:00
Adam Seskunas
57de449009 Port CRMDatabase from Java to C++
--Port createTables and createQueries
--Add a general test for the CRMDatabase
--Edit Make file

Change-Id: Ifbbb9010c8d8b8a4a199af73539b1f6a9ec45a0c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169573
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
2024-07-02 08:45:36 +02:00
Andrea Gelmini
102cbf4626 Fix "lets" -> "let's"
Change-Id: I01968fc18b093dbbc27213f01c3da38ae151c62c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169748
Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
Tested-by: Jenkins
2024-06-29 17:22:12 +02:00
Bogdan Buzea
2d5eafef08 Resave with newer Glade version
Change-Id: I79863a21c54986c24ba437f4ce3c0d9ce7f8708c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169394
Tested-by: Jenkins
Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2024-06-26 05:29:31 +02:00
Bogdan Buzea
8edd336e92 Resave with newer Glade version
Change-Id: I143d715d8b5b8630f5153af525b83521555cabb8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169378
Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
Tested-by: Jenkins
2024-06-26 04:37:28 +02:00
Bogdan Buzea
70b3e128ae Resave with newer Glade version
Change-Id: I5e97ebd5cb357673d7bfda563e83c2e75934b88d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169391
Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
Tested-by: Jenkins
2024-06-25 01:43:10 +02:00
Taichi Haradaguchi
4220b8be72 Add newline at end of file
Change-Id: I731d8d80e075c8df8a104ec963b89337a91d536c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169376
Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
Tested-by: Jenkins
2024-06-24 23:21:36 +02:00
Bogdan Buzea
9a07403258 Resave with newer Glade version
Change-Id: Ieaa8a90ddef6a49a3dfbb59575bf8defebeaa854
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169382
Tested-by: Jenkins
Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2024-06-24 13:43:03 +02:00
Bogdan Buzea
7cfb1165ff Resave with newer Glade version
Change-Id: I86065d81a449360f09268fe617f8f09e7a917411
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169385
Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
Tested-by: Jenkins
2024-06-24 05:18:29 +02:00
Bogdan Buzea
87cf6f4dda Resave with newer Glade version
Change-Id: I56f5bbeed4850a742403ffd7dd43fca25101ad17
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169380
Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
Tested-by: Jenkins
2024-06-24 05:15:32 +02:00
Bogdan Buzea
d55b8b4728 Resave with newer Glade version
Change-Id: I011489b4d87a078af6083001d076f71140b98a0a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169401
Tested-by: Jenkins
Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2024-06-24 02:04:11 +02:00
Zainab Abbasi
b00183ebb2 tdf#158237 Use C++20 contains() instead of find() and end()
Change-Id: I9ebe5e8c966a21b99a5229a4418738e4178716a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169312
Tested-by: Jenkins
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-06-21 16:42:11 +02:00
Xisco Fauli
fb8f4b57ce DBTestBase: Add createDBDocument
it can be used later on when porting the java tests
to CppUnittest

Change-Id: I17420fdf490d979392f5aeb90c3b3bfb319d7764
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169274
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
2024-06-20 15:44:26 +02:00
Xisco Fauli
39714d3e66 CppunitTest_dbaccess_embeddeddb_performancetest: use maTempFile
Change-Id: Ib63008ddaf9aeb0ed02dd5cbc9680eda2cefbfac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169269
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-06-20 15:35:02 +02:00
Noel Grandin
86a827da7c loplugin:unusedfields
Change-Id: I4bc67811e228b4806db9f9b9bf9fb0de0eb36de2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169263
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-06-20 14:03:21 +02:00
Andrea Gelmini
07a84353fb Fix typo
Change-Id: I84a64e6a2e90d462ed7eb5fe4adeb3c6966c91c0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169215
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-06-19 23:03:20 +02:00
Andrea Gelmini
dbfa98d162 Fix typo
Change-Id: I339f7b48db82d52faea5343412554c4c4939068e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169181
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-06-19 08:30:01 +02:00
Noel Grandin
0572ef356b loplugin:ostr in various
Change-Id: I7aa8ed716998a185996482dc561219b398a1c919
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169080
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-06-18 13:16:23 +02:00
Oliver Specht
c39e4f6b8a Add SfxItemType to SfxPoolItem
The SfxPoolItem has a new member SfxItemType m_eItemType to
compare types based on enums instead of typeinfo() which
consumes a lot of time e.g. while AutoFormat is running

Change-Id: I033ce67bc9a28ee4790f162380314de85fb4154e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166452
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2024-06-18 01:07:42 +02:00