Don't just use the font's height, but set the font at the OutputDevice,
to get the correct Y position of the redaction rectangle.
Still need to increase the top/bottom of the rectangle a little; also add
a little on the right edge, at least the "t" in Arial sticks out.
Change-Id: Ic6505fc7fa8697d72a6b11259005bb308e74a50c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176498
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
EMFWriter::ImplWriteTextRecord() has a special case for the last
position of the DX array to write an average width of all the characters
excluding the last one.
This has been the case since CVS initial import, and i was unable to
find any reason for it.
When redacting "Schritte" (large text in bugdoc), it causes the right
edge of the rectangle to be at 2964 instead of 3103, exposing the last
character.
Change-Id: I86391e97c4d06093adf3045b04f69153e8e3b0ef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176497
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Tested-by: Jenkins
* Update helpcontent2 from branch 'master'
to d8b9ac2e6884fe6d6420443adfc1d4ce862232d6
- Remove Calc screenshots.
+ used only once in a help page
+ Calc localized screenshots are missing.
+ Re-visit "make screenshots" for Calc sometime in the future.
Change-Id: I7a8df7b48eec280d63396c457e3115236bb57ae6
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176505
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Jenkins
* Update helpcontent2 from branch 'master'
to 6d1f4acbed85b4a1a59d955c712def6b03689c0a
- tdf#162627 Update help for Status Bar's Combined Display
The functionality that used to require a double-click now works with
a single click.
The functionality to insert a field by double-clicking was removed in
commit ebabf6d1fa
Author: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Date: Sat Nov 8 23:02:11 2014 +0100
fdo#86018 Don't do anything when clicked on placeholder in statusbar
No idea why this code got executed in sw, it has no action in sd and sc.
Change-Id: If83eeed71de812b1c64f7111e8311c9cc02248c3
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176494
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
through use of context menu entries in the Writer Navigator Footnotes
and Endnotes content types
Change-Id: I2c7b6d01013023702f9272e222b76a83710ca6f1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176495
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
* Update helpcontent2 from branch 'master'
to e9d4aba7ef8015a50cfe78c611632b445573a874
- tdf#162504 Add help page for Design sidebar deck
Add new file source/text/swriter/01/sidebar_design.xhp to describe the
features of the Display sidebar deck.
In AllLangHelp_swriter.mk
- Add new file source/text/swriter/01/sidebar_design.xhp to repository
In source/text/shared/01/05210200.xhp
Add section tags to allow content to easily be linked and embedded in
other pages.
In source/text/shared/01/themesdialog.xhp
Add section tags to allow content to easily be linked and embedded in
other pages.
Change-Id: Ic6566b6b1c2a3a6a92d22b2f49b9220cef4bd03c
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176493
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Jenkins
Yikes - especially when delete is involved.
Previously it was deleting the in-use background,
regardless of where the mouse right-click happened.
You might wonder why not just query GetHighlightedItemId?
That is because (at least for GTK)
the highlightedItem is zero'd out as soon as the pop-up starts,
i.e. when the mouse is moved over top of the context menu.
Change-Id: Ib88cb0edb8c2c8f854c35821d8125a1991d12a55
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176447
Reviewed-by: Justin Luth <jluth@mail.com>
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Co-author: Regina Henschel
This implements the new draw:handle attributes of ODF 1.4. For reasons
for new attributes see https://issues.oasis-open.org/browse/OFFICE-4110
The old attributes are deprecated but may still be written. So we keep
them to be backward compatible.
Change-Id: I0b3443d000b2b163363f9070e5e276af2b018cbb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174966
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
To be able to sign externally, we need a way to know what is the
document hash that would be passed to
NSS_CMSSignedData_SetDigestValue(), without actually performing the
signing.
Note that svl::crypto::SigningContext already gives us a way to expose
the time that would be used for signing.
Expose the hash in a similar way: the format is a SHA-256 hash in base64
form.
This adapts both places dealing with time: vcl::PDFWriter::GetDateTime()
and svl::crypto::Signing::Sign, to make sure they use the same time,
otherwise the hash would potentially depend on two times, which would be
hard to reproduce later when we serialize the signature we get.
Change-Id: Ib039db4cdd043c8117215c31cb5bc83397693820
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176470
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
After commit df3483fa74 "tdf#130857
VclBuilder: Make MenuAndId a template", 2024-11-10
[CXX] vcl/jsdialog/executor.cxx
C:\lo\core\include\rtl/ref.hxx(126): error C2027: use of undefined type 'PopupMenu'
C:\lo\core\include\vcl/builder.hxx(41): note: see declaration of 'PopupMenu'
C:\lo\core\include\rtl/ref.hxx(126): note: the template instantiation context (the oldest one first) is
C:\lo\core\include\vcl/toolkit/menubtn.hxx(40): note: see reference to class template instantiation 'VclPtr<PopupMenu>' being compiled
C:\lo\core\include\vcl/vclptr.hxx(64): note: see reference to class template instantiation 'rtl::Reference<reference_type>' being compiled
with
[
reference_type=PopupMenu
]
C:\lo\core\include\rtl/ref.hxx(123): note: while compiling class template member function 'rtl::Reference<reference_type>::~Reference(void)'
with
[
reference_type=PopupMenu
]
C:\lo\core\include\vcl/vclptr.hxx(217): note: see the first reference to 'rtl::Reference<reference_type>::~Reference' in 'VclPtr<PopupMenu>::~VclPtr'
with
[
reference_type=PopupMenu
]
Change-Id: Ifa2f8e55135faf8864a157aeddcf2764f4b2db4b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176471
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
V1037 Two or more case-branches perform the same actions. Check lines: 981, 1008
V1037 Two or more case-branches perform the same actions. Check lines: 1018, 1025
Change-Id: Iea6f6edc65490587cb974f6d3baa17d3a337a0c6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175217
Tested-by: Jenkins
Reviewed-by: David Gilbert <freedesktop@treblig.org>
