no need for the pimpl pattern here
Change-Id: I8b18df1dc4769bc6f3cc49c1d59910a0cd61d471
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147969
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Changing e.g. the HoriOrientPosition property resulted in a layout
update, but setting IsSplitAllowed to true had no effect on the layout.
The problem seems to be that the new RES_FLY_SPLIT is not handled in any
update notification.
Fix the problem by initially handling this the same way as RES_FRM_SIZE
is already done, that triggers a 2nd page when a large fly frame is
newly allowed to split, for existing fly frames as well.
Disabling needs more work, still.
Change-Id: I2cba04213286e72384a56a28f2b321f7fd577639
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148029
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
Set the filter option explicitly, rather than inferring it from the test
name.
Change-Id: I4af0edce4316b7717512db70e8ad970126e2b3e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148018
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
For a document it is expected that it always has a theme available
so we need to create a theme with some default attributes set (a
default color scheme for now) when we create a SdrModel and SdrPage
(only for Writer currently).
This also changes some ColorSets, SdrPage, SdrModel methods, to use
better return types (cost& instead of raw pointers and vice versa
depending on the use case).
Change-Id: I874247784b845109e42567e3f45647dda46ccf3b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146816
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
add tooltip for this label, and revise extended tip
Change-Id: Ibff5bac33193df749d7a4117a205f58c0592aefb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147852
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
This suite is large enough so that avoiding the
declaration/registration/definition of each test manually saves a lot of
space.
Change-Id: I842b45e14e1d05de8d8bfd7c1e2baa6da6e1c6f9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147996
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
This was added in d15f4fc67d
"add disabled test code for tdf#40110" already commented out
if the test is enabled, it will fail because fdo40110test.ods
and fdo40110test.csv were not included in the commit
Change-Id: I11e7860bdfa710a78da1a04f72e9eea5bc00d037
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147967
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
...which isn't needed anymore to suppress warnings from other plugins like
loplugin:external ever since 45c06838e9 "only
unit-test one loplugin at a time". Also, the declaration of the function test
in cppunitassertequals.hxx had already started to deviate from its definition in
cppunitassertequals.cxx.
Change-Id: I3fbc8a9a805bd5bc4d8afbf958edff04b89add3f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148010
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Modify the hack from commit ce95e39f8e
(tdf#44282 fix missing space for numbered lists in TOC, 2016-08-16),
which added the space after entry numbers unconditionally.
There are other possibilities, like custom separators between the entry
number and text (e.g., [E#][T][E][T][#]); or the entry number (maybe
with limited depth) used with page number (like in [E#][E][T][E#]-[#]).
Generally, when entry number is not immediately followed by entry text,
the space is not needed.
Additionally, the space is not needed when the number text already ends
with a space character.
Change-Id: Ifa6c474574bfb74466ab721eca49f421a3750942
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147997
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
an empty vector is only 2 words big
Change-Id: I3e4a9d42b9ecb44c57ce11c400a17a4c8b053eca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147972
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
an empty vector is only 2 words big
Change-Id: Ib8309d0819c88fe6a4f7cd322c37dd52190bd060
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147971
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
There were a few remaining DeviceFormat::DEFAULTS in remaining in
IOS blocks after commit 00659bcdbb
Change-Id: I29e1f2bd6d4ce20dea7a45ce17bc6f3b929859c6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148008
Tested-by: Jenkins
Reviewed-by: Patrick Luby <plubius@neooffice.org>
maven central so far doesn't support ipv6 on the primary URL (see
https://issues.sonatype.org/browse/MVNCENTRAL-658 ), it is only enabled
on a dedicated ipv6.repo1.maven.org URL currently.
Add that one to the list of repositories so that ipv6-only hosts can also
fetch the dependencies.
(when using internal ipv4 as well, you'll also need to export
JAVA_OPTS="-Djava.net.preferIPv6Addresses=true"
since otherwise the gradle wrapper fails to download gradle)
Change-Id: I22f0e07fd4e6bb518396f76db20c174e45588372
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147917
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
soffice.bin: /home/ms/lo/master/svl/source/items/itempool.cxx:822: const SfxPoolItem& SfxItemPool::GetDefaultItem(sal_uInt16) const: Assertion `!"unknown which - don't ask me for defaults"' failed.
Because editeng doesnt have RES_MARGIN_TEXTLEFT yet and it's mapped to a
slot id so the dialog works...
Looks like this TABS_RELATIVE_TO_INDENT doesn't exist in editeng anyway.
(regression from commit db115bec92)
Change-Id: I64169a4d6f4663adaa2a17786836c2dcc7e1f394
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148006
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Table rows exported with an extra empty cell, if there was a
nested table in them (and not in the last cell).
Partial revert of commit 1f77a5e8d5
"n#203704 fix RTF export table output for subtables".
Note: the partially reverted code was for the old table format
(used before OOo 2.3). This old format is partially converted to the
new table format since commit e366c92881
"sw: ODF import: convert the simplest sub-tables to rowspan tables".
Change-Id: I63ebefbb99e1a95cd60ce8d8dc34c307573d4b58
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147887
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>
it is just a vector, only 2 words big
Change-Id: I88ca1befea1fc3dba05f7628e4319aedb3250751
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147968
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
...including
<0b06d2638b>
"Update gvfs to the current master"
Change-Id: I23cbf8aec7771eda59f66733bcde6cdbed3d0ddd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147994
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Turns out as-char flys can be decorative too.
The confusing GraphicImport takes a GraphicImportType by value but
everything else is a reference to a DomainMapper_Impl member.
The latter appears to work better so handle GraphicImportType the same
way and remove the function parameter.
(regression from commit 31084ebb59)
Change-Id: I18c1d47d39751e8ddcaa52498077d89c43a934e9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147998
Tested-by: Michael Stahl <michael.stahl@allotropia.de>
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
The problem is that the list element applies a list style, which should
override the list style that's set in the common style
"myStyleWithNumbering" of the paragraph, but these happend to be the
same list styles and so the override was skipped, resulting in bad text
formatting.
<text:list xml:id="list3425910577850" text:continue-numbering="true" text:style-name="Numbering_20_123">
The same problem exists if the list-item element has a style-override.
This is similar to bug i#101349 which fixed it for an automatic
paragraph style applying the same list style as its parent style.
Change-Id: Idc6f10f93976de7e7bdceccbe3012c4157f61ad1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147930
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Each component has its own set of toolbars, depending
on the component type (Calc, Writer, Basic IDE, ...).
In the context of the actual class, a toolbar
is presumed defined statically:
- either by the application
- or by a customization done by the user.
The definition of a toolbar can be stored
in the application configuration files
or in the current document.
Changes made by scripts to toolbars stored
in the application are persistent. They are valid
for all documents of the same type.
Note that the menubar and the statusbar
are not considered toolbars in this context.
A toolbar consists in a series of graphical
controls to trigger actions.
The "Toolbar" service gives access to the "ToolbarButton" service to manage
the individual buttons belonging to the toolbar.
The "Toolbar" service is triggered from next
services: Document, Calc, Writer, Base, FormDocument
and Datasheet. All those components might host toolbars.
Proposed properties in the Toolbar service:
BuiltIn
Docked
HasGlobalScope
Name
ResourceURL
Visible (r/w)
XUIElement
Proposed method:
ToolbarButtons()
Proposed properties in the ToolbarButton service:
Caption
Height
Index
OnClick (r/w)
Parent
TipText (r/w)
Visible (r/w)
X
Y
(The Height, Width, X, Y properties allow for
easy hook of a popup menu to tye button)
Proposed method:
Execute()
Both services are available both from Basic and Python user scripts.
An update of the dcumentation help is required.
Change-Id: I43cb523b52e3d6362994557d74c4ef9faa220507
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147925
Tested-by: Jean-Pierre Ledure <jp@ledure.be>
Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
Tested-by: Jenkins
This fixes an ODT regression from LO 7.2's
commit 0a32371cc2.
The hack applies the last character formatting in the paragraph
to the numbering characters. This was a hack that existed for
DOC and DOCX and RTF in various troublesome modes for quite a while.
However, recently since 6.4ish era there have been some
improvements for DOC and DOCX, so these have been excluded and
now only RTF remains.
Most of the time an RTF file also looks like a DOC
(from a compat settings point of view),
so even RTF files usually don't have this clause apply.
In fact, I looked for the RTF files that this hack still applies to,
but couldn't find a single example. Really? Did something change?
I also looked for examples of files I will be excluding (!isOnlyRTF)
and only found tdf135973.odt and tdf146955.odt. Neither one has
character formatting on their numbered lists, so they can't
be used effectively for a unit test.
It is somewhat pointless to make a test. I don't even think we
can round-trip an RTF that has these characteristics.
Likely the best thing is to just drop the hack altogether,
especially since it would pass the unit tests now.
(I'm sure it was failing before.)
If we can't round-trip it, is there any point in having this
non-import hack in place?
Change-Id: I2f95c10e1d0a9dc53b01027e9c97e5ded29c6750
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147939
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
This suite is large enough so that avoiding the
declaration/registration/definition of each test manually saves a lot of
space.
Change-Id: I8f0017eccadf2ca5ea57ea3c1f8bea357b0c05f7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147961
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
In order to unify the code and to make sure
Scheduler::ProcessEventsToIdle() is always called afterwards
See 9027920783
"improve reliability of CppunitTest_sw_uiwriter3
something in the paste stuff seems to need UI events to be
processed"
Initially, these uno commands were replaced in
9d08a0cea0
"avoid uno:Paste in tests
clipboard is a shared resource (except for svp) so interleaved
tests are not guaranteed to get out what they put in"
However, this is no longer a problem since
e25ba7dc57
"use a dummy clipboard when running unit tests
so the multiple unit tests don't stomp on each other.
This fixes a couple of things in my earlier attempt
(*) actually set the env variable on Windows
(*) don't use a global variable to test the env var, because that
variable might be initialised BEFORE the env var is actually set"
Change-Id: Ifae66e522b0a1e57fa1fa6d16980c6491b397f7c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147957
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
This suite is large enough so that avoiding the
declaration/registration/definition of each test manually saves a lot of
space.
Change-Id: I29efb96151d06fe19ec50a8c6cd363ae052d421f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147962
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
it is only one pointer big
Change-Id: Iad5444ed6783abc2916510fd83c5b5a11d17e8f7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147950
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
no need to use pimpl pattern here
Change-Id: Iebc412aaad83c2f1fc149cc320729ce25030cbc3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147949
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
it is only one pointer big
Change-Id: I4af56814be106026515aee6c09caa14e0f3eb09a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147948
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
no need to use pimpl pattern here
Change-Id: I289f545ff237b9770f3a193460a943e91b86fadb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147955
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
In Impress after fields that span multiple lines, a
linebreak is already forced. (PowerPoint doesn't have such
behaviour)
Therefore if the imported pptx file has a line break after
the multiline field - Impress ends up displaying an extra
line break.
This patch implements ignoring of a linebreak that follows
after a multiline field during paint (when not in EditMode),
using a compatibility flag. (IgnoreBreakAfterMultilineField)
Change-Id: I1e6772424cc0eead06b53d104b06820038a81ea1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147408
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
