Change-Id: I631e050316acdcbb42dfbb5e6476a4e8e7cc0f8d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90221
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Not needed at all and gtk3 is already disabled there.
Change-Id: Ic6f8be17645df22a414ae4b191a97b9bf1c16d1b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90206
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
For tdf#124292, Qt's own HiDPI scaling was explicitly disabled,
but it turns out, you can't really scale QStyle painting then.
This patch series had a 2nd approach also used by Gtk+ currently,
which relied on the scaling of ths Cairo surface, which works
surprisingly good, but has to lie about the real DPI value, so
nothing is scaled twice. Also all icons are then scaled instead
of rendered with the proper resolution.
When HiDPI support in Qt is enabled, and the application is
started using QT_SCALE_FACTOR=1.25, Qt simply lowers the reported
resolution, keeps the logical DPI value of 96 and changes the
devicePixelRatio to the specified value. But LO still expects
the real DPI values and sizes, so we have to multiply a lot of
rectangles, sizes and positions.
The current result is far from perfect, which you can see with
the various graphics glitches, but it at least doesn't crash
anymore in the ControlType::Editbox sizing code.
The main problem is all the up and downscaling in the
getNativeControlRegion code, so LO knows the size of the widgets
for the correct layouting, since there seem to be no API to
get the scaled values from Qt / QStyle.
Change-Id: I687b1df6ef27724ce68326d256e9addccd72e759
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86239
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
<https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/54883/> had been a
case I noticed of a "Gerrit Linux clang/dbgutil" build failing due to stale PCH
information:
[...]
> [build GEN] compilerplugins/clang/sharedvisitor/makeshared.plugininfo
> fatal error: file '/usr/include/asm-generic/errno.h' has been modified since the precompiled header '/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/compilerplugins/clang/sharedvisitor/clang.pch' was built
> note: please rebuild precompiled header '/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/compilerplugins/clang/sharedvisitor/clang.pch'
[...]
and this issue had apparently caused all those Gerrit Jenkins builds to fail for
at least a day. For unmaintained builds like those, I think it is better to
have a more robust setup, where stale PCH information cannot break the build.
Also, as those builds do not make compilerplugins.clean and rather share it
across builds, there should not be much of a performance impact when disabling
PCH in the analyzer.
(It turns out that compilerplugins/clang/sharedvisitor/analyzer.cxx would always
have enabled PCH, as compilerplugins/Makefile-clang.mk always passes in some
definition of LO_CLANG_USE_ANALYZER_PCH. Fixed that now.)
Change-Id: I7b8b24c1049c501634bd59c5fb482bec72427cf6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90211
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins
instead of its value, because the min value is 2, but we set
empty text to indicate multiple values are selected in the underlying
text.
Change-Id: If4232b500cd177a264aa5e6ca0537021483db95f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90208
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
After this commit, it will be possible to automatically
create a Gitpod instance from the core repo, simply
by giving its address.
The instance will have all the build dependencies
and the latest core repo cloned. It is suggested to limit
the thread number by 4 by using the autogen.input file.
Otherwise, your compiler processes might get killed during
the build.
'Gitpod launches ready-to-code dev environments
for your GitHub or GitLab project with a single click.'
Change-Id: I7a0e07be6b36063f0527cb03ef032df3412afc7c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90197
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
if we have enough space under the horizontal X axis.
Note: allow truncation of vertical X axis labels only if they
are text labels and the position is NEAR_AXIS or OUTSIDE_START.
Regressions from commit 35d062f787
(tdf#116163: Limit label height in chart if needed)
and commit 26caf1bc59
(tdf#114179: Custom size and position of the chart wall)
Change-Id: Idf86bc2b5482bb50a266cda57cc502621c2e08ed
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89829
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: I3d34eb4933ad574321c0de6a650fc89dd0aa353f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90144
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
If "values-x" property is empty, export X-Y (scatter) chart category
labels in c:xVal/c:strRef/c:strCache/c:pt/c:v to avoid missing data
points at next import.
Change-Id: Ib5ed99bd1186bd1cfa3e2559aff1c8d214547017
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90011
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
noticed something that wasn't being picked up, wrote some tests,
and found an unhandled case in Plugin::getParentFunctionDecl
Change-Id: I52b4ea273be6614e197392dfc4d6053bbc1704de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90141
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
which does not cause tons of extra pages to show up
Change-Id: Ia80d66de2056d78d8cecd2814239951d0de97018
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90193
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This patch ignores outline tracking when other than Headings/outline
content is navigated to from the Navigator.
Change-Id: I3ecbe508b5d641e8f9bd8fe2e70d8ae23f0bf879
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89928
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Change-Id: Ic820d7c1a21de3244f94cb4af2dfb83d7fb128d3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90169
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Change-Id: Iaa85fe6332f057642dfd01eee7a1d2b1e27c49b3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90168
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
We added a single setup method to replaced setActive call in each
tests.
This commit drop all the replaced setActive call in each tests in
this tiledrendering module.
Signed-off-by: Andrew Lee (李健秋) <andrew.lee@collabora.co.uk>
Change-Id: If0d0b8f6cd03bfbb935bd8a0023530799f5cde34
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90158
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Originally there are 'setActive' in the 1st call of each tests in the
tiledrendering module.
Here we add a single setActive to replace the 1st call of each tests.
Signed-off-by: Andrew Lee (李健秋) <andrew.lee@collabora.co.uk>
Change-Id: I7e8a6fa39d2d4bf0e4eab2e30cbee7437e59ef9a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90157
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I93bffad0f550cc2b12e6fb65879767573485943f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90154
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Files which could become clang-format conformant with
under 5-percent lines of change relative to the total
count of lines in the file are found by using bin/find-clang-format.py,
and fixed with /opt/lo/bin/clang-format -i <path-of-the-file>
There will be follow-up patches to fix all 'under-5-percent' files.
Change-Id: I4952f350f4d22913ea94689b902ffa26c223ff96
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90152
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
* Update helpcontent2 from branch 'master'
to 4d5bdcb2d5e8fd040995ec870003a3f2b117a720
- update help page for Hatch in Area tab
- adjust command names to match dialog box
- adjust access command for all modules
- puts commands in same order as dialog box
- add missing command (background color)
- <h1> <h2> <h3>
- remove "Delete" element (which does not appear)
- update "howtoget"
- add switch and new menu command for Impress
<menuitem>
Change-Id: I20164e2b31115a931097e8bfabc73ff1487502af
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/89683
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
Files which could become clang-format conformant with
under 5-percent lines of change relative to the total
count of lines in the file are found by using bin/find-clang-format.py,
and fixed with /opt/lo/bin/clang-format -i <path-of-the-file>
There will be follow-up patches to fix all 'under-5-percent' files.
Change-Id: Ia2b85f00fc182798176d0af686b37f0df59ecb3c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90151
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
