Commit graph

502402 commits

Author SHA1 Message Date
Caolán McNamara
75235a0759 cid#1636560 silence Unchecked return value
Change-Id: Iffb4b464ff124ffce19548a756d878130c10921a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177772
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
2024-12-04 11:39:41 +01:00
Michael Weghorn
10d32939b1 gtk4: Unbreak --enable-gtk4 build
gtk_icon_view_convert_widget_to_bin_window_coords was
dropped in gtk commit [1]

    commit 8dc5e13e8c66cd260edff17dbaa10eedcc95ae1b
    Author: Timm Bäder <mail@baedert.org>
    Date:   Tue Jun 27 11:11:57 2017 +0200

        iconview: Remove bin_window

, so make the code using it conditional for gtk3.

This at least unbreaks the build for now after

    commit a36a58933a
    Date:   Mon Nov 25 17:07:59 2024 +0530

        sd: convert sidebar masterpage panels from drawingview to iconview

It's possible gtk4 needs to do something else instead,
but that can still be added later.
See discussion newly started at [2] which might
give some insights.

[1] 8dc5e13e8c
[2] https://gerrit.libreoffice.org/c/core/+/177642/comment/4edf0ddd_f71cb30b/

Change-Id: I3bd42614addd03d483c7b41daa2b3a4677b9318e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177769
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-04 11:29:52 +01:00
anonymotter
9138548640 tdf#158979 Add static variable for last used merge option
A static variable has been added so that, when merging cells in Calc
where multiple cells have content in them, it will remember which of the three
merge options was last used in a given session and automatically select that
option the next time the merge cells dialog pops up. The default for the first
merge in a session remains the option to keep the content of hidden cells.

Change-Id: I35f6c01ffe9dff2756e3b9f5d530725e5d939db8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177455
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-12-04 11:08:05 +01:00
Caolán McNamara
16030c0700 cid#1636562 Uninitialized scalar field
Change-Id: I4d9f76cc5cb767054e138819d2b8dd9032188c6c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177770
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-12-04 11:01:10 +01:00
Noel Grandin
5155e21bf1 loplugin:unusedfields
Change-Id: Iac4a64af74c92cbd76335faa62e51fa80ef21789
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177718
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-12-04 10:22:09 +01:00
Jean-Pierre Ledure
d28fcb3e26 ScriptForge (SF_Session) enhance ExecuteCalcFunction
The ExecuteCalcFunction() method is a wrapper
of the
   com.sun.star.sheet.FunctionAccess::callFunction()
method.

This method accepts a broad variety of arguments
- scalars: numeric and strings only
- data arrays (= arrays os arrays)
- 2D arrays (1D arrays give errors)
- com.sun.star.table.XCellRange objects
depending on the called function and its
execution or not as an "array function".

The actual commit makes that the arguments passed to
   session.ExecuteCalcFunction()
are checked as formally correct: scalars are filtered
as numeric or strings, dates and booleans are converted,
arrays are reshaped to 2D where necessary.

The actual change facilitates, as an example,
the use of complex array functions like XLOOKUP,
a powerful search engine on large data sets.

The implemented functionalities are valid in Basic
and Python.

The help documentation might be completed with
additional examples.

Change-Id: I6bba1e21828ef09c5c6f0463cbcfa1f5df695073
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177744
Tested-by: Jenkins
Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2024-12-04 10:21:45 +01:00
Tibor Nagy
43e511e642 tdf#88226 sd: fix cutting off the overflow text on the notes print page
This fix offers two options to preserve the overflowed text:
1: if the "Original size" option is selected for printing,
   the overflowed text will be displayed on a new page.
2: if the "Fit to Printable Area" option is selected for printing,
   notes will be scaled to fit within the available printable space.

The "Multiple sheets of paper" and "Tile sheet of paper" options are disabled for notes because these options are intended for slide printing and do not make much sense for printing notes.

The orientation for the notes print page has also been fixed.

Change-Id: I99e56cf9aed5c32764797469a8ea7f3b25053882
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177511
Reviewed-by: Nagy Tibor <tibor.nagy.extern@allotropia.de>
Tested-by: Jenkins
2024-12-04 10:17:24 +01:00
Mike Kaganski
eae43ee911 Use o3tl::cow_wrapper instead of std::shared_ptr
Change-Id: I05ff47fe51cccce6a78745027ae8c2679783bd8a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177766
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-12-04 09:56:54 +01:00
Michael Weghorn
230a9da04f vcl: Drop MenuFloatingWindow::KillActivePopup param
Move logic to the only caller that passed something else than
the default nullptr.

Change-Id: I293f2ca7ccd22f8f0f57a7fd91a6b4dfaa6a8846
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177747
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
2024-12-04 08:36:51 +01:00
Michael Weghorn
3e144ccb3c vcl: Slightly simplify check in MenuBarWindow::KillActivePopup
Use existing PopupMenu::ImplGetFloatingWindow
instead of casting manually.

Change-Id: I9449130e077fc997d724d5fadc854a278ba16cce
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177746
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-04 08:36:46 +01:00
Michael Weghorn
02bc6cd589 vcl: Change Menu::ClosePopup param to PopupMenu*
Change Menu::ClosePopup param from Menu* to
the child class PopupMenu*, as this is always
a PopupMenu. This also removes the need to
cast to PopupMenu in the PopupMenu::ClosePopup
override.

Change-Id: I129e6ebc7c801c1ca93514f26f79b76f970957a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177745
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-04 08:36:39 +01:00
Rashesh
a36a58933a sd: convert sidebar masterpage panels from drawingview to iconview
- also removes unused PreviewValueSet

Change-Id: I5e7dacb4f472de526a61366295bc91edca12e9ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177642
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-12-04 07:40:30 +01:00
Tomaž Vajngerl
171aa32c38 pdf: fix saving external PDF with form fields
Change-Id: I3d7fdcfe2c4ec0f716425c349b0bf621809fd249
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177741
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Jenkins
2024-12-04 04:35:46 +01:00
Tomaž Vajngerl
345d1138c8 pdf: simplify EncryptionHashTransporter
No need for a map to remember the implementation - we can just
dynamic_cast to the actual implementation.

Change-Id: If590316023be7f749d270c04b7ad3dc5fa1993b0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177644
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-12-04 02:54:08 +01:00
Tomaž Vajngerl
780b41adb4 pdf: introduce IPDFEncryptor interface
Change-Id: I9cc0413f6c0af3be6ef83f4dbcf8dcf73b992f92
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177643
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2024-12-04 02:53:53 +01:00
Xisco Fauli
53110dd25e Revert "PVS: V614 Potentially null smart pointer 'pFillData' used"
This reverts commit 60df7e1052.

Reason for revert:
Michael Stahl: "the PVS warning is wrong, checking bChgFillData is already enough"

Change-Id: I7d963e2b2ebbb30195af05b70ad36ab8d78e7c25
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177760
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-12-04 00:16:23 +01:00
Xisco Fauli
c196546d24 python: upgrade to 3.10.16
Downloaded from https://www.python.org/ftp/python/3.10.16/Python-3.10.16.tar.xz

Change-Id: I677c1dec6ac1d06596d7ff88269b6cac70d848c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177757
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-12-04 00:14:02 +01:00
Christian Lohmaier
92099b161f Update git submodules
* Update helpcontent2 from branch 'master'
  to 0321da3f2b7fca3f7bda1655d64206f28231818e
  - Reapply "enable help for Tagalog (tl)"
    
    This reverts commit dc50ebde81a0e9266806878b69de81da422ec39c.
    
    Change-Id: I0795bff471896fba0972f6e8e44cc81b97e66ccd
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/177749
    Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
    Tested-by: Jenkins
2024-12-03 22:37:25 +01:00
Christian Lohmaier
f84a4390d9 Update git submodules
* Update helpcontent2 from branch 'master'
  to ac15fc2c15fa9e188f0acf1749ca63c2ac228530
  - add missing screenshots & files for Tagalog help
    
    Change-Id: I078f85931d21441929737105e694e0936fd1531f
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/177748
    Tested-by: Jenkins
    Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-12-03 22:37:17 +01:00
László Németh
bfb8f9cae7 tdf#48459 sw inline heading: don't apply inside frames or over 120 chars
Don't apply inline heading 1) in a text frame
2) or if the selected text is over 120 characters.

1) It would be enough to limit this for inline heading
frames, but the recent FN_INSERT_FRAME – which is used
for creating the Inline Heading frame, cannot handle the
insertion inside a frame: the new frame is anchored outside
of the frame, not inside the actual paragraph, resulting
bad layout.

2) Increase also the limit of applying the inline heading
to 120 characters (very upper limit for a long line) from 75.

Follow-up to commit 7a35f3dc74
"tdf#48459 sw inline heading: apply it on the selected words",

Change-Id: I05de4be3a08926fdabad2e601d4bbe57ae25f7c1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177739
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: Jenkins
2024-12-03 21:13:54 +01:00
anonymotter
7a12424df2 tdf#158068 Replace string literals with OUString literals in canvas
Change-Id: I7bbcc08786843d6d289b3170248ce2696e57f3b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177602
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Jenkins
2024-12-03 20:46:51 +01:00
Michael Stahl
1b4bf7effc sw: HTML import: apply hard formatting at insert position ...
... even if there is a character format hint there - in this case, a
RES_TXTATR_AUTOFMT attribute will not be converted to the SwTextNode's
item set.

Also add a test that uses the XDocumentInsertable interface to insert
the HTML, which is closer to the real use case.

(follow-up to commit f45d2fa85b)

Change-Id: Idbf7efceabca8d43d3e32d0b29fb37a9322c184c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177740
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Tested-by: Jenkins
2024-12-03 19:25:02 +01:00
Christian Lohmaier
6420c3df6c Update git submodules
* Update translations from branch 'master'
  to 9a24d35bd2100d7686503528bfce2cb2d6d18ca4
  - update translations for master/25.2
    
    and force-fix errors using pocheck
    
    Change-Id: I8cd66ba0ada8029d2c300d43b6c37ff7da3c3584
2024-12-03 18:44:23 +01:00
Christian Lohmaier
c3ed6e5a2c windows: use jom instead of nmake to build openssl if available
jom (https://wiki.qt.io/Jom) is a parallel version of nmake that
especially helps with building openssl since everything is compiled
individually/the compiler cannot use parallelism either.
Also in a LibreOffice build there's not much else that can be done in
parallel/other stuff requires openssl to be built to continue.

Change-Id: Ib16b0f947991a1d3255aeae7dc5d9bdee0b157a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177743
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Jenkins
2024-12-03 18:07:38 +01:00
Balazs Varga
16b2cae80e tdf#164090: a11y sw: add new warning for non numbered empty paragraph
Add new warning for empty paragraph between numbering paragraphs.

Change-Id: Ib85b376da77a72a87ab05a3e8271be43e223f129
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177493
Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
Tested-by: Jenkins
2024-12-03 17:21:46 +01:00
Andrea Gelmini
863f5d26f9 Fix typo
Change-Id: I7066a328fa54c062d1a12582d4f270e70f466c32
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177702
Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
Tested-by: Jenkins
2024-12-03 16:59:33 +01:00
Stephan Bergmann
7f927322d9 configmgr: Better handling of finalized vs. non-finalized in the same layer
When there are multiple competing configuration settings for the same
configuration layer (e.g., in xcu files of two different extensions from the
same extension layer), then the setting that is read last always won, even if
any of the settings read earlier is marked as finalized.  (The reason for
originally doing it that way was that it kept the code logic somewhat simple.)

However, esp. for a scenario of multiple extensions in one extension layer
(bundled, shared, or user), it can be unexpected by a user that a non-finalized
setting (that comes from the extension that happens to be read last) can win
over a finalized one.

Therefore, change the logic accordingly.  Now, if any of the competing settings
are finalized, the first finalized one that is read wins.

Change-Id: I22aeade543a5b26d95d49cfcb561f974cd7a5081
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177737
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-12-03 16:26:52 +01:00
Pranam Lashkari
f643a98b2b Revert "sc: manage conditional format with simpler dialog"
This reverts commit 58c3f70c514ef4ce0de5419ab7daa3bebfb96f37.

Change-Id: I500a96508684547c158cdd1814540a4b24f667d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177290
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177341
Tested-by: Jenkins
2024-12-03 16:12:38 +01:00
Pranam Lashkari
acc8b8c49d Revert "sc: added date condition option in conditional format manage dialog"
This reverts commit 9928f1fa147d4ff838cbf6fcfe0d976ecef97cef.

Change-Id: Ieb7dfdeccaffed4ad81ff9b5b0eb3b3b49fd8d05
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177289
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177340
Tested-by: Pranam Lashkari <lpranam@collabora.com>
2024-12-03 16:12:31 +01:00
Pranam Lashkari
ec1b094127 Revert "sc: now formula conditions can be managed
...from condition format manager"

This reverts commit 8374dd472cb4a2e2edab969a73ca88ffeaadbcd8.

Change-Id: I532c17596adccfa5c88baaf2df897f3ffbee0fe6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177288
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177339
Tested-by: Pranam Lashkari <lpranam@collabora.com>
2024-12-03 16:08:36 +01:00
Pranam Lashkari
eb933099a5 Revert "sc: preview style in easy format dialog"
This reverts commit 2661be5f8fb28ada80b4f5336d59f54b520bf614.

Change-Id: Ie3482641cbbb34baa866a679c782221d2d513df1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177287
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177338
Tested-by: Jenkins
2024-12-03 16:08:26 +01:00
Pranam Lashkari
904b515782 Revert "sc: give warning about condition input in easy condition dialog"
This reverts commit 2a6dc9dfd84b278352608f475a600e866846af2e.

Change-Id: I061f8ebfbf0115dd55d357c325a3905c5a774a57
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177286
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177337
Tested-by: Jenkins
2024-12-03 16:08:19 +01:00
Pranam Lashkari
70b9e65eae Revert "sc: display all the conditions of same ranges
...in conditional format manager"

This reverts commit 399253ca8ca391504ff1f6a3709fb41d438ce2d6.

Change-Id: I3c0a79ee0a34364d0a51ab4736810f35efe4bfdc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177285
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177336
Tested-by: Jenkins
2024-12-03 16:08:11 +01:00
Pranam Lashkari
36108acc12 Revert "sc: now conditions can be edited from easy conditional format dialog"
This reverts commit 8115c82f1f7f2621e2d99c93e1a3b2196279602a.

Change-Id: Ie3f389561ee8f734ac76b3dec352382281f91c30
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177284
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177335
Tested-by: Pranam Lashkari <lpranam@collabora.com>
2024-12-03 16:08:04 +01:00
Pranam Lashkari
dcf48b9d2d Revert "sc: prefill easy condition dialog with editing condition data"
This reverts commit 598e93b1b11f4cdff96f6117c2a7d35f3698fd23.

Change-Id: Ifdbc8920f232d388eac2a07cd6e2e2dece204a7a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177283
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177334
Tested-by: Jenkins
2024-12-03 16:07:56 +01:00
Stephan Bergmann
0b42fcdb37 external/boost: Avoid some -Wdeprecated-variadic-comma-omission
...new with GCC 15 trunk -std=c++26 since
<https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=cc67d95dc100706ea665e8cce581d59466aba62e>
"c++: Implement C++26 P3176R1 - The Oxford variadic comma",

> In file included from workdir/UnpackedTarball/boost/boost/rational.hpp:82,
>                  from source/external/boost/include/boost/rational.hpp:30,
>                  from source/tools/source/generic/fract.cxx:32:
> workdir/UnpackedTarball/boost/boost/integer/common_factor_rt.hpp:66:56: error: omission of ‘,’ before varargs ‘...’ is deprecated in C++26 [-Werror=deprecated-variadic-comma-omission]
>    66 |          inline constexpr void constexpr_swap(T&a, U& b...) BOOST_GCD_NOEXCEPT(T)
>       |                                                        ^~~
>       |                                                        ,

and

> In file included from workdir/UnpackedTarball/boost/boost/move/unique_ptr.hpp:24,
>                  from workdir/UnpackedTarball/boost/boost/spirit/home/classic/core/non_terminal/impl/grammar.ipp:18,
>                  from workdir/UnpackedTarball/boost/boost/spirit/home/classic/core/non_terminal/grammar.hpp:21,
>                  from workdir/UnpackedTarball/boost/boost/spirit/home/classic/core.hpp:42,
>                  from workdir/UnpackedTarball/boost/boost/spirit/home/classic.hpp:24,
>                  from workdir/UnpackedTarball/boost/boost/spirit/include/classic.hpp:11,
>                  from source/external/boost/include/boost/spirit/include/classic.hpp:30,
>                  from sdext/source/pdfimport/pdfparse/pdfparse.cxx:23:
> workdir/UnpackedTarball/boost/boost/move/detail/unique_ptr_meta_utils.hpp:500:39: error: omission of ‘,’ before varargs ‘...’ is deprecated in C++26 [-Werror=deprecated-variadic-comma-omission]
>   500 | struct is_unary_function_impl<R (*)(T0...)>
>       |                                       ^~~
>       |                                       ,

Change-Id: I56856e274a7c577c53d96343992bb79d4c3d602e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177730
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
Tested-by: Jenkins
2024-12-03 15:42:44 +01:00
Martin Srebotnjak
6d96021511 Update git submodules
* Update translations from branch 'master'
  to 93f61b8759efdb510d3e24eac33e10c8231aedf8
  - Updated Slovenian translation
    
    Change-Id: I0f24e5a42d5d8650fec3dc21d199882691bbdbba
2024-12-03 15:36:28 +01:00
Caolán McNamara
d7736eb6ae fix --disable-scripting build
Change-Id: I0b0113d5e3a1652280e0d84c1beba7c572ded191
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177736
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-12-03 15:23:45 +01:00
Caolán McNamara
3e6ad944ac don't bother passing const std::[u16]string_view by reference
Change-Id: I49477c20849dd99118d5935c0f1576429648bfca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177734
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-12-03 15:18:31 +01:00
Caolán McNamara
63594c6202 crashtesting: fix failure of forum-en-13617.odt to reload from .doc
Change-Id: I907e282c9e7b75abca9a4c91ba12a2c57fc45f40
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177733
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
2024-12-03 15:01:58 +01:00
Caolán McNamara
db40f96f61 Resolves: tdf#139700 use WB_FLATVALUESET to get tracking highlights
a problem since:

commit 53d2a03904
CommitDate: Tue Jan 14 13:45:44 2020 +0100

    weld PageSizePopup

Change-Id: I5e55d1972a205b7bf1ec6f6bdfd2d8cd22e13eca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177728
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-12-03 13:49:27 +01:00
Tomaž Vajngerl
b83387a554 add OpenGL transitions even when OpenGL is not available
This is needed for online, so the sidebar fills all the available
transitions.

Change-Id: Id3af1ed0272305fe7f1ab2d5dddd967276bbbb3d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177727
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-12-03 12:54:44 +01:00
Mohit Marathe
e3dd37ce0c tdf#163403 fix comments not showing in generic backend
Change-Id: I21345049d8137e43cc3e50b0b1bcc8d41a123458
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177582
Tested-by: Jenkins
Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de>
2024-12-03 12:45:32 +01:00
Balazs Varga
1699d29fca tdf#164137 - Fix Accessibility sidebar gives no warnings
We need to check rather the update button is visible instead of the
expanders.

Regression from commit: 13ac356a32
(tdf#164048 sw a11y: improve error/warning levels with...)

Change-Id: I63fb5906ad2f7bb13bc5822c284861a419897c4e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177723
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-12-03 12:22:11 +01:00
Caolán McNamara
02b2dce99c cid#1636522 Missing move assignment operator
Change-Id: I2d5f4e69b5cb9205743484c23443df2084da4fad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177721
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-12-03 11:47:19 +01:00
Heiko Tietze
a0db0bd2e8 Resolves tdf#127937 - Feedback for AutoCalculate
Shows an icon in the statusbar if autocalc is off;
clicking the icon toggles autocalc on

Change-Id: I7fb3296281647583f6f761427d35dcd79282f06c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177418
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-12-03 11:24:48 +01:00
Balazs Varga
e99ef8f347 Related: tdf#163902 fix version number typo in the ui file
Version number was accidentally downgrade after re-saving with glade.

Change-Id: I266280884739dba65e97804d542f358a20e575f6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177717
Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
Tested-by: Jenkins
2024-12-03 11:22:42 +01:00
Patrick Luby
24032fea95 tdf#164047 Don't include libicuuc in libraptor2-lo link list on macOS
For some unkown reason (maybe due to the macOS two-level namespace?)
including the $(ICU_LIBS) link flags causes a crash on startup in
the macOS dynamic library loader on some versions of macOS running
on Intel machines. LibreOffice 24.8.3 and earlier did not have this
bug since libraptor2-lo was not linked against libicuuc. So, revert
back to the LibreOffice 24.8.3 macOS build behavior.

On macOS, libraptor2-lo still links successfully even without
libicuuc and the bundled JavaScript HelloWorld macro still runs. So
it appears that libraptor2-lo does not need any symbols in libicuuc
or, if it does, libicuuc has already been loaded by the time
libraptor2-lo is loaded.

Change-Id: I2e09ce57b5f7aea631a522f5d33f3a4b1ebfd419
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177594
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
2024-12-03 11:08:36 +01:00
Christian Lohmaier
2d5f8af346 don't require pkg-config in wsl-as-helper build
windows build doesn't make use of system libraries, so we only need to
make autoconf/configure happy (allow it to use PKG_CHECK_MODULES macro)
but for that adding the m4/mac path is enough (there's nothing mac
specific, just the pkg-config macros have been added for mac initially)

Change-Id: Ia5db12833c26d89b7e0dbd7009562836885d8055
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177562
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-12-03 10:51:46 +01:00
Christian Lohmaier
6e93419f46 wsl-as-helper: look for perl modules in the perl that's actually used
i.e. strawberry-perl-portable for the installsets and openssl

The only module that needs to be installed (and only when building
installation sets) is Font::TTF::Font - but only on the windows side,
not in the wsl-container.

in the wsl-as-helper case there are three different versions of perl
involved:

  * one inside wsl, since autogen.sh is a perl script
  * one provided by git-bash - used for the majority of the build
    whenever a recipe uses perl
  * and strawberry-perl-portable for building openssl (since that is
    picky and needs one that handles the windows-paths a certain way)
    and for building the installation sets (because of similar
    assumptions in path mangling)

Change-Id: I8374749f21c7862f2e9e77d760077e836a6e9166
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177560
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-12-03 10:51:41 +01:00