Commit graph

417716 commits

Author SHA1 Message Date
Noel Grandin
b27fee9e0e loplugin:useuniqueptr cppu,idlc,io,ucbhelper
Change-Id: I6d8c24fabd52b39c66ce0b88b547df7ec85dad76
Reviewed-on: https://gerrit.libreoffice.org/47725
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-11 07:37:16 +01:00
Noel Grandin
96d9bd2262 loplugin:useuniqueptr in l10ntools
update plugin to find all places where we are unconditionally deleting
stuff in a destructor

Change-Id: Ia0fedc2420c7717ed2bdd8d3bb00262d2a63e0bc
Reviewed-on: https://gerrit.libreoffice.org/47724
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-11 07:36:26 +01:00
Noel Grandin
f14b9d3029 convert (a>b?a:b) to std::max(a,b)
with something like:
   git grep -nP '(.*)\s*>\s*(.*)\s*\?\s*\g1\s*:\s*\g2'

Change-Id: I60b9a3a2a09162bc0de4c13fdde2c209696e5413
Reviewed-on: https://gerrit.libreoffice.org/47602
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-11 07:35:43 +01:00
Olivier Hallot
d11120b95e Updated core
Project: help  2575baa6d1f20327dc943b1cc73ff4252f6cbfe6

Fix HIDs with '?' inside

'?' interferes in logic to extract HID

Change-Id: I5252d1cf861959cc6ad2b49afe9b19f4c9698f56
Reviewed-on: https://gerrit.libreoffice.org/47734
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-01-11 02:31:15 +01:00
Olivier Hallot
60ffa31dd9 Updated core
Project: help  01879555450189381cc02517433807056b193af8

Add L10n to labels, in New help UI

* Add l10n for  "%PRODUCTNAME %PRODUCTVERSION Help"
* same for "Module"
* Content-Security-Policy only for online case

Change-Id: Iedad3e198211c122fe5845171d5dcbc6edd4778d
Reviewed-on: https://gerrit.libreoffice.org/47713
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-01-11 02:29:51 +01:00
Armin Le Grand
ced59c16a8 RotateFlyFrameFix: Add RotCenter info to ODF export
Since the WriterFlyFrames are implicitly rotated around
their center in the Writer UI this has to be added to the
transformation in ODF expressing this. The saved data
now contains the shape data in svg:x/y/width/height statements
(and thus back-compatible AFAP) and a draw:transform statement
(that is to be applied to the defined shape) containing the
rotation around the object's center.

Change-Id: Iccfc70924364f1d58995fce180bce9b6e7643ff4
Reviewed-on: https://gerrit.libreoffice.org/47719
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-01-11 01:53:16 +01:00
Armin Le Grand
cba1c400af RotateFlyFrameFix: Disable AutoContour for rotated Flys
As long as it is not clear when, how and why we should offer
this feature and if ODF needs to be adapted to it, disable
the feature for now. Discussion about how to support is ongoing.

Change-Id: I8ecd91ef9aefb6f49840a4f6108f5d5a17072af0
Reviewed-on: https://gerrit.libreoffice.org/47721
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-01-11 01:35:50 +01:00
heiko tietze
effc05eecb tdf#103705 Tooltip improvement for clone formatting
Change-Id: I77b621197cd5d5ecd514390da216c1a903248db8
Reviewed-on: https://gerrit.libreoffice.org/47578
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-01-11 00:44:18 +01:00
heiko tietze
92262c813f tdf#114701 Missing widget labels in Customization dialog
Labels placed above controls

Change-Id: If05d54a172a3d4f98231fc7a3fb30d097e4e216e
Reviewed-on: https://gerrit.libreoffice.org/47391
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-01-11 00:43:54 +01:00
Andrea Gelmini
371001baf0 Fix typo
Change-Id: Ib148e8b5b9a9641b756023f1fb2eea4e6fa9dd5f
Reviewed-on: https://gerrit.libreoffice.org/47723
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-10 20:49:59 +01:00
Stephan Bergmann
e14cba17ab Silence clang-cl -Werror,-Wmicrosoft-unqualified-friend, redux
...adding two more wrapper files missing from
aef6da021d "Silence clang-cl -Werror,-Wmicrosoft-
unqualified-friend in external/boost", necessary since
653736fb23 "pdf: use bimap for GraphicsContext-id
map"

Change-Id: Ied377274d355f27af5d97d7bea89e3b598d9b7d0
Reviewed-on: https://gerrit.libreoffice.org/47688
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-10 19:41:47 +01:00
Tor Lillqvist
29e7b95e9c Do use just std::cerr in cppuhelper::ServiceManager::preloadImplementations()
As the 1aedb6c434 commit message said,
the point is that we want this output even with a LO built for
production where SAL_INFO() and SAL_WARN() are no-ops.

Change-Id: I5f788c3914286ca8df2c7e290150adae0be42820
2018-01-10 20:07:12 +02:00
Tor Lillqvist
4a114d6295 Bin superfluous using declarations
Change-Id: Icf8a2703b7e72f48bde1cc3bc6fd0de2e663a407
2018-01-10 19:50:45 +02:00
Tor Lillqvist
35ec045f6e Don't try to preload the KDE4 shell backend as that crashes
Change-Id: I1c1ff4ec7cda00a76bdeb018366afed2187c7ef8
2018-01-10 19:50:45 +02:00
Tor Lillqvist
f9f830ac31 Simplify logging in cppuhelper::ServiceManager::preloadImplementations()
Use just SAL_INFO(), with tag "cppuhelper.preload". No unconditional
writes to std::cerr. Also, log the loading attempt beforehand, so that
it is printed before any crash during the loading of a component.

Change-Id: Ifde8be8cb5d18dd88df21c45c906deb575d36960
2018-01-10 19:50:45 +02:00
Christian Lohmaier
6561dd71ca Updated core
Project: translations  37dce4e45765761dcf3ade415b7197a1d7026cdc

update translations for 6.0 rc2

and force-fix errors using pocheck

Change-Id: Id698a59cad30f1ad3c37e7d078bd781bb5f2f1fd
2018-01-10 18:27:26 +01:00
Katarina Behrens
0a50357ded tdf#79077: Harmonize PapersizeFromSetup checkboxes in printer config
job setup and options tab page. Also fix a small UI regression

Change-Id: I48532ac4e188d68008e947924da651239262d8b2
Reviewed-on: https://gerrit.libreoffice.org/47703
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-01-10 18:05:41 +01:00
Caolán McNamara
6f69982c6b ofz#5221 depth protect Prepare
Change-Id: I49804a8c65b3af204bfd79d6ff5b3280ab876ec4
Reviewed-on: https://gerrit.libreoffice.org/47693
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-10 18:00:39 +01:00
Tor Lillqvist
99ab7bf20e This is a hash: '#', this is a slash: '/'
Change-Id: I3a0bd41f021547678f7e423d10c8900723006bb6
2018-01-10 18:54:22 +02:00
jan Iversen
6cbea52dd0 iOS, missed remove debug line
Change-Id: I018f733cd2697f9b8456c6e4d720817d612b341b
2018-01-10 17:26:24 +01:00
jan Iversen
7590db54ea iOS, update to compile app
The dylib reference was wrong, when starting from scratch

Change-Id: I88f1a2bf5634683d3d13faa71a1aa8c039f0c472
2018-01-10 17:21:39 +01:00
Caolán McNamara
b0486259aa ofz: Integer-overflow
Change-Id: Iad8ebd0861a74399f6bb4a18aecf0de735a60b61
Reviewed-on: https://gerrit.libreoffice.org/47694
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-10 17:20:34 +01:00
László Németh
bcf85c9c1a Updated core
Project: dictionaries  58274a91b8e64e14282def27d118929b35da4ba8

tdf#95024 update Hungarian spelling dictionary

    – new and fixed words

    – apply new changes from Magyar Helyesírási Szótár (2017):

      charme →  sárm
      Vietnam →  Vietnám

    – start to use new Hunspell features for two-word, etc.
      suggestions for common misspellings

      mégegyszer →  még egyszer
      egyesegyedül →  egyes-egyedül

Change-Id: I38eac7b1023c823af69268ed81b86bde3309a3d0
Reviewed-on: https://gerrit.libreoffice.org/47677
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2018-01-10 17:14:48 +01:00
Tor Lillqvist
4e5716b57c Mention that the getError() semantics are unclear
Change-Id: Ifd5b04cc13085749f0f800bdb69cc3fdd5581916
2018-01-10 17:30:08 +02:00
Samuel Mehrbrodt
d2763bde00 tdf#113874 Guard against invalid states
Change-Id: I013dd4eb81f0fbef25d9f58e27fe72d800d910ba
Reviewed-on: https://gerrit.libreoffice.org/47702
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-01-10 15:48:35 +01:00
Michael Stahl
21ee376d99 gbuild: print a better error message when adding non-existing Module
A confusing message "Corrupted module target stack!" is printed
because:

"If an included makefile cannot be found in any of these directories, a
 warning message is generated, but it is not an immediately fatal error;
 processing of the makefile containing the include continues.  Once it
 has finished reading makefiles, make will try to remake any that are
 out of date or don’t exist."

Change-Id: Ia728c0283885fe839dbf8dd8ae2a885230f23836
Reviewed-on: https://gerrit.libreoffice.org/47701
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
2018-01-10 15:27:28 +01:00
ekuiitr
728104b31c tdf#96099 Removed some trivial typedefs related to UnOrderedMap and size_t.
Change-Id: I59d3d0b2c1097b5ca96505dc99a4a104b4f8ab48
Reviewed-on: https://gerrit.libreoffice.org/47082
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-10 15:20:44 +01:00
Julien Nabet
c2bc2c4633 tdf#113923: don't use twice a new column in table copy
In the case where:
1: we enabled the creation of a primary key
2: we come back here from the "Back" button of the next page,
we want to avoid to list the new column generated in the next page

So we must check added columns in right panel must exist in the table

Change-Id: I467007941b03811381a216c1ab3de8fe729f9b9b
Reviewed-on: https://gerrit.libreoffice.org/47684
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2018-01-10 14:43:15 +01:00
Miklos Vajna
d03a754722 sfx2 store: add API to allow avoiding the fsync of the output file
The use-case is when the consumer of the output file will read it right
after SfxBaseModel::storeToURL() returns, in which case an expensive
fsync is pointless.

Times for 100 hello world inputs: 8516 -> 2785 ms is spent in ODT-load + HTML
export + close (33% of original).

Change-Id: I05e424a43ebfeea363f82b57af60f5aaa28696b4
Reviewed-on: https://gerrit.libreoffice.org/47695
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2018-01-10 14:35:47 +01:00
Miklos Vajna
e1026e267b pdfium: update to 3312
Change-Id: I3e81c097870264bfcdd8c14407dcb95f5b153793
Reviewed-on: https://gerrit.libreoffice.org/47689
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2018-01-10 14:35:13 +01:00
jan Iversen
d9bde4c6af iOS, corrected path in LO
Patch thanks to Jon Nermut.

LO looked in the wrong directories on iOS

Change-Id: I8a9c019f7443445b780bc2ce1c77c998f74239e8
2018-01-10 14:23:02 +01:00
jan Iversen
e4f5c5cebb iOS, reference to hook_2 wrong
Change-Id: I4f0051bac812969988b701383a9df7db96ce245e
2018-01-10 14:23:02 +01:00
jan Iversen
ffd994298d iOS, catch library changes in make
Updated makefiles to be dependent on the static libs, ensuring
that iOS is rebuild when a core library changed.

Change-Id: I5ebd1d703eb9a3af0e284910cdc307dd62f4d3fc
2018-01-10 14:23:02 +01:00
Caolán McNamara
80074e280d ofz#5211 limit table parsing depth
Change-Id: I77b569faacc6f2655b050d09a236f78843e87560
Reviewed-on: https://gerrit.libreoffice.org/47691
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-10 13:57:13 +01:00
Samuel Mehrbrodt
dd758f54fa tdf#83877 Copy signature line properties too when copying shape
Change-Id: I3265c2fa3b858a1e2ad1c0c73f3912a6c68b1043
Reviewed-on: https://gerrit.libreoffice.org/47659
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-01-10 08:34:49 +01:00
Tamás Zolnai
aa02ed306f tdf#106991: Highlighting remains after select no fill
Change-Id: I911970539b96bc0d1c6427829fcae869142c9010
Reviewed-on: https://gerrit.libreoffice.org/47679
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-01-10 05:59:14 +01:00
Andrea Gelmini
0cc38c926e Fix typo
Change-Id: I2261578d54e4b986871eab9c309884eb903aa3c6
Reviewed-on: https://gerrit.libreoffice.org/47614
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-10 03:12:13 +01:00
Vasily Melenchuk
0074951704 tdf#113572: allow switching to data range in copypasted chart
- enable data range toolbar button for charts with internal
  data table and possiblilty to switch to data range
- show warning before destoying data table
- recreation of data provider

Change-Id: I2a08b723be80d411e970bfe2ee53dee7d3d52faa
Reviewed-on: https://gerrit.libreoffice.org/44605
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-01-10 01:24:06 +01:00
Olivier Hallot
8c15140f92 Updated core
Project: help  2c7cfc527a05ef757ab3ecfd6ab5a2582a104680

Add Content-Security-Policies in new Help pages

Change-Id: I115fc16fbf4b8284bfedc735761434bb586f0355
Reviewed-on: https://gerrit.libreoffice.org/47660
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-01-10 01:14:56 +01:00
Stephan Bergmann
cc033ec70a Don't use non-Windows sys/time.h
(The comment what the test wants to check quotes noelgrandin on #libreoffice-
dev.)

Change-Id: I8e8980902c8113eb75d24064e68a47e70bc483d6
Reviewed-on: https://gerrit.libreoffice.org/47676
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-09 23:22:27 +01:00
Stephan Bergmann
17b9ef3858 Don't build off-by-default loplugin:unusedfields on Windows for now
...due to missing sys/file.h

Change-Id: I7cfd64c5355d9fdbb85320f876c277a408be9352
Reviewed-on: https://gerrit.libreoffice.org/47675
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-09 23:21:47 +01:00
Stephan Bergmann
b3ef638cb2 Various loplugin (clang-cl)
Change-Id: Ib91d9f82b99989a37e5e03ecb9138a59436ce2c8
Reviewed-on: https://gerrit.libreoffice.org/47674
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-09 23:21:08 +01:00
Stephan Bergmann
aef6da021d Silence clang-cl -Werror,-Wmicrosoft-unqualified-friend in external/boost
...messages like:

> workdir/UnpackedTarball/boost\boost/bimap/detail/map_view_iterator.hpp(138,18):  error: unqualified friend declaration referring to type outside of the nearest enclosing namespace is a Microsoft extension; add a nested name specifier [-Werror,-Wmicrosoft-unqualified-friend]
>     friend class iterator_core_access;
>                  ^
>                  ::boost::iterators::

Change-Id: I393b7c95943a55d5f755cfed41e0b7bc3306c568
Reviewed-on: https://gerrit.libreoffice.org/47673
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-09 23:20:20 +01:00
Stephan Bergmann
a49be6bd58 no matching function for call to 'intrusive_ptr_add_ref'
...with clang-cl, in instantiation of member function
'boost::intrusive_ptr<const ScMatrix>::intrusive_ptr' requested at
sc/inc/token.hxx(291,20):
class SC_DLLPUBLIC ScMatrixCellResultToken : public formula::FormulaToken

Change-Id: Id8485d937744759ddbe36e8508c54e2a996df4d2
Reviewed-on: https://gerrit.libreoffice.org/47672
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-09 23:19:00 +01:00
Stephan Bergmann
b4860abacf loplugin:unnecessaryparen (clang-cl)
Change-Id: I867dd6f70d83f9e57ff3b9b5c73e18b6860e9026
Reviewed-on: https://gerrit.libreoffice.org/47671
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-09 23:17:23 +01:00
Stephan Bergmann
a5070d17b3 -Werror,-Wformat (clang-cl)
Change-Id: I21be71f795c6c04d63a0103e251448edeb4c54d2
Reviewed-on: https://gerrit.libreoffice.org/47670
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-09 23:16:46 +01:00
Stephan Bergmann
a707dc29ec Avoid clash with ERROR macro from wingdi.h on Windows
Change-Id: Ifd9d9f08184eaf00e2d33765c80b7df234bce02a
Reviewed-on: https://gerrit.libreoffice.org/47669
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-09 23:16:18 +01:00
Caolán McNamara
337243fd28 ofz#5193 Negative-size-param
Change-Id: I8c3cf71e4d7ad15d61e5aff738ebc6d326574635
2018-01-09 20:49:30 +00:00
Caolán McNamara
bac55d0821 just use a simple vector
Change-Id: I4aeb611ba7e50c008a9d28d1f7efa308c77ba0a1
Reviewed-on: https://gerrit.libreoffice.org/47647
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-09 21:42:14 +01:00
Caolán McNamara
cbebd5333e don't need to dynamically allocate these
Change-Id: I847dfd45ea7115cdc1e8f95740477b76f1c68f7a
Reviewed-on: https://gerrit.libreoffice.org/47646
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-09 21:39:09 +01:00