Korrawit Pruegsanusak
b9376ed8d4
Code Cleanup
...
* Remove empty and bogus comments
* Remove dead codes
* Fix typos in comments
Released under LGPLv3+/MPL
2011-05-30 12:03:44 +01:00
Kohei Yoshida
b585a9809c
Doing this will handle empty sub strings correctly.
2011-05-29 10:25:40 -04:00
Kohei Yoshida
344edada80
String to rtl::OUString & sal_Bool to bool in ScUserList et. al.
2011-05-29 01:12:03 -04:00
Kohei Yoshida
6882d598fe
Removed unnecessary forward declarations.
2011-05-28 22:46:37 -04:00
Kohei Yoshida
f5574561f7
This header no longer needed.
2011-05-28 20:44:19 -04:00
Kohei Yoshida
225208f28c
Removed dependency on ScCollection from ScChartCollection.
2011-05-28 20:43:16 -04:00
Kohei Yoshida
06077f20db
More on replacing String with rtl::OUString.
2011-05-28 17:58:35 -04:00
Kohei Yoshida
a13baa0b1d
Use bool and rtl::OUString in ScChartCollection et. al.
2011-05-28 17:46:59 -04:00
Kohei Yoshida
c75d2a287d
sal_Bool to bool in ScDPObject.
2011-05-28 17:17:33 -04:00
Kohei Yoshida
10807dfacf
String to OUString in ScDPObject.
2011-05-28 17:04:12 -04:00
Kohei Yoshida
a5e4f7a7ac
String to rtl::OUString in ScDPServiceDesc.
2011-05-28 16:37:51 -04:00
Kohei Yoshida
d5d4e2608d
String to rtl::OUString in the external ref manager code.
...
And fixed the fallouts of this change to get it to build.
2011-05-28 16:22:27 -04:00
Kohei Yoshida
7e5fb2d5dd
Revert "Removed unnecessary data members."
...
This reverts commit ed2aa8e1ebd4bea03d958b86e721400ef59cb76d.
These data members were indeed necessary. Let's not remove them.
2011-05-28 01:06:28 -04:00
Kohei Yoshida
04e7f3f258
Revert "Extracted a method from a code block."
...
This reverts commit 4f46e40020699ea79d0d7254431aff27b087e4e2.
2011-05-28 01:03:59 -04:00
Kohei Yoshida
eb7fe34e8d
sal_Bool to bool.
2011-05-28 00:33:13 -04:00
Kohei Yoshida
ff057f094b
Consolidated local functions in anonymous namespace.
2011-05-28 00:10:01 -04:00
Kohei Yoshida
b1a119ea9c
Extracted a method from a code block.
2011-05-28 00:08:03 -04:00
Kohei Yoshida
4d8e0a3d68
Massive cleanup of ScTabView. No more sal_Bool from the header.
...
I found one abuse of sal_Bool being used as an integer. The block
mode was a boolean but had 3 different states. Replaced that with
enum.
2011-05-27 23:24:37 -04:00
Kohei Yoshida
82d1e7f1b5
More clean up of unnecessary code.
2011-05-27 21:59:09 -04:00
Kohei Yoshida
56d3ce7cc9
Removed unnecessary data members.
...
These two can be used as local variables as they are only used in
one method.
2011-05-27 21:40:14 -04:00
Kohei Yoshida
0d9923996f
fdo#34214: Fixed selection by arrow keys around merged cells.
2011-05-27 20:03:41 -04:00
Jan Holesovsky
89eee95deb
Merge branch 'master' of git://anongit.freedesktop.org/libreoffice/calc
2011-05-27 20:49:22 +02:00
Jacek Wolszczak
15a1ac94cd
Follow-up of DBG_* removal
2011-05-27 06:03:38 +02:00
Jacek Wolszczak
2fdfcbfad3
Replace DBG_* with OSL_* in sc/source/filter
2011-05-27 06:03:38 +02:00
Jacek Wolszczak
8b569e74d6
Replace DBG_* with OSL_* in sc/source/ui
2011-05-27 06:03:37 +02:00
Jacek Wolszczak
45df4e3859
Replace DBG_* with OSL_* in sc/source/core
2011-05-27 06:03:37 +02:00
Jacek Wolszczak
a64076a069
Replace DBG_* with OSL_* in calc/chart2
2011-05-27 06:03:36 +02:00
Markus Mohrhard
2075ba251a
add unit test for ScDocument::MoveTab
...
this unit test is disabled for now because there is a problem with ScProgress in ScDocument::MoveTab during unit tests
2011-05-26 19:12:43 +02:00
Caolán McNamara
f68e364154
use same hack as lotuswordpro qa for tail_build different pwd
2011-05-26 09:50:21 +01:00
Kohei Yoshida
eafe57da83
fdo#37458: Prevent crash on named range deletion.
...
Simple NULL pointer checks will prevent crashes....
2011-05-26 00:07:20 -04:00
Kohei Yoshida
4f5e783c06
Forgot to uncomment this line.
...
Now that we always set locale to en_US during unit test, this test
should be okay.
2011-05-25 23:01:44 -04:00
Kohei Yoshida
48dcb2615e
Re-enable the CVE test.
2011-05-25 21:03:40 -04:00
Kohei Yoshida
225520a39c
Launch error message in case the external doc could not be reached.
2011-05-25 15:33:36 -04:00
Kohei Yoshida
0b83a9aff5
Adjusted for signature change in DataChanged().
2011-05-25 15:24:51 -04:00
Kohei Yoshida
0a6f106620
Paste link from another calc doc as external reference instead of DDE.
...
DDE is deprecated, and it relies on platform dependent file paths which
are non-portable. Better use external references for paste link
operations.
2011-05-25 14:26:17 -04:00
Kohei Yoshida
0b75d1985f
Check if the referenced file is loadable, and if not, don't update.
2011-05-25 14:04:06 -04:00
Joseph Powers
5995c09705
Remove some unneeded #include <tools/unqidx.hxx>
2011-05-24 19:11:48 -07:00
Markus Mohrhard
3877519bb4
fix for fdo#37548: InsertNames->InsertAll doesn't insert anything
2011-05-24 21:53:54 -04:00
Kohei Yoshida
3939664580
fdo#37520: Don't cache the array size but query it dynamically.
...
The size of the array may change during the loop, so we need to always
query it dynamically via size() instead of caching it at the beginning
of the loop.
Signed-off-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2011-05-24 21:48:56 -04:00
Markus Mohrhard
a015d23d8f
remove problem inserted by a DECLARE_LIST removal
...
the DECLARE_LIST container decremented the internal index pointin to the current element when REMOVE was called, when we now iterate over the new container and remove an element we must do this ourself
2011-05-24 21:39:45 -04:00
Jan Holesovsky
e713f1ec23
Merge remote-tracking branch 'origin/integration/dev300_m106'
2011-05-24 15:03:17 +02:00
Kohei Yoshida
dd7605f990
Got it to build. Mostly VBA stuff but no idea what kind of shape it is in.
2011-05-23 23:54:21 -04:00
Joseph Powers
bded50069f
Remove some extra #incude <tools/pstm.hxx>
2011-05-23 20:30:20 -07:00
Joseph Powers
82d9a10229
Fix an old remove DECLARE_LIST bug. Could be related to fdo#37429
...
Thanks for finding this go to npcdoom.
2011-05-23 07:19:28 -07:00
David Tardon
7268a5f961
fix mis-merge
2011-05-23 14:38:06 +02:00
Markus Mohrhard
218e880b36
fix for fdo#37429 crash when copy/paste table from writer to calc
2011-05-23 13:50:15 +02:00
Rafael Dominguez
e5da5f4486
Replace List for std::vector<String>.
2011-05-22 22:52:43 -07:00
Rafael Dominguez
988d4d45a8
Replace List for std::vector<String>.
2011-05-22 22:52:43 -07:00
Rafael Dominguez
40e2f7f90a
Replace List for std::vector<String>.
2011-05-22 22:52:43 -07:00
David Tardon
f82f7ba5ae
compensate for already shifted segments
2011-05-23 07:38:02 +02:00