New keywords can now simply be added to a static array rather than
adding a new "else if" blocks for each keyword.
Change-Id: Ib581b3e834a57e0dfa9d139bcb4ae7a0a52a5472
The ctor later will turn that reference to a pointer anyway, but the old
code made it easy to pass a String, get it implicitly converted to
OUString, and then we took the address of the temporary OUString, later
resulting in accessing already freed memory. Instead, take an OUString
pointer, and then the compiler will warn about a String* -> OUString*
conversion. Adapt one remaining caller accordingly.
Change-Id: I4084dea1d245f0c8919d6afe47c5f391729f6eaf
IMO Calling this method again is not required. The If Blocks returns
false when User Clicks "Cancel" Button in "Format Cell" Widget,
IMO on Cancel Their is no need to Update the table. And on Ok
SetAttrToSelectedCells method is called which inturn calls
UpdateTableShape() method.
Change-Id: I2bb0bb616cc978717a1494e01f257631aadd613c
Reviewed-on: https://gerrit.libreoffice.org/3391
Reviewed-by: Tor Lillqvist <tml@iki.fi>
Tested-by: Tor Lillqvist <tml@iki.fi>
Iterate over all selected cells, set appropriate alignment based on
current writing direction and alignment of the cell.
Don’t change alignment when cell is center aligned or justified.
and if alignment is right or left, change it respective to writing direction.
Change-Id: Ie98a46af97236ab4303d030f11bd167939dde32b
Reviewed-on: https://gerrit.libreoffice.org/3549
Reviewed-by: Tor Lillqvist <tml@iki.fi>
Tested-by: Tor Lillqvist <tml@iki.fi>
By removing the last two libs: nullcanvas and directx5canvas.
directx5canvas seems to be dead and nullcanvas don't have entries in scp2.
Change-Id: Ib8fc1da123f8374fb83192f14db730638213f564
Reviewed-on: https://gerrit.libreoffice.org/3626
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
Cleanup of source code:
- translated German to English
- removed useless comment decorations
- removed commented out code
- some reformatting of code
Change-Id: I71d5fdab8226d61bda9ac906bb82176dc11cafd2
Reviewed-on: https://gerrit.libreoffice.org/3643
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
My simple test file is finally valid but is still now shown in Excel.
There must be another bug in our exporter.
Change-Id: Ib55e5b32edc3a556e9081b3008df539275dc289b
This does not work yet as we have several validation errors in our
exported OOXML chart doc. I have to clean them up before the documents
are accepted by Excel.
Change-Id: I0bba64a9c6cab489199c8e6f04158fea7b953d0a
This is a part of my effort to get a runnable $(INSTDIR) as a more
convenient alternative to make dev-install. I plan to copy all necessary
shared libs, executables and other files to $(INSTDIR), which increases
the disk space demands for a build (there would be three copies of a
library/executable in the same build: one in $(WORKDIR), another in
$(OUTDIR) and one in $(INSTDIR)). Because the runnable instdir idea is
limited to Linux anyway (at least for now), it will be disabled by
default.
Change-Id: Ib61109b1a193c61c0236b50b64c34fea20f40297
CLOOK = "Compiler Limit: Out Of Keys", an error reported by Microsoft's
compiler a long time ago. No such problem in those versions we support. No
need to mention CLOOK in comments any more.
While at it, re-combine one large switch statement that was split to avoid
CLOOK.
Change-Id: Id93d973a5fb3c81b6c754eef0ba3b0bd55a649d2
Reviewed-on: https://gerrit.libreoffice.org/3640
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
This was a situation similar to
d0d295af53. Unfortunately just changing
SwTxtSizeInfo's pTxt to an OUString copy doesn't work, as we still have
code that relies on that being a pointer only.
Change-Id: I202d7e6f5bd3005fc50551aa7195b419994ca3e8
Crash with GCC 4.8 without the modification.
Temporary fix, should be replaced by OUString copy.
Change-Id: Ieb2437f2ee6b02884aa10f2d03a4223306329cd8
Reviewed-on: https://gerrit.libreoffice.org/3647
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
Tested-by: Miklos Vajna <vmiklos@suse.cz>
This was actually meant for idls, not headers :-) And it is obsolete, as
we do not deliver these to $(OUTDIR) anymore. We use explicit include
paths into $(SRCDIR) instead.
Change-Id: Iccb0dc529a99be59390f032fc331996146829abb
Change-Id: I389569b027a900f42e43762c5685ec239bc4b565
Reviewed-on: https://gerrit.libreoffice.org/3646
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
The creation of the UNO shape in SdrObject::getUnoShape is influenced
by pPage, so when the page changes we need to discard the cached UNO
shape so that a new one will be created with the new page.
This replaces my first shot at a fix for fdo#60910 which reinstated a
line to discard the custom shape engine (and consequently the UNO shape) in
SdrObjCustomShape::InvalidateRenderGeometry. That worked but did more
discarding than was necessary.
Change-Id: I665fb6f9e1563bbc4eced046f027a53991a7e45f
Reviewed-on: https://gerrit.libreoffice.org/3642
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
