All callers use the default of `true` for the
`bTraverseParentPath` param since
Change-Id: I88fe0e6ec9bb693710e3f7ab0c6c2e46686be720
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Mon Dec 2 03:28:50 2024 +0100
sc a11y: Don't suppress a11y events when setting new pos
, so simplify this by dropping the param altogether.
Change-Id: If47333f096d31afc3fb2c57dcc03d8e342ae4aa5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177640
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Don't suppress a11y events when setting the new
position string in the combobox in Calc's formula
toolbar.
Suppressing events was added in
commit 38fe580341
Author: Malte Timmermann [mt] <malte.timmermann@oracle.com>
Date: Thu Jan 20 16:34:26 2011 +0100
accfixes: added more accessibility information and fixed tab orders in multiple dialogs (sc module)
for unclear reasons.
The only potential reason I can come up with could be
to avoid announcement by screen readers, but they
usually don't announce text/value changes to non-focused
controls anyway, and neither Orca on Linux nor NVDA
on Windows announcement changed with this change in place
when moving focus between cells in Calc.
Without this change in place, having the combobox's
"text" child selected in Accerciser's treeview
of LO's a11y hierarchy, the text shown in the "Text"
interface section would not automatically update to display
the newly selected location due to the missing
event when using the qt6 VCL plugin. With this change in
place, it is updated as expected.
Change-Id: I88fe0e6ec9bb693710e3f7ab0c6c2e46686be720
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177638
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Controls/shapes and images/objects have a display option in tools/options/
Writer/View and in print dialog there is "Form controls" and
"Images and other graphic objects". With this change the options
will actually be applied again.
Change-Id: I52389a8519d863792a7cd126a95a389c90c05a5e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171905
Tested-by: Jenkins
Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
(make from 5 existing only one)
Much of what makes up this patch is adapted from existing code that is
used to organize and select macros and to assign macros to shortcut
keys. Comments in the patch say where code is borrowed from.
Known issues:
+ Scripting framework library rename for BeanShell, Java, and JavaScript
always returns fail when there are no macro entries in the library even
though it actually succeeds. The same thing happens using
SvxScriptOrgDialog::renameEntry.
+ Deleting Basic macros from the Macro Manager dialog is not implemented
yet.
Change-Id: If4da04549f8b39675910cbbd1f94dd9a6b73c31a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176254
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
mergelibs have been added to the LibreOfficeMacOSX distro config in
e6e22bee15, but AppleRemote has been
disabled in the sandboxing case since 2013
4fe9ef81aa "The AppleRemote code is
blocked by sandboxing so bypass it in that case"
(unclear to me whether fundamentally not working or whether it was
disabled to get sandboxing as a whole in a working state quickly, since
there was an earlier entitlement for mac.remotecontrols)
Change-Id: I8514319b1d9ffa3a993267eaebac0c2ff058740f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177621
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
the intl data for firebird has been added with
07cc2fdc3d (and the associated config file
later moved to Resources with dfa78d2eac)
Change-Id: I4fe666076c42bae21b371fe0ea9495ebc915bd21
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177617
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
its an out only param, not in-out
Change-Id: I4e969bf06bed41a7e04497880f8ea51a3f784feb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177612
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
* Update translations from branch 'master'
to 685db476dad288f6635917ae0ca05d5369c64c15
- update translations for master / 25.2
and force-fix errors using pocheck
Change-Id: Iad27f4c2f514466569dcb982849dee099b6c77d7
For some reason, SfxLibrary's own interfaces were used outside of
WeakComponentImplHelper; and derived classes didn't use inheritance
helper.
Change-Id: Ib0b6cf5cfa559fe5eedc4d05247655aca1bfc4b8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177607
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
it's there to speed up later read of it, but in normal situations we
shouldn't use it anymore IIUC
Change-Id: Ia075e32cd4820729b341d4d47dbfb9126a363559
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177601
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
DocBookTemplate.ott
Simply copy makefile of extra/templates
fix bug tdf#161930: mimetype is zipped only once
Modifications to DocBookTemplate.stw:
- change fonts to bundled fonts: Liberation Serif, Noto Sans CJK, Noto Sans Devanagari
(not so useful as used fonts are defined in
docbooktosoffheadings.xsl and sofftodocbookheadings.xsl)
- remove language and country tags
- remove page size
- remove writing mode tags
- remove content.xml
- remove meta.xml
- simplify settings.xml
- remove unused namespaces
Change-Id: Ic2a2284c3d890b8a6b7b4e29bdab18c33d40dcee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174847
Tested-by: Jenkins
Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Having a map, two vectors, and a counter for what is a job for a single
map is a bit too much.
Change-Id: I50d29f03a2463e6f63ed8e645c36b4c77aa1413a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177604
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
The extra complexity was introduced for #i94994# in commit
3266965986 (CWS-TOOLING: integrate CWS
ab61, 2009-02-11).
Change-Id: If5a69984e3c2c963d4eea2824373fbf1e8a47fef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177603
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Declare support for the "Insert Breaks" dialog that
can be triggered using the "Insert" -> "More Breaks" ->
"Manual Break" menu entry in Writer.
This means that native Qt widgets are used for that dialog
now when using the qt5 or qt6 VCL plugin and starting LO with
environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
Change-Id: I338b017d082532a831168f1c6d0e3e5147e04a39
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177599
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Declare support for the "Split Table" dialog that
can be triggered using the "Table" -> "Split Table"
menu entry in Writer while the cursor is inside of a
table cell.
This means that native Qt widgets are used for that dialog
now when using the qt5 or qt6 VCL plugin and starting LO with
environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
Change-Id: Iae4855027de533ff7f9a4148f8101a56c281abcf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177598
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Declare support for the "Split Cells" dialog that
can e.g. be triggered using the "Table" -> "Split Cells"
menu entry in Writer while the cursor is inside of a
table cell.
This means that native Qt widgets are used for that dialog
now when using the qt5 or qt6 VCL plugin and starting LO with
environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set.
Change-Id: I5b994698ea46e9ede763169d21fe53527b3b369b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177597
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Fix bad condition with ++std::npos in the following !WithChildren
inline heading branch:
else if( pOutlNdsInline && ++nEndPosInline < pOutlNdsInline->size() )
The problem was reported by Caolán McNamara.
Remove also an unused variable in docnum.cxx.
Follow-up to commit 32398232e9
"tdf#164074 sw inline heading: add up/down outline moving".
Change-Id: I61d75451adeb13fe8e74ce586c4668a8caf0105b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177580
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
Use an internal property for that, alowing to pass the option from the
import site to SdrOle2Obj::AddOwnLightClient. Maybe there is some more
proper way to do this, but I couldn't find it.
Change-Id: I74c881c5c35689a7b58d44d8d65c1010d202c98d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177586
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
This is similar to
Change-Id: Id0cd9ca29ee0cbd638f90a32434b1ce6b4200e6b
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Sat Nov 30 10:24:30 2024 +0100
tdf#130857 VclBuilder: Deduplicate extract* methods returning bool
, but for methods extracting an OUString value instead
of a bool one.
Change-Id: Ic90ac0c630ee7454b8a7fa4f34383f8635d21ff3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177585
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Add new `extractBoolEntry` helper that takes the
map, key and a default value to return if the
map doesn't contain the key.
Use that new helper to deduplicate the various
methods implementing the same logic over and over
again.
Change-Id: Id0cd9ca29ee0cbd638f90a32434b1ce6b4200e6b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177584
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Before
commit 2e509b886f
Date: Sun Jun 12 17:42:05 2022 +0200
Convert ImplWindowStateFromStr to WindowData(str)
, `rData` was a method param for ImplWindowStateFromStr.
Now, using it instead of just using `this` is
unnecessary.
Change-Id: I7974161990375e44d4d78097e49a9f42e118bcce
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177579
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
That was apparently forgotten in
commit 0a4ec73c23
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Fri Oct 25 10:04:10 2024 +0200
tdf#130857 qt weld: Add a QtInstanceFrame
and none of the dialogs declared as supported this
far was actually calling any method making use
of it, as that would have triggered nullptr
dereference.
(Seen now while experimenting with adding support for
the "Search and Replace" dialog.)
Change-Id: I84ec83f4d4af8b2828e5033f366037b3114629d0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177578
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
None of the weld::Box methods are used, so having a pointer
to the weld::Container subclass is sufficient in the
"Find and Replace" dialog implementation.
Change-Id: I1219dd657ab8fb6067c90aabdc27b2b84c0a1443
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177577
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
