if we truly want it to be modeless, then unset this bit and use
the runAsync mechanism
Change-Id: I7d1cae1975d6ac20ef34b7744981ee72b9f52c78
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109540
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
It has grown recently and is going to grow more.
cfgitem.hxx has been moved and clangformated because it is not anymore in excludelist
Change-Id: I277837b2c0a90ae4e84028dc6e19962939c1aef3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108645
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
If there is no param info for formal paramter then type of formal parameter and actual parameter will be same
and there is no need to set the flag in that case.
Change-Id: I12af64f82fc5b2d6d7fb920bde1cb96f8c7bd51b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109070
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
was made public in
commit d487d6e082
rework Color to have R,G,B,A public variables
but it's best to keep them private since we're changing the internal
representation - and there is surprisingly little that depends
on accessing the internals anyhow.
Change-Id: I234d80fb33105f7bf5b865fb7c8194d893b09878
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109508
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
The second GetNextNode() was a nullptr
that was being dereferenced.
Now, when enter is pressed after some text followed by a colon,
that line is made into a heading3, and the new blank line is
properly using the text body paragraph style.
Change-Id: If10dc85e490ac57fc150b3d541f5033dfd5293bb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109413
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
* Update helpcontent2 from branch 'master'
to 02621d694b83cc0fa710cbf110f8262967360402
- update Load Styles and related help pages to "Load Styles from Template"
https://gerrit.libreoffice.org/c/core/+/109006 changed the label of
the command "Load Styles" to "Load Styles from Template" and changed
the some labels in the dialog box. This patch updates all help pages
that were affected by that change, and takes the opportunity to
review these pages and make small improvements where needed.
( swriter/00/00000405.xhp )
* update menu labels
* replace German id "vorlagenladen" -> "loadstyles"
( swriter/00/stylesmenu.xhp )
* update menu labels for "Load Styles", "Update Selecte Style"
and "New Style from Selection"
* update to <menuitem> and <keycode>, only for modified paragraphs
( swriter/01/05140000.xhp )
* update menu labels
( swriter/01/05170000.xhp )
* update menu labels
* replace German id "vorlagenladen" -> "loadstyles"
and "vorlagentext" -> "styles_text" (which does not seem
to be used anywhere else)
( swriter/guide/load_styles.xhp )
* update to <h1>
( swriter/main0115.xhp )
* update menu labels
Change-Id: I779b2644195f3f6cdc00743c7577875e3e198902
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/109289
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
ForceImportWWFieldsAsGenericFields is set. Not sure what restrictions it
needs.
Change-Id: I8b8e61fb320d5c2b66d5ff332517759b53e68817
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109378
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
all these widgets are visible so it makes no difference in this dialog
Change-Id: I05e15a584f5020343fcc05b1c28bc9cef71f15c8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109486
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
This patch makes the Navigation (navigationobjectbar) toolbar reappear
when Writer is started if it was displayed in the toolbar layout when
Writer was ended.
Change-Id: I71ddf85daf98720f7c5fd29462d1a2bcb48114d8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109503
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Instead of filling the document model tree with fill* methods,
refactor that to use objects that are attached (via get_id) to the
tree nodes directly. For this introduce DocumentModelTreeEntry
and subclasses, which implement what the current UNO object is
that is being shown for a tree node and a "fill" virtual method,
which is used to fill the child nodes of the tree when expanding
a tree node.
This makes the code much easier to work with and in addition it
makes it possible to have all the tree nodes to fill the content
on demand when expanded.
Change-Id: Id5a027e060af90e483181439568f17d0172d1b35
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109500
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Using Navigate-by to move through the recency stack sets the writer
shell to standard mode before navigation. Navigation using the Back and
Forward navigation controls does not. This results in incorrect
behaviour when a drawing object is selected and navigation is attempted.
This patch sets writer shell to standard mode before recency navigation
is done using .uno:NavigateBack and .uno:NavigateForward.
Change-Id: If05883e8188452736cfedac9153bcc91422bf7e8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109504
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
This introduces DocumentModelTreeHandler which is used to handle
the left-side document model tree. This makes it easier to track
how the tree is populated and handled by encapsulation.
Change-Id: I0c11d8012d149c6f4ce9a5067a8c368fb794efe1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109498
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
The macOS-specific code is nowadays compiled in Library_vclplug_osx.mk
so these macros that listed files compiled both for iOS and macOS were
used only for iOS in this makefile anyway.
Change-Id: I607ce0bd8834b81caff664f28419e50e87af87f8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109484
Tested-by: Tor Lillqvist <tml@collabora.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Make vcl compile again for iOS and make the Collabora Office iOS app
work again when built against a master build of core.
For now, keep the old versions of the functions touched by
1a16762531 in vcl/ios/salios.cxx, and
move the modified versions to the new file vcl/osx/salmacos.cxx.
Keep the functions as they were except that ifdefs for MACOSX or IOS
are expanded. Keep the formatting as it was to make comparisons
easier. Thus add the new files to the clang-format exclusion list.
While at it, also move vcl/quartz/salgdiutils.cxx to vcl/osx as it is
compiled only for macOS anyway.
Change-Id: I990ef678f2263031d4a5af8cc547fffe185d17c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109480
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Starting with macOS Big Sur, coloring has changed. Currently there is
no documentation which system color should be used for selected tab
text. As a workaround text color is changed for macOS Big Sur and
newer only.
Change-Id: I2e8c83527775c17f95e5e4afe70577442e14715e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109479
Tested-by: Tor Lillqvist <tml@collabora.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
(1) Remove hack to make application look as if being linked against SDK 10.13
(2) Use quad storage size on virtual devices for displaying on retina displays thereafter
(3) Apply workaround to downsample bitmaps from scaled layers (to be implemented)
(4) Disable dark mode (to be implemented)
(5) Provide new environment variables:
VCL_MACOS_FORCE_WINDOW_SCALING:
window scaling on non retina displays
VCL_MACOS_FORCE_DARK_MODE:
enable dark mode (macOS 10.14, iOS 13 and newer)
VCL_MACOS_USE_SYSTEM_APPEARANCE:
use light mode or dark mode (macOS 10.14, iOS 13 and newer) as configured by system preferences
Change-Id: I99877cd62a98cb91bcbf27af62b043c31c5f5fc9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109072
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
I don't know if it can happen or if it's a false positive
but at least, we're sure now it won't fail
Change-Id: Id4620d74c0893b308b9fb45be71ca6c425066ae4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109470
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
by using std::max<tools::Long> and std::min<tools::Long>
Change-Id: I07c93227cf040f159d1977ca94988169ecd6dc14
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109464
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
