Rather than silently returning only the first (left) part of the
UNION, error out.
Change-Id: I6ed1eba55ad33f149d9010933a3c7a835fce0451
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113207
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Lionel Mamane <lionel@mamane.lu>
Tested-by: Jenkins
* Update helpcontent2 from branch 'master'
to 938d18980a672859c4e9b754df10bf18fa6b1cd4
- Revert "tdf#137715 add "note" to AVERAGE, SUMSQ, PRODUCT in Calc function help"
This reverts commit 11e69d34205bf773f2aa4f4be5c8fa08566ed7d7.
Reason for revert: A new, better solution is found for adding a
note to these functions that avoids retranslation and avoids technical
problems with <embedvar>. That solution will be used in a new patch
for these functions.
Change-Id: I614eb2020b77715b5785ad3a2934cc359f0b8ef9
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/113214
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
* Update helpcontent2 from branch 'master'
to 4de9606186a78818a49c1f8d687b30d0e09fda9b
- tdf#137715 add "note" to DateSequence functions about text in range
+ add generic <note> in scalc/01/common_func.xhp about text
in data ranges, which can be used for all functions that
can be affected by this problem.
+ embed this note for all relevant DateSequence functions.
Change-Id: If1c245d70f2b4aa464c50e502eed387b1d39f081
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/113129
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
instead of blindly assuming a SELECT is not a UNION, leading to an
out-of-bounds array access when it is.
Change-Id: I8f904ae65acba8d8ee23b95299058207af68c0ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113189
Reviewed-by: Lionel Mamane <lionel@mamane.lu>
Tested-by: Jenkins
* Update helpcontent2 from branch 'master'
to 11e69d34205bf773f2aa4f4be5c8fa08566ed7d7
- tdf#137715 add "note" to AVERAGE, SUMSQ, PRODUCT in Calc function help
( scalc/01/04060106.xhp )
+ add two variables "ignores" and "look" to <tip> in SUM
+ use two new variables to compose similar tip for
"PRODUCT" and "SUMSQ"
( scalc/01/04060184.xhp )
+ use two new variables to compose similar tip for AVERAGE
Change-Id: Id6fd2f38a3f3d7c381b3efe99a98303a81e0c1d6
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/105535
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
* added tooltips to tabs that did not have them and
adapted existing one to the fact that this is a style
dialog, and the tabs must be understood in relation to
editing a list style.
Change-Id: I316f8c4cc2e486476334c703916b5851905169fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111776
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
- shows different image for each selection mode
- tooltip indicates the current selection mode and mouse click hint
- replaces left-click cycle selection mode with context menu popup
Change-Id: Ieb2662de99cf42d4ada4c1a590bebc8363861c7b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112367
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
by selecting to the start of the next outline node vs selecting to end
of the last paragraph before the next outline node.
Change-Id: I5a51ff5c1ced8d9ab0aee7c7b38fc5235027f384
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113140
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Give them a separate type at a UI level, so later a file picker can be
shown for the local file case.
Change-Id: If0ed639ea3d196da70fded6d1eb606f1ef4f2082
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113161
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
Full support of the session class methods from Python
The InvokeSimpleScript() python method has been
extended to support broader scopes (extensions and user documents)
and ParamArray arguments in Basic.
Indeed the SF_Session.ExecuteBasicScript() and
SF_Session.ExecuteCalcFunction() require a varying number
of arguments.
No regression found in unit tests
Change-Id: I0899bc6535b00340ed82b46336d60a7bb23b2098
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113154
Tested-by: Jean-Pierre Ledure <jp@ledure.be>
Tested-by: Jenkins
Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
if rotated by 90 or 270 degrees using clipping to
cell boundaries, like MSO does. E.g. this avoid of
importing MSO documents with unreadable header cells.
Note: it's possible to improve the patch extending
clipping for the neighboring empty area instead of
clipping all text exceeding the cell boundary
(as in the case of the non-rotated, non-wrapped text).
Co-authored-by: Attila Szűcs (NISZ)
Change-Id: Idd37f7eb7208ff3818dcdab93ef0ec57275db954
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111964
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
This triggered an assert in VclBuilder where it expects a weld::Box
and not weld::Grid when accessing the root.
Change-Id: Ifc0d7c7e8d52c5383aecd9814329e10bf55e6c89
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113151
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Writer used to dump the same image file as many times
as it was featured in different headers or footers in
the document, bloating the .docx file size.
This is countered by making all "relationships" in the
header*.xml.rels files point to the same image.
Change-Id: I44d72630289c721d58d8f7e208517df2f1fe621c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112656
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
keep continuing on a short read, zeroing out the rest of the block, if
something was read, but give up if nothing could be read.
vcl/qa/cppunit/graphicfilter/data/png/pass/invalid-chunk.png remains
working after this. Though to be honest it is also unchanged if
we just png_error intead of png_warning
Change-Id: I7dc24bcfc0b33e534a3f9665b11cd9aca8003a89
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113152
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
so we can use a more natural syntax than "!!"
Change-Id: I8152a0d3ce37115fc83d332a26725ca1d28d959a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113147
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
it's wrong since it was introduced in 12c95935f2
$SC_FORCE_CALCULATION to force Calc use opencl/threads for everything
See sc/source/core/tool/calcconfig.cxx:39
Change-Id: I5569e220059d66a4bf71ec267cae603810c066c1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113149
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
Tested-by: Jenkins
Steps to reproduce the problem:
1) double-click on a bibliography entry field -> edit bibliography entry
dialog appears
2) click on "edit" button -> define bibliography entry sub-dialog
appears
3) change e.g. the URL there -> OK -> sub-dialog closes
4) click "close" -> outer dialog closes
And now the user is confused, because the field is not updated. This
works as expected if "apply" is pressed instead of "close".
This happens because the SwAuthMarkModalDlg that hosts the
SwAuthorMarkPane can be in insert or edit mode. The inner dialog just
updates in-memory state outside the doc model. This makes sense in
insert mode, so the user can fine-tune where to insert the field; but
a separate "apply" step in edit mode makes little sense.
Fix the problem by automatically applying the changed values in edit
mode.
Change-Id: I333225328d103f160f8120a2abc7a264322437a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113146
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
The code was introduced in 627c246984
< tdf#96674 drawingML import: fix handling of zero width/height lines >
and later on removed by 36bade04d3
< tdf106792 Get rid of SvxShapePolyPolygonBezier > with the comment
"I doubt that the additional code to make a line not exactly hor/ver is needed.
Checked and it is not needed, thus removed the change from
tdf#96674 in shape.cxx."
it turned out, it's still needed
Change-Id: Ib64ee17227e3e588e94381abeabe5a2ff2e0b7d1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113102
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Both sw/ and xmloff/ can depend on test/, so no need to duplicate this.
Change-Id: I93bfdb4422bdef9f8d28bc37548130fae49829e9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113107
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Just use 1-bit or 8-bit instead.
Change-Id: If3b4f82caf9a851741e7e8938a019a3bd21665e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113139
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Change BitmapColorQuantizationFilter to use only 8-bit palette
bitmap as result of the filter.
Change-Id: I9c7226288166bcf1769059a2dff81830cf26adc6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113138
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
This removes writing 4-bit palette bitmaps when writing to the
BMP format and reading from a 4-bit BMP uses 8-bit palette
instead.
This also changes the tests with the new expectations, but at
the same time it makes sure old BMP files and SVM files are still
compatible.
Change-Id: Ia5611a1f36ffa0a27ef5973296674f743fe80f65
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113137
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Use 8-bit palette instead of 4-bit when reading from XPM. Modify
the test to expect bit-count 8.
Change-Id: I7b8e8254ad58cdda0829baea75809aa8596090e5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113134
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
