and not when previewing another document, which sidesteps the
infinite loop in this example
Change-Id: Ideb41029f4c98a50555cd35227867d9fdd5ae5a4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96977
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Avoids: implicit declaration of function 'getopt' is invalid in C99
[-Werror,-Wimplicit-function-declaration].
Change-Id: Ic178f53d1002425df52e220b1723fb12edca13df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96910
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Abandoned <b9ecec7c74687ed5a9470cffb7d02e0e6e83107e> "Don't call out to UNO with
SolarMutex locked" documents a deadlock where a synchronous
documentEventOccurred call made with SolarMutex locked evokes an asynchronous
release call back (serviced on a different physical thread, but which blocks the
original thread) that then wants to acquire the SolarMutex. While we usually
appear to get away with wrapping those UNO calls in SolarMutexReleaser (though
knowing all too well that that is nothing but a bad hack that may well cause
crashes and deadlocks at least in theory), the place in
SfxBaseModel::postEvent_Impl was obviously too sensitive for that hack: It did
cause enough different crashes (e.g., hitting
assert(pSchedulerData == pMostUrgent);
in Scheduler::ProcessTaskScheduling, vcl/source/app/scheduler.cxx) and deadlocks
(e.g., different threads now taking the SolarMutex and JobExecutor's mutex in
framework/source/jobs/jobexecutor.cxx in different orders) to make me search for
a different "fix", so I came up with this hack instead.
Change-Id: Icd26926279cb86ce529edb4544a3ec0bc9a8b108
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96946
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
using UNO API RelativeWidthRelation and the associated
lo-ext attribute for OpenDocument export.
See commit 43d7f4e364
(offapi: document the 4 new properties which are no longer read-only).
Co-authored-by: Balázs Regényi
Change-Id: I2dada8ad764a1fba33d241117cc4bc5eddae74ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95525
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
On some machines (depending on fonts installed) creation
of SwBulletPortion with bullet = \0 leads to drawing
a bullet as a empty rectangle.
Change-Id: I2826944f2278e8c9a6c740b11b69d2e4e5108158
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96711
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
* Update helpcontent2 from branch 'master'
to 47b0c69b0a1cefe027366d6e01f4f14470edaa2f
- Update CSS box colors to match new Colibre
Change-Id: I5ed9fdcad79fc34032e6c8d1536aaaf12d32e177
- show the undo manager's node array
- show SwUndoDelete
- show SwUndoSaveContent
- show SwHistory
- show SwHistoryHint
- show SwHistoryTextFlyCnt
- show SwUndoFlyBase
- show SwHistorySetFormat
- show SwUndoInserts
When an action + undo pair goes wrong, it's easier to see the state of
the undo stack after the action this way, then decide if the undo stack
is already bad, or the problem is with the undo implementation.
Change-Id: Ic509a233dce3c47db9697982eb7ea423f4706129
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96930
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
as a step towards using tools::JsonWriter for DumpAsPropertyTree
Since this method is only used by the LOK stuff, we can just
remove the node down at the generation site in vcl::Window
Change-Id: I1b3b9a0732dcdb18267cb56e545a30c8f56b4ae2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96839
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
reserve inside a loop is a pessimization, since it breaks the
logarithmic resizing of the std::vector data area.
Also use the std::vector::insert method, instead of std::copy, since
the insert method will perform less resizing operations.
On my machine, this takes the sort operation from 25s to less than 1s.
Change-Id: I30b99d42c56abc5a4ad5c133c7579fac3952173c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96929
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
so split it into the bit that is needed and just include that.
add missing license headers
Change-Id: I875f91176e6881e830fee6a58368d0b28ce9a0f7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96774
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Instead of hiding it, show hanging first paragraph
line in narrow table cells, like MSO does.
Change-Id: Ibfa7242644db36c1be4d2fe93af75cb295d443b4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96865
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
Regression from commit 74844277cc (disable
generation of ole previews in ODF format until after load, 2016-09-13),
if the document has charts without previews, it's loaded, fields are
updated and saved, we no longer generate those previews.
Given that Tools -> Update -> Update all is always an explicit user
action, restore the permission to update OLE previews / links before
performing the actual update.
With this, comphelper::EmbeddedObjectContainer::StoreAsChildren() will
generate those missing previews inside the getUserAllowsLinkUpdate()
conditional block.
Change-Id: Ib54e06a2e2f2e1c65951fdec302e59e63c71d008
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96928
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
sharing a single widget between multiple notebook pages isn't
going to work with native notebooks, so replace with a row
of toggle buttons
Change-Id: Ic24632f6d94d9238423f8b5e61d5e945c98e4a3b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96891
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Regression from commit ed654c4aa7 (Revert
"fdo#43869 use the old rtf importer for paste", 2012-11-30), the direct
problem is that SwXText::insertTextPortion() is now used by
writerfilter, so in case it's not as good as the internal API used by
the old RTF filter, we have a problem.
This function calls SwXCell::CreateCursor(), which calls
SwXCell::createTextCursor(), which uses Move() to go to the first
content node in the cell, but that means we end up at the inner cell's
XText for an outer cell.
So later when we want to go to the end of the outer cell, we can't, as
that would be a different XText and we throw an exception.
Fix the problem by instead using createTextCursorByRange(), which
immediately positions the cursor at the insert position, so the XText
will be correct.
FWIW, the ODF import at SwXMLImport::setTextInsertMode() also uses
createTextCursorByRange() to handle this situation.
Change-Id: I1db13b860bc60771d98c2b4099be73f4bf41c375
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96901
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Move those data members and functions in GalleryTheme that deal with reading
and writing of binary files to the new class GalleryBinaryEngine. These
internal changes must not reflect any change in the behaviour.
Functions moved in this patch: ImplReadSgaObject(), ImplWrite(),
ImplCreateUniqueURL()
Change-Id: Ifd30bc7920f31007dfe7fe2ffdc539dfc43976ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96541
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
* Update helpcontent2 from branch 'master'
to 540b892df6e000c75dd0a9dacc50a06ea48a3182
- Review Area tab called by many modules.
Change-Id: I9afa69a68c538647d4643e9b68077c97ff4eb079
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/96900
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
This code apparently expected that bitmaps are initialized with
the first color in the palette, but that's not guaranteed to be
the case (fails at least with Skia and X11 'gen' bitmaps).
Change-Id: Ie4f7412e0a6c4c1110fc5fbb8ab5bed3c96f652f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96864
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
There is no /usr/bin/python3 on those. With a current Xcode, it is the
python3 that comes with Xcode that /usr/bin/python3 runs anyway.
Change-Id: Iaee3d030337d6dfc37b67852a492b054fb4b9fee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96062
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96858
Tested-by: Jenkins
* Update helpcontent2 from branch 'master'
to a9324f47d6240144e8023079435b7f36bc0a9703
- Fix backgound color page after translator review
Special thanks to Mihkel Tonnov.
Change-Id: If0ef8d7aa9ca076937330f86f1cfaf8f5ec40f32
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/96849
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Calc's dependency check done before parallel formula cell group
calculation tries to ensure valid cell values for all the dependencies
of the group's cell, and if it detects a problem such as a cycle
it bails out. But since ScFormulaCell::Interpret() simply bailed out
without doing anything, other cells could use that cell's possibly
incorrect value for their calculation and get their dirty flag reset.
This fix adds a flag to mark that bailing out is in progress, which
ensures the bail-out is short-circuited and no cell values are set.
Change-Id: Ia93c70d456682e19ce533abd2cf65ce35ffed9ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96838
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
Tested-by: Jenkins