Commit graph

451109 commits

Author SHA1 Message Date
Caolán McNamara
d1069a583d cid#1401342 Uncaught exception
Change-Id: Ia22ed8541f1148355d71cd5b90ad13e64c1b50c2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97289
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-27 21:47:11 +02:00
Rizal Muttaqin
22bacc8205 elementary: tdf#133538 add White Space icons
- Add Calc's Fill icons

Change-Id: I4b099359f2dfd1a90be77b5eb03e4f3a932d99a1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97316
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-06-27 21:45:46 +02:00
Caolán McNamara
ae1b0875b2 cid#1464973 & cid#1464975 Resource leak
Change-Id: I4df8fefa7f875e0a25585c4fef22f077dcd0b83d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97318
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-27 20:25:10 +02:00
Caolán McNamara
acb71f8382 cid#1464972 Unchecked dynamic_cast
Change-Id: If40ee310e0a16af7ce93a5f93e2b436069aa153a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97317
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-27 20:24:05 +02:00
Caolán McNamara
877ca303e6 cid#1464971 Dereference null return value
Change-Id: Id0f6aec4552e551d3ba697bb4a3c9b0e498fdf24
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97315
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-27 20:23:32 +02:00
Caolán McNamara
122ce7b090 cid#1464968 Logically dead code
added in...

commit 99c4fefdbb
Date:   Wed Apr 22 11:43:22 2020 +0300

    tdf#98409 doc export: export (non-default) cell margins

Change-Id: Ie6bf4f16f73eb4d6b604e7c98ee61b388e9acd27
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97312
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-27 20:23:11 +02:00
Caolán McNamara
bd02918f77 cid#1464970 Unchecked dynamic_cast
Change-Id: I9190065a88defe9165ac79a0339a6a510b0903d8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97314
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-27 20:22:45 +02:00
Caolán McNamara
2a87fbc2f6 cid#1464966 Logically dead code
since...

commit d6c7fbe28a
Date:   Wed May 20 14:23:51 2020 +0200

    [API CHANGE] officecfg,xmloff: remove SaveBackwardCompatibleODF

Change-Id: I05db7083262d02aa051372773fc6ef60c1549b8f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97311
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-27 20:22:11 +02:00
Caolán McNamara
a211032bf9 cid#1464969 Unchecked return value
Change-Id: I74c1f2d3e45222be7357e0ded70beeb5437ff892
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97313
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-27 18:03:44 +02:00
Caolán McNamara
91c97cbcd5 cid#1464965 Logically dead code
since...

commit d6c7fbe28a
Date:   Wed May 20 14:23:51 2020 +0200

    [API CHANGE] officecfg,xmloff: remove SaveBackwardCompatibleODF

Change-Id: Idbe785a2426adf3288a3ba27e065a7ddd8d9406f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97310
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-27 17:54:44 +02:00
Julien Nabet
d9438b8d00 cid#1464973: RESOURCE_LEAK (sc/excel)
Change-Id: I923788f57e022c99a89a6406cf3ed02066efd022
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97279
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-27 17:16:12 +02:00
Julien Nabet
d072f33fd6 cid#1464963: Null pointer dereferences (sw/wrtww8)
Change-Id: Iea4b91b440c87a8a193a3c6b683a017d0948399c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97281
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-27 16:34:43 +02:00
Julien Nabet
a81bc97c2b cid#1464967: RESOURCE_LEAK (sw/wrtww8)
Change-Id: Ic1aa0d42f174808c7700875cb31f1c726b3160e9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97280
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-27 16:33:23 +02:00
Julien Nabet
04ca5efc80 cid#1464974: Null pointer dereferences (sw/unosett)
Change-Id: I4ea6de59ce1d1cb3133b0fb57176caee5497878f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97276
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-27 16:27:13 +02:00
Julien Nabet
7e8e53bb6a cid#1464975: RESOURCE_LEAK (sd/sdpptwrp)
Change-Id: Icb8a1add327e7b11b4095c1e3f60cddf2ea0f5c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97275
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-27 16:24:36 +02:00
Caolán McNamara
76df547f17 map has-frame to WB_BORDER
Change-Id: I3f0aeceb3015bb09d6b82a631f3b001f9061d090
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97265
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-27 16:18:28 +02:00
Caolán McNamara
ca9b3ace07 those properties should use - not _
Change-Id: Ifae279b7ffd50cd7f977e0b03a9207355a9304a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97264
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-27 16:17:03 +02:00
Tomaž Vajngerl
1bb9280d0e drawinglayer: pragma once for fontattribute.hxx
Change-Id: I1d257a34b15a65d9b988a791e154ee64e781e0ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97284
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-27 16:00:22 +02:00
Rizal Muttaqin
0899795719 Breeze: tdf#133538, tdf#126122, tdf#70102
- tdf#133538: Add Show White Space icons
- tdf#126122: Differentiate icons for Promote and Indent
- tdf#70102: Add RTL support for outline & numbering
- Add Calc's Fill icons

Change-Id: I16757a199852f544b4c32a011205dea483e7606f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97282
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-06-27 15:42:14 +02:00
Srijan Bhatia
e13ba48c7f tdf#90978 add exit button to impress presenter console
Change-Id: If8a5226d700eb7a4137218191b5abc85bbb36b4d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97041
Tested-by: Jenkins
Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-06-27 12:01:23 +02:00
Luboš Luňák
e318e4cea3 do not use VCL scaling algorithm from Skia
The only threaded one is "Super" (i.e. the default one), and Skia
at a comparable quality seems to perform better. And the code is
simpler too.

Change-Id: I366197fe1a033c1f7a5f5c7f9fdcc00bff74dc11
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97278
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-06-27 10:43:54 +02:00
Luboš Luňák
0a890e9cbd properly copy pending scale quality in SkiaSalBitmap
EnsureBitmapData() was using Create() to make a copy of the bitmap
to scale, but the quality was not copied, so it was usually
at the default (and slowest) high quality.

Change-Id: I7100304a935db420e2d55c2a9450016be1195965
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97277
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-06-27 10:43:16 +02:00
Luboš Luňák
172b914219 cache raster scaling also in Skia's drawAlphaBitmap()
Change-Id: I52849097267326cb362b113241179a766d286a6b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97273
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-06-27 10:16:08 +02:00
Luboš Luňák
92de6c794e use boost::make_shared_noinit()
The unnecessary initialization of all elements with plain
boost::make_shared() actually shows up in the profiler.

Change-Id: I054b13ac74362aca7f2dfa7dc746d3a80c7f1042
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97267
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-06-27 10:15:32 +02:00
Rizal Muttaqin
2b7861dd23 Colibre: tdf#133538: icons for Show White Space
Change-Id: I757696ece0b06cdd91358ea8944ba5cc49a644d0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97274
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-06-27 09:49:57 +02:00
László Németh
076c95b27b AutoCorrect: fix redundant loading
of new localized options added by
commit da64ec8c8a
(tdf#133589 AutoCorrect: transliterate to Old Hungarian)
and commit 77b213890a
(tdf#133524 add option to angle quote AutoCorrect)

Change-Id: I39f97cfc5a9deb7cbe92d175b2e59ba2ab8a2707
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97266
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-27 09:11:42 +02:00
Rizal Muttaqin
4842d8f51f Karasa Jaga: tdf#133753, tdf#133582, tdf#106229
- tdf#133753: "Base point" image in "Position and Size" dialog
- tdf#133582: checkbox and radio for gen env
- tdf#106229: Infobar Success type

Change-Id: I4253c6737af17273043cf6941f426b89b8b74ecf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97270
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-06-27 06:04:13 +02:00
Caolán McNamara
e54ff4c1c9 update some pches
Change-Id: I54b734062d94a59c2651827c02349d9562ac6cf9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97262
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-26 22:10:36 +02:00
Xisco Fauli
17c2bd87e9 tdf#103734: sc: Add unittest
Change-Id: Iffc31232e58e0beb6c24f09ef2406c72fa502c00
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97261
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-26 21:11:05 +02:00
Caolán McNamara
a4eebe2cf6 drop unnecessary include
Change-Id: I8d0dd93a2bcf8c4ea1bf1f6a5ed7a866e181127b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97237
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-26 20:37:04 +02:00
Caolán McNamara
dc960e30ee weld FixedTextControl
Change-Id: I0a2983aa4d389aa0e65aa117d576295d02460b4a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97236
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-26 20:36:23 +02:00
Xisco Fauli
ec0554c5ea tdf#118624: sc: Add unittest
Change-Id: I377d64258d1bd93af99284eb7b74e16d7924effd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97260
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-26 20:14:48 +02:00
Alain Romedenne
20479772e9 Update git submodules
* Update helpcontent2 from branch 'master'
  to 7a9ad91c49811550018363ddda12b5d2e5563c42
  - tdf#131416 Enum Basic statement syntax diagram
    
    Change-Id: I7f0ad87f1b7bd678ca46caff518272e6ec5d7928
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/97139
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-06-26 19:37:49 +02:00
Xisco Fauli
d64867aeb2 tdf#127982: sc: Add unittest
Change-Id: I6fc4299012db9094ceec3c8146bfef317c93e3cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97259
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-26 19:35:06 +02:00
Xisco Fauli
9028f048ca UITest_writer_tests7: wait until the child is available (blind fix)
it fails spuriously with

Traceback (most recent call last):
File "sw/qa/uitest/writer_tests7/tdf99711.py", line 43, in test_tdf99711
self.assertEqual(get_state_as_dict(xWriterEdit.getChild('selectwidth'))['Text'], '10.00 mm')
uno.com.sun.star.uno.RuntimeException: Could not find child with id: selectwidth

Change-Id: If80dac67880a1f4200331a7894ba2ecae4504bb2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97184
Tested-by: Jenkins
Tested-by: René Engelhard <rene@debian.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-26 19:33:57 +02:00
Stephan Bergmann
a6862a26d6 tdf#134106: Get rid of XDesktopInternal again
For internal functionality that is not meant to be called by client code, I
think it is appropriate to hide it either via XUnoTunnel (but which would have
been a tad incovenient, as it would have meant to make framework::Desktop in
framework/inc/services/desktop.hxx available to the code in
desktop/source/app/app.cxx), or via reuse of some existing, sufficently fitting
interface (as is done here with css.task.XJob).  This nicely avoids the
backwards compatibilty issue with remote Python scripts, as discussed in
tdf#134106 "Binary URP bridge disposed during call to
ServiceManager.createInstanceWithContext".

Change-Id: Ic9db9401ddf0f6b696344dd1d5c6ad279ea5a832
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97241
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins
2020-06-26 18:52:36 +02:00
Xisco Fauli
389008b049 tdf#129681: sc: Add unittest
Change-Id: I160774b1b3d32fb5521d3f7a184f33922839bb1c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97239
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-26 18:35:39 +02:00
Caolán McNamara
b08292b918 weld FixedImageControl
Change-Id: I13f3480794232a9c203ae047a4fcad372988b8b8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97235
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-26 18:13:10 +02:00
Miklos Vajna
5d29618307 sd signature line: allow move / resize of shape before signing
Once the initial rectangle is drawn, a certificate is attached to this
shape. Allow modifying this shape (and only this one) before the actual
signing, in case the user wants to fine-tune the geometry.

Change-Id: Icdf4ffa99eaf02f81d60884d45c26b3500ea73d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97240
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2020-06-26 17:55:31 +02:00
Luboš Luňák
3d37d59137 use Skia's SkShader for blending bitmaps
It turns out it's sometimes more efficient to use
SkCanvas::drawPaint() with SkShader::Blend() used to blend bitmaps
together, rather than manually creating temporary SkImage
for the blending. This way it saves memory and it also performs
faster e.g. for tdf#134237, where when zoomed it processes only
relevant parts of the images instead of blending a whole enlarged
image).
Sadly in raster mode it is sometimes still faster to cache
the image (e.g. with tdf#134160), so keep the caching there as well,
for when useful.

Change-Id: I887ae330907100c21a0d152783fcd7e8ef230355
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97238
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-06-26 17:42:22 +02:00
Stephan Bergmann
311fe58df8 Improve loplugin:elidestringvar
...by addressing the follow-up TODO mentioned in the commit message of
7a3736f908 "New loplugin:elidestringvar"
(extending it not only to uses with a constant sal_Unicode, but also to uses
with OUStringLiteral).

(All necessary changes have been made in preceding "Upcoming improved
loplugin:elidestringvar" commits.)

Change-Id: Ib0000ef9c4a1dad52124dfd039dd936cf7e3ba3f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97226
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-26 17:31:53 +02:00
Xisco Fauli
0960a8c5ce tdf#130583: sc: Add unittest
Change-Id: I74f2d90f4f9eb17d1833ceedd1598c1439489354
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97222
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-26 17:27:20 +02:00
Caolán McNamara
8f1569568a use underlying BitmapEx
Change-Id: I1ddc5a50a54bb230af1c76a8098c68fdb0495df0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97234
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-26 16:49:07 +02:00
Balazs Varga
f6604dd2cf tdf#134039 Chart view: fix moving pie chart area
Do not allow to move data labels, when we create
data series for the first time, in case of pie or
donut chart, but allow to move when we recreate
data series for pie or donut chart.

Change-Id: If0d61116da1524d15553f8a80453ce2003484d1c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96534
Tested-by: Jenkins
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-26 16:00:44 +02:00
Tor Lillqvist
0ebdd6ebad There is no mysqlc module
Change-Id: I0106f5a86b86e40e97bbaf6918bc77601bd3a7fe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97220
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-06-26 15:56:29 +02:00
Stephan Bergmann
587bd66769 QueueInfo must be VCL_DLLPUBLIC now also for --enable-mergelibs
...after 1a6b0f167d "vcl: split off QueueInfo to
own files" made its member functions non-inline; see e.g.,
<https://ci.libreoffice.org/job/lo_callgrind_linux/8949/>:

> /usr/bin/ld: /home/buildslave/lode/jenkins/workspace/lo_callgrind_linux/workdir/CxxObject/sw/source/ui/dbui/mmresultdialogs.o: in function `SwMMResultPrintDialog::PrinterChangeHdl_Impl(weld::ComboBox&)':
> /home/buildslave/lode/jenkins/workspace/lo_callgrind_linux/sw/source/ui/dbui/mmresultdialogs.cxx:754: undefined reference to `QueueInfo::GetPrinterName() const'
> /usr/bin/ld: /home/buildslave/lode/jenkins/workspace/lo_callgrind_linux/sw/source/ui/dbui/mmresultdialogs.cxx:755: undefined reference to `QueueInfo::GetDriver() const'
> collect2: error: ld returned 1 exit status
> /home/buildslave/lode/jenkins/workspace/lo_callgrind_linux/sw/Library_swui.mk:20: recipe for target '/home/buildslave/lode/jenkins/workspace/lo_callgrind_linux/instdir/program/libswuilo.so' failed

Change-Id: I26b0591142c8936ed82488bdbcebb098208c705c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97223
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-26 15:54:02 +02:00
Caolán McNamara
d1e8831e06 improve tab traversal in addons with native widgets
Change-Id: I55d0390522122cc4409ea14274e756881315df0a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97219
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-26 15:44:28 +02:00
Caolán McNamara
07875e36f7 weld SpinfieldControl
Change-Id: I1696105ead648c86076f05f50f6286e9a3a932d4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97218
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-26 15:44:11 +02:00
Caolán McNamara
bda370031e extend FormattedSpinButton to allow custom input/output
Change-Id: Ie84c1d46bc6fa3e29ed97147de486911dc6ecc0c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97217
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-26 15:18:39 +02:00
Stephan Bergmann
e772025f36 Upcoming improved loplugin:elidestringvar: writerfilter
Change-Id: Ib06004b058c8079692adabd384dca72b63e8167a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97210
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-26 14:42:53 +02:00