Commit 0c49aa58cf (tdf#161508: add
another loop control hack, 2024-06-11) only checked the frame area
sizes and positions, but ignores the "valid" frags. It turns out,
that these flags also needed when checking the loop condition.
Change-Id: If155f2424b9a02cad6bf6d5c931dfccfb110d4c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174310
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
testTdf123898 fails locally but passes on Jenkins, because in Jenkins
builds the hyphenation data doesn't exist yet (as verified by a
CPPUNIT_ASSERT(xHyphenator->hasLocale(lang::Locale("de", "DE", OUString())))
in first revision of this patch.
Add makefile dependencies to all sw tests that call hasLocale().
The test still needs to check though in case --without-myspell-dicts is
used.
Failure looks ignorable, adapt the test:
Test name: (anonymous namespace)::testTdf123898::TestBody
equality assertion failed
- Expected: PortionType::Para
- Actual : PortionType::Text
Change-Id: Iaa94e248b01f7bab7f8451f6b0ff08a7d0a8e9b6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168669
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Load a document, sign it, "green" icon on the status bar. Reload the
document, turns into a "yellow" icon saying the CA is not trusted, when
it was already trusted before.
The trouble is that the document signature status is calculated on load,
and the CA to be trusted is only given later, as part of the
initialization of the LOK view.
Fix the problem by invalidating the signature state when a new CA is
trusted.
The test document was produced by signing an empty document using the
keys from xmlsecurity/qa/xmlsec/data/, which gives us a way to create a
signature that is initially not trusted.
Change-Id: I1e1dbf616ce54c4823d62104f838342de6870f52
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174307
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
primarily for Windows where unittests also use Windows' GetTempPathW
function that prefers TMP over TEMP over USERPROFILE over the windows
directory/doesn't respect TMPDIR
Unittests not using TMPDIR is annoying since bitdefender will block
access on some CVE tests. While you can create "dev drives" now that
also allow you to disable AV-scanning permanently on those, that of
course won't help when the files are created outside the devdrive/in the
default temporary directory.
Using TEMPDIR allows to specify the dir in autogen.input and the user
won't have to add the regular temp-dir to AV-exclusions or remember to
always disable the real-time-scanning before starting a build.
Change-Id: I47349e4318e8de99e45961a4989975cf4081fc07
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174267
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Jenkins
just remove the mutex, this class is only ever accessed from one
thread
Change-Id: I7c088c0cb33d21513a5566ae65f663877d829072
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174291
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
just remove the mutex, this class is only ever accessed from one
thread
Change-Id: Ie2b42a6a141676ee4cb14549d44f15fd55194aaf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174289
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Added general interfaces to be able to render directly
to an RGBA target SDPR:
- processor2d::createPixelProcessor2DFromScratch creates
a target-SDPR with given pixel size and RGB or RGBA,
owning and using a cairo surface internally
- processor2d::extractBitmapExFromBaseProcessor2D extracts
rendered content to BitmapEx, including alpha
All this is currently only implemented for Ciaro, thus
the internal impls are encapsulated by USE_HEADLESS_CODE,
but already created gererally available. The return values
have to be checked to see if an evtl. shortcut is possible.
For convertToBitmapEx this means that it can do conversions
much faster than up to now for cairo when CairoSDPR is
available, else it has to to the older slower way that
also works and is the default: Create RGB content, create
Mask, RemoveBlendedStartColor (see convertToBitmapEx
implementation). This works and has the same quality,
but needs two renderings and one bitmap operation, thus
is clearly slower.
Note that these interfaces can and will be supported for
other SDPR implementations in the future, thus will make
this converter automatically faster on systems where we
will have a SDPR in the future, too.
Also note that this is the gereral converter from
a sequence of Primitives to Bitmap data, already used in
many places, inculding UNO API, thus is expected to have
some impact on conversion efficiency - if Cairo is used,
so e.g. also headless.
Change-Id: Ia638a549a04b19622892d91651317ec6727b6cd0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174266
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
Tested-by: Jenkins
...like
> connectivity/source/drivers/odbc/OPreparedStatement.cxx:285:136: error: replace function parameter of type 'const OUString &' with 'std::u16string_view' [loplugin:stringviewparam]
> 285 | void OPreparedStatement::setParameter(const sal_Int32 parameterIndex, const sal_Int32 _nType, const sal_Int16 _nScale, const OUString &_sData)
> | ~~~~~~~~~~~~~~~~^~~~~~
and
> connectivity/source/drivers/odbc/ODatabaseMetaDataResultSet.cxx:851:117: error: directly use a 'std::u16string_view' (aka 'basic_string_view<char16_t>') value instead of a _ustr user-defined string literal [loplugin:ostr]
> 851 | SQLWChars aCOL = !uCOL.isEmpty() ? SQLWChars(uCOL.makeStringAndClear()) : SQLWChars(u"" SQL_ALL_TABLE_TYPES ""_ustr);
> | ^~~~~~~
caused by SQLWCHAR being 32-bit wchar_t on macOS (rather than 16-bit unsigned
short, as on Linux), so SQLWChars is CHARS<sal_uInt32> (rather than
CHARS<sal_Unicode>) with a ctor taking a std::u16string_view argument (rather
than an OUString argument)
Change-Id: I194af5feda5ba6279ed87264bc467b5d574406cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174263
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
While at it, move some methods where they are used
Change-Id: I56151046f068d355f9bfe9769c0aee7d9cf95f39
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174036
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
Drop all the special-casing of particular (parent) roles
etc. when considering whether or not to set the focusable
state.
Instead, fully rely on the AccessibleStateType::FOCUSABLE
state as reported by the underlying XAccessibleContext
and report the IAccessible/MSAA STATE_SYSTEM_FOCUSABLE
state whenever the former is set.
I tend to think that if this this change results in
unexpected behavior, it is likely that issues should best
be fixed in the underlying XAccessibleContext
implementations rather than worked around in the Windows
a11y bridge.
Change-Id: I6e2eee3a9cbe779de3b3d349f23efc6a68a8344b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174278
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
The LABEL, STATIC and NOTIFICATION roles are
used for readonly text, so if the EDITABLE state were
ever set on these, that should be fixed in the underlying
XAccessibleContext implementation instead of special
handling to always set the readonly state in the
Windows a11y bridge. Therefore, rely on the
EDITABLE state not being set for these in order to
report the IAccessible/MSAA STATE_SYSTEM_READONLY
like for the other roles handled here.
Change-Id: Ie8398ad0186d57ebf92701ab3a2c0603b50f5a2e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174277
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
... to make clear that this is a constant with
no state set.
Also, move the definition to the only source file
where it's used.
Change-Id: Iaaba8d7053f71c63caab57c2b692b8e5898d37cb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174276
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
This `pos` param never gets passed explicitly, so is
always the default `LAST_CHILD`.
Therefore, drop the param completely to simplify
this.
Change-Id: I8f51fe58b47bb2f0c18a853c81b8b6c85d4a6602
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174275
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
* Drop the `isExpandable` out param that's unused
at the only call site.
* Use a bool return value instead of an out param
for the remaining `isExpandable`.
Change-Id: I2a37f0fec752f5e8e802ec781acf49035b3fbf2d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174273
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Explicitly specifying the `AccessibleStateType`
namespace makes the distinction between
the UNO and the IAccessible2 states clearer.
Change-Id: If8dba19fa716753b1b838377546c5c810e588e5a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174270
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
drop mutex, only allowed to be called from ctor
Change-Id: I1878cf368caacafdcee96a7112a6cc768ce87520
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174207
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
This partial revert fixes a 24.2.4 regression from
commit 72ea1005b9
Author: Michael Stahl on Mon May 6 15:58:36 2024 +0200
tdf#160402 writerfilter: extend StyleMap with all Word styles
By using the English localization name,
the style was imported, used, and exported as English
instead of being mapped to the built-in style
whose name depends on the UI language in use.
So, revert back to using the internal version of the style names.
For English -> Dutch, that means that
Internet Link -> (MS Word's) Hyperlink -> Internetkoppeling
instead of remaining as the English "Internet Link"
For non-English UIs, the Internet Link character style
was duplicating on each file save (or perhaps each language switch).
I didn't notice the endless duplication for the other styles,
because they aren't used very much,
and are only written if used.
At worst, each localized versions was written once.
Change-Id: Icf58d7d716ac40f05f170c31787d8a8a9942868e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173230
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
1) Move the try-catch around assing a signature inside the block that
already got the response from the certificate chooser, it's unlikely
that choosing the certificate (and not yet signing) would fail.
2) Convert the dialog to async and allow it to be a jsdialog.
3) Hide not relevant widgets for LOK: we have a single signing
certificate, so the search entry is not useful.
The refresh button has an unclear purpose, as it was initially added
in commit fb9874231f (Caching
Certificates in the CertificateChooser dialog session-wise, 2023-08-26),
but later commit efe414c4a8 (Don't reuse
CertificateChooser instances, 2024-02-07) disabled this chaching. In any
case, the certificate won't change during the lifetime of a single LOK
view, so hide that as well.
4) Invoke the inner certificate viewer in an async way, too.
Change-Id: Ibf618ea7632cf801d1d9180b9aa7dd193c45ffda
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174215
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
