Commit graph

451204 commits

Author SHA1 Message Date
Xisco Fauli
d73c266552 tdf#134390: sc: Add UItest
Change-Id: I12ab42afbe902a25f93deaa4884280392c705f38
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97516
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-30 21:00:29 +02:00
Caolán McNamara
714b2b617e tdf#134270 rearrange so we know the final treeview width
so we can unconditionally use the treeview width as the optimized
pre-calculated row width hint and then fix up the gen fixed column
settings to take account of the auto CHK_BTN mode

Change-Id: I2e1eaf4b1121d5e705eb7db3464f123c038db246
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97532
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-30 20:53:38 +02:00
Bjoern Michaelsen
907b60b37f dont (ab-)use typeless GetInfo() interface
Change-Id: I73ab1e0efcb3559dfe37f3f408b3ec4862a408e4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97472
Tested-by: Jenkins
Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-06-30 20:46:41 +02:00
Alain Romedenne
aa6cb71da7 Update git submodules
* Update helpcontent2 from branch 'master'
  to ba1243452608af3997b42b975895a3e838c767c6
  - Advanced Basic libraries brief descriptions
    
    Change-Id: I7cdeba9ec039a42eff0072d44e92bf95d78ecd90
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/97497
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-06-30 20:37:07 +02:00
Stephan Bergmann
d902e04baf Upcoming improved loplugin:staticanonymous -> redundantstatic: basic
Change-Id: I1046ee1ea28e19afa51b0e20ee573105ced77535
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97522
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-30 19:05:48 +02:00
Stephan Bergmann
eb582a59f8 Upcoming improved loplugin:staticanonymous -> redundantstatic: binaryurp
Change-Id: I67340a41005d93d11686ed5f5d49bf6e4938f8c7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97523
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-30 18:51:07 +02:00
Caolán McNamara
8bfc3b5814 prefer down for main dropdown and right for subdropdown
Change-Id: I89d689e0cf2aea246b5fa6b545807d7059e076f9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97480
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-30 18:42:42 +02:00
Stephan Bergmann
81bfb3c727 Upcoming improved loplugin:staticanonymous -> redundantstatic: basctl
Change-Id: I316331cee15bbb87ecfbda84f3195759e521df6a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97520
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-30 18:30:02 +02:00
Stephan Bergmann
65269c2717 Upcoming improved loplugin:staticanonymous -> redundantstatic: basegfx
Change-Id: I66b7e0fd74c7ce57cd2859e189caadb84be4d541
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97521
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-30 18:29:32 +02:00
Stephan Bergmann
80f92c3ce3 Upcoming improved loplugin:staticanonymous -> redundantstatic: accessibility
Change-Id: Ibb44e313924970319c3409323160ca7f5a6d184e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97519
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-30 18:29:06 +02:00
Olivier Hallot
98901a4b2a Update git submodules
* Update helpcontent2 from branch 'master'
  to f8d5d058a35ca8fe9b6797e45fe703a7d7486ed1
  - tdf#133998 Help entries split in middle of sentence
    
    Removed <ahelp> tags from Help file, and copy contents
    to extended tips in dialog file as done in
    
    https://gerrit.libreoffice.org/c/core/+/97526
    
    Change-Id: I933b1f89f8f5ea5a43dedbc25ea1de8014f3ea76
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/97529
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-06-30 17:36:25 +02:00
Xisco Fauli
af5c748b39 check-missing-unittests: Add date to the output and...
check for writer undo and calc interpreter missing tests

Change-Id: Ic891f3585eb96eda3c9c6ab4d012cd03d324df54
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96436
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-30 17:14:06 +02:00
Luboš Luňák
a0710ac169 faster conversions from 1bpp mask bitmaps for Skia/GL
Tdf#134363 leads to creating a large 1bpp bitmap, and this conversion
takes ages.

Change-Id: If596d55829698df54f1b205a5f9a5d68cbea40fe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97489
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-06-30 17:10:29 +02:00
Xisco Fauli
1890862091 tdf#134021: sw: Add unittest
Change-Id: I789adaf699a857e28416132d253c04128def5984
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97481
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-30 17:09:44 +02:00
Andrea Gelmini
21c0deb198 Fix typo
Change-Id: I9562d74b5b75d6ad6f98e413410d527c7e8d502e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97510
Tested-by: Jenkins
Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2020-06-30 16:46:30 +02:00
Tor Lillqvist
dead5cae83 tdf#128502: Fix (haha) for a crash with multiple docs open in the iOS app
Just a band-aid to avoid a crash. The LibreOfficeKit-related code
would need a thorough re-factoring to properly be prepared for
multiple open documents.

Change-Id: I8c31e2badd747f3086526f89638fa495f4dcf295
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97205
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97409
Tested-by: Jenkins
2020-06-30 15:42:32 +02:00
Caolán McNamara
8a6935f8cf tdf#134414 Variables page doesn't need expanders
Change-Id: I5a38e1e8052c96970f9701f776f7675fda5f21c6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97479
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-30 15:37:49 +02:00
Michael Stahl
17aeb522f5 tdf#134404 sw: another subtlety with start/end of section (at-para flys)
fix this problem by comparing the start/end of the selection instead of
the anchor position, which always has an index of 0:

1. new document with image anchored to paragraph
2. insert one letter
3. press Enter
4. Backspace -> Image gone

(regression from cc4b5091e7)

Change-Id: I1219a9f58ce19ea88d697c90c862fe9005318177
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97511
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-30 15:06:26 +02:00
Miklos Vajna
2017bf06ab Related: tdf#128743 fix unwanted background color of transparent wallpaper
With this, the unwanted line at the top of the background image goes
away and we can consider re-adding those images again in the future.

Change-Id: I36822e84ab38b0b534371f939592f6a270f2d326
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97482
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-30 14:01:25 +02:00
Gülşah Köse
6f752061d5 Related: tdf#131175 OOXML chart: import data label fill pattern
Change-Id: I2db64489c86e4381167eb13af4ab5118113960d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93715
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-30 13:56:53 +02:00
Xisco Fauli
9b0a0bcc7e tdf#134243: sw: Add UItest
Change-Id: I59376419048ddddff3e4fbbd6d3eb7436ee87747
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97029
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-30 13:05:34 +02:00
Olivier Hallot
77ad641a85 Update git submodules
* Update helpcontent2 from branch 'master'
  to 74e0455c41e1e6b95c9e8cc34db4b4da0802f30d
  - Mute l10n on bookamrk hid=
    
    Change-Id: I306ece30659e9b9fe1b193f8d6fb3a5161bd8be7
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/97461
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-06-30 12:58:15 +02:00
Tünde Tóth
72613bd2a0 tdf#126425 Chart: fix missing legend with exceeding text
Ellipsize legend box contents, if the custom size of
the chart legend is too small to contain the text.

Change-Id: I91ef913f509b233912a8bfb878a1c80d577e2a88
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96437
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-30 12:44:23 +02:00
Caolán McNamara
d828da851e tdf#134390 update spin button before processing activate signal
Change-Id: I698c789c9fe79e931547d8b230a4885393f5ff28
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97476
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-30 12:18:45 +02:00
Caolán McNamara
fac0288099 Related: tdf#134390 allow entry "activate" for gen spinbutton
Change-Id: I3c497586479a08089f167ccb890e79e7b9d1f4bd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97459
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-30 10:36:02 +02:00
Caolán McNamara
0313b1eeee tdf#134360 some sidebar widgets getting stuck in a disabled state
Change-Id: I655525679dd2471e9d0c1a5af246901594b188ed
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97454
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-30 10:34:19 +02:00
Caolán McNamara
011a4932aa add set_alignment to Entry
Change-Id: I004fb0e19c1bb25bdb5d11ba5d5d5f39b137874c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97423
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-30 10:33:28 +02:00
Caolán McNamara
c99375b5b4 ofz#23783 Invalid-enum-value
Change-Id: Ifd641a24dc8db9cb19bb41480c19ed1e3f29c43a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97455
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-30 10:33:03 +02:00
Miklos Vajna
682e0488df tdf#134099 sw: fix textbox anchors on copy-paste and undo
Regression from commit c7307c7725
(fdo#82191 sw::DocumentLayoutManager: copy textbox content of draw
formats, 2014-08-15), without which this problem gets hidden, as copy
breaks the textbox into 2 pieces, so the textbox codepaths are no longer
hit.

The direct problem is that SwHistorySetFormat::SetInDoc() uses a raw
node index into the nodes array, which is past the end of the nodes
array.

Root cause is that we have this invariant that actions and their undo
has to be in sync, otherwise raw node indexes no longer work. In this
case, SwUndoSaveContent::DelContentIndex() did not delete a fly frame
format, because it was out of range, as it had a wrong anchor.

Fix this in SwTextFlyCnt::SetAnchor(), so that whenever the anchor of a
draw format is set via that function, we update its textbox as well.

Also fix a related problem when fly formats were copied twice.

Change-Id: I0d6c9069544c405eb20c5fed65fb40423b0adc84
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97457
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-30 09:28:31 +02:00
Tor Lillqvist
ca1df564c3 Let's not run on hope
Change-Id: If2fb2c55d53321ec2e5beff0ade9974c02811f7f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97120
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97408
Tested-by: Jenkins
2020-06-30 08:18:52 +02:00
Luboš Luňák
a3020001d1 actually call Skia init function
The SkGraphics::Init() docs say it's called by global variable
initialization, but that doesn't seem to exist. Call it manually,
as it decides e.g. which CPU features to use.

Change-Id: I7e0e18290240ff2ae3298d5569c22f7dc083dde4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97415
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-06-30 08:04:06 +02:00
Luboš Luňák
0059392fc7 direct 8bit gray -> RGBA conversion in SkiaSalBitmap
Change-Id: Ic77f9b8f9244e7fdaca78f91686645eee421d18f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97288
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-06-30 08:03:46 +02:00
Luboš Luňák
29dc1029be differentiate between 8bit and any-bit grey palette (tdf#121120)
Only the grey palette with 256 colors means that pixel values map
directly to color values. Tdf#121120 has an image with 2-bit
palette where color index 1 is (255,255,255), but that means
the pixel value 1 cannot be just treated as color.

Change-Id: Ifbd953af7f291e4fb8032ea0f4c33c0514770856
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97283
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-06-30 08:02:45 +02:00
Samuel Mehrbrodt
63f3485b57 tdf#130151 Fix toc pointing to wrong page
Change-Id: I26c1027722613f751bd39fde97f1e14d3238eefa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97413
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Jenkins
2020-06-30 07:58:20 +02:00
Szymon Kłos
d3338ff2a3 notebookbar: don't overwrite popup height
Change-Id: I41e0bab8f44b1d7be627e3a7e0f3293179f3977c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97215
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97418
Tested-by: Jenkins
2020-06-30 07:47:19 +02:00
Mike Kaganski
0cc0667caa Reduce code duplication
Change-Id: Ia5526e61c8dd632fbc5eae2d5c02b46b928f4fa0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97430
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-06-30 05:01:18 +02:00
Tor Lillqvist
4c14c88cc6 Avoid crash with multiple documents open in the iOS app
Also add a FIXME. Just 'hoping' is not good enough. But yeah, much of
this code indeeed works mostly by accident.

Change-Id: Ic6bcbc10229a0b7cdd8d696794efe152fca4faea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97117
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97407
Tested-by: Jenkins
2020-06-29 23:24:04 +02:00
Mike Kaganski
458e3f67c0 Small refactor
Change-Id: I14021d3e0b83dcd4fb5544239e982c8ada32d029
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97429
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-06-29 22:25:18 +02:00
Stephan Bergmann
14e625e0a0 Fix check whether "msi" is among --with-package-format=... tokens
Change-Id: I8979a88743926141af3b3c6f9b579b4ee34f494b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97426
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-29 22:22:32 +02:00
Chris Sherlock
49d6768483 tdf#74424 vcl: Flush() is implemented in OutputDevice so no need for type check
Change-Id: I12f177dadf9a637ab3ef2fa7d85fe96d1d141808
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96811
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-29 21:59:18 +02:00
Olivier Hallot
68541c1a13 Update git submodules
* Update helpcontent2 from branch 'master'
  to 971425d46a52037cc1bead7c0a1054d84c10e56b
  - refactor some database Help files
    
    Change-Id: Ia3ad2896015c335450d0970d8cf51044473e249e
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/97456
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-06-29 21:08:39 +02:00
Tomaž Vajngerl
affe8a36c9 sd: support changing position with .uno:EditAnnotation
Change-Id: Ie5c683c06079e4d77d42b242c60cf67257db5c16
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97421
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-29 18:47:14 +02:00
Miklos Vajna
0760b11c59 cui: fix context of aboutdialog's btnReleaseNotes
Change-Id: Ifab5c7b0dd007e8a318c8d89b9501f9e30cf60f2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97422
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2020-06-29 18:39:26 +02:00
A_GAN
2803b09ec0 OOXML/ODF Support for Shadow blur radius
Adding export support for OOXML. Adding import/export support for ODF
Changing some values in test cases as convertEMUtoHmm round the fraction.
Add two test functions for OOXML and ODF export.

Change-Id: Ie5d862b46b5264ead4954f407fee2837b5151cd7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96907
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-29 18:32:57 +02:00
Michael Stahl
cb0c7e26e5 curl: upgrade to release 7.71.0
Fixes CVE-2020-8169, and about 3 other ones that don't affect LO/libcmis.

Disable new optional dependencies "ngtcp2" and "quiche".

Change-Id: I595ed909c4e792ac3244643511a338b117e7f102
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97406
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-29 17:52:21 +02:00
Stephan Bergmann
61fcf830aa Call framework::Desktop::shutdown directly
...instead of via the XJob hack introduced in
a6862a26d6 "tdf#134106: Get rid of
XDesktopInternal again"

Change-Id: Ic533e8faba1a3da65ead74d78f0ab9c4aab1ca6a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97397
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-29 16:40:52 +02:00
Caolán McNamara
733023dd10 tdf#134386 set m_pTemplateProvider before creating any other pages
Change-Id: Icc501b127f92cdbfbf0987af9b0b560f1efbc056
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97404
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-29 16:18:27 +02:00
Caolán McNamara
4162df8c09 make browser rows slightly taller
Change-Id: I6a466bfd43bb38cafa4cea0c1e68ed788922b53f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97405
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-29 16:02:42 +02:00
Mesut Çifci
4054126f79 tdf#39593 reduce copy/paste in BitmapScaleSuperFilter
Change-Id: I1f6387d3ff931b0c885e0cb8ee5b99c880a1484e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94137
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-29 15:45:23 +02:00
Jan-Marek Glogowski
8565546ce6 tdf#134054 toolbox: respect drop-down arrow rect
When centering the text and icon on the button, the code didn't
take the drop-down arrow rect width into account, resulting in an
overlapped arrow. This is especially visible, if the drop-down
is shown and the button is wrongly highlighted.

There is supposed to be some vertical mode, which I couldn't find
in the GUI, so this just adapts the width in horizontal mode.

Change-Id: I194780dc32db610041ad0ee45a425e1026c7c4e3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97358
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-06-29 15:24:27 +02:00