Commit graph

482871 commits

Author SHA1 Message Date
Heiko Tietze
3fffe54bb1 Resolves tdf#146579 - Accessibility for statusbar icons
Added a rectangle around the active versions

Change-Id: I473bb77a624c260db946e1718bff90eae9a4f805
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146131
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-01-25 16:41:34 +00:00
Stephan Bergmann
b61da415b7 Update git submodules
* Update helpcontent2 from branch 'master'
  to dc89de95c0858af3e6116f2d2b736787c30fe213
  - Recipe has no dependency on target dir
    
    Seen this fail once at
    <https://buildbot.flathub.org/#/builders/31/builds/1623>,
    
    > cp: cannot create regular file '/run/build/libreoffice/workdir/CustomTarget/helpcontent2/help3xsl/online_transform.xsl': No such file or directory
    > make[1]: *** [/run/build/libreoffice/helpcontent2/CustomTarget_html.mk:186: /run/build/libreoffice/workdir/CustomTarget/helpcontent2/help3xsl/online_transform.xsl] Error 1
    
    Change-Id: I8cfa387d1bb2ef488f5f34ff20b9dc975d424751
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/146141
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-25 15:42:03 +00:00
Stephan Bergmann
63ef3cf5bf Use ImplInheritanceHelper in OAccessibleTextHelper
(Explicitly deleting the special member functions is needed to avoid MSVC

> include\cppuhelper/implbase.hxx(152): error C2280: 'comphelper::OAccessibleExtendedComponentHelper::OAccessibleExtendedComponentHelper(comphelper::OAccessibleExtendedComponentHelper &&)': attempting to reference a deleted function
> include\comphelper/accessiblecomponenthelper.hxx(220): note: see declaration of 'comphelper::OAccessibleExtendedComponentHelper::OAccessibleExtendedComponentHelper'
> include\comphelper/accessiblecomponenthelper.hxx(220): note: 'comphelper::OAccessibleExtendedComponentHelper::OAccessibleExtendedComponentHelper(comphelper::OAccessibleExtendedComponentHelper &&)': function was explicitly deleted
> include\comphelper/accessibletexthelper.hxx(133): note: see reference to function template instantiation 'cppu::ImplInheritanceHelper<comphelper::OAccessibleExtendedComponentHelper,com::sun::accessibility::XAccessibleText>::ImplInheritanceHelper<cppu::ImplInheritanceHelper<comphelper::OAccessibleExtendedComponentHelper,com::sun::accessibility::XAccessibleText>>(cppu::ImplInheritanceHelper<comphelper::OAccessibleExtendedComponentHelper,com::sun::accessibility::XAccessibleText> &&)' being compiled
> include\comphelper/accessibletexthelper.hxx(133): note: see reference to function template instantiation 'cppu::ImplInheritanceHelper<comphelper::OAccessibleExtendedComponentHelper,com::sun::accessibility::XAccessibleText>::ImplInheritanceHelper<cppu::ImplInheritanceHelper<comphelper::OAccessibleExtendedComponentHelper,com::sun::accessibility::XAccessibleText>>(cppu::ImplInheritanceHelper<comphelper::OAccessibleExtendedComponentHelper,com::sun::accessibility::XAccessibleText> &&)' being compiled

)

Change-Id: I00377be4a5fb44b2ef2b5001823ca0d89ead026b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146109
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-25 15:40:16 +00:00
Stephan Bergmann
cbfbf11952 Use ImplInheritanceHelper in OAccessibleSelectionHelper
(Explicitly deleting the special member functions is needed to avoid MSVC

> include\cppuhelper/implbase.hxx(152): error C2280: 'comphelper::OAccessibleComponentHelper::OAccessibleComponentHelper(comphelper::OAccessibleComponentHelper &&)': attempting to reference a deleted function
> include\comphelper/accessiblecomponenthelper.hxx(191): note: see declaration of 'comphelper::OAccessibleComponentHelper::OAccessibleComponentHelper'
> include\comphelper/accessibleselectionhelper.hxx(120): note: see reference to function template instantiation 'cppu::ImplInheritanceHelper<comphelper::OAccessibleComponentHelper,com::sun::accessibility::XAccessibleSelection>::ImplInheritanceHelper<cppu::ImplInheritanceHelper<comphelper::OAccessibleComponentHelper,com::sun::accessibility::XAccessibleSelection>>(cppu::ImplInheritanceHelper<comphelper::OAccessibleComponentHelper,com::sun::accessibility::XAccessibleSelection> &&)' being compiled
> include\comphelper/accessibleselectionhelper.hxx(120): note: see reference to function template instantiation 'cppu::ImplInheritanceHelper<comphelper::OAccessibleComponentHelper,com::sun::accessibility::XAccessibleSelection>::ImplInheritanceHelper<cppu::ImplInheritanceHelper<comphelper::OAccessibleComponentHelper,com::sun::accessibility::XAccessibleSelection>>(cppu::ImplInheritanceHelper<comphelper::OAccessibleComponentHelper,com::sun::accessibility::XAccessibleSelection> &&)' being compiled
> include\cppuhelper/implbase.hxx(151): error C2248: 'comphelper::OAccessibleComponentHelper::OAccessibleComponentHelper': cannot access private member declared in class 'comphelper::OAccessibleComponentHelper'
> include\comphelper/accessiblecomponenthelper.hxx(191): note: see declaration of 'comphelper::OAccessibleComponentHelper::OAccessibleComponentHelper'
> include\comphelper/accessiblecomponenthelper.hxx(185): note: see declaration of 'comphelper::OAccessibleComponentHelper'

)

Change-Id: I2414d9f777de42b62c33492a90299aa9a9d53699
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146108
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-25 15:40:02 +00:00
Tomaž Vajngerl
784ee6e9fa sw: change or create the selected theme in SdrPage on theme change
When the theme color changes (from the UI), also the theme that
is set to the SdrPage needs to change. If there is no theme set
yet, a new theme needs to be created (from a set of defaults).

Change-Id: I5e3d6d9f973712ddb875a41adba1aff04395ca7a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146129
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-25 14:56:41 +00:00
Tomaž Vajngerl
cae93bc7a4 sw: support theme colors in color picker in writer
Implements SfxDocumentShell::GetThemeColors, which allows the
color picker to use the theme colors and change them in Writer.

Change-Id: Ic13d2086d4ff037b377b475630b02ed1509fdf3d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146120
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-25 14:56:34 +00:00
Tomaž Vajngerl
8640e24b12 tdf#66580 added hybrid PDF test cases
Change-Id: I2a58e6cd5b40266b3c55729febb7006c7a7b4170
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146068
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-25 14:56:26 +00:00
Stephan Bergmann
5dfa9433d2 Fix typo
...which was pointed out in
<https://lists.freedesktop.org/archives/libreoffice/2023-January/089867.html>
"Re: Question re the uno-skeletonmaker'-t' CLI qualifier"

Change-Id: I5f03de657bc93dace104bdd307e8f6938742b61b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146126
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-25 14:45:00 +00:00
Rafael Lima
79811c27f3 tdf#129905 Create toggle for Section boundaries
Currently in Writer it is not possible to enable/disable Section Boundaries independently from Text Boundaries (which are toggleable via View - Text Boundaries). Hence its only possible to enable/disable them together.

This patch creates a new command that allows to enable/disable Section Boundaries (now in View - Section Boundaries) indepentently from Text Boundaries.

Change-Id: I76981ed1a055ce8d1e0f83c3055fef75df37f019
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146077
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-01-25 13:38:28 +00:00
Miklos Vajna
fd3d4d894d sw: add UNO API for multi-page fly frames
This exposes the internal property added in
0bb90afaeb (sw: add document model for
multi-page fly frames, 2023-01-24) on the UNO API.

Change-Id: If9acd2d2130f727bc9481980445c0da01be04729
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146124
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2023-01-25 12:40:04 +00:00
Andras Timar
6053df3ecd NSS initialization guard
Change-Id: I61a5886d0d13eaef6a61479e35d52a85937075ed
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142385
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146042
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2023-01-25 12:24:34 +00:00
Christian Lohmaier
bb391230db Update git submodules
* Update translations from branch 'master'
  to b4907d3a23fe5b27877fbf12fcc39c18790524a9
  - update translations for master/7.5.0 rc3 (macOS version bump)
    
    and force fix errors using pocheck
    
    Change-Id: Ib5123ee34e691b4869b489d23a644c1791807b03
2023-01-25 12:09:19 +00:00
Mike Kaganski
4172fcb751 Fix no-pch Windows build: missing include
> In file included from C:/lo/src/build/workdir/UnpackedTarball/skia/tools/sk_app/win/VulkanWindowContext_win.cpp:9:
> C:/lo/src/build/workdir/UnpackedTarball/skia\tools/sk_app/win/WindowContextFactory_win.h(23,1): error: unknown type name 'SK_API'
> SK_API std::unique_ptr<WindowContext> MakeVulkanForWin(HWND, const DisplayParams&);
> ...

Change-Id: I7f88cbb005310dd586e53b262ce31a71d49faedc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146121
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-01-25 11:30:29 +00:00
Balazs Varga
5f2d7db094 tdf#150098 sc validation: allowing formulas for validity test
Calculate the formula results, before checking the validity test.

Change-Id: I7420982a8cbcd2df6ab0adea6e3cf61aaccb1600
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146011
Tested-by: Jenkins
Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-01-25 11:01:27 +00:00
Andrea Gelmini
15b4f96ddc Update git submodules
* Update helpcontent2 from branch 'master'
  to 60b9c9da98f43ba0048cadac79bb683f82c2c30d
  - Fix typos
    
    Change-Id: I63a7a69b053b3ddca65a0bd41ac903ce425815a8
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/146128
    Tested-by: Jenkins
    Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-01-25 10:42:26 +00:00
Michael Weghorn
9e10d4cc27 android: Don't warn about NDK 21 and 22
At least for these 2 configurations, building the app with
NDK 22.1.7171670 worked fine:

x86 dbgutil build:

    --build=x86_64-unknown-linux-gnu
    --with-android-ndk=/home/michi/Android/Sdk/ndk/22.1.7171670/
    --with-android-sdk=/home/michi/Android/Sdk
    --with-distro=LibreOfficeAndroidX86
    --enable-sal-log
    --with-external-tar=/home/michi/development/libreoffice-external
    --enable-ccache
    --enable-dbgutil
    --with-jdk-home=/usr/lib/jvm/java-17-openjdk-amd64/

32-bit ARM release build:

    --build=x86_64-unknown-linux-gnu
    --with-android-ndk=/home/michi/Android/Sdk/ndk/22.1.7171670/
    --with-android-sdk=/home/michi/Android/Sdk
    --with-distro=LibreOfficeAndroid
    --with-external-tar=/home/michi/development/libreoffice-external
    --enable-ccache
    --with-jdk-home=/usr/lib/jvm/java-11-openjdk-amd64/
    --enable-release-build

Change-Id: I6c4d47b7e96232f44cb310badb18a8a30b585de8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146117
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-01-25 10:35:19 +00:00
Pranam Lashkari
7595f39230 sw: lok: avoid creating callback json if kit is not active
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I60ae5a37acdbe4ea01b730702cc499833ce5b77c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146036
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146102
Tested-by: Jenkins
2023-01-25 08:33:48 +00:00
Andras Timar
15397a1058 more detailed NSS error report
Change-Id: I1b005a331aeed1c00d6bf18a6dff0ffa844ba6f5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142286
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Aron Budea <aron.budea@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146041
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2023-01-25 08:33:41 +00:00
Pranam Lashkari
b03790dac0 sw: send LOK call back on section deletion
this helps with zotero when user deletes or undo a bibliography stored as a section
without this online will be unaware of any such changes made by user

Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I6a8ae3924d548e97299a8d74f8c93c3345d1a430
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146007
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146101
Tested-by: Jenkins
2023-01-25 08:33:36 +00:00
Pranam Lashkari
c8e49e7a49 sw: send LOK call back on bookmark deletion
this helps with zotero when user deletes a bookmark or use undo
without this online will be unaware of any such changes made by user

Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: Id5ea4ee0ee1d16c399460cd177ec8e33256ce3dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145777
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
(cherry picked from commit ea112b6d85)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146022
Tested-by: Jenkins
2023-01-25 08:33:28 +00:00
Miklos Vajna
843bca8989 CppunitTest_sw_rtfexport2: clean up no longer needed preTest()
Avoid magic in preTest() based on the bugdoc name.

Change-Id: I31d19f8f200b45ae791b998a173f3b520e6f01d2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146100
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-01-25 08:22:47 +00:00
Colomban Wendling
293db294e3 test: Add AccessibilityTools::nameEquals()
Some accessible names contain a suffix when OSL_DEBUG_LEVEL > 0, which
makes it tricky to compare to a known value.  To fix that, introduce a
helper that knows how and when to deal with the suffix properly that
can then be used to easily check accessible names.

As we already have a similar, yet private, helper for menu items on
Windows (that include the keybinding label as a suffix), merge the two
together in a unified solution for comparing names.

Change-Id: I7e67edbc7817218ef3e097062d25888172056c21
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142257
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-01-25 08:22:01 +00:00
Mike Kaganski
d183daea1a tdf#153161: (Ab)use a call to XTextRange::getString to flush edits
Restore the call (without checking its returned value), removed in commit
d194474aab ("tdf#151100: xText->getString()
may be empty for content needing export", 2022-09-22), side effects of
which obviously allow some object's changes to get flushed and saved.

Change-Id: I62f27cd056c32ad76f79a4862e2f4a0964eaadef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146106
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-01-25 07:25:16 +00:00
Stephan Bergmann
5c312c986e Use ImplInheritanceHelper in VCLXAccessibleComponent
Change-Id: I300f033054bddc2c0ee1973dbafc108c477bf09a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146103
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-25 06:44:18 +00:00
Noel Grandin
aef70869b0 Update skia to m110
Removing those bits of the patches that appear to have been
upstreamed.

Change-Id: Ia7683c26af4c622ca4fccb828df023ae30e724a6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146069
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-25 06:39:05 +00:00
Andrea Gelmini
81ced283de Fix typo
Change-Id: I4f60a62492b8e0b92c805dd5f4db43193a5d2288
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146104
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-01-25 06:08:34 +00:00
Justin Luth
e125e6623f related tdf#151548 formfield navigation: loop to beginning/end
When reaching the end of the form using keyboard navigation,
the next tabstop should return the user to the beginning of
the form.

This patch adds that to the existing legacy formfield navigation.
I'll wait with a unit test until I have added
activeX/contentControls into the mix.

Change-Id: I24a15a60f5a0a2721f512cca50397efddcbf7e4b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146035
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
2023-01-24 22:22:11 +00:00
Caolán McNamara
d8b60e66bf tdf#152404 crash with ibus-mozc with ctrl+alt+c during ExtTextInput
Change-Id: I86e19387d93a57c3ad263f0c2dc9222a5f3480be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146065
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-24 21:16:13 +00:00
Mike Kaganski
639d092bc2 Fix build
... failed locally with

  C:\lo\src\core\include\rtl/ref.hxx(129): error C2027: use of undefined type 'SvXMLImportPropertyMapper'
  C:\lo\src\core\include\xmloff/shapeimport.hxx(46): note: see declaration of 'SvXMLImportPropertyMapper'
  C:\lo\src\core\include\rtl/ref.hxx(127): note: while compiling class template member function 'rtl::Reference<SvXMLImportPropertyMapper>::~Reference(void)'
  C:\lo\src\core\include\xmloff/xmlprcon.hxx(64): note: see reference to function template instantiation 'rtl::Reference<SvXMLImportPropertyMapper>::~Reference(void)' being compiled
  C:\lo\src\core\include\xmloff/xmlprcon.hxx(37): note: see reference to class template instantiation 'rtl::Reference<SvXMLImportPropertyMapper>' being compiled

Change-Id: I08211c58ca61d2bc81062d0b104d8ce47ffccd91
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146098
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-01-24 20:55:58 +00:00
Stephan Bergmann
880117f743 Missing include
> include\rtl/ref.hxx(129): error C2027: use of undefined type 'SvXMLImportPropertyMapper'
> include\xmloff/shapeimport.hxx(46): note: see declaration of 'SvXMLImportPropertyMapper'
> include\rtl/ref.hxx(127): note: while compiling class template member function 'rtl::Reference<SvXMLImportPropertyMapper>::~Reference(void)'
> include\xmloff/xmlprcon.hxx(64): note: see reference to function template instantiation 'rtl::Reference<SvXMLImportPropertyMapper>::~Reference(void)' being compiled
> include\xmloff/xmlprcon.hxx(37): note: see reference to class template instantiation 'rtl::Reference<SvXMLImportPropertyMapper>' being compiled

Change-Id: I77083e021ae16bce8b2f749b96b6c6607c22ff87
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146072
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-24 20:45:54 +00:00
Olivier Hallot
74d3d85dc5 Update git submodules
* Update helpcontent2 from branch 'master'
  to 366cd93675b556c330ca6f1146f6bd67e09e8647
  - tdf#118008 (part) Format menu update
    
    * Include align and number format menu entries
    * collected default number formats in one help file
    
    Change-Id: I01db0099ec0b4c421a717656ff3957f190501f53
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/146094
    Tested-by: Jenkins
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-01-24 20:26:03 +00:00
Rafael Lima
882a39e909 Update git submodules
* Update helpcontent2 from branch 'master'
  to 0b9ab742651f4014540723356720507edc2ec3ac
  - Document new RemoveDuplicates method in SF Calc service
    
    This patch also updates the method SortRange to remove the original limit of 3 row/column as keys (see commit 40bc1b2753)
    
    Change-Id: If2f3e6cc97f3effdde34ee44330335ae85fef226
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/146028
    Tested-by: Jenkins
    Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-01-24 20:23:58 +00:00
Rafael Lima
a53825419a Update git submodules
* Update helpcontent2 from branch 'master'
  to 40d7045493a707ba164779fc506e2825b8c0909d
  - Improve ScriptForge TOC help page
    
    This patch also fixes the Basic service help page by classifying ThisComponent and ThisDatabaseDocument as properties instead of methods.
    
    Change-Id: Ia3937b0ea3fb057dacfc31ead1db512ddd951d64
    Reviewed-on: https://gerrit.libreoffice.org/c/help/+/146023
    Tested-by: Jenkins
    Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
    Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-01-24 20:19:03 +00:00
Stephan Bergmann
5747634948 Use ImplInheritanceHelper in OAccessibleExtendedComponentHelper
(Explicitly deleting the special member functions is needed to avoid MSVC

> include\cppuhelper/implbase.hxx(152): error C2280: 'comphelper::OCommonAccessibleComponent::OCommonAccessibleComponent(const comphelper::OCommonAccessibleComponent &)': attempting to reference a deleted function
> include\comphelper/accessiblecomponenthelper.hxx(176): note: compiler has generated 'comphelper::OCommonAccessibleComponent::OCommonAccessibleComponent' here
> include\comphelper/accessiblecomponenthelper.hxx(176): note: 'comphelper::OCommonAccessibleComponent::OCommonAccessibleComponent(const comphelper::OCommonAccessibleComponent &)': function was implicitly deleted because a base class invokes a deleted or inaccessible function 'cppu::BaseMutex::BaseMutex(const cppu::BaseMutex &)'
> include\cppuhelper/basemutex.hxx(43): note: 'cppu::BaseMutex::BaseMutex(const cppu::BaseMutex &)': function was implicitly deleted because a data member invokes a deleted or inaccessible function 'osl::Mutex::Mutex(const osl::Mutex &)'
> include\osl/mutex.hxx(107): note: 'osl::Mutex::Mutex(const osl::Mutex &)': function was explicitly deleted
> include\comphelper/accessiblecomponenthelper.hxx(228): note: see reference to function template instantiation 'cppu::ImplInheritanceHelper<comphelper::OCommonAccessibleComponent,com::sun::accessibility::XAccessibleExtendedComponent>::ImplInheritanceHelper<cppu::ImplInheritanceHelper<comphelper::OCommonAccessibleComponent,com::sun::accessibility::XAccessibleExtendedComponent>>(cppu::ImplInheritanceHelper<comphelper::OCommonAccessibleComponent,com::sun::accessibility::XAccessibleExtendedComponent> &&)' being compiled
> include\comphelper/accessiblecomponenthelper.hxx(228): note: see reference to function template instantiation 'cppu::ImplInheritanceHelper<comphelper::OCommonAccessibleComponent,com::sun::accessibility::XAccessibleExtendedComponent>::ImplInheritanceHelper<cppu::ImplInheritanceHelper<comphelper::OCommonAccessibleComponent,com::sun::accessibility::XAccessibleExtendedComponent>>(cppu::ImplInheritanceHelper<comphelper::OCommonAccessibleComponent,com::sun::accessibility::XAccessibleExtendedComponent> &&)' being compiled

)

Change-Id: Ia5a7b244dd018c1a63cc2940dba197c43827d563
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146062
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-01-24 19:57:25 +00:00
ektagoel12
21fbb4b952 tdf#141908 Replace usage of sal_Int32 with Color
Change-Id: Id2849140ba1302d59918eb30458984aef2b5c6ef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145964
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-01-24 17:57:20 +00:00
Noel Grandin
e011ac1c14 [API CHANGE] remove service sd::framework::ModuleController
It makes no sense to be constructed externally.

Change-Id: I7e756e225e7b6e1785194b2f73edd5a7d65ec0e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146056
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-24 17:28:57 +00:00
Miklos Vajna
0bb90afaeb sw: add document model for multi-page fly frames
Currently we can have multi-page tables and fly frames (where the
content wraps around the fly frame), but not both at the same time.

Allowing multi-page fly frames in general would probably go too far, but
handling this in case the fly frame only contains a table would make
sense to support Word's multi-page floating tables.

Fix this by adding a new SwFormatFlySplit property on fly frames: this
is meant to be enabled when the fly frame is part of a multi-page
floating table.

Unlike table split, this is off by default. Some logic will be needed
later to enable this in case the fly frame originates from a Word
floating table. (And obvously this is just the doc model, everything
else still needs doing.)

Change-Id: Id92130c684016cd7e7153e15b0ec6821e4471879
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146095
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
2023-01-24 15:50:45 +00:00
Rafael Lima
413bd0a96b tdf#153076 Make Basic editor background color independent from document color
This patch creates a separate color configuration entry for the background of the Basic Editor (svtools::BASICEDITOR). This allows the user to set the color of the Basic Editor independently from the color used as document background.

Currently the color used is DOCCOLOR, which means that if the user wants to use a different color in the Basic Editor, they must change the document color as well. However, the user may want to use f.i. a dark background in the Basic editor while maintaining a white color for documents, which is currently not possible.

By default, both color schemes "LibreOffice" and "LibreOffice Dark" use the same color for DOCCOLOR and BASICEDITOR to replicate the existing behavior. But now, if the user wants to use a different color for the Basic Editor, than it's possible to change it without affecting the color of documents.

Change-Id: I2f33b1ccb497d7e22faab7fa48cb96841785ce99
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145590
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-01-24 15:37:10 +00:00
Tor Lillqvist
6e2d28934e Clarify comment
Change-Id: I33d10ea4f3ca35619d6f857d18b5c53a22d822a7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146097
Tested-by: Tor Lillqvist <tml@collabora.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2023-01-24 15:21:31 +00:00
Tor Lillqvist
d514097753 Surround recently added code that breaks on COWASM with ifdef
After 7a6324ea0d I started getting UNO
exceptions with the message "component context fails to supply service
com.sun.star.xml.crypto.SEInitializer of type
com.sun.star.xml.crypto.XSEInitializer".

It is likely that it breaks in the iOS and Android apps, too, so
bypass for those, too.

Change-Id: Id08afbf6bea071c8b0b6564342716e0b064cb712
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146071
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2023-01-24 15:17:30 +00:00
Tor Lillqvist
e37a4598bb Use PYTHONWARNINGS=ignore instead of 'default' for Emscripten
The Emscripten compiler, emcc is a Python script that wraps the actual
compiler. It outputs annoying warnings like

    .../emscripten/tools/building.py:638: ResourceWarning: unclosed file <_io.TextIOWrapper name='/tmp/emscripten_temp_0fvvg__1/conftest.js.jso.js' mode='w' encoding='utf-8'>

to stderr. (Ditto for em++.) Some steps in typical configure script
think that a non-empty stderr means there was a problem in compiling a
test program. This happens even for a microscopic test program with an
option like -Werror which surely *is* supported.  Avoid this by
setting PYTHONWARNINGS=ignore.

Change-Id: I11927fc7dccaa65a239ba65dfc7c6bb7487bf12d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146070
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2023-01-24 15:11:49 +00:00
Jean-Pierre Ledure
bc8c1d45ac ScriptForge (SF_Dialog) define constants as properties
OKBUTTON and CANCELBUTTON are defined in the help
as properties, both for Basic and Python user scripts.

To make
  dialog.OKBUTTON
valid in Basic, OKBUTTON should be defined either as (1)
  Public Const OKBUTTON = 1
or (2)
  Property Get OKBUTTON()

Actually, it if a Private constant. <= wrong

Choice is made to make it a full property (2).

Python equivalent is OK, no change required.

No impact on help documentation.

Change-Id: Id4cf7dfbaff68fc8cc48a5c4779374ce1e7cc88b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146008
Tested-by: Jenkins
Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2023-01-24 14:25:01 +00:00
Tor Lillqvist
a771945f98 Be consistent in checks for LIBO_INTERNAL_ONLY
Only check whether LIBO_INTERNAL_ONLY is defined or not. Don't check its value.

If undefined, its value will default to 0, but checking the value will
cause a warning that will be treated as an error if you compile with
-Werror, as you should.

Change-Id: I1d9e4569a016d2e6dbaa9d612071a5528ff1902e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146066
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2023-01-24 14:02:40 +00:00
Michael Stahl
90e1698dab tdf#153090 xmloff: ODF import/export of source style on ToX
For Table of Figures/Objects/Tables.

Make this similar to DOCX: only one source style is possible, so omit
the intermediate text:index-source-styles element.

Also a boolean attribute like text:use-index-source-styles appears as
unnecessary complexity, so try to do without.

Change-Id: I7cb599c7ec1261ddedc196a25c3eafe35f35fbe9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146013
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-01-24 13:39:23 +00:00
Caolán McNamara
668f55b658 tdf#152404 crash in Windows with ctrl+alt+c during ExtTextInput
Change-Id: I73ed19eeae49ef737aae372b8f4c053f67a169c8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146064
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-24 12:32:30 +00:00
Tomaž Vajngerl
6d3aafc3aa sw: disable theme dialog if the theme is not set to the draw page
Change-Id: I3d60e9b82dfd59b5afc7769a7895acfcc5c3417c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146061
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-24 11:33:44 +00:00
Tomaž Vajngerl
9b324f97b5 sw: remove tab pages from theme dialog - crashes online
Remove the tab pages for now, as they crash the dialog in online,
and the tab pages aren't used currently anyway.

Change-Id: I35a2875510fd74b6a3060edf83c7190ba80a4eef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146060
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-24 11:33:36 +00:00
Jan Holesovsky
4132bd5477 No need for openssl in the cross build's instdir_for_build
So disable it from the configure & make sure it is not brought in by the
non-iOS check.

Change-Id: I9bbf1c593d1d48197951002e04e7f925d35ecba9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146034
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2023-01-24 11:28:53 +00:00
Tomaž Vajngerl
e052f6e1d4 tdf#66580 write ODF document as an attachment in hybrid mode
This changes the hybrid mode so that the ODF document is written
as an PDF compatible file attachment into the PDF document. It also
keeps writing the /AdditionalStreams element into the trailer to
keep backwards compatibility for now.

Change-Id: Ica31159cfbd591c6741e3da62c42d1fefd085696
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146053
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-24 10:50:49 +00:00
Tomaž Vajngerl
217ef2ed9b pdfimport: refactor pdf and hybrid format detection code
Change-Id: I3421fbcc717a75377db887f567ce3bb9631a4f28
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146052
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-01-24 10:50:34 +00:00